On 9/20/2018 3:37 PM, Rex Zhu wrote:
initialize gfx/sdma before dpm features enabled.
and disable dpm features before gfx/sdma fini.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/cik.c | 17 +
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 11 +--
So we can query what features are enabled for debugging.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
b/drivers/gpu/drm/amd/powerplay
For consistency with other vega parts.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 18 -
.../gpu/drm/amd/powerplay/hwmgr/vega20_thermal.c | 5 +
.../gpu/drm/amd/powerplay/smumgr/vega20_smumgr.c | 23 +-
.../gpu
For getting the 64 bit enabled smc feature mask from vega parts.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/include/kgd_pp_interface.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/include/kgd_pp_interface.h
b/drivers/gpu/drm/amd/include/kgd_pp_interface.h
ind
Print the enabled smc feature mask in amdgpu_pm_info for debugging.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
index 8c334fc808c2.
So we can query what features are enabled for debugging.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hw
to vega10_smumgr.c. For consistency with other vega parts.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 11 +--
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.h | 2 --
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c | 1 +
driv
For consistency with other asics.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 8
.../gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c | 22 ++
.../gpu/drm/amd/powerplay/smumgr/vega12_smumgr.h | 4
3 files changed, 22 in
For consistency with other asics.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 32 +++---
.../gpu/drm/amd/powerplay/smumgr/vega20_smumgr.c | 22 ---
.../gpu/drm/amd/powerplay/smumgr/vega20_smumgr.h | 4 ---
3 files changed,
So we can query what features are enabled for debugging.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 5 +
drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 8
drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.h | 2 ++
3 files changed
On 2018-09-19 07:08 PM, Lyude Paul wrote:
> Currently the way that we prevent userspace from performing new modesets
> on MST connectors that have just been destroyed is rather broken.
> There's nothing in the actual DRM DP MST topology helpers that checks
> whether or not a connector still exists,
On 2018-09-18 07:06 PM, Lyude Paul wrote:
> Hook this into amdgpu's atomic check for their connectors so they never
> get modesets on no-longer-present MST connectors. We'll also expand on
> this later once we add DP MST fallback retraining support.
>
> As well, turns out that the only atomic DRM
On 2018-09-18 07:06 PM, Lyude Paul wrote:
> Currently the way that we prevent userspace from performing new modesets
> on MST connectors that have just been destroyed is rather broken.
> There's nothing in the actual DRM DP MST topology helpers that checks
> whether or not a connector still exists,
What's the status with this error and the suggested patch to fix it ? It
impacts GPU reset on Polaris11.
Do we want to investigate why the original patch breaks it or just
disable with the proposed patch ?
P.S Suspend resume also stopped working on latest branch - will bisect
it later today
Am 20.09.2018 um 18:24 schrieb James Zhu:
On 2018-09-20 11:49 AM, Alex Deucher wrote:
On Thu, Sep 20, 2018 at 11:27 AM James Zhu wrote:
On 2018-09-20 11:14 AM, Alex Deucher wrote:
On Thu, Sep 13, 2018 at 4:56 PM James Zhu wrote:
When VCN PG state is unchanged, it is unnecessary to reset
On 2018-09-20 11:49 AM, Alex Deucher wrote:
On Thu, Sep 20, 2018 at 11:27 AM James Zhu wrote:
On 2018-09-20 11:14 AM, Alex Deucher wrote:
On Thu, Sep 13, 2018 at 4:56 PM James Zhu wrote:
When VCN PG state is unchanged, it is unnecessary to reset power
gate state
Signed-off-by: James Zhu
Hi Dave,
A few fixes for 4.19:
- Add a new polaris pci id
- KFD fixes for raven and gfx7
The following changes since commit 8ca4fff974ad5288d38298f15bf218f2eac2d5e7:
Merge tag 'drm-intel-fixes-2018-09-19' of
git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2018-09-20 10:01:53
+100
On Thu, Sep 20, 2018 at 11:27 AM James Zhu wrote:
>
>
>
> On 2018-09-20 11:14 AM, Alex Deucher wrote:
> > On Thu, Sep 13, 2018 at 4:56 PM James Zhu wrote:
> >> When VCN PG state is unchanged, it is unnecessary to reset power
> >> gate state
> >>
> >> Signed-off-by: James Zhu
> >> ---
> >> driv
From: Zhu, Rex
Sent: Thursday, September 20, 2018 10:43 AM
To: Deucher, Alexander; amd-gfx@lists.freedesktop.org; Quan, Evan
Subject: RE: [PATCH 1/3] drm/amd/pp: Avoid divide-by-zero in
smu7_fan_ctrl_set_fan_speed_rpm
Hi Alex and Evan,
For the fan control via
On 2018-09-20 11:14 AM, Alex Deucher wrote:
On Thu, Sep 13, 2018 at 4:56 PM James Zhu wrote:
When VCN PG state is unchanged, it is unnecessary to reset power
gate state
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 1 +
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c |
On Thu, Sep 13, 2018 at 4:56 PM James Zhu wrote:
>
> When VCN PG state is unchanged, it is unnecessary to reset power
> gate state
>
> Signed-off-by: James Zhu
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 1 +
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 12 ++--
> 2 files changed,
Hi Dave,
This is a new pull for drm-next on top of last weeks with the following
changes:
- Fixed 64 bit divide
- Fixed vram type on vega20
- Misc vega20 fixes
- Misc DC fixes
- Fix GDS/GWS/OA domain handling
Previous changes from last week:
amdgpu/kfd:
- Picasso (new APU) support
- Raven2 (new A
Thanks for the fix.
We've moved to logging functionality more closely aligned with the rest of DRM
and dropped logger.c a while back.
Harry
On 2018-09-05 02:43 PM, Ján Kosterec wrote:
> amdgpu driver fails compilation when compiling with CONFIG_FORTIFY_SOURCE
> kernel option:
>
> In function ‘
Hi Alex and Evan,
For the fan control via sysfs, I think we need to clarify the use case.
We support manual/auto fan control mode.
User can set the mode through pwm_enable. 1 mean manual. 2 mean auto
User can set fan speed via pwm1 and fan1_input.
For pwm1, user set the percentage value (0% -
Ping
Alex and Christian,
Could you give a review on this updated patch?
Thanks & Best Regards!
James Zhu
From: James Zhu
Sent: Thursday, September 13, 2018 4:55 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhu, James
Subject: [PATCH v2] drm/amdgpu:No action w
Series is:
Acked-by: Alex Deucher
From: amd-gfx on behalf of Rex Zhu
Sent: Thursday, September 20, 2018 6:07:28 AM
To: amd-gfx@lists.freedesktop.org; Zhou, Hang
Cc: Zhu, Rex
Subject: [PATCH 1/4] drm/amdgpu: Halt rlc/cp in rlc_safe_mode
before halt rlc/cp, nee
Series is:
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Rex Zhu
Sent: Thursday, September 20, 2018 3:14:25 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhu, Rex
Subject: [PATCH 1/3] drm/amd/pp: Avoid divide-by-zero in
smu7_fan_ctrl_set_fan_speed_rpm
The
Am 20.09.2018 um 13:03 schrieb Chunming Zhou:
points array is one-to-one match with syncobjs array.
v2:
add seperate ioctl for timeline point wait, otherwise break uapi.
Signed-off-by: Chunming Zhou
---
drivers/gpu/drm/drm_internal.h | 2 +
drivers/gpu/drm/drm_ioctl.c| 2 +
drivers/gp
Am 20.09.2018 um 13:03 schrieb Chunming Zhou:
This patch is for VK_KHR_timeline_semaphore extension, semaphore is called
syncobj in kernel side:
This extension introduces a new type of syncobj that has an integer payload
identifying a point in a timeline. Such timeline syncobjs support the
follo
user mode can query timeline payload.
Signed-off-by: Chunming Zhou
---
drivers/gpu/drm/drm_internal.h | 2 ++
drivers/gpu/drm/drm_ioctl.c| 2 ++
drivers/gpu/drm/drm_syncobj.c | 53 ++
include/uapi/drm/drm.h | 11 +++
4 files changed, 68 insertio
Signed-off-by: Chunming Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 6870909da926..58cba492ba55 100644
--- a/drivers/gpu/drm/amd/amdgp
points array is one-to-one match with syncobjs array.
v2:
add seperate ioctl for timeline point wait, otherwise break uapi.
Signed-off-by: Chunming Zhou
---
drivers/gpu/drm/drm_internal.h | 2 +
drivers/gpu/drm/drm_ioctl.c| 2 +
drivers/gpu/drm/drm_syncobj.c | 99 +
Am 20.09.2018 um 13:03 schrieb Chunming Zhou:
flags can be used by driver to decide whether need to block wait submission.
Signed-off-by: Chunming Zhou
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
drivers/gpu/drm/drm_syncobj.c | 4 ++--
drive
syncobj wait/signal operation is appending in command submission.
Signed-off-by: Chunming Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 8 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 114 +++--
include/uapi/drm/amdgpu_drm.h | 10 +++
3 files changed, 104 inser
This patch is for VK_KHR_timeline_semaphore extension, semaphore is called
syncobj in kernel side:
This extension introduces a new type of syncobj that has an integer payload
identifying a point in a timeline. Such timeline syncobjs support the
following operations:
* CPU query - A host operati
flags can be used by driver to decide whether need to block wait submission.
Signed-off-by: Chunming Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
drivers/gpu/drm/drm_syncobj.c | 4 ++--
drivers/gpu/drm/v3d/v3d_gem.c | 4 ++--
drivers/gpu/drm/vc4/vc4_gem.c |
initialize gfx/sdma before dpm features enabled.
and disable dpm features before gfx/sdma fini.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/cik.c | 17 +
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 11 +--
drivers/gpu/drm/amd/amdgpu/si.c
Need to disable dpm features before halt rlc.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 14 +
drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c | 37
2 files changed, 33 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/d
before halt rlc/cp, need to
1. enter rlc safe mode
2. wait rlc/cp idle
Signed-off-by: Hang Zhou
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 86 ---
1 file changed, 59 insertions(+), 27 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/g
the CG related registers have been programed in golden setting
PG register default value is 0.
Signed-off-by: Hang Zhou
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
Am 20.09.2018 um 11:45 schrieb Zhou, David(ChunMing):
-Original Message-
From: amd-gfx On Behalf Of
Christian K?nig
Sent: Thursday, September 20, 2018 5:35 PM
To: Zhou, David(ChunMing) ; dri-
de...@lists.freedesktop.org
Cc: Dave Airlie ; Rakos, Daniel
; Daniel Vetter ; amd-
g...@lists.
> -Original Message-
> From: amd-gfx On Behalf Of
> Christian K?nig
> Sent: Thursday, September 20, 2018 5:35 PM
> To: Zhou, David(ChunMing) ; dri-
> de...@lists.freedesktop.org
> Cc: Dave Airlie ; Rakos, Daniel
> ; Daniel Vetter ; amd-
> g...@lists.freedesktop.org
> Subject: Re: [PATCH
The only thing I can still see is that you use wait_event_timeout()
instead of wait_event_interruptible().
Any particular reason for that?
Apart from that it now looks good to me.
Christian.
Am 20.09.2018 um 11:29 schrieb Zhou, David(ChunMing):
Ping...
-Original Message-
From: amd-
Ping...
> -Original Message-
> From: amd-gfx On Behalf Of
> Chunming Zhou
> Sent: Wednesday, September 19, 2018 5:18 PM
> To: dri-de...@lists.freedesktop.org
> Cc: Zhou, David(ChunMing) ; amd-
> g...@lists.freedesktop.org; Rakos, Daniel ; Daniel
> Vetter ; Dave Airlie ; Koenig,
> Christia
Hi Lyude,
Thank you for the patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Lyude-Paul/Fix-legacy-DPMS-changes-with-MST/20180919-203434
base: git://anongit.freedesktop.org/drm-intel for-linux-next
smatch warnings:
drivers/gpu/drm/drm_dp_mst_topology.c:314
In particular if one's e-mail is in the To: field of the e-mail.
While there can be false positives, e.g. because a patch depends on
other patches, in general those e-mails point out valid issues in kernel
patches sent out for review. In that case, one should follow up with an
amended patch, or i
Please see in line.
Regards
Rex
From: amd-gfx on behalf of Evan Quan
Sent: Thursday, September 20, 2018 10:26 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander; Quan, Evan
Subject: [PATCH] drm/amd/powerplay: enable fan RPM and pwm settings
Manual
User can set fan's revolution per minute via
fan1_input.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h| 3 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 28 +-
drivers/gpu/drm/amd/include/kgd_pp_interface.h | 1 +
drivers/gpu/drm/amd/
set the target rpm value to wrong register.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c | 2 +-
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/
The minRPM speed maybe equal to zero. so need to check
input RPM not equal to 0, otherwise cause divide-by-zero driver crash.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7
50 matches
Mail list logo
