RE: [PATCH] drm/amdgpu: Moved doorbell structures to seperate file

2018-11-23 Thread Zeng, Oak
Alex, No I didn't. I don't know what happened to my email account. Can you forward that comment to me again? Regards, Oak From: Deucher, Alexander Sent: Friday, November 23, 2018 3:20 PM To: Zeng, Oak ; amd-gfx@lists.freedesktop.org Cc: Zeng, Oak Subject: Re: [PATCH] drm/amdgpu: Moved doorbel

Re: [PATCH] drm/amdgpu: Add delay after enable RLC ucode

2018-11-23 Thread Kuehling, Felix
On 2018-11-22 1:22 p.m., Liu, Shaoyun wrote: > Driver shouldn't try to access any GFX registers until RLC is idle. > During the test, it took 12 seconds for RLC to clear the BUSY bit > in RLC_GPM_STAT register which is un-acceptable for driver. > As per RLC engineer, it would take RLC Ucode less th

Re: amdgpu: several powerplay errors during boot of HAWAII PRO GPU

2018-11-23 Thread Alex Deucher
On Fri, Nov 23, 2018 at 5:28 AM Kai Wasserbäch wrote: > > [Please CC me on replies, I'm not subscribed to amd-gfx.] > > Hey, > with the recent 4.19.x series of kernels I'm seeing several errors being > logged > during boot for my R9 290 (HAWAII PRO) GPU: > > [ 50.057264] amdgpu: [powerplay] Fai

Re: [PATCH] drm/amdgpu: Moved doorbell structures to seperate file

2018-11-23 Thread Deucher, Alexander
Did you see my other comments about consolidating vega10, raven, and vega12? Reviewed-by: Alex Deucher From: amd-gfx on behalf of Oak Zeng Sent: Friday, November 23, 2018 3:01:23 PM To: amd-gfx@lists.freedesktop.org Cc: Zeng, Oak Subject: [PATCH] drm/amdgpu:

RE: [PATCH] drm/amdgpu: Moved doorbell structures to seperate file

2018-11-23 Thread Zeng, Oak
Hi Alex, This is a follow up patch to your previous comment on the doorbell patches. Please review. Regards, Oak -Original Message- From: Zeng, Oak Sent: Friday, November 23, 2018 3:01 PM To: amd-gfx@lists.freedesktop.org Cc: Zeng, Oak Subject: [PATCH] drm/amdgpu: Moved doorbell stru

[PATCH] drm/amdgpu: Moved doorbell structures to seperate file

2018-11-23 Thread Oak Zeng
Move doorbell structures, enum definitions and helper functions from amdgpu.h to amdgpu_doorbell.h. No functional change Change-Id: I09f7b84869b6d3c688b7a2506ff78d62b3de23f5 Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 227 +--- drivers/gpu/drm/a

RE: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic

2018-11-23 Thread Zeng, Oak
Hi Alex, It is strange I didn't get your email on Wednesday. I will add one patch to move all the doorbell definitions to a separate amdgpu_doorbell.h Regards, Oak From: Deucher, Alexander Sent: Friday, November 23, 2018 1:57 PM To: Alex Deucher ; Zeng, Oak ; Koenig, Christian Cc: amd-gfx li

Re: [PATCH] drm: should break if already get the best size

2018-11-23 Thread Deucher, Alexander
Please add a proper patch description. Alex From: amd-gfx on behalf of Zhu, Rex Sent: Friday, November 23, 2018 4:44:31 AM To: Liu, Monk; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm: should break if already get the best size Tested-by: Rex Zhu

Re: [PATCH] drm/amdgpu: disable UVD/VCE for some polaris 12 variants

2018-11-23 Thread Deucher, Alexander
Is this required? Are the harvesting fuses incorrect? If the blocks are harvested, we should bail out of the blocks properly during init. Also, please make this more explicit if we still need it. E.g., if ((adev->pdev->device == 0x67df) && (adev->pdev->revision == 0xf7))

RE: [PATCH RFC 4/5] drm/amdgpu: Add accounting of command submission via DRM cgroup

2018-11-23 Thread Ho, Kenny
On Fri, Nov 23, 2018 at 1:13 PM Koenig, Christian wrote: > Am 23.11.18 um 18:36 schrieb Eric Anholt: > > Christian König writes: > >> Am 20.11.18 um 21:57 schrieb Eric Anholt: > >>> Kenny Ho writes: > Account for the number of command submitted to amdgpu by type on a per > cgroup basi

Re: [PATCH 7/7] drm/amdgpu: Use new doorbell layout for vega20 and future asic

2018-11-23 Thread Deucher, Alexander
The main idea is to be able to use different layouts on different asics that may share the same IP code. Alex From: amd-gfx on behalf of Christian K?nig Sent: Thursday, November 22, 2018 4:26:53 AM To: Alex Deucher; Zeng, Oak Cc: amd-gfx list Subject: Re: [PA

Re: [PATCH RFC 4/5] drm/amdgpu: Add accounting of command submission via DRM cgroup

2018-11-23 Thread Koenig, Christian
Am 23.11.18 um 18:36 schrieb Eric Anholt: > Christian König writes: > >> Am 20.11.18 um 21:57 schrieb Eric Anholt: >>> Kenny Ho writes: >>> Account for the number of command submitted to amdgpu by type on a per cgroup basis, for the purpose of profiling/monitoring applications. >>> For

Re: [PATCH] drm/amdgpu: add the checking to avoid NULL pointer dereference

2018-11-23 Thread Koenig, Christian
Am 23.11.18 um 15:10 schrieb Zhou, David(ChunMing): > > 在 2018/11/23 21:30, Koenig, Christian 写道: >> Am 23.11.18 um 14:27 schrieb Zhou, David(ChunMing): >>> 在 2018/11/22 19:25, Christian König 写道: Am 22.11.18 um 07:56 schrieb Sharma, Deepak: > when returned fence is not valid mostly due to

Re: [PATCH RFC 4/5] drm/amdgpu: Add accounting of command submission via DRM cgroup

2018-11-23 Thread Eric Anholt
Christian König writes: > Am 20.11.18 um 21:57 schrieb Eric Anholt: >> Kenny Ho writes: >> >>> Account for the number of command submitted to amdgpu by type on a per >>> cgroup basis, for the purpose of profiling/monitoring applications. >> For profiling other drivers, I've used perf tracepoints

Re: [PATCH] drm/amdgpu: add the checking to avoid NULL pointer dereference

2018-11-23 Thread Chunming Zhou
在 2018/11/23 21:30, Koenig, Christian 写道: > Am 23.11.18 um 14:27 schrieb Zhou, David(ChunMing): >> 在 2018/11/22 19:25, Christian König 写道: >>> Am 22.11.18 um 07:56 schrieb Sharma, Deepak: when returned fence is not valid mostly due to userspace ignored previous error causes NULL pointer

Re: [PATCH] drm/amdgpu: add the checking to avoid NULL pointer dereference

2018-11-23 Thread Chunming Zhou
在 2018/11/22 19:25, Christian König 写道: > Am 22.11.18 um 07:56 schrieb Sharma, Deepak: >> when returned fence is not valid mostly due to userspace ignored >> previous error causes NULL pointer dereference. > > Again, this is clearly incorrect. The my other mails on the earlier > patch. Sorry for

Re: [PATCH] drm/amdgpu: add the checking to avoid NULL pointer dereference

2018-11-23 Thread Koenig, Christian
Am 23.11.18 um 14:27 schrieb Zhou, David(ChunMing): > > 在 2018/11/22 19:25, Christian König 写道: >> Am 22.11.18 um 07:56 schrieb Sharma, Deepak: >>> when returned fence is not valid mostly due to userspace ignored >>> previous error causes NULL pointer dereference. >> Again, this is clearly incorrec

Re: [PATCH] drm/amdgpu: Fix static checker warning

2018-11-23 Thread Christian König
Am 23.11.18 um 11:32 schrieb Rex Zhu: drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c:49 amdgpu_allocate_static_csa() error: uninitialized symbol 'ptr'. the test if (!bo) doesn't work, as the bo is a pointer to a pointer. so need to check !*bo Signed-off-by: Rex Zhu Reviewed-by: Christian König -

[PATCH] drm/amdgpu: Fix static checker warning

2018-11-23 Thread Rex Zhu
drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c:49 amdgpu_allocate_static_csa() error: uninitialized symbol 'ptr'. the test if (!bo) doesn't work, as the bo is a pointer to a pointer. so need to check !*bo Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c | 2 +- 1 file changed, 1 inse

amdgpu: several powerplay errors during boot of HAWAII PRO GPU

2018-11-23 Thread Kai Wasserbäch
[Please CC me on replies, I'm not subscribed to amd-gfx.] Hey, with the recent 4.19.x series of kernels I'm seeing several errors being logged during boot for my R9 290 (HAWAII PRO) GPU: > [ 50.057264] amdgpu: [powerplay] Failed to retrieve minimum clocks. > [ 50.057266] amdgpu: [powerplay] Er

Re: [PATCH] drm: should break if already get the best size

2018-11-23 Thread Zhu, Rex
Tested-by: Rex Zhu Without this patch, if we search node via rb tree. For example: we insert different node with rand size, size range in (1-). the key in root node is 5587. if we try to find the node with key equal to 5587 or 7381, Loop: node->key is 5587 node->key is 2273 nod

[bug report] drm/amd/display: Add support for Freesync 2 HDR and Content to Display Mapping

2018-11-23 Thread Dan Carpenter
Hello SivapiriyanKumarasamy, This is a semi-automatic email about new static checker warnings. The patch e1e8a020c6b8: "drm/amd/display: Add support for Freesync 2 HDR and Content to Display Mapping" from Sep 11, 2018, leads to the following Smatch complaint: drivers/gpu/drm/amd/amdgpu/../

RE: [PATCH] drm/amdgpu: disable UVD/VCE for some polaris 12 variants

2018-11-23 Thread Cui, Flora
Patch is Reviewed-by: Flora Cui -Original Message- From: amd-gfx On Behalf Of Junwei Zhang Sent: Friday, November 23, 2018 4:32 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jerry Subject: [PATCH] drm/amdgpu: disable UVD/VCE for some polaris 12 variants Some variants don't support UV

[bug report] drm/amdgpu: Refine CSA related functions

2018-11-23 Thread Dan Carpenter
Hello Rex Zhu, The patch 1e256e276221: "drm/amdgpu: Refine CSA related functions" from Oct 15, 2018, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c:49 amdgpu_allocate_static_csa() error: uninitialized symbol 'ptr'. drivers/gpu/drm/amd/amdgp

Re: [PATCH] drm/amdgpu: disable UVD/VCE for some polaris 12 variants

2018-11-23 Thread Zhang, Jerry(Junwei)
please ignore this patch, there is typo in code. On 11/23/18 4:01 PM, Junwei Zhang wrote: Some variants don't support UVD and VCE. Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/vi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drive

[PATCH] drm/amdgpu: disable UVD/VCE for some polaris 12 variants

2018-11-23 Thread Junwei Zhang
Some variants don't support UVD and VCE. Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/vi.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index f3a4cf1f013a..3338b013ded4 100644 --- a/drivers/gpu/drm/amd/amd

[PATCH] drm/amd/amdkfd: Remove duplicate header

2018-11-23 Thread Brajeswar Ghosh
Remove gca/gfx_8_0_enum.h which is included more than once Signed-off-by: Brajeswar Ghosh --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_vi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_vi.c b/drivers/gpu/drm/amd/amdkfd/kfd_dev

[PATCH] drm/amd/amdgpu: Remove duplicate header

2018-11-23 Thread Brajeswar Ghosh
Remove drm/drm_fb_helper.h which is included more than once Signed-off-by: Brajeswar Ghosh --- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h index b9e9e8b02fb7..1cac

Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic.

2018-11-23 Thread Kuehling, Felix
On 2018-10-22 1:23 p.m., Arun KS wrote: > Remove managed_page_count_lock spinlock and instead use atomic > variables. > > Suggested-by: Michal Hocko > Suggested-by: Vlastimil Babka > Signed-off-by: Arun KS Acked-by: Felix Kuehling Regards,   Felix > > --- > As discussed here, > https://patch

[PATCH] drm/amd/display: Remove duplicate header

2018-11-23 Thread Brajeswar Ghosh
Remove dce/dce_mem_input.h which is included more than once Signed-off-by: Brajeswar Ghosh --- drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c b/drivers/gpu/drm/amd/display/dc/dce80/dc

[PATCH] drm/amdgpu: disable UVD/VCE for some polaris 12 variants

2018-11-23 Thread Junwei Zhang
Some variants don't support UVD and VCE. Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/vi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index f3a4cf1f013a..46a92eca831b 100644 --- a/drivers/gpu/drm/amd/am