Re: [PATCH] drm/amd/powerplay: Fix missing break in switch

2019-01-28 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: cd70f3d6e3fa drm/amd/powerplay: PP/DAL interface changes for dynamic clock switch. The bot has tested the following trees: v4.20.5, v4.19.18, v4.14.96. v4.20.5: Build OK! v4.19.18

[PATCH] drm/amdgpu: add AMDGPU_IB_FLAG_GET_START_SYNCOBJ to expose scheduled fence

2019-01-28 Thread Marek Olšák
From: Marek Olšák Normal syncobjs signal when an IB finishes. Start syncobjs signal when an IB starts. Signed-off-by: Marek Olšák --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 18 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++

Re: [PATCH] drm/amd/powerplay: Fix missing break in switch

2019-01-28 Thread Gustavo A. R. Silva
On 1/28/19 10:19 AM, Alex Deucher wrote: > On Fri, Jan 25, 2019 at 5:31 PM Gustavo A. R. Silva > wrote: >> >> Add missing break statement in order to prevent the code from falling >> through to the default case. >> >> The resoning for this is that pclk_vol_table is an automatic variable. >> So,

Re: [PATCH] drm/amdgpu: clean up memory/GDS/GWS/OA alignment code

2019-01-28 Thread Christian König
Am 22.01.19 um 22:45 schrieb Marek Olšák: From: Marek Olšák - move all adjustments into one place - specify GDS/GWS/OA alignment in basic units of the heaps - it looks like GDS alignment was 1 instead of 4 Signed-off-by: Marek Olšák Reviewed-by: Christian König --- drivers/gpu/drm/amd/

[PATCH xf86-video-ati 5/7] Only update drmmode_crtc->flip_pending after actually submitting a flip

2019-01-28 Thread Michel Dänzer
From: Michel Dänzer And only clear it if it matches the framebuffer of the completed flip being processed. Fixes (WW) RADEON(0): flip queue failed: Device or resource busy (WW) RADEON(0): Page flip failed: Device or resource busy (EE) RADEON(0): present flip failed due to clobbering drmmode

[PATCH xf86-video-ati 1/7] dri3: Flush if necessary in dri3_fd_from_pixmap

2019-01-28 Thread Michel Dänzer
From: Michel Dänzer To make sure the client can't use the shared pixmap storage for direct rendering first, which could produce garbage. Bugzilla: https://bugs.freedesktop.org/109235 (Ported from amdgpu commit d168532ee739f7e33a2798051e64ba445dd3859f) Signed-off-by: Michel Dänzer --- src/rade

[PATCH xf86-video-ati 6/7] Call drmHandleEvent again if it was interrupted by a signal

2019-01-28 Thread Michel Dänzer
From: Michel Dänzer drmHandleEvent can be interrupted by a signal in read(), in which case it doesn't process any events but returns -1, which drm_handle_event propagated to its callers. This could cause the following failure cascade: 1. drm_wait_pending_flip stopped waiting for a pending flip.

[PATCH xf86-video-ati 7/7] Keep waiting for a pending flip if drm_handle_event returns 0

2019-01-28 Thread Michel Dänzer
From: Michel Dänzer drm_wait_pending_flip stopped waiting if drm_handle_event returned 0, but that might have processed only some unrelated DRM events. As long as the flip is pending, we have to keep waiting for its completion event. Noticed while working on the previous fix. (Ported from amdgp

[PATCH xf86-video-ati 4/7] Don't allow TearFree scanout flips to complete in the same vblank period

2019-01-28 Thread Michel Dänzer
From: Michel Dänzer We were using a relative target of 0, meaning "complete the flip ASAP". This could result in the flip sometimes, but not always completing in the same vertical blank period where the corresponding drawing occurred, potentially causing judder artifacts with applications updatin

[PATCH xf86-video-ati 2/7] dri2: Flush in dri2_create_buffer2 after calling glamor_set_pixmap_bo

2019-01-28 Thread Michel Dänzer
From: Michel Dänzer To make sure the client can't use the shared pixmap storage for direct rendering first, which could produce garbage. Bugzilla: https://bugs.freedesktop.org/109235 (Ported from amdgpu commit ebd32b1c07208f8dbe853e089f5e4b7c6a7a658a) Signed-off-by: Michel Dänzer --- src/rade

[PATCH xf86-video-ati 3/7] glamor: Avoid glamor_create_pixmap for pixmaps backing windows

2019-01-28 Thread Michel Dänzer
From: Michel Dänzer If the compositing manager uses direct rendering (as is usually the case these days), the storage of a pixmap allocated by glamor_create_pixmap needs to be reallocated for sharing it with the compositing manager. Instead, allocate pixmap storage which can be shared directly.

Re: [PATCH] drm/amdgpu: clean up memory/GDS/GWS/OA alignment code

2019-01-28 Thread Marek Olšák
Ping On Tue, Jan 22, 2019 at 4:45 PM Marek Olšák wrote: > From: Marek Olšák > > - move all adjustments into one place > - specify GDS/GWS/OA alignment in basic units of the heaps > - it looks like GDS alignment was 1 instead of 4 > > Signed-off-by: Marek Olšák > --- > drivers/gpu/drm/amd/amdg

Re: [PATCH] drm/amdgpu: add a workaround for GDS ordered append hangs with compute queues

2019-01-28 Thread Marek Olšák
Ping On Tue, Jan 22, 2019 at 3:05 PM Marek Olšák wrote: > From: Marek Olšák > > I'm not increasing the DRM version because GDS isn't totally without bugs > yet. > > v2: update emit_ib_size > > Signed-off-by: Marek Olšák > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gds.h | 2 ++ > drivers/gpu/dr

Re: [PATCH] drm/amdgpu: Show XGMI node and hive message per device only once

2019-01-28 Thread Alex Deucher
On Mon, Jan 28, 2019 at 12:02 PM Liu, Shaoyun wrote: > > Reduce the unnecessary repeat node and hive information during XGMI > initialization > > Change-Id: I1c1e4dadf9d771cde53225666b9a10ceca9167c0 > Signed-off-by: shaoyunl Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_xg

[PATCH] drm/amdgpu: Show XGMI node and hive message per device only once

2019-01-28 Thread Liu, Shaoyun
Reduce the unnecessary repeat node and hive information during XGMI initialization Change-Id: I1c1e4dadf9d771cde53225666b9a10ceca9167c0 Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH] drm/amd/display - Don't leak memory when updating streams

2019-01-28 Thread Wentland, Harry
On 2019-01-28 9:00 a.m., Nicholas Kazlauskas wrote: > [Why] > The flip and full structures were allocated but never freed. > > [How] > Free them at the end of the function. There's a small behavioral > change here with the function returning early if the allocation fails > but we wouldn't should b

Re: [PATCH] drm/amd/powerplay: Fix missing break in switch

2019-01-28 Thread Alex Deucher
On Fri, Jan 25, 2019 at 5:31 PM Gustavo A. R. Silva wrote: > > Add missing break statement in order to prevent the code from falling > through to the default case. > > The resoning for this is that pclk_vol_table is an automatic variable. > So, it makes no sense to update it just before falling th

[PATCH AUTOSEL 4.19 203/258] drm/amd/display: validate extended dongle caps

2019-01-28 Thread Sasha Levin
From: Wenjing Liu [ Upstream commit 99b922f9ed6a6313c0d2247cde8aa1e4a0bd67e4 ] [why] Some dongle doesn't have a valid extended dongle caps, but we still set the extended dongle caps to be valid. This causes validation fails for all timing. [how] If no dp_hdmi_max_pixel_clk is provided, don't us

[PATCH AUTOSEL 4.19 185/258] drm/amd/display: fix YCbCr420 blank color

2019-01-28 Thread Sasha Levin
From: Eric Yang [ Upstream commit 12750d1647f118496f1da727146f255f5e44d500 ] [Why] YCbCr420 packing format uses two chanels for luma, and 1 channel for both chroma component. Our previous implementation did not account for this and results in every other pixel having very high luma value, showin

[PATCH AUTOSEL 4.19 183/258] drm/amd/display: Add retry to read ddc_clock pin

2019-01-28 Thread Sasha Levin
From: Paul Hsieh [ Upstream commit bd4905a9583c760da31ded7256dca6f71483c3dc ] [WHY] On customer board, there is one pluse (1v , < 1ms) on DDC_CLK pin when plug / unplug DP cable. Driver will read it and config DP to HDMI/DVI dongle. [HOW] If there is a real dongle, DDC_CLK should be always pull

[PATCH AUTOSEL 4.19 109/258] drm/amdgpu/powerplay: fix clock stretcher limits on polaris (v2)

2019-01-28 Thread Sasha Levin
From: Alex Deucher [ Upstream commit de4aaab5cc9770a8c4dc13d9bfb6a83b06bba57e ] Adjust limits for newer polaris variants. v2: fix polaris11 kicker (Jerry) Reviewed-by: Junwei Zhang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- .../drm/amd/powerplay/smumgr/polaris10_smumgr.c |

[PATCH AUTOSEL 4.19 048/258] drm/amd/display: fix gamma not being applied correctly

2019-01-28 Thread Sasha Levin
From: Murton Liu [ Upstream commit 8ce504b9389be846bcdf512ed5be8f661b3bf097 ] [why] Gamma was always being set as identity on SDR monitor, leading to no changes in gamma. This caused nightlight to not apply correctly. [how] Added a default gamma structure to compare against in the sdr case. Si

[PATCH AUTOSEL 4.19 049/258] drm/amd/display: calculate stream->phy_pix_clk before clock mapping

2019-01-28 Thread Sasha Levin
From: Yogesh Mohan Marimuthu [ Upstream commit 08e1c28dd521c7b08d1b0af0bae9fb22ccc012a4 ] [why] phy_pix_clk is one of the variable used to check if one PLL can be shared with displays having common mode set configuration. As of now phy_pix_clock varialbe is calculated in function dc_validate_str

[PATCH AUTOSEL 4.20 243/304] drm/amd/display: validate extended dongle caps

2019-01-28 Thread Sasha Levin
From: Wenjing Liu [ Upstream commit 99b922f9ed6a6313c0d2247cde8aa1e4a0bd67e4 ] [why] Some dongle doesn't have a valid extended dongle caps, but we still set the extended dongle caps to be valid. This causes validation fails for all timing. [how] If no dp_hdmi_max_pixel_clk is provided, don't us

[PATCH AUTOSEL 4.20 221/304] drm/amd/display: fix YCbCr420 blank color

2019-01-28 Thread Sasha Levin
From: Eric Yang [ Upstream commit 12750d1647f118496f1da727146f255f5e44d500 ] [Why] YCbCr420 packing format uses two chanels for luma, and 1 channel for both chroma component. Our previous implementation did not account for this and results in every other pixel having very high luma value, showin

[PATCH AUTOSEL 4.20 218/304] drm/amd/display: Add retry to read ddc_clock pin

2019-01-28 Thread Sasha Levin
From: Paul Hsieh [ Upstream commit bd4905a9583c760da31ded7256dca6f71483c3dc ] [WHY] On customer board, there is one pluse (1v , < 1ms) on DDC_CLK pin when plug / unplug DP cable. Driver will read it and config DP to HDMI/DVI dongle. [HOW] If there is a real dongle, DDC_CLK should be always pull

[PATCH AUTOSEL 4.20 219/304] drm/amd/display: Wait edp HPD to high in detect_sink

2019-01-28 Thread Sasha Levin
From: Dale Zhao [ Upstream commit 0a6414e75d231ee1bb7ffb2f5eb246b682a884cd ] [Why] In 99% user case, edp will be post by vbios. In 1% / current case: Lenovo don't light up edp panel in vbios post stage, vbios won't be lit up. Thus in dal when we init DCN 10 hw, we power up edp, then we start det

[PATCH AUTOSEL 4.20 129/304] drm/amdgpu/powerplay: fix clock stretcher limits on polaris (v2)

2019-01-28 Thread Sasha Levin
From: Alex Deucher [ Upstream commit de4aaab5cc9770a8c4dc13d9bfb6a83b06bba57e ] Adjust limits for newer polaris variants. v2: fix polaris11 kicker (Jerry) Reviewed-by: Junwei Zhang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- .../drm/amd/powerplay/smumgr/polaris10_smumgr.c |

[PATCH AUTOSEL 4.20 056/304] drm/amd/display: calculate stream->phy_pix_clk before clock mapping

2019-01-28 Thread Sasha Levin
From: Yogesh Mohan Marimuthu [ Upstream commit 08e1c28dd521c7b08d1b0af0bae9fb22ccc012a4 ] [why] phy_pix_clk is one of the variable used to check if one PLL can be shared with displays having common mode set configuration. As of now phy_pix_clock varialbe is calculated in function dc_validate_str

[PATCH AUTOSEL 4.20 055/304] drm/amd/display: fix gamma not being applied correctly

2019-01-28 Thread Sasha Levin
From: Murton Liu [ Upstream commit 8ce504b9389be846bcdf512ed5be8f661b3bf097 ] [why] Gamma was always being set as identity on SDR monitor, leading to no changes in gamma. This caused nightlight to not apply correctly. [how] Added a default gamma structure to compare against in the sdr case. Si

[PATCH AUTOSEL 4.20 013/304] drm/amd/display: Fix potential nullptr error

2019-01-28 Thread Sasha Levin
From: Bhawanpreet Lakha [ Upstream commit 4f7129112c2a30331f3045a42026fad82e6cb72b ] [Why] Fix surface/plane potential nullptr [How] add null check Signed-off-by: Bhawanpreet Lakha Reviewed-by: Aric Cyr Acked-by: Leo Li Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/g

Re: [PATCH] drm/amd/display - Don't leak memory when updating streams

2019-01-28 Thread Michel Dänzer
On 2019-01-28 3:00 p.m., Nicholas Kazlauskas wrote: > [Why] > The flip and full structures were allocated but never freed. > > [How] > Free them at the end of the function. There's a small behavioral > change here with the function returning early if the allocation fails > but we wouldn't should b

回复:[PATCH 2/2] drm/amdgpu: cleanup setting bulk_movable

2019-01-28 Thread Zhou, David(ChunMing)
Reviewed-by: Chunming Zhou send from my phone 原始邮件 主题:[PATCH 2/2] drm/amdgpu: cleanup setting bulk_movable 发件人:Christian König 收件人:amd-gfx@lists.freedesktop.org 抄送: We only need to set this to false now when BOs are removed from the LRU. Signed-off-by: Christian König ---

Re: [PATCH] drm/amd/display - Don't leak memory when updating streams

2019-01-28 Thread Li, Sun peng (Leo)
On 2019-01-28 9:00 a.m., Nicholas Kazlauskas wrote: > [Why] > The flip and full structures were allocated but never freed. > > [How] > Free them at the end of the function. There's a small behavioral > change here with the function returning early if the allocation fails > but we wouldn't should

[PATCH] drm/amd/display - Don't leak memory when updating streams

2019-01-28 Thread Nicholas Kazlauskas
[Why] The flip and full structures were allocated but never freed. [How] Free them at the end of the function. There's a small behavioral change here with the function returning early if the allocation fails but we wouldn't should be doing anything in that case anyway. Fixes: c00e0cc0fdc0 ("drm/a

Re: [PATCH 05/20] drm/amd/display: Call into DC once per multiplane flip

2019-01-28 Thread Kazlauskas, Nicholas
On 1/28/19 6:59 AM, Michel Dänzer wrote: > On 2019-01-22 7:28 p.m., sunpeng...@amd.com wrote: >> From: David Francis >> >> [Why] >> amdgpu_dm_commit_planes was performing multi-plane >> flips incorrectly: >> >> It waited for vblank once per flipped plane >> >> It prepared flip ISR and acquired the

[PATCH 1/2] drm/amdgpu: cleanup amdgpu_pte_update_params

2019-01-28 Thread Christian König
kptr is not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index 0bc6f553dc08..a404ac17e5ae 100644 --- a/drivers/g

[PATCH 2/2] drm/amdgpu: cleanup setting bulk_movable

2019-01-28 Thread Christian König
We only need to set this to false now when BOs are removed from the LRU. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index a404a

Re: [PATCH 05/20] drm/amd/display: Call into DC once per multiplane flip

2019-01-28 Thread Michel Dänzer
On 2019-01-22 7:28 p.m., sunpeng...@amd.com wrote: > From: David Francis > > [Why] > amdgpu_dm_commit_planes was performing multi-plane > flips incorrectly: > > It waited for vblank once per flipped plane > > It prepared flip ISR and acquired the corresponding vblank ref > once per plane, altho

Re: [PATCH] drm/amdgpu: sriov restrict max_pfn below AMDGPU_GMC_HOLE

2019-01-28 Thread Christian König
Am 24.01.19 um 04:38 schrieb wentalou: sriov need to restrict max_pfn below AMDGPU_GMC_HOLE. access the hole results in a range fault interrupt IIRC. Change-Id: I0add197a24a54388a128a545056e9a9f0330abfb Signed-off-by: Wentao Lou Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu