[PATCH] drm/amd/powerplay: fix pcie sysfs interface when set wrong value

2019-03-03 Thread likun Gao
From: Likun Gao The operation of mutex_unlock smu->mutex should be done when forced level is larger than NUM_LINK_LEVELS in the function of force_clk_levels. Reported-by: Julia Lawall Signed-off-by: Likun Gao --- drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 6 -- 1 file changed, 4 insert

Re: [PATCH] drm/amd/powerplay: fix pcie sysfs interface when set wrong value

2019-03-03 Thread Huang Rui
On Mon, Mar 04, 2019 at 11:47:49AM +0800, likun Gao wrote: > From: Likun Gao > > The operation of mutex_unlock smu->mutex should be done when forced level is > larger than NUM_LINK_LEVELS in the function of force_clk_levels. > > Reported-by: Julia Lawall > Signed-off-by: Likun Gao Reviewed-b

Re: [PATCH] drm/amdgpu/powerplay: Fix missing break in switch statement

2019-03-03 Thread Huang Rui
On Fri, Mar 01, 2019 at 03:29:43PM -0600, Gustavo A. R. Silva wrote: > Add missing break statement in order to prevent the code from falling > through to case SMU_Discrete_DpmTable. > > This bug was found thanks to the ongoing efforts to enable > -Wimplicit-fallthrough. > > Fixes: 34a564eaf528 ("

RE: [PATCH] drm/amd/powerplay: fix memdup.cocci warnings

2019-03-03 Thread Gao, Likun
Reviewed-by: Likun Gao -Original Message- From: Julia Lawall Sent: Saturday, March 02, 2019 2:51 PM To: Gao, Likun Cc: Deucher, Alexander ; Wang, Kevin(Yang) ; Quan, Evan ; Koenig, Christian ; David Airlie ; Daniel Vetter ; Huang, Ray ; amd-gfx@lists.freedesktop.org; kbuild test ro