[pull] amdgpu drm-next-5.2

2019-04-10 Thread Alex Deucher
Hi Dave, Daniel, More stuff for 5.2: - Fixes for powerplay custom profiles - DC bandwidth clean ups and fixes - RAS fixes for vega20 - DC atomic resume fix - Better plane handling in DC - Freesync improvements - Misc bug fixes and cleanups The following changes since commit 5ebffda257731a11cf1db6

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization v3

2019-04-10 Thread Quan, Evan
Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Yintian Tao > Sent: Wednesday, April 10, 2019 10:26 PM > To: amd-gfx@lists.freedesktop.org > Cc: Tao, Yintian > Subject: [PATCH] drm/amdgpu: support dpm level modification under > virtualization v3 > > Under veg

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Kuehling, Felix
How does forcing DPM levels work in SRIOV? Can clocks switch fast enough to allow different VFs have different clocks? If not, can one VF override the clocks used by another VF? In that case, wouldn't that violate the isolation between VFs? Regards, Felix -Original Message- From: amd

[pull] amdgpu, amdkfd drm-fixes-5.1

2019-04-10 Thread Alex Deucher
Hi Dave, Daniel, A few fixes for 5.1: - Cursor fixes - Add missing picasso pci id to KFD - XGMI fix - Shadow buffer handling fix for GPU reset The following changes since commit d939f44d4a7f910755165458da20407d2139f581: drm/amdgpu: remove unnecessary rlc reset function on gfx9 (2019-04-02 16:

Re: How to get useful information other than "the whole system locks up"?

2019-04-10 Thread Braiam
On Sat, Apr 6, 2019 at 3:25 PM Braiam wrote: > > At this point I decided that the system isn't going to recover, so I > tried to soft-reboot it, but it only ended locked and had to hard > reboot. > > I've found this bug[1] that seems related, user watching videos. I > will try removing vaapi and

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization v3

2019-04-10 Thread Tao, Yintian
Hi Alex Many thanks for your review. Best Regards Yintian Tao -Original Message- From: Alex Deucher Sent: Wednesday, April 10, 2019 11:32 PM To: Tao, Yintian Cc: amd-gfx list Subject: Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization v3 On Wed, Apr 10, 201

Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization v3

2019-04-10 Thread Alex Deucher
On Wed, Apr 10, 2019 at 10:25 AM Yintian Tao wrote: > > Under vega10 virtualuzation, smu ip block will not be added. > Therefore, we need add pp clk query and force dpm level function > at amdgpu_virt_ops to support the feature. > > v2: add get_pp_clk existence check and use kzalloc to allocate bu

Re: [PATCH 3/3] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-10 Thread Koenig, Christian
Am 10.04.19 um 17:05 schrieb Grodzovsky, Andrey: > On 4/10/19 10:41 AM, Christian König wrote: >> Am 10.04.19 um 16:28 schrieb Grodzovsky, Andrey: >>> On 4/10/19 10:06 AM, Christian König wrote: Am 09.04.19 um 18:42 schrieb Grodzovsky, Andrey: > On 4/9/19 10:50 AM, Christian König wrote: >

Re: [PATCH 3/3] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-10 Thread Grodzovsky, Andrey
On 4/10/19 10:41 AM, Christian König wrote: > Am 10.04.19 um 16:28 schrieb Grodzovsky, Andrey: >> On 4/10/19 10:06 AM, Christian König wrote: >>> Am 09.04.19 um 18:42 schrieb Grodzovsky, Andrey: On 4/9/19 10:50 AM, Christian König wrote: > Am 08.04.19 um 18:08 schrieb Andrey Grodzovsky: >

Re: [PATCH 3/3] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-10 Thread Christian König
Am 10.04.19 um 16:28 schrieb Grodzovsky, Andrey: On 4/10/19 10:06 AM, Christian König wrote: Am 09.04.19 um 18:42 schrieb Grodzovsky, Andrey: On 4/9/19 10:50 AM, Christian König wrote: Am 08.04.19 um 18:08 schrieb Andrey Grodzovsky: Also reject TDRs if another one already running. Signed-off

Re: [PATCH 3/3] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-10 Thread Grodzovsky, Andrey
On 4/10/19 10:06 AM, Christian König wrote: > Am 09.04.19 um 18:42 schrieb Grodzovsky, Andrey: >> On 4/9/19 10:50 AM, Christian König wrote: >>> Am 08.04.19 um 18:08 schrieb Andrey Grodzovsky: Also reject TDRs if another one already running. Signed-off-by: Andrey Grodzovsky --

[PATCH] drm/amdgpu: support dpm level modification under virtualization v3

2019-04-10 Thread Yintian Tao
Under vega10 virtualuzation, smu ip block will not be added. Therefore, we need add pp clk query and force dpm level function at amdgpu_virt_ops to support the feature. v2: add get_pp_clk existence check and use kzalloc to allocate buf v3: return -ENOMEM for allocation failure and correct the cod

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization v2

2019-04-10 Thread Tao, Yintian
Hi Christian Many thanks for your review. I will correct the patch by v3 Best Regards Yintian Tao -Original Message- From: Christian König Sent: Wednesday, April 10, 2019 10:02 PM To: Tao, Yintian ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: support dpm level modif

Re: [PATCH 3/3] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-10 Thread Christian König
Am 09.04.19 um 18:42 schrieb Grodzovsky, Andrey: On 4/9/19 10:50 AM, Christian König wrote: Am 08.04.19 um 18:08 schrieb Andrey Grodzovsky: Also reject TDRs if another one already running. Signed-off-by: Andrey Grodzovsky ---   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 94

Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization v2

2019-04-10 Thread Christian König
Am 10.04.19 um 15:02 schrieb Yintian Tao: Under vega10 virtualuzation, smu ip block will not be added. Therefore, we need add pp clk query and force dpm level function at amdgpu_virt_ops to support the feature. v2: add get_pp_clk existence check and use kzalloc to allocate buf Change-Id: I71341

[PATCH] drm/amdgpu: support dpm level modification under virtualization v2

2019-04-10 Thread Yintian Tao
Under vega10 virtualuzation, smu ip block will not be added. Therefore, we need add pp clk query and force dpm level function at amdgpu_virt_ops to support the feature. v2: add get_pp_clk existence check and use kzalloc to allocate buf Change-Id: I713419c57b854082f6f739f1d32a055c7115e620 Signed-o

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
Hi Christian Many thanks. The reason is that the reserved buffer for pf2vf communication is allocated from visible VRAM and the allocation granularity from it is page size at amdgpu_ttm_fw_reserve_vram_init. Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sen

Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Koenig, Christian
Hi Yintian, yeah, kzalloc would obvious work. But why do you need such a large buffer in the first place? Rule of thumb is that each function should not use more than 1KB of stack, otherwise the compiler will raise a warning. Christian. Am 10.04.19 um 14:09 schrieb Tao, Yintian: > Hi Christi

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
Hi Christian Thanks for your review. May I use the kzalloc to allocate the memory for the buffer to avoid the stack problem you said? Because hypervisor driver will transfer the message through this page size memory. Best Regards Yintian Tao -Original Message- From: Christian König

RE: [PATCH] drm/ttm: fix incrementing the page pointer for huge pages

2019-04-10 Thread Huang, Ray
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian K?nig > Sent: Wednesday, April 10, 2019 5:46 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/ttm: fix incrementing the page pointer for huge pages > > When we incremen

Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Christian König
Am 10.04.19 um 11:58 schrieb Quan, Evan: -Original Message- From: amd-gfx On Behalf Of Yintian Tao Sent: 2019年4月9日 23:18 To: amd-gfx@lists.freedesktop.org Cc: Tao, Yintian Subject: [PATCH] drm/amdgpu: support dpm level modification under virtualization Under vega10 virtualuzation, sm

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
Hi Evan Many thanks for your review. I will submit v2 patch according to your comments. Best Regards Yintian Tao -Original Message- From: amd-gfx On Behalf Of Quan, Evan Sent: Wednesday, April 10, 2019 5:58 PM To: Tao, Yintian ; amd-gfx@lists.freedesktop.org Cc: Tao, Yintian Subject

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Quan, Evan
> -Original Message- > From: amd-gfx On Behalf Of > Yintian Tao > Sent: 2019年4月9日 23:18 > To: amd-gfx@lists.freedesktop.org > Cc: Tao, Yintian > Subject: [PATCH] drm/amdgpu: support dpm level modification under > virtualization > > Under vega10 virtualuzation, smu ip block will not be

[PATCH] drm/ttm: fix incrementing the page pointer for huge pages

2019-04-10 Thread Christian König
When we increment the counter we need to increment the pointer as well. Signed-off-by: Christian König Fixes: e16858a7e6e7 drm/ttm: fix start page for huge page check in ttm_put_pages() --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
Hi Christian Many thanks. I got it. Hi Alex Can you help review on it? Many thanks in advance. Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: Wednesday, April 10, 2019 4:44 PM To: Tao, Yintian Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/a

Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Koenig, Christian
Hi Yintian, sorry but this is power management and that is not something I'm very familiar with. I can only say that at least on first glance the coding style looks good to me :) Probably best to wait for Alex to wake up. Regards, Christian. Am 10.04.19 um 10:38 schrieb Tao, Yintian: > Ping.

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
Ping Hi Christian Can you help have review on it? Thanks in advance. Best Regards Yintian Tao -Original Message- From: amd-gfx On Behalf Of Yintian Tao Sent: Tuesday, April 09, 2019 11:18 PM To: amd-gfx@lists.freedesktop.org Cc: Tao, Yintian Subject: [PATCH] drm/amdgpu: support