[PATCH] drm/amd/display: Make two functions static

2019-05-10 Thread YueHaibing
Fix sparse warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_clk_mgr.c:260:5: warning: symbol 'dcn10_set_dispclk' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_clk_mgr.c:286:5: warning: symbol 'dcn10_set_dprefclk' was not declared. Should

Re: [PATCH][next] drm/amdgpu: fix return of an uninitialized value in variable ret

2019-05-10 Thread Nathan Chancellor
On Fri, May 10, 2019 at 11:08:42AM +0100, Colin King wrote: > From: Colin Ian King > > In the case where is_enable is false and lo_base_addr is non-zero the > variable ret has not been initialized and is being checked for non-zero > and potentially garbage is being returned. Fix this by not retur

Re: [PATCH] drm/amdgpu: remove static GDS, GWS and OA allocation

2019-05-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, May 10, 2019 at 1:58 PM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > As far as we know this was never used by userspace and so should be > removed. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c |

Re: [PATCH 7/8] drm/amdkfd: New IOCTL to allocate queue GWS

2019-05-10 Thread Kuehling, Felix
On 2019-05-10 12:01 p.m., Zeng, Oak wrote: > Add a new kfd ioctl to allocate queue GWS. Queue > GWS is released on queue destroy. > > Change-Id: I60153c26a577992ad873e4292e759e5c3d5bbd15 > Signed-off-by: Oak Zeng > --- > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 45 > ++

Re: [PATCH 6/8] drm/amdkfd: Add function to add/remove gws to kfd process

2019-05-10 Thread Kuehling, Felix
The subject for this one should start with drm/amdgpu: because it's a change in amdgpu, not KFD. See two more comments inline. Regards,   Felix On 2019-05-10 12:01 p.m., Zeng, Oak wrote: > [CAUTION: External Email] > > GWS bo is shared between all kfd processes. Add function to add gws > to kf

Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-10 Thread Jerome Glisse
On Fri, May 10, 2019 at 07:53:24PM +, Kuehling, Felix wrote: > Don't set this flag by default in hmm_vma_do_fault. It is set > conditionally just a few lines below. Setting it unconditionally > can lead to handle_mm_fault doing a non-blocking fault, returning > -EBUSY and unlocking mmap_sem une

Re: [PATCH 1/2] mm/hmm: support automatic NUMA balancing

2019-05-10 Thread Jerome Glisse
On Fri, May 10, 2019 at 07:53:23PM +, Kuehling, Felix wrote: > From: Philip Yang > > While the page is migrating by NUMA balancing, HMM failed to detect this > condition and still return the old page. Application will use the new > page migrated, but driver pass the old page physical address

[PATCH 1/2] mm/hmm: support automatic NUMA balancing

2019-05-10 Thread Kuehling, Felix
From: Philip Yang While the page is migrating by NUMA balancing, HMM failed to detect this condition and still return the old page. Application will use the new page migrated, but driver pass the old page physical address to GPU, this crash the application later. Use pte_protnone(pte) to return

[PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking

2019-05-10 Thread Kuehling, Felix
Don't set this flag by default in hmm_vma_do_fault. It is set conditionally just a few lines below. Setting it unconditionally can lead to handle_mm_fault doing a non-blocking fault, returning -EBUSY and unlocking mmap_sem unexpectedly. Signed-off-by: Felix Kuehling --- mm/hmm.c | 2 +- 1 file c

[PATCH 0/2] Two bug-fixes for HMM

2019-05-10 Thread Kuehling, Felix
These problems were found in AMD-internal testing as we're working on adopting HMM. They are rebased against glisse/hmm-5.2-v3. We'd like to get them applied to a mainline Linux kernel as well as drm-next and amd-staging-drm-next sooner rather than later. Currently the HMM in amd-staging-drm-next

Re: [RFC PATCH v2 4/5] drm, cgroup: Add total GEM buffer allocation limit

2019-05-10 Thread Kenny Ho
On Fri, May 10, 2019 at 1:48 PM Koenig, Christian wrote: > Well another question is why do we want to prevent that in the first place? > > I mean the worst thing that can happen is that we account a BO multiple > times. That's one of the problems. The other one is the BO outliving the lifetime of

Re: [PATCH] Revert "vgaarb: Keep adding VGA device in queue"

2019-05-10 Thread Aaron Ma
On 5/10/19 11:46 PM, Michel Dänzer wrote: >> Given that the bug is a bit a mess I think we need to add a bit more >> context here in the commit message. My understanding: >> >> Goal of the revert commit was to make the integrated boot device the >> primary one, if we can't detect which one is the b

[PATCH] drm/amdgpu: remove static GDS, GWS and OA allocation

2019-05-10 Thread Christian König
As far as we know this was never used by userspace and so should be removed. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 6 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_gds.h | 21 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 11 +++--- drivers/gp

Re: [RFC PATCH v2 4/5] drm, cgroup: Add total GEM buffer allocation limit

2019-05-10 Thread Koenig, Christian
Am 10.05.19 um 17:25 schrieb Kenny Ho: > [CAUTION: External Email] > > On Fri, May 10, 2019 at 11:08 AM Koenig, Christian > wrote: >> Am 10.05.19 um 16:57 schrieb Kenny Ho: >>> On Fri, May 10, 2019 at 8:28 AM Christian König >>> wrote: Am 09.05.19 um 23:04 schrieb Kenny Ho: >> So the drm cgr

Re: [RFC PATCH v2 0/5] new cgroup controller for gpu/drm subsystem

2019-05-10 Thread Koenig, Christian
Am 10.05.19 um 17:07 schrieb Kenny Ho: > [CAUTION: External Email] > > On Fri, May 10, 2019 at 8:31 AM Christian König > wrote: >> I think it is a good approach to try to add a global limit first and >> when that's working go ahead with limiting device specific resources. > What are some of the gl

Re: [PATCH 2/8] drm/amdgpu: Remove GWS barriers pre-reservation for gfx

2019-05-10 Thread Christian König
Am 10.05.19 um 18:01 schrieb Zeng, Oak: User space allocated GWS barriers are used. The kernel pre-allocated GWS barriers are unused. I have a patch which goes a step further and also removes the GDS and OA stuff as well and also cleans up the internal variables. Give me a moment to dig that

[PATCH 10/16] drm/amd/display: Use DCN functions instead of DCE

2019-05-10 Thread Bhawanpreet Lakha
From: Wesley Chalmers [WHY] DCN code should make as few references to DCE as possible [HOW] Copy DCE110 implementation of find_first_free_match_stream_enc_for_link into DCN10 Signed-off-by: Wesley Chalmers Reviewed-by: Tony Cheng Acked-by: Bhawanpreet Lakha --- .../drm/amd/display/dc/dcn10/

[PATCH 16/16] drm/amd/display: 3.2.31

2019-05-10 Thread Bhawanpreet Lakha
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 8795e29ea888..2

[PATCH 13/16] drm/amd/display: Explicitly specify update type per plane info change

2019-05-10 Thread Bhawanpreet Lakha
From: Nicholas Kazlauskas [Why] The bit for flip addr is being set causing the determination for FAST vs MEDIUM to always return MEDIUM when plane info is provided as a surface update. This causes extreme stuttering for the typical atomic update path on Linux. [How] Don't use update_flags->raw f

[PATCH 12/16] drm/amd/display: Rename EDID_BLOCK_SIZE to DC_EDID_BLOCK_SIZE

2019-05-10 Thread Bhawanpreet Lakha
From: Joshua Aberback Signed-off-by: Joshua Aberback Reviewed-by: Abdoulaye Berthe Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +++--- drivers/gpu/drm/amd/display/dc/dc_types.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dri

[PATCH 11/16] drm/amd/display: Use VCP for extended colorimetry

2019-05-10 Thread Bhawanpreet Lakha
From: Aric Cyr DPRX should send the VCP extended colorimetry packet if the sink supports DPCD rev1.4 and reports the extended colorimetry bit. Signed-off-by: Aric Cyr Reviewed-by: Anthony Koo Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c | 4 ++

[PATCH 15/16] drm/amd/display: Disable ABM before destroy ABM struct

2019-05-10 Thread Bhawanpreet Lakha
From: Paul Hsieh [Why] When disable driver, OS will set backlight optimization then do stop device. But this flag will cause driver to enable ABM when driver disabled. [How] Send ABM disable command before destroy ABM construct Signed-off-by: Paul Hsieh Reviewed-by: Anthony Koo Acked-by: Bha

[PATCH 07/16] drm/amd/display: Program VTG params after programming Global Sync

2019-05-10 Thread Bhawanpreet Lakha
From: Joshua Aberback [Why] VTG has a parameter FP2, which is defined as: if VSTARTUP is before VSYNC: FP2 = number of lines in between VSTARTUP and VSYNC else FP2 = 0 Currently, FP2 is only programmed during "program_timing". However, the position of VSTARTUP is affected

[PATCH 09/16] drm/amd/display: Engine-specific encoder allocation

2019-05-10 Thread Bhawanpreet Lakha
From: Wesley Chalmers [WHY] From DCE110 onward, we have the ability to assign DIG BE and FE separately for any display connector type; before, we could only do this for DP. Signed-off-by: Wesley Chalmers Reviewed-by: Tony Cheng Acked-by: Bhawanpreet Lakha --- .../gpu/drm/amd/display/dc/core/

[PATCH 06/16] drm/amd/display: add null checks and set update flags

2019-05-10 Thread Bhawanpreet Lakha
From: Dmytro Laktyushkin * add plane state null checks * add and set update surface flags Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Bernstein Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/core/dc.c | 6 ++ .../gpu/drm/amd/display/dc/core/dc_resource.c |

[PATCH 08/16] drm/amd/display: enabling stream after HPD low to high happened

2019-05-10 Thread Bhawanpreet Lakha
From: Charlene Liu [Why] 1. No real HPD plug in/out but HPD happens, the driver notifies OS connection changed. 2. No display in target. When HPD goes low to high, the driver should regard as HPD and enter setmode flow. [How] In this case, even stream didn't change but still retrain. Signed-o

[PATCH 05/16] drm/amd/display: 3.2.30

2019-05-10 Thread Bhawanpreet Lakha
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index fb573f483cb5..3

[PATCH 14/16] drm/amd/display: dont set otg offset

2019-05-10 Thread Bhawanpreet Lakha
From: Jun Lei move the update of otg instance outside of hw programming logic, since this is sw state, it should always be updated and should never be optimized away. Signed-off-by: Jun Lei Reviewed-by: Eric Yang Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/core/dc.c | 4 --

[PATCH 03/16] drm/amd/display: Remove DPMS state dependency for fast boot

2019-05-10 Thread Bhawanpreet Lakha
From: SivapiriyanKumarasamy [Why] The DPMS state of a display should not impact whether we want to enable fast boot. Currently fast boot is not enabled when resuming from S4 because of this. [How] Remove check for DPMS state when determining if fast boot can be applied. Signed-off-by: Sivapiri

[PATCH 04/16] drm/amd/display: Reuse MPC OGRAM for 1D blender

2019-05-10 Thread Bhawanpreet Lakha
From: Vitaly Prosyak [Why & How] Reuse existent code path and in order to do that apply de gamma in 1D blender LUT and re use MPC OGAM. Follow up is required. Signed-off-by: Vitaly Prosyak Reviewed-by: Aric Cyr Acked-by: Bhawanpreet Lakha Acked-by: Krunoslav Kovac Acked-by: Vitaly Prosyak -

[PATCH 02/16] drm/amd/display: Hook up CRC capture support for dce120

2019-05-10 Thread Bhawanpreet Lakha
From: Nicholas Kazlauskas [Why] Many IGT tests require CRC capture in order to confirm that the output is visually correct. These skip on dce120 because configure_crc and get_crc aren't set. [How] Hook up is_tg_enabled, configure_crc and get_crc functions on dce120's timing generator. The logi

[PATCH 01/16] drm/amd/display: define v_total_min and max parameters

2019-05-10 Thread Bhawanpreet Lakha
From: Charlene Liu add these parameters for future use Signed-off-by: Charlene Liu Reviewed-by: Dmytro Laktyushkin Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dml/display_mode_structs.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc

[PATCH 00/16] DC Patches 10 May 2019

2019-05-10 Thread Bhawanpreet Lakha
Summary Of Changes * CRC capture for dce112 * EDID read refactor * Explicit update type for planes Aric Cyr (3): drm/amd/display: 3.2.30 drm/amd/display: Use VCP for extended colorimetry drm/amd/display: 3.2.31 Charlene Liu (2): drm/amd/display: define v_total_min and max parameters drm

[PATCH 5/8] drm/amdkfd: Add function to set queue gws

2019-05-10 Thread Zeng, Oak
Add functions in process queue manager to set/get queue gws. Also set process's number of gws used. Currently only one queue in process can use and use all gws. Change-Id: I03e480c8692db3eabfc3a188cce8904d5d962ab7 Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h |

[PATCH 4/8] drm/amdkfd: Allocate gws on device initialization

2019-05-10 Thread Zeng, Oak
On device initialization, KFD allocates all (64) gws which is shared by all KFD processes. Change-Id: I1f1274b8d4f6a8ad08785e2791a9a79def75e913 Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 14 +- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 3 +++ 2 files chang

[PATCH 8/8] drm/amdkfd: PM4 packets change to support GWS

2019-05-10 Thread Zeng, Oak
Add a field in map_queues packet to indicate whether this is a gws control queue. Only one queue per process can be gws control queue. Change num_gws field in map_process packet to 7 bits Change-Id: I0db91d99c6962d14f9202b2eb950f8e7e497b79e Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdkfd/

[PATCH 7/8] drm/amdkfd: New IOCTL to allocate queue GWS

2019-05-10 Thread Zeng, Oak
Add a new kfd ioctl to allocate queue GWS. Queue GWS is released on queue destroy. Change-Id: I60153c26a577992ad873e4292e759e5c3d5bbd15 Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 45 include/uapi/linux/kfd_ioctl.h | 19 ++

[PATCH 1/8] drm/amdkfd: Add gws number to kfd topology node properties

2019-05-10 Thread Zeng, Oak
Add amdgpu_amdkfd interface to get num_gws and add num_gws to /sys/class/kfd/kfd/topology/nodes/x/properties. Only report num_gws if MEC FW support GWS barriers. Currently it is determined by a environment variable which will be replaced with MEC FW version check when firmware is ready. Change-Id:

[PATCH 3/8] drm/amdkfd: Add interface to alloc gws from amdgpu

2019-05-10 Thread Zeng, Oak
Add amdgpu_amdkfd interface to alloc and free gws from amdgpu Change-Id: I4eb418356e5a6051aa09c5e2c4a454263631d6ab Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 34 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 ++ 2 files changed, 36 i

[PATCH 6/8] drm/amdkfd: Add function to add/remove gws to kfd process

2019-05-10 Thread Zeng, Oak
GWS bo is shared between all kfd processes. Add function to add gws to kfd process's bo list so gws can be evicted from and restored for process. Change-Id: I75d74cfdadb7075ff8b2b68634e205deb73dc1ea Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 + drivers/gpu/

[PATCH 2/8] drm/amdgpu: Remove GWS barriers pre-reservation for gfx

2019-05-10 Thread Zeng, Oak
User space allocated GWS barriers are used. The kernel pre-allocated GWS barriers are unused. Change-Id: I7aac259d1f6b7064d02aff231279ff605c29ea34 Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gds.h | 3 +-- drivers/gpu/drm/

Re: [PATCH] Revert "vgaarb: Keep adding VGA device in queue"

2019-05-10 Thread Michel Dänzer
On 2019-05-10 5:42 p.m., Daniel Vetter wrote: > On Fri, May 10, 2019 at 09:29:58AM -0500, Alex Deucher wrote: >> This breaks multiple graphics cards in the Amigaone x5000 >> on PPC. >> >> This reverts commit 3d42f1ddc47a69c0ce155f9f30d764c4d689a5fa. >> >> Bug: https://bugs.freedesktop.org/show_bug.

Re: [PATCH] Revert "vgaarb: Keep adding VGA device in queue"

2019-05-10 Thread Michel Dänzer
On 2019-05-10 4:29 p.m., Alex Deucher wrote: > This breaks multiple graphics cards in the Amigaone x5000 > on PPC. > > This reverts commit 3d42f1ddc47a69c0ce155f9f30d764c4d689a5fa. > > Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109345 It's not clear to me yet that this was really a regres

Re: [PATCH] Revert "vgaarb: Keep adding VGA device in queue"

2019-05-10 Thread Daniel Vetter
On Fri, May 10, 2019 at 09:29:58AM -0500, Alex Deucher wrote: > This breaks multiple graphics cards in the Amigaone x5000 > on PPC. > > This reverts commit 3d42f1ddc47a69c0ce155f9f30d764c4d689a5fa. > > Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109345 > Signed-off-by: Alex Deucher > CC: A

Re: [RFC PATCH v2 4/5] drm, cgroup: Add total GEM buffer allocation limit

2019-05-10 Thread Kenny Ho
On Fri, May 10, 2019 at 11:08 AM Koenig, Christian wrote: > Am 10.05.19 um 16:57 schrieb Kenny Ho: > > On Fri, May 10, 2019 at 8:28 AM Christian König > > wrote: > >> Am 09.05.19 um 23:04 schrieb Kenny Ho: > So the drm cgroup container is separate to other cgroup containers? In cgroup-v1, which i

Re: [RFC PATCH v2 0/5] new cgroup controller for gpu/drm subsystem

2019-05-10 Thread Kenny Ho
On Fri, May 10, 2019 at 8:31 AM Christian König wrote: > > I think it is a good approach to try to add a global limit first and > when that's working go ahead with limiting device specific resources. What are some of the global drm resource limit/allocation that would be useful to implement? I wou

Re: [RFC PATCH v2 4/5] drm, cgroup: Add total GEM buffer allocation limit

2019-05-10 Thread Koenig, Christian
Am 10.05.19 um 16:57 schrieb Kenny Ho: > [CAUTION: External Email] > > On Fri, May 10, 2019 at 8:28 AM Christian König > wrote: >> Am 09.05.19 um 23:04 schrieb Kenny Ho: >>> + /* only allow bo from the same cgroup or its ancestor to be imported >>> */ >>> + if (drmcgrp != NULL && >>> +

Re: [RFC PATCH v2 4/5] drm, cgroup: Add total GEM buffer allocation limit

2019-05-10 Thread Kenny Ho
On Fri, May 10, 2019 at 8:28 AM Christian König wrote: > > Am 09.05.19 um 23:04 schrieb Kenny Ho: > > + /* only allow bo from the same cgroup or its ancestor to be imported > > */ > > + if (drmcgrp != NULL && > > + !drmcgrp_is_self_or_ancestor(drmcgrp, obj->drmcgrp)) {

[PATCH] Revert "vgaarb: Keep adding VGA device in queue"

2019-05-10 Thread Alex Deucher
This breaks multiple graphics cards in the Amigaone x5000 on PPC. This reverts commit 3d42f1ddc47a69c0ce155f9f30d764c4d689a5fa. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109345 Signed-off-by: Alex Deucher CC: Aaron Ma --- drivers/gpu/vga/vgaarb.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH][next] drm/amdgpu: fix return of an uninitialized value in variable ret

2019-05-10 Thread Colin King
From: Colin Ian King In the case where is_enable is false and lo_base_addr is non-zero the variable ret has not been initialized and is being checked for non-zero and potentially garbage is being returned. Fix this by not returning ret but instead returning -EINVAL on the zero lo_base_addr case.

Re: [RFC PATCH v2 0/5] new cgroup controller for gpu/drm subsystem

2019-05-10 Thread Christian König
That looks better than I thought it would be. I think it is a good approach to try to add a global limit first and when that's working go ahead with limiting device specific resources. The only major issue I can see is on patch #4, see there for further details. Christian. Am 09.05.19 um 2

Re: [RFC PATCH v2 4/5] drm, cgroup: Add total GEM buffer allocation limit

2019-05-10 Thread Christian König
Am 09.05.19 um 23:04 schrieb Kenny Ho: The drm resource being measured and limited here is the GEM buffer objects. User applications allocate and free these buffers. In addition, a process can allocate a buffer and share it with another process. The consumer of a shared buffer can also outlive

Re: [RFC PATCH v2 5/5] drm, cgroup: Add peak GEM buffer allocation limit

2019-05-10 Thread Christian König
Am 09.05.19 um 23:04 schrieb Kenny Ho: This new drmcgrp resource limits the largest GEM buffer that can be allocated in a cgroup. Change-Id: I0830d56775568e1cf215b56cc892d5e7945e9f25 Signed-off-by: Kenny Ho --- include/linux/cgroup_drm.h | 2 ++ kernel/cgroup/drm.c| 59 +

Re: [PATCH] drm/amdgpu: avoid duplicated tmo report on same job

2019-05-10 Thread Koenig, Christian
Yeah, that's indeed a bit problematic. How about calling drm_sched_suspend_timeout() then? On the other hand just suppressing the logging is fine with me as well. Christian. Am 10.05.19 um 12:01 schrieb Liu, Monk: > Christian, > > Would your approach leave the global queue (which holds TDR work

Compiler warnings with current amd-staging-drm-next

2019-05-10 Thread Michel Dänzer
drivers/gpu/drm//amd/amdgpu/df_v3_6.c: In function ‘df_v3_6_pmc_start’: drivers/gpu/drm//amd/amdgpu/df_v3_6.c:464:2: warning: enumeration value ‘CHIP_TAHITI’ not handled in switch [-Wswitch] switch (adev->asic_type) { ^~ drivers/gpu/drm//amd/amdgpu/df_v3_6.c:464:2: warning: enumeration va

Re: [PATCH][next] drm/amdgpu: fix return of an uninitialized value in variable ret

2019-05-10 Thread Dan Carpenter
On Fri, May 10, 2019 at 11:08:42AM +0100, Colin King wrote: > From: Colin Ian King > > In the case where is_enable is false and lo_base_addr is non-zero the > variable ret has not been initialized and is being checked for non-zero > and potentially garbage is being returned. Fix this by not retur

RE: [PATCH] drm/amdgpu: avoid duplicated tmo report on same job

2019-05-10 Thread Liu, Monk
Christian, Would your approach leave the global queue (which holds TDR work) stuck there and other work item never get handled ? /Monk -Original Message- From: Koenig, Christian Sent: Friday, May 10, 2019 4:58 PM To: Liu, Monk ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/am

Re: [PATCH] drm/amdgpu: avoid duplicated tmo report on same job

2019-05-10 Thread Koenig, Christian
Hi Monk, yeah, that's much closer to what I had in mind. But your comments got me thinking more about this. What do you think about changing amdgpu_job_timedout() like this:     if (amdgpu_device_should_recover_gpu(ring->adev))     amdgpu_device_gpu_recover(ring->adev, job); + 

[PATCH 2/2] drm/amd/powerplay: Enable "disable dpm" feature for vega20 power functions.

2019-05-10 Thread Chengming Gui
use pm_enabled to control all power related functions about vega20. Signed-off-by: Chengming Gui --- drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 48 +++--- 1 file changed, 38 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c b/drive

[PATCH 1/2] drm/amd/powerplay: Enable "disable dpm" feature to support swSMU debug

2019-05-10 Thread Chengming Gui
add pm_enabled to control the dpm off/on. Signed-off-by: Chengming Gui --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 34 +++--- drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 1 + drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 34 ++ 3 file

[PATCH][next] drm/amdgpu: fix spelling mistake "retrived" -> "retrieved"

2019-05-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in a DRM_ERROR error message. Fix this. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c b/drivers/gpu/drm/amd/amdgpu

[PATCH] drm/amdgpu: avoid duplicated tmo report on same job

2019-05-10 Thread Monk Liu
Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c| 12 +++- include/drm/gpu_scheduler.h| 1 + 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_devic

RE: [PATCH] drm/amdgpu: avoid duplicated tmo report on same job

2019-05-10 Thread Liu, Monk
Hi Christian, What about this one, no timer logic change on scheduler part, only the duplicated tmo report is muted /Monk -Original Message- From: amd-gfx On Behalf Of Monk Liu Sent: Friday, May 10, 2019 3:18 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: [PATCH] drm/am