Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-13 Thread Kees Cook
On Thu, Jun 13, 2019 at 04:26:32PM +0100, Catalin Marinas wrote: > On Thu, Jun 13, 2019 at 12:02:35PM +0100, Dave P Martin wrote: > > On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: > > > +static int zero; > > > +static int one = 1; > > > > !!! > > > > And these can't even be

RE: [PATCH] drm/amdgpu: Need to set the baco cap before baco reset

2019-06-13 Thread Deng, Emily
Hi Russell, This patch will read vbios, and parse vbios to get the baco reset feature bit. From the call trace, it shows error in " amdgpu_get_bios ", but this patch don't modify amdgpu_get_bios, and code before amdgpu_get_bios. Please first check why it will has error when read vbios.

[PATCH] drm/amdgpu: Fix connector atomic_check compilation fail

2019-06-13 Thread Sean Paul
From: Sean Paul I missed amdgpu in my connnector_helper_funcs->atomic_check conversion, which is understandably causing compilation failures. Fixes: 6f3b62781bbd ("drm: Convert connector_helper_funcs->atomic_check to accept drm_atomic_state") Cc: Daniel Vetter Cc: Ville Syrjälä Cc: Jani

Re: [PATCH] drm/amd/display: fix compilation error

2019-06-13 Thread Alex Deucher
On Thu, Jun 13, 2019 at 2:42 PM Sam Ravnborg wrote: > > Hi Alex. > > On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote: > > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam > > wrote: > > > > > > this patch fixes below compilation error > > > > > >

Re: [PATCH] drm/amd/display: fix compilation error

2019-06-13 Thread Sam Ravnborg
Hi Alex. On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote: > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam > wrote: > > > > this patch fixes below compilation error > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In > > function

Re: [PATCH] drm/amdgpu: only use kernel zone if need_dma32 is not required

2019-06-13 Thread Koenig, Christian
Am 13.06.19 um 18:37 schrieb Kuehling, Felix: > [SNIP] There is an issue found by KFDTest.BigBufStressTest, it allocates buffers up to 3/8 of total 256GB system memory, each buffer size is 128MB, then use queue to write to the buffers. If ttm_mem_global_alloc_page get page pfn

Re: [PATCH] drm/amdgpu: only use kernel zone if need_dma32 is not required

2019-06-13 Thread Kuehling, Felix
On 2019-06-13 8:59, Yang, Philip wrote: > On 2019-06-13 4:54 a.m., Koenig, Christian wrote: >> Am 12.06.19 um 23:13 schrieb Yang, Philip: >>> On 2019-06-12 3:28 p.m., Christian König wrote: Am 12.06.19 um 17:13 schrieb Yang, Philip: > TTM create two zones, kernel zone and dma32 zone for

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-13 Thread Vincenzo Frascino
On 13/06/2019 16:57, Catalin Marinas wrote: > On Thu, Jun 13, 2019 at 04:45:54PM +0100, Vincenzo Frascino wrote: >> On 13/06/2019 16:35, Catalin Marinas wrote: >>> On Thu, Jun 13, 2019 at 12:16:59PM +0100, Dave P Martin wrote: On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-13 Thread Catalin Marinas
On Thu, Jun 13, 2019 at 04:45:54PM +0100, Vincenzo Frascino wrote: > On 13/06/2019 16:35, Catalin Marinas wrote: > > On Thu, Jun 13, 2019 at 12:16:59PM +0100, Dave P Martin wrote: > >> On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: > >>> + > >>> +/* > >>> + * Control the relaxed

Re: [PATCH] drm/amdgpu: only use kernel zone if need_dma32 is not required

2019-06-13 Thread Yang, Philip
On 2019-06-13 4:54 a.m., Koenig, Christian wrote: > Am 12.06.19 um 23:13 schrieb Yang, Philip: >> On 2019-06-12 3:28 p.m., Christian König wrote: >>> Am 12.06.19 um 17:13 schrieb Yang, Philip: TTM create two zones, kernel zone and dma32 zone for system memory. If system memory address

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-13 Thread Vincenzo Frascino
On 13/06/2019 16:35, Catalin Marinas wrote: > On Thu, Jun 13, 2019 at 12:16:59PM +0100, Dave P Martin wrote: >> On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: >>> From: Catalin Marinas >>> >>> It is not desirable to relax the ABI to allow tagged user addresses into >>> the

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-13 Thread Catalin Marinas
On Thu, Jun 13, 2019 at 12:16:59PM +0100, Dave P Martin wrote: > On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: > > From: Catalin Marinas > > > > It is not desirable to relax the ABI to allow tagged user addresses into > > the kernel indiscriminately. This patch introduces a

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-13 Thread Catalin Marinas
Hi Dave, On Thu, Jun 13, 2019 at 12:02:35PM +0100, Dave P Martin wrote: > On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: > > +/* > > + * Global sysctl to disable the tagged user addresses support. This control > > + * only prevents the tagged address ABI enabling via prctl()

Re: [PATCH] radeon: no need to check return value of debugfs_create functions

2019-06-13 Thread Alex Deucher
On Thu, Jun 13, 2019 at 7:56 AM Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Alex Deucher > Cc: "Christian König" >

Re: [PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

2019-06-13 Thread Alex Deucher
On Tue, Jun 4, 2019 at 4:22 PM Yrjan Skrimstad wrote: > > On Thu, May 30, 2019 at 02:08:21AM +0200, Yrjan Skrimstad wrote: > > This driver currently contains a repeated 500ms blocking delay call > > which causes frequent major buffer underruns in PulseAudio. This patch > > fixes this issue by

Re: [PATCH] amdgpu_dm: no need to check return value of debugfs_create functions

2019-06-13 Thread Kazlauskas, Nicholas
On 6/13/19 9:20 AM, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc:

[PATCH] amdkfd: no need to check return value of debugfs_create functions

2019-06-13 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Oded Gabbay Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: David Airlie Cc: Daniel

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-13 Thread Dave Martin
On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: > From: Catalin Marinas > > It is not desirable to relax the ABI to allow tagged user addresses into > the kernel indiscriminately. This patch introduces a prctl() interface > for enabling or disabling the tagged ABI with a global

[PATCH] amdgpu: no need to check return value of debugfs_create functions

2019-06-13 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: David Airlie Cc: Daniel Vetter Cc:

[PATCH] amdgpu_dm: no need to check return value of debugfs_create functions

2019-06-13 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: David

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-06-13 Thread Dave Martin
On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: > From: Catalin Marinas > > It is not desirable to relax the ABI to allow tagged user addresses into > the kernel indiscriminately. This patch introduces a prctl() interface > for enabling or disabling the tagged ABI with a global

[PATCH] radeon: no need to check return value of debugfs_create functions

2019-06-13 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: David Airlie Cc: Daniel Vetter Cc:

RE: [PATCH] drm/amdgpu: Need to set the baco cap before baco reset

2019-06-13 Thread Russell, Kent
Hi Emily, This patch caused a regression on MI25 (Chip 6860, VBIOS 113-D0513700-001) machines where the driver would not boot. Note that this was not seen on Vega10 Frontier (Chip 6863, VBIOS 113-D0501100-X09) or Radeon64 (Chip 697f). Reverting this patch resolved the issue with no other work

RE: [PATCH] drm/amdgpu: return 0 by default in amdgpu_pm_load_smu_firmware

2019-06-13 Thread Huang, Ray
> -Original Message- > From: amd-gfx On Behalf Of Paul > Menzel > Sent: Thursday, June 13, 2019 6:32 PM > To: Alex Deucher > Cc: Deucher, Alexander ; Sibren Vasse > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: return 0 by default in > amdgpu_pm_load_smu_firmware >

Re: [PATCH] drm/amdgpu: return 0 by default in amdgpu_pm_load_smu_firmware

2019-06-13 Thread Paul Menzel
Dear Alex, On 06/11/19 16:51, Alex Deucher wrote: > Fixes SI cards running on amdgpu. Shouldn’t the caller be updated to check for the error code? Wouldn’t that be more explicit? else if (!strcmp(chip_name, "raven") && (amdgpu_pm_load_smu_firmware(adev, _version) == 0) > Fixes:

Re: [PATCH] drm/amdgpu: only use kernel zone if need_dma32 is not required

2019-06-13 Thread Koenig, Christian
Am 12.06.19 um 23:13 schrieb Yang, Philip: > On 2019-06-12 3:28 p.m., Christian König wrote: >> Am 12.06.19 um 17:13 schrieb Yang, Philip: >>> TTM create two zones, kernel zone and dma32 zone for system memory. If >>> system memory address allocated is below 4GB, this account to dma32 zone >>> and

Re: [PATCH] drm/amd/display: fix compilation error

2019-06-13 Thread Daniel Vetter
On Thu, Jun 13, 2019 at 08:18:54AM +0530, Hariprasad Kelam wrote: > On Wed, Jun 12, 2019 at 10:35:26PM -0400, Alex Deucher wrote: > > On Wed, Jun 12, 2019 at 10:34 PM Hariprasad Kelam > > wrote: > > > > > > this patch fixes below compilation error > > > > > >