Re: [PATCH -next] drm/amdgpu: remove set but not used variables 'ret'

2019-06-22 Thread Julia Lawall
On Sun, 23 Jun 2019, Dan Carpenter wrote: > On Sat, Jun 22, 2019 at 01:43:19PM +0300, Dan Carpenter wrote: > > On Sat, Jun 22, 2019 at 11:03:14AM +0800, Mao Wenan wrote: > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c > > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c > > > index 0e6db

Re: [PATCH -next] drm/amdgpu: remove set but not used variables 'ret'

2019-06-22 Thread Dan Carpenter
On Sat, Jun 22, 2019 at 01:43:19PM +0300, Dan Carpenter wrote: > On Sat, Jun 22, 2019 at 11:03:14AM +0800, Mao Wenan wrote: > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c > > index 0e6dba9..0bf4dd9 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/

[pull] amdgpu, amdkfd, radeon drm-next-5.3

2019-06-22 Thread Alex Deucher
Hi Dave, Daniel, Last round of updates for 5.3. The big one here is navi10 support. The rest is just a few other odds and ends. My first shot at annotated tags. The following changes since commit 561564bea3248293398dc32ec36da40fb71faed0: Merge tag 'omapdrm-5.3' of git://git.kernel.org/pub/s

Re: [PATCH -next v2] drm/amdgpu: return 'ret' in amdgpu_pmu_init

2019-06-22 Thread Joe Perches
On Sat, 2019-06-22 at 21:05 +0800, Mao Wenan wrote: > There is one warning: > drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c: In function ‘amdgpu_pmu_init’: > drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:249:6: warning: variable ‘ret’ set > but not used [-Wunused-but-set-variable] > int ret = 0; [] > v1->v

Re: [PATCH -next v2] drm/amdgpu: return 'ret' in amdgpu_pmu_init

2019-06-22 Thread Julia Lawall
On Sat, 22 Jun 2019, maowenan wrote: > > > On 2019/6/22 21:06, Julia Lawall wrote: > > > > > > On Sat, 22 Jun 2019, Mao Wenan wrote: > > > >> There is one warning: > >> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c: In function ‘amdgpu_pmu_init’: > >> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:249:6: war

Re: [PATCH -next v2] drm/amdgpu: return 'ret' in amdgpu_pmu_init

2019-06-22 Thread maowenan
On 2019/6/22 21:06, Julia Lawall wrote: > > > On Sat, 22 Jun 2019, Mao Wenan wrote: > >> There is one warning: >> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c: In function ‘amdgpu_pmu_init’: >> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:249:6: warning: variable ‘ret’ set >> but not used [-Wunused-bu

Re: [PATCH -next v2] drm/amdgpu: return 'ret' in amdgpu_pmu_init

2019-06-22 Thread Julia Lawall
On Sat, 22 Jun 2019, Mao Wenan wrote: > There is one warning: > drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c: In function ‘amdgpu_pmu_init’: > drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:249:6: warning: variable ‘ret’ set > but not used [-Wunused-but-set-variable] > int ret = 0; > ^ > amdgpu_pmu

[PATCH -next v2] drm/amdgpu: return 'ret' in amdgpu_pmu_init

2019-06-22 Thread Mao Wenan
There is one warning: drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c: In function ‘amdgpu_pmu_init’: drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:249:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] int ret = 0; ^ amdgpu_pmu_init() is called by amdgpu_device_init() in drivers/g

Re: [PATCH -next] drm/amdgpu: remove set but not used variables 'ret'

2019-06-22 Thread Dan Carpenter
On Sat, Jun 22, 2019 at 11:03:14AM +0800, Mao Wenan wrote: > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c > index 0e6dba9..0bf4dd9 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c > @@ -246,12

Re: [PATCH -next] drm/amdgpu: remove set but not used variables 'ret'

2019-06-22 Thread maowenan
On 2019/6/22 14:02, Julia Lawall wrote: > > > On Sat, 22 Jun 2019, Mao Wenan wrote: > >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c: In function ‘amdgpu_pmu_init’: >> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:249:6: warning: variable ‘ret’ set