It's looks fine for me.
Reviewed-by: Kevin Wang
Best Regards,
Kevin
On 7/30/19 2:01 PM, Kenneth Feng wrote:
> provide the interface for DAL to disable uclk switch on navi10.
> in this case, the uclk will be fixed to maximum.
> this is a workaround when display configuration causes underflow iss
provide the interface for DAL to disable uclk switch on navi10.
in this case, the uclk will be fixed to maximum.
this is a workaround when display configuration causes underflow issue.
Signed-off-by: Kenneth Feng
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 14
drivers/g
On 7/30/19 12:09 PM, Kenneth Feng wrote:
> provide the interface for DAL to disable uclk switch on navi10.
> in this case, the uclk will be fixed to maximum.
> this is a workaround when display configuration causes underflow issue.
>
> Signed-off-by: Kenneth Feng
> ---
> .../drm/amd/display/amd
provide the interface for DAL to disable uclk switch on navi10.
in this case, the uclk will be fixed to maximum.
this is a workaround when display configuration causes underflow issue.
Signed-off-by: Kenneth Feng
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 17 +++
driver
On 7/30/19 4:14 AM, Alex Deucher wrote:
> From: Evan Quan
>
> Initialize arcturus SMU metrics table.
>
> Signed-off-by: Evan Quan
> Reviewed-by: Kevin Wang
> Reviewed-by: Alex Deucher
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 7 +++
> 1 file c
On 7/30/19 4:14 AM, Alex Deucher wrote:
> From: Evan Quan
>
> No VCN DPM bit check as that's different from VCN PG. Also
> no extra check for possible double enablement/disablement
> as that's already done by VCN.
>
> Signed-off-by: Evan Quan
> Reviewed-by: Kenneth Feng
> Signed-off-by: Alex De
[ By request, resending to include amd-gfx + intel-gfx. Since resending,
I fixed the nit with ordering of header includes that Sam noted. ]
This RFC series is first implementation of some ideas expressed
earlier on dri-devel [1].
Some of the goals (open for much debate) are:
- Create common
Introduce DRM memory region types to be common for both drivers using
TTM and for i915. For now, TTM continues to define it's own set but
uses the DRM base definitions.
Signed-off-by: Brian Welty
---
include/drm/drm_mm.h| 8
include/drm/ttm/ttm_placement.h | 8
2 f
Some fields are deleted from intel_memory_region in favor of instead
using the new nested drm_mem_region structure.
Note, this is based upon unmerged i915 series [1] in order to show how
i915 might begin to integrate the proposed drm_mem_region.
[1] https://lists.freedesktop.org/archives/intel-gf
Move basic members of ttm_mem_type_manager into a new DRM memory region
structure. The idea is for this base structure to be nested inside
the TTM structure and later in Intel's proposed intel_memory_region.
As comments in the code suggest, the following future work can extend
the usefulness of t
From: Kevin Wang
remove redundacy debug log in smu.
eg:
[ 6897.969447] amdgpu: [powerplay] smu 11 clk dpm feature 1 is not enabled
[ 6897.969448] amdgpu: [powerplay] smu 11 clk dpm feature 1 is not enabled
[ 6897.969448] amdgpu: [powerplay] smu 11 clk dpm feature 1 is not enabled
[ 6899.024114] a
From: Evan Quan
The power limit retrieval should be done per asic. Since we may
need to lookup in the pptable and that's really asic specific.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 2 +-
drivers/gpu
From: Evan Quan
Add missing feature maps for arcturus.
Signed-off-by: Evan Quan
Reviewed-by: Kevin Wang
Reviewed-by: Alex Deucher
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerpl
From: Evan Quan
Support arcturus fan speed retrieval.
Signed-off-by: Evan Quan
Reviewed-by: Kevin Wang
Reviewed-by: Alex Deucher
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 40
1 file changed, 40 insertions(+)
diff --git a/drivers/gpu
From: Evan Quan
VCN is widely used in new ASICs and different from tranditional
UVD and VCE.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/include/kgd_pp_interface.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/a
From: Evan Quan
There may be 1Mhz delta between target and actual frequency. That
should be taken into consideration for current level check.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 35 +++--
From: Evan Quan
Those bitmask prefixed by "SMU_" should be used.
Signed-off-by: Evan Quan
Reviewed-by: Kevin Wang
Reviewed-by: Alex Deucher
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
From: Evan Quan
Make sure we can still get the accurate gfxclk/uclk/socclk frequency
even on dpm disabled.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 30 +++-
1 file changed, 29 insertions(
From: Evan Quan
Per current logics, the features to enable are determined together
by driver and pptable. This is not efficient in co-debug with
firmware team.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 6
From: Evan Quan
Commonly used for VCN powergate status retrieval for SW SMU.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerplay/amd
From: Evan Quan
No VCN DPM bit check as that's different from VCN PG. Also
no extra check for possible double enablement/disablement
as that's already done by VCN.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/navi10_ppt.c |
From: Evan Quan
Arcturus ASIC specific powerplay interfaces.
V2: correct SMU msg naming
drop unnecessary debugs
V3: rebase (Alex)
Signed-off-by: Evan Quan
Reviewed-by: Kevin Wang
Reviewed-by: Le Ma
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1193 ++
From: Evan Quan
Enable arcturus SW SMU routines.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 49 +-
1 file changed, 30 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/amd/powe
From: Hawking Zhang
we should pass irq type, instead of irq client id,
to irq_get/put interface
Signed-off-by: Hawking Zhang
Reviewed-by: Feifei Xu
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
From: Evan Quan
Enable arcturus real-time clock retrieval.
Signed-off-by: Evan Quan
Reviewed-by: Kevin Wang
Reviewed-by: Alex Deucher
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 24
1 file changed, 24 insertions(+)
diff --git a/driver
From: Evan Quan
Arcturus VCN should powergate in the way as Navi.
Signed-off-by: Evan Quan
Reviewed-by: Le Ma
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
From: Evan Quan
Enable arcturus UMD PSTATE support.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 229 ++-
1 file changed, 225 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/p
From: Evan Quan
Initialize base address for those IPs which are used in powerplay.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/arct_reg_init.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/ar
From: Evan Quan
VCN should be used for Vega20 later ASICs while UVD and VCE
are for previous ASICs.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 56 +-
1 file changed, 36 insertions(+), 20
From: Evan Quan
As for now, only "Prefetcher" is guarded to be working from
SMU firmware.
Signed-off-by: Evan Quan
Reviewed-by: Hawking Zhang
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/dri
From: Evan Quan
Enable VCN powergate status report on Raven.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/s
From: Evan Quan
Arcturus powerplay is ready to use.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c
b/drivers/gpu/drm/amd/amdgpu/soc15
From: Evan Quan
Initialize arcturus SMU metrics table.
Signed-off-by: Evan Quan
Reviewed-by: Kevin Wang
Reviewed-by: Alex Deucher
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/amd/power
From: Evan Quan
Support sensor reading for gpu loading, power and
temperatures.
Signed-off-by: Evan Quan
Reviewed-by: Kevin Wang
Reviewed-by: Alex Deucher
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 142 +++
1 file changed, 142 insertions(+
From: Le Ma
Update for sdma ras ecc_irq and other minors.
Signed-off-by: Le Ma
Reviewed-by: Hawking Zhang
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 77 +-
1 file changed, 27 insertions(+), 50 deletions(-)
diff --git a/drivers/gpu/drm/am
From: Evan Quan
This is especially useful in early bring up phase.
v2: disabled by default (Alex)
Signed-off-by: Evan Quan
Reviewed-by: Le Ma
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 ++
drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 4 +++-
2 fil
From: Evan Quan
It guides how driver should interface with SMU in arcturus.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
.../powerplay/inc/smu11_driver_if_arcturus.h | 58 +++
1 file changed, 33 insertions(+), 25 deletions(-)
diff --git
From: Evan Quan
New smcdpminfo table used in arcturus.
Signed-off-by: Evan Quan
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/include/atomfirmware.h | 86 ++
1 file changed, 86 insertions(+)
diff --git a/drivers/gpu/drm/amd/include/atomfir
From: Le Ma
Arcturus has different _BASE_IDX value in some HWIP_offset.h. To make source
files like smu_v11_0.c and soc15.c that include HWIP_offset.h of Vega20
reusable for Arcturus, align this base offset with Vega20.
Signed-off-by: Le Ma
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
From: Evan Quan
Correct header and fix typo.
Signed-off-by: Evan Quan
Reviewed-by: Le Ma
Reviewed-by: Kenneth Feng
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/inc/arcturus_ppsmc.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/p
This series updates arcturus support enabling powerplay and assorted
bug fixes.
Evan Quan (26):
drm/amd/powerplay: add smcdpminfo table v4_6 support
drm/amd/powerplay: add SW SMU interface for dumping pptable out (v2)
drm/amd/powerplay: update smu11_driver_if_arcturus.h
drm/amd/powerplay:
Series is:
reviewed-by: shaoyunl
On 2019-07-29 11:31 a.m., Cornwall, Jay wrote:
> VCC moved out of user SGPR allocation in gfx10. It's now stored
> in SGPRs 106-107.
>
> Also fixes incorrect SGPR read offsets.
>
> Cc: Shaoyun Liu
> Signed-off-by: Jay Cornwall
> ---
> drivers/gpu/drm/amd/amdkf
On Mon, Jul 29, 2019 at 11:31 AM Cornwall, Jay wrote:
>
> VCC moved out of user SGPR allocation in gfx10. It's now stored
> in SGPRs 106-107.
>
> Also fixes incorrect SGPR read offsets.
>
> Cc: Shaoyun Liu
> Signed-off-by: Jay Cornwall
Series is:
Acked-by: Alex Deucher
> ---
> drivers/gpu/dr
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Michel
Dänzer
Sent: Monday, July 29, 2019 12:20 PM
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH] drm/amdgpu: Update pitch on page flips without DC as well
From: Michel Dänzer
DC already handles this c
From: Michel Dänzer
DC already handles this correctly since amdgpu minor version 31. Bump
the minor version again so that xf86-video-amdgpu can take advantage of
this working without DC as well now.
Signed-off-by: Michel Dänzer
---
See
https://gitlab.freedesktop.org/xorg/driver/xf86-video-amd
VCC moved out of user SGPR allocation in gfx10. It's now stored
in SGPRs 106-107.
Also fixes incorrect SGPR read offsets.
Cc: Shaoyun Liu
Signed-off-by: Jay Cornwall
---
drivers/gpu/drm/amd/amdkfd/cwsr_trap_handler.h | 452 ++---
.../gpu/drm/amd/amdkfd/cwsr_trap_handler_gfx
Copy/paste error, first 4 VGPRs are separated by 64 dwords (256 bytes).
Cc: Shaoyun Liu
Signed-off-by: Jay Cornwall
---
drivers/gpu/drm/amd/amdkfd/cwsr_trap_handler.h | 6 +++---
drivers/gpu/drm/amd/amdkfd/cwsr_trap_handler_gfx10.asm | 6 +++---
2 files changed, 6 insertions(+), 6 delet
These moved from SGPRs in gfx9 to HWREG in gfx10.
Cc: Shaoyun Liu
Signed-off-by: Jay Cornwall
---
drivers/gpu/drm/amd/amdkfd/cwsr_trap_handler.h | 56 +-
.../gpu/drm/amd/amdkfd/cwsr_trap_handler_gfx10.asm | 14 ++
2 files changed, 48 insertions(+), 22 deletions(-)
d
Is this a known issue?
No, that looks like a new one to me.
Is that somehow reproducible?
Christian.
Am 29.07.19 um 10:14 schrieb Bas Nieuwenhuizen:
Hi all,
I have a TTM refcount issue:
[173774.309968] [ cut here ]
[173774.309970] kernel BUG at drivers/gpu/drm/ttm/tt
On Fri, 2019-07-26 at 19:23 +0200, Andrzej Pietrasiewicz wrote:
> Use the ddc pointer provided by the generic connector.
>
> Signed-off-by: Andrzej Pietrasiewicz
Acked-by: Philipp Zabel
Thanks!
regards
Philipp
> ---
> drivers/gpu/drm/imx/imx-ldb.c | 7 ---
> 1 file changed, 4 insertions
On Fri, 2019-07-26 at 19:23 +0200, Andrzej Pietrasiewicz wrote:
> Use the ddc pointer provided by the generic connector.
>
> Signed-off-by: Andrzej Pietrasiewicz
Acked-by: Philipp Zabel
regards
Philipp
> ---
> drivers/gpu/drm/imx/imx-tve.c | 6 --
> 1 file changed, 4 insertions(+), 2 del
On Wed, 24 Jul 2019, Andrzej Pietrasiewicz wrote:
> Allow passing ddc adapter pointer to the init function. Even if
> drm_connector_init() sometime in the future decides to e.g. memset() all
> connector fields to zeros, the newly added function ensures that at its
> completion the ddc member of co
In radeon_connector_set_property(), there is an if statement on line 743
to check whether connector->encoder is NULL:
if (connector->encoder)
When connector->encoder is NULL, it is used on line 755:
if (connector->encoder->crtc)
Thus, a possible null-pointer dereference may occur.
To fix
Hi all,
I have a TTM refcount issue:
[173774.309968] [ cut here ]
[173774.309970] kernel BUG at drivers/gpu/drm/ttm/ttm_bo.c:202!
[173774.309982] invalid opcode: [#1] PREEMPT SMP NOPTI
[173774.309985] CPU: 13 PID: 128214 Comm: kworker/13:2 Not tainted
5.2.0-rc1-g3f2e5
Coccinelle reports a path that the array "data" is never initialized.
The path skips the checks in the conditional branches when either
of callback functions, read_wave_vgprs and read_wave_sgprs, is not
registered. Later, the uninitialized "data" array is read
in the while-loop below and passed to
55 matches
Mail list logo
