Re: [PATCH] drm/amdgpu: introduce vram lost for reset

2019-08-27 Thread Christian König
Am 27.08.19 um 10:34 schrieb Monk Liu: for SOC15/vega10 the BACO reset & mode1 would introduce vram lost in high end address range, current kmd's vram lost checking cannot catch it since it only check very ahead visible frame buffer Looks mostly good to me. Only question I have is why to use a

Re: [PATCH v2] drm/amdgpu: Default disable GDS for compute+gfx

2019-08-27 Thread zhoucm1
On 2019/7/23 上午3:08, Christian König wrote: Am 22.07.19 um 17:34 schrieb Greathouse, Joseph: Units in the GDS block default to allowing all VMIDs access to all entries. Disable shader access to the GDS, GWS, and OA blocks from all compute and gfx VMIDs by default. For compute, HWS firmware will

RE: [PATCH] drm/amdgpu: introduce vram lost for reset

2019-08-27 Thread Liu, Monk
sure _ Monk Liu|GPU Virtualization Team |AMD [sig-cloud-gpu] From: Deucher, Alexander Sent: Tuesday, August 27, 2019 8:48 PM To: Liu, Monk ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: introduce vram lost for reset Can you update nv.c as we

Re: [PATCH 2/2] mm/hmm: hmm_range_fault() infinite loop

2019-08-27 Thread Ralph Campbell
On 8/27/19 11:41 AM, Jason Gunthorpe wrote: On Fri, Aug 23, 2019 at 03:17:53PM -0700, Ralph Campbell wrote: Signed-off-by: Ralph Campbell mm/hmm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/hmm.c b/mm/hmm.c index 29371485fe94..4882b83aeccb 100644 +++ b/mm/hmm.c @@ -292,6 +29

Re: [PATCH 2/2] mm/hmm: hmm_range_fault() infinite loop

2019-08-27 Thread Jason Gunthorpe
On Fri, Aug 23, 2019 at 03:17:53PM -0700, Ralph Campbell wrote: > Signed-off-by: Ralph Campbell > mm/hmm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/hmm.c b/mm/hmm.c > index 29371485fe94..4882b83aeccb 100644 > +++ b/mm/hmm.c > @@ -292,6 +292,9 @@ static int hmm_vma_walk_hol

Re: [PATCH 3/3] drm/amd/powerplay: enable jpeg powergating for navi1x

2019-08-27 Thread Alex Deucher
Series is: Reviewed-by: Alex Deucher On Tue, Aug 27, 2019 at 3:20 AM Yuan, Xiaojie wrote: > > jpeg pg depends on vcn pg > > Signed-off-by: Xiaojie Yuan > --- > drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/

[PATCH] drm/amdgpu: Handle job is NULL use case in amdgpu_device_gpu_recover

2019-08-27 Thread Andrey Grodzovsky
This should be checked at all places job is accessed. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device

Re: [PATCH] drm/amd/display: fix struct init in update_bounding_box

2019-08-27 Thread Alex Deucher
On Tue, Aug 27, 2019 at 1:33 PM Raul E Rangel wrote: > > dcn20_resource.c:2636:9: error: missing braces around initializer > [-Werror=missing-braces] > struct _vcs_dpi_voltage_scaling_st > calculated_states[MAX_CLOCK_LIMIT_STATES] = {0}; > ^ > > Fixes: 7ed4e6352c16f ("drm/amd/display:

RE: [PATCH] drm/amdgpu: fix commit 4ef9d7d

2019-08-27 Thread Huang, Ray
Reviewed-by: Huang Rui -Original Message- From: amd-gfx On Behalf Of Aaron Liu Sent: Tuesday, August 27, 2019 12:33 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Aaron Subject: [PATCH] drm/amdgpu: fix commit 4ef9d7d For picasso(adev->pdev->device == 0x15d8)&raven2(adev->rev_id >= 0x8),

[PATCH] drm/amd/display: fix struct init in update_bounding_box

2019-08-27 Thread Raul E Rangel
dcn20_resource.c:2636:9: error: missing braces around initializer [-Werror=missing-braces] struct _vcs_dpi_voltage_scaling_st calculated_states[MAX_CLOCK_LIMIT_STATES] = {0}; ^ Fixes: 7ed4e6352c16f ("drm/amd/display: Add DCN2 HW Sequencer and Resource") Signed-off-by: Raul E Rangel

Re: [PATCH] drm/amdgpu: fix commit 4ef9d7d

2019-08-27 Thread Alex Deucher
On Tue, Aug 27, 2019 at 11:34 AM Aaron Liu wrote: > > For picasso(adev->pdev->device == 0x15d8)&raven2(adev->rev_id >= 0x8), > firmware is sufficient to support gfxoff. > In commit 4ef9d7dc2db166cbe83fe4621385f034c9347fd2, for picasso&raven2, > return directly and cause gfxoff disabled. > > Signed

Re: linux-next: Tree for Aug 27 (amdgpu)

2019-08-27 Thread Alex Deucher
On Tue, Aug 27, 2019 at 11:31 AM Randy Dunlap wrote: > > On 8/27/19 2:05 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20190826: > > > > on i386: > > ../drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c: In function > ‘dcn20_hw_sequencer_construct’: > ../drivers/gpu/drm

[PATCH] drm/amdgpu: fix commit 4ef9d7d

2019-08-27 Thread Aaron Liu
For picasso(adev->pdev->device == 0x15d8)&raven2(adev->rev_id >= 0x8), firmware is sufficient to support gfxoff. In commit 4ef9d7dc2db166cbe83fe4621385f034c9347fd2, for picasso&raven2, return directly and cause gfxoff disabled. Signed-off-by: Aaron Liu --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c |

Re: linux-next: Tree for Aug 27 (amdgpu)

2019-08-27 Thread Randy Dunlap
On 8/27/19 2:05 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190826: > on i386: ../drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c: In function ‘dcn20_hw_sequencer_construct’: ../drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:2127:28: error: ‘dcn20_dsc_

Re: [PATCH] drm/amd: remove meaningless descending into amd/amdkfd/

2019-08-27 Thread Alex Deucher
On Tue, Aug 27, 2019 at 3:29 AM Masahiro Yamada wrote: > > Since commit 04d5e2765802 ("drm/amdgpu: Merge amdkfd into amdgpu"), > drivers/gpu/drm/amd/amdkfd/Makefile does not contain any syntax that > is understood by the build system. > > Signed-off-by: Masahiro Yamada Applied. thanks! Alex >

RE: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

2019-08-27 Thread Othman, Ahmad
Hi Alex, There are callers in the same file "info_packet.c" -Original Message- From: Alex Deucher Sent: August 27, 2019 10:20 To: Wentland, Harry Cc: YueHaibing ; Wentland, Harry ; Li, Sun peng (Leo) ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; airl...@linux.

Re: [PATCH] drm/amdgpu: Add APTX quirk for Dell Latitude 5495

2019-08-27 Thread Alex Deucher
On Tue, Aug 27, 2019 at 9:07 AM Kai-Heng Feng wrote: > > Needs ATPX rather than _PR3 to really turn off the dGPU. This can save > ~5W when dGPU is runtime-suspended. > > Signed-off-by: Kai-Heng Feng Applied. thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 1 + > 1 fil

Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

2019-08-27 Thread Alex Deucher
On Tue, Aug 27, 2019 at 10:01 AM Harry Wentland wrote: > > On 2019-08-27 3:09 a.m., YueHaibing wrote: > > After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), > > there is no caller in tree. > > > > Reported-by: Hulk Robot Signed-off-by: YueHaibing > > > > Reviewed-by: Harry Wentlan

[PATCH v9 1/6] drm/dp_mst: Add PBN calculation for DSC modes

2019-08-27 Thread David Francis
With DSC, bpp can be fractional in multiples of 1/16. Change drm_dp_calc_pbn_mode to reflect this, adding a new parameter bool dsc. When this parameter is true, treat the bpp parameter as having units not of bits per pixel, but 1/16 of a bit per pixel v2: Don't add separate function for this Cc:

Re: [PATCH RESEND 02/14] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-08-27 Thread Alex Deucher
On Mon, Aug 26, 2019 at 3:26 PM Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_connectors.c | 143 +++-- > 1 file changed, 107 inserti

Re: [PATCH RESEND 03/14] drm/amdgpu: Provide ddc symlink in dm connector's sysfs directory

2019-08-27 Thread Harry Wentland
On 2019-08-26 3:25 p.m., Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2

Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

2019-08-27 Thread Harry Wentland
On 2019-08-27 3:09 a.m., YueHaibing wrote: > After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), > there is no caller in tree. > > Reported-by: Hulk Robot Signed-off-by: YueHaibing > Reviewed-by: Harry Wentland Harry > --- > .../drm/amd/display/modules/info_packet/info_packet.

Re: [PATCH] drm/amdgpu: correct in_suspend setting for navi series

2019-08-27 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Hawking Zhang Sent: Tuesday, August 27, 2019 5:19 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: [PATCH] drm/amdgpu: correct in_suspend setting for navi series in_suspend flag should be se

Re: [PATCH] drm/amdgpu: introduce vram lost for reset

2019-08-27 Thread Deucher, Alexander
Can you update nv.c as well? With that fixed, Reviewed-by: Alex Deucher From: amd-gfx on behalf of Monk Liu Sent: Tuesday, August 27, 2019 4:34 AM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: [PATCH] drm/amdgpu: introduce vram lost for reset for

[PATCH] drm/amdgpu: Add APTX quirk for Dell Latitude 5495

2019-08-27 Thread Kai-Heng Feng
Needs ATPX rather than _PR3 to really turn off the dGPU. This can save ~5W when dGPU is runtime-suspended. Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c b/dri

[PATCH] drm/amdgpu: correct in_suspend setting for navi series

2019-08-27 Thread Hawking Zhang
in_suspend flag should be set in amdgpu_device_suspend/resume in pairs, instead of gfx10 ip suspend/resume function. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgp

Re: [PATCH 3/4] drm/amdgpu: Determing PTE flags separately for each mapping (v2)

2019-08-27 Thread Koenig, Christian
Am 27.08.19 um 01:07 schrieb Kuehling, Felix: > The same BO can be mapped with different PTE flags by different GPUs. > Therefore determine the PTE flags separately for each mapping instead > of storing them in the KFD buffer object. > > Add a helper function to determine the PTE flags to be extend

Re: [PATCH 4/4] drm/amdgpu: Use optimal mtypes and PTE bits for Arcturus

2019-08-27 Thread Koenig, Christian
Am 27.08.19 um 01:07 schrieb Kuehling, Felix: > For compute VRAM allocations on Arturus use the new RW mtype > for non-coherent local memory, CC mtype for coherent local > memory and PTE_SNOOPED bit for invalidating non-dirty cache > lines on remote XGMI mappings. > > Signed-off-by: Felix Kuehling

Re: [PATCH 1/4] drm/amdgpu: Extends amdgpu vm definitions (v2)

2019-08-27 Thread Koenig, Christian
Am 27.08.19 um 01:07 schrieb Kuehling, Felix: > From: Oak Zeng > > Add RW mtype introduced for arcturus. > > v2: > * Don't add probe-invalidation bit from UAPI > * Don't add unused AMDGPU_MTYPE_ definitions > > Signed-off-by: Oak Zeng > Signed-off-by: Felix Kuehling We should have used the hard

Re: [PATCH 2/4] drm/amdgpu: Support new arcturus mtype

2019-08-27 Thread Koenig, Christian
Am 27.08.19 um 01:07 schrieb Kuehling, Felix: > From: Oak Zeng > > Arcturus repurposed mtype WC to RW. Modify gmc functions > to support the new mtype > > Change-Id: Idc338e5386a57020f45262025e2664ab4ba9f291 > Signed-off-by: Oak Zeng Reviewed-by: Christian König > --- > drivers/gpu/drm/amd/a

[PATCH] drm/amdgpu: introduce vram lost for reset

2019-08-27 Thread Monk Liu
for SOC15/vega10 the BACO reset & mode1 would introduce vram lost in high end address range, current kmd's vram lost checking cannot catch it since it only check very ahead visible frame buffer Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdg

Re: [PATCH V2] drm: Add LTTPR defines for DP 1.4a

2019-08-27 Thread Jani Nikula
On Mon, 26 Aug 2019, "Siqueira, Rodrigo" wrote: > DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR) > which is required to add support for systems with Thunderbolt or other > repeater devices. > > Changes since V1: > - Adjusts registers names to be aligned with spec and the

[RFC] AMD polaris MEM_AP_SIZE location (PCI BAR aperture size)

2019-08-27 Thread Petr Cvek
Hello, I'm trying to run AMD GPUs in unusual configurations. I was able to decrease the PCI BAR size in HD4550 by its BIOS strap configuration and change it to 64MB (and I was able to run it on MIPS vocore2 board :-D ). Is there a similar configuration location for AMD polaris 11/RX 460 BIOS?

[PATCH 2/3] drm/amdgpu: enable athub powergating for navi12

2019-08-27 Thread Yuan, Xiaojie
Signed-off-by: Xiaojie Yuan --- drivers/gpu/drm/amd/amdgpu/nv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index 9eda82d4430e..384f8f512fc4 100644 --- a/drivers/gpu/drm/amd/amdgpu/nv.c +++ b/drivers/gpu/d

[PATCH 1/3] drm/amdgpu: enable vcn powergating for navi12

2019-08-27 Thread Yuan, Xiaojie
Signed-off-by: Xiaojie Yuan --- drivers/gpu/drm/amd/amdgpu/nv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index a3d99f2ddf6b..9eda82d4430e 100644 --- a/drivers/gpu/drm/amd/amdgpu/nv.c +++ b/drivers/gpu/d

[PATCH 3/3] drm/amd/powerplay: enable jpeg powergating for navi1x

2019-08-27 Thread Yuan, Xiaojie
jpeg pg depends on vcn pg Signed-off-by: Xiaojie Yuan --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c index 2d908afbf525..1970843f225f 100

[PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

2019-08-27 Thread YueHaibing
After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), there is no caller in tree. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- .../drm/amd/display/modules/info_packet/info_packet.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/gpu/drm/amd/di