[PATCH 1/4] drm/amdgpu: change ras bps type to eeprom table record structure

2019-09-04 Thread Zhou1, Tao
change bps type from retired page to eeprom table record, prepare for saving umc error records to eeprom Signed-off-by: Tao Zhou Reviewed-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 59 - drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 11 +++-- 2 files

[PATCH 4/4] drm/amdgpu: move the call of ras recovery_init and bad page reserve to proper place

2019-09-04 Thread Zhou1, Tao
ras recovery_init should be called after ttm init, bad page reserve should be put in front of gpu reset since i2c may be unstable during gpu reset. add cleanup for recovery_init and recovery_fini v2: add more comment and print. remove cancel_work_sync in recovery_init. Signed-off-by: Tao

[PATCH 2/4] drm/amdgpu: Hook EEPROM table to RAS

2019-09-04 Thread Zhou1, Tao
support eeprom records load and save for ras, move EEPROM records storing to bad page reserving v2: remove redundant check for con->eh_data Signed-off-by: Tao Zhou Signed-off-by: Andrey Grodzovsky Reviewed-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 109

[PATCH 3/4] drm/amdgpu: save umc error records

2019-09-04 Thread Zhou1, Tao
save umc error records to ras bad page array v2: add bad pages before gpu reset v3: add NULL check for adev->umc.funcs Signed-off-by: Tao Zhou Signed-off-by: Andrey Grodzovsky Reviewed-by: Guchun Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c

RE: [PATCH 2/3] drm/amdgpu: Remove clock gating restore.

2019-09-04 Thread Zhou1, Tao
It's better to add space after "*" in comment, with this fixed, the series is: Reviewed-by: Tao Zhou > -Original Message- > From: Andrey Grodzovsky > Sent: 2019年9月5日 10:50 > To: amd-gfx@lists.freedesktop.org > Cc: alexdeuc...@gmail.com; Zhang, Hawking ; > Zhou1, Tao ; Chen, Guchun > ;

RE: [PATCH 3/3] drm/madgpu: Fix EEPROM Checksum calculation.

2019-09-04 Thread Chen, Guchun
Reviewed-by: Guchun Chen -Original Message- From: Andrey Grodzovsky Sent: Thursday, September 5, 2019 10:50 AM To: amd-gfx@lists.freedesktop.org Cc: alexdeuc...@gmail.com; Zhang, Hawking ; Zhou1, Tao ; Chen, Guchun ; Saceleanu, Cristian ; Grodzovsky, Andrey Subject: [PATCH 3/3]

RE: [PATCH 2/3] drm/amdgpu: Remove clock gating restore.

2019-09-04 Thread Chen, Guchun
Reviewed-by: Guchun Chen Tested-by: Guchun Chen -Original Message- From: Andrey Grodzovsky Sent: Thursday, September 5, 2019 10:50 AM To: amd-gfx@lists.freedesktop.org Cc: alexdeuc...@gmail.com; Zhang, Hawking ; Zhou1, Tao ; Chen, Guchun ; Saceleanu, Cristian ; Grodzovsky, Andrey

RE: [PATCH 1/3] drm/amdgpu: Add smu lock around in pp_smu_i2c_bus_access

2019-09-04 Thread Chen, Guchun
Reviewed-by: Guchun Chen Tested-by: Guchun Chen Regards, Guchun -Original Message- From: Andrey Grodzovsky Sent: Thursday, September 5, 2019 10:50 AM To: amd-gfx@lists.freedesktop.org Cc: alexdeuc...@gmail.com; Zhang, Hawking ; Zhou1, Tao ; Chen, Guchun ; Saceleanu, Cristian ;

[PATCH 2/3] drm/amdgpu: Remove clock gating restore.

2019-09-04 Thread Andrey Grodzovsky
Restoring clock gating break SMU opeartion afterwards, avoid this until this further invistigated with SMU. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[PATCH 1/3] drm/amdgpu: Add smu lock around in pp_smu_i2c_bus_access

2019-09-04 Thread Andrey Grodzovsky
Protect from concurrent SMU accesses. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c index

[PATCH 3/3] drm/madgpu: Fix EEPROM Checksum calculation.

2019-09-04 Thread Andrey Grodzovsky
Fix typo which messed up the calculation. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c

RE: [PATCH] drm/amd/display: Add stereo mux and dig programming calls for dcn21

2019-09-04 Thread Liu, Aaron
Acked-by: Aaron Liu BR, Aaron Liu > -Original Message- > From: amd-gfx On Behalf Of > roman...@amd.com > Sent: Thursday, September 5, 2019 5:43 AM > To: amd-gfx@lists.freedesktop.org > Cc: Wentland, Harry ; Liu, Aaron > ; Li, Roman ; Huang, Ray > ; Deucher, Alexander > ; Lakha,

[PATCH 1/1] drm/amdgpu: Disable retry faults in VMID0

2019-09-04 Thread Kuehling, Felix
There is no point retrying page faults in VMID0. Those faults are always fatal. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 2 ++

Re: Graceful page fault handling for Vega/Navi

2019-09-04 Thread Kuehling, Felix
On 2019-09-04 7:03 p.m., Huang, Ray wrote: > On Wed, Sep 04, 2019 at 05:02:21PM +0200, Christian König wrote: >> Hi everyone, >> >> this series is the next puzzle piece for recoverable page fault handling on >> Vega and Navi. >> >> It adds a new direct scheduler entity for VM updates which is

Re: Graceful page fault handling for Vega/Navi

2019-09-04 Thread Huang, Ray
On Wed, Sep 04, 2019 at 05:02:21PM +0200, Christian König wrote: > Hi everyone, > > this series is the next puzzle piece for recoverable page fault handling on > Vega and Navi. > > It adds a new direct scheduler entity for VM updates which is then used to > update page tables during a fault. >

Re: [PATCH 02/10] drm/amdkfd: add renoir kfd device info

2019-09-04 Thread Huang, Ray
On Thu, Sep 05, 2019 at 03:38:31AM +0800, Kuehling, Felix wrote: > On 2019-09-04 11:48 a.m., Huang, Ray wrote: > > This patch inits renoir kfd device info, so we treat renoir as "dgpu" > > (bypass iommu v2). Will enable needs_iommu_device till renoir iommu is > > ready. > > > > Signed-off-by:

Re: [PATCH 01/10] drm/amdkfd: add renoir cache info for CRAT

2019-09-04 Thread Huang, Ray
On Thu, Sep 05, 2019 at 03:35:20AM +0800, Kuehling, Felix wrote: > On 2019-09-04 11:48 a.m., Huang, Ray wrote: > > Renoir's cache info should be the same with raven and carrizo's. > > > > Signed-off-by: Huang Rui > > --- > > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 > > 1 file changed, 4

Re: Graceful page fault handling for Vega/Navi

2019-09-04 Thread Kuehling, Felix
On 2019-09-04 11:02 a.m., Christian König wrote: > Hi everyone, > > this series is the next puzzle piece for recoverable page fault handling on > Vega and Navi. > > It adds a new direct scheduler entity for VM updates which is then used to > update page tables during a fault. > > In other words

Re: [PATCH 00/10] drm/amdkfd: introduce the kfd support for Renoir

2019-09-04 Thread Huang, Ray
On Thu, Sep 05, 2019 at 03:42:50AM +0800, Kuehling, Felix wrote: > Patches 2-10 are > > Reviewed-by: Felix Kuehling > > See my comments on patches 1 and 2 in separate emails. In patch 1 it > looks like you're based on an outdated version of the branch or a > different branch altogether.

Re: [PATCH 4/9] drm/amdgpu: allow direct submission of PDE updates.

2019-09-04 Thread Kuehling, Felix
On 2019-09-04 11:02 a.m., Christian König wrote: > For handling PDE updates directly in the fault handler. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- >

Re: [PATCH 9/9] drm/amdgpu: add graceful VM fault handling v2

2019-09-04 Thread Kuehling, Felix
On 2019-09-04 11:02 a.m., Christian König wrote: > Next step towards HMM support. For now just silence the retry fault and > optionally redirect the request to the dummy page. > > v2: make sure the VM is not destroyed while we handle the fault. > > Signed-off-by: Christian König > --- >

Re: gnome-shell stuck because of amdgpu driver [5.3 RC5]

2019-09-04 Thread Mikhail Gavrilov
On Wed, 4 Sep 2019 at 13:37, Daniel Vetter wrote: > > Extend your backtrac warning slightly like > > WARN(r, "we're stuck on fence %pS\n", fence->ops); > > Also adding Harry and Alex, I'm not really working on amdgpu ... [ 3511.998320] [ cut here ] [ 3511.998714]

[PATCH] drm/amd/display: Add stereo mux and dig programming calls for dcn21

2019-09-04 Thread Roman.Li
From: Roman Li [Why] The earlier patch "Hook up calls to do stereo mux and dig programming..." doesn't include update for dcn21. [How] Align dcn21 gpio settings with updated stereo control interface. Signed-off-by: Roman Li --- .../amd/display/dc/gpio/dcn21/hw_factory_dcn21.c | 38

Re: linux-next: Tree for Sep 4 (amd/display/)

2019-09-04 Thread Randy Dunlap
On 9/4/19 6:34 AM, Stephen Rothwell wrote: > Hi all, > > News: this will be the last linux-next I will release until Sept 30. > > Changes since 20190903: > on x86_64: In file included from ../drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c:77:0:

Re: [PATCH 9/9] drm/amdgpu: add graceful VM fault handling v2

2019-09-04 Thread Yang, Philip
This series looks nice and clear for me, two questions embedded below. Are we going to use dedicated sdma page queue for direct VM update path during a fault? Thanks, Philip On 2019-09-04 11:02 a.m., Christian König wrote: > Next step towards HMM support. For now just silence the retry fault

Re: [PATCH 2/2] drm/amdgpu: cleanup PTE flag generation v2

2019-09-04 Thread Kuehling, Felix
On 2019-09-04 8:17 a.m., Christian König wrote: > Move the ASIC specific code into a new callback function. > > v2: mask the flags for SI and CIK instead of a BUG_ON(). > > Signed-off-by: Christian König Nit-pick inline. Otherwise the series is Reviewed-by: Felix Kuehling > --- >

Re: [PATCH 00/10] drm/amdkfd: introduce the kfd support for Renoir

2019-09-04 Thread Kuehling, Felix
Patches 2-10 are Reviewed-by: Felix Kuehling See my comments on patches 1 and 2 in separate emails. In patch 1 it looks like you're based on an outdated version of the branch or a different branch altogether. Please check that your series is based on the latest amd-staging-drm-next.

Re: [PATCH 02/10] drm/amdkfd: add renoir kfd device info

2019-09-04 Thread Kuehling, Felix
On 2019-09-04 11:48 a.m., Huang, Ray wrote: > This patch inits renoir kfd device info, so we treat renoir as "dgpu" > (bypass iommu v2). Will enable needs_iommu_device till renoir iommu is ready. > > Signed-off-by: Huang Rui Looks good, but please coordinate with Yong who is changing the

Re: [PATCH 01/10] drm/amdkfd: add renoir cache info for CRAT

2019-09-04 Thread Kuehling, Felix
On 2019-09-04 11:48 a.m., Huang, Ray wrote: > Renoir's cache info should be the same with raven and carrizo's. > > Signed-off-by: Huang Rui > --- > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c >

[PATCH V4] drm: Add LTTPR defines for DP 1.4a

2019-09-04 Thread Siqueira, Rodrigo
DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR) which is required to add support for systems with Thunderbolt or other repeater devices. Changes since V3: - Replace spaces by tabs Changes since V2: - Drop the kernel-doc comment - Reorder LTTPR according to register offset

Re: drm/amdgpu: remove the redundant null check

2019-09-04 Thread Markus Elfring
> debugfs_remove and kfree has taken the null check in account. > hence it is unnecessary to check it. Just remove the condition. How do you think about a wording like the following? The functions “debugfs_remove” and “kfree” tolerate the passing of null pointers. Hence it is unnecessary to

Re: drm/amdgpu: Delete an unnecessary check before two function calls

2019-09-04 Thread Markus Elfring
> The functions “debugfs_remove” and “kfree” test whether their argument > is NULL and then return immediately. > Thus the tests around the shown calls are not needed. > > This issue was detected by using the Coccinelle software. I suggest to take another look at a similar patch. drm/amdgpu:

Re: [PATCH v18 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel

2019-09-04 Thread Andrey Konovalov
On Wed, Sep 4, 2019 at 6:22 PM Cristian Marussi wrote: > > Hi Andrey ! > > On 04/09/2019 15:52, Andrey Konovalov wrote: > > On Fri, Aug 23, 2019 at 7:49 PM Cristian Marussi > > wrote: > >> > >> > >> Hi > >> > >> On 23/08/2019 18:16, Andrey Konovalov wrote: > >>> On Fri, Aug 23, 2019 at 3:56 PM

Re: [PATCH v18 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel

2019-09-04 Thread Cristian Marussi
Hi Andrey ! On 04/09/2019 15:52, Andrey Konovalov wrote: > On Fri, Aug 23, 2019 at 7:49 PM Cristian Marussi > wrote: >> >> >> Hi >> >> On 23/08/2019 18:16, Andrey Konovalov wrote: >>> On Fri, Aug 23, 2019 at 3:56 PM Cristian Marussi >>> wrote: Hi Andrey On 24/06/2019 15:33,

[PATCH AUTOSEL 5.2 58/94] drm/amd/powerplay: correct Vega20 dpm level related settings

2019-09-04 Thread Sasha Levin
From: Evan Quan [ Upstream commit 83e09d5bddbee749fc83063890244397896a1971 ] Correct the settings for auto mode and skip the unnecessary settings for dcefclk and fclk. Signed-off-by: Evan Quan Acked-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.2 50/94] drm/amdgpu: fix dma_fence_wait without reference

2019-09-04 Thread Sasha Levin
From: Christian König [ Upstream commit 42068e1ef961c719f967dbbb4ddcb394a0ba7917 ] We need to grab a reference to the fence we wait for. Signed-off-by: Christian König Reviewed-by: Chunming Zhou Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH 09/10] drm/amdgpu: disable gfxoff while use no H/W scheduling policy

2019-09-04 Thread Huang, Ray
While gfxoff is enabled, the mmVM_XXX registers will be 0xfff while the GFX is in "off" state. KFD queue creattion doesn't use ring based method, so it will trigger a VM fault. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 +

[PATCH 00/10] drm/amdkfd: introduce the kfd support for Renoir

2019-09-04 Thread Huang, Ray
Hi all, These patch set provides the kfd support for ROCm stack on Renoir APU. Thanks, Ray Huang Rui (10): drm/amdkfd: add renoir cache info for CRAT drm/amdkfd: add renoir kfd device info drm/amdkfd: enable kfd device queue manager v9 for renoir drm/amdkfd: add renoir typs for the

[PATCH 06/10] drm/amdkfd: init kernel queue for renoir

2019-09-04 Thread Huang, Ray
Renoir is GFX v9, so init v9 kernel queue. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c b/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c index 26c66bb..2462d24 100644

[PATCH 03/10] drm/amdkfd: enable kfd device queue manager v9 for renoir

2019-09-04 Thread Huang, Ray
Renoir is GFX9, so enable v9 devcie queue manager. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c

[PATCH 10/10] drm/amdkfd: enable renoir while device probes

2019-09-04 Thread Huang, Ray
This patch is to add asic flag to enable device probe during kfd init. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c index

[PATCH 02/10] drm/amdkfd: add renoir kfd device info

2019-09-04 Thread Huang, Ray
This patch inits renoir kfd device info, so we treat renoir as "dgpu" (bypass iommu v2). Will enable needs_iommu_device till renoir iommu is ready. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

[PATCH 08/10] drm/amdkfd: add renoir kfd topology

2019-09-04 Thread Huang, Ray
This patch adds renoir kfd topology which is the same with Raven. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c index

[PATCH 01/10] drm/amdkfd: add renoir cache info for CRAT

2019-09-04 Thread Huang, Ray
Renoir's cache info should be the same with raven and carrizo's. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c index a84c810..2a428c9

[PATCH 05/10] drm/amdkfd: init kfd apertures v9 for renoir

2019-09-04 Thread Huang, Ray
Renoir is GMC v9, so init v9 kfd apertures. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c b/drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c index 7a5b3b2..989c74f 100644

[PATCH 04/10] drm/amdkfd: add renoir typs for the workaround of iommu v2

2019-09-04 Thread Huang, Ray
Renoir is the same with Raven, will enable iommu event in future. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_events.c index

[PATCH 07/10] drm/amdkfd: add package manager for renoir

2019-09-04 Thread Huang, Ray
Renoir use GFX v9, so adds v9 package manager. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c index

RE: [PATCH 2/2] drm/amd/display: update renoir_ip_offset.h

2019-09-04 Thread Li, Roman
Acked-by: Roman Li -Original Message- From: Liu, Aaron Sent: Wednesday, September 4, 2019 2:07 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Li, Roman ; Liu, Aaron Subject: [PATCH 2/2] drm/amd/display: update renoir_ip_offset.h This patch updates

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-04 Thread Michel Dänzer
On 2019-09-04 2:08 p.m., Sasha Levin wrote: > > FWIW, I've added another test to my scripts to try and catch these cases > (Revert "%s"). It'll slow down the scripts a bit but it's better to get > it right rather than to be done quickly :) Indeed, thanks! And again sorry for the brouhaha, I just

[PATCH 7/9] drm/amdgpu: allocate PDs/PTs with no_gpu_wait in a page fault

2019-09-04 Thread Christian König
While handling a page fault we can't wait for other ongoing GPU operations or we can potentially run into deadlocks. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 4/9] drm/amdgpu: allow direct submission of PDE updates.

2019-09-04 Thread Christian König
For handling PDE updates directly in the fault handler. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +-

[PATCH 8/9] drm/amdgpu: reserve the root PD while freeing PASIDs

2019-09-04 Thread Christian König
Free the pasid only while the root PD is reserved. This prevents use after free in the page fault handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git

Graceful page fault handling for Vega/Navi

2019-09-04 Thread Christian König
Hi everyone, this series is the next puzzle piece for recoverable page fault handling on Vega and Navi. It adds a new direct scheduler entity for VM updates which is then used to update page tables during a fault. In other words previously an application doing an invalid memory access would

[PATCH 6/9] drm/amdgpu: allow direct submission of clears

2019-09-04 Thread Christian König
For handling PD/PT clears directly in the fault handler. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 9/9] drm/amdgpu: add graceful VM fault handling v2

2019-09-04 Thread Christian König
Next step towards HMM support. For now just silence the retry fault and optionally redirect the request to the dummy page. v2: make sure the VM is not destroyed while we handle the fault. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 74 ++

[PATCH 2/9] drm/amdgpu: split the VM entity into direct and delayed

2019-09-04 Thread Christian König
For page fault handling we need to use a direct update which can't be blocked by ongoing user CS. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 21 +++--

[PATCH 5/9] drm/amdgpu: allow direct submission of PTE updates

2019-09-04 Thread Christian König
For handling PTE updates directly in the fault handler. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 1/9] drm/ttm: return -EBUSY on pipelining with no_gpu_wait

2019-09-04 Thread Christian König
Setting the no_gpu_wait flag means that the allocate BO must be available immediately and we can't wait for any GPU operation to finish. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 43 +--- 1 file changed, 25 insertions(+), 18 deletions(-)

[PATCH 3/9] drm/amdgpu: allow direct submission in the VM backends v2

2019-09-04 Thread Christian König
This allows us to update page tables directly while in a page fault. v2: use direct/delayed entities and still wait for moves Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c | 16 ++---

Re: [PATCH v18 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel

2019-09-04 Thread Andrey Konovalov
On Fri, Aug 23, 2019 at 7:49 PM Cristian Marussi wrote: > > > Hi > > On 23/08/2019 18:16, Andrey Konovalov wrote: > > On Fri, Aug 23, 2019 at 3:56 PM Cristian Marussi > > wrote: > >> > >> Hi Andrey > >> > >> On 24/06/2019 15:33, Andrey Konovalov wrote: > >>> This patch is a part of a series that

RE: [PATCH 2/2] drm/amdgpu: cleanup PTE flag generation v2

2019-09-04 Thread Huang, Ray
Series look good for me. Reviewed-by: Huang Rui -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Wednesday, September 4, 2019 8:17 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/2] drm/amdgpu: cleanup PTE flag generation v2 Move the ASIC specific code into

RE: [PATCH 2/2] drm/amd/powerplay: implement sysfs for getting dpm clock

2019-09-04 Thread Huang, Ray
Reviewed-by: Huang Rui -Original Message- From: amd-gfx On Behalf Of Liang, Prike Sent: Wednesday, September 4, 2019 2:02 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Liang, Prike Subject: [PATCH 2/2] drm/amd/powerplay: implement sysfs for getting dpm clock With the

RE: [PATCH] drm/amdgpu: disable stutter mode for renoir

2019-09-04 Thread Huang, Ray
Please add a comment that "disable stutter for the moment because NMI warning storm, and will enable it back till the issue is addressed". With that fixed, patch is Acked-by: Huang Rui -Original Message- From: Liu, Aaron Sent: Wednesday, September 4, 2019 5:18 AM To:

Re: [PATCH 1/2] drm/amd/display: bypass stereo programming

2019-09-04 Thread Harry Wentland
On 2019-09-04 2:06 a.m., Liu, Aaron wrote: > From: Roman Li > > hack to avoid crash on renoir > should be resolved after upcoming gpio refactoring promotion > > Signed-off-by: Roman Li Nack. This is not the right way to do this upstream. We shouldn't use compile time guard to change ASIC

Re: [PATCH v2 1/3] drm/amd: be quiet when no SAD block is found

2019-09-04 Thread Harry Wentland
On 2019-09-04 5:12 a.m., Jean Delvare wrote: > It is fine for displays without audio functionality to not provide > any SAD block in their EDID. Do not log an error in that case, > just return quietly. > > This fixes half of bug fdo#107825: > https://bugs.freedesktop.org/show_bug.cgi?id=107825 >

[PATCH 1/2] drm/amdgpu: cleanup mtype mapping

2019-09-04 Thread Christian König
Unify how we map the UAPI flags to the PTE hardware flags for a mapping. Only the MTYPE is actually ASIC dependent, all other flags should be copied over 1 to 1 and ASIC differences are handled later on. Signed-off-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-

[PATCH 2/2] drm/amdgpu: cleanup PTE flag generation v2

2019-09-04 Thread Christian König
Move the ASIC specific code into a new callback function. v2: mask the flags for SI and CIK instead of a BUG_ON(). Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 29 ++---

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-04 Thread Sasha Levin
On Wed, Sep 04, 2019 at 10:55:10AM +0200, Michel Dänzer wrote: On 2019-09-03 10:16 p.m., Daniel Vetter wrote: On Tue, Sep 3, 2019 at 10:01 PM Sasha Levin wrote: On Tue, Sep 03, 2019 at 07:03:47PM +0200, Greg KH wrote: On Tue, Sep 03, 2019 at 06:40:43PM +0200, Michel Dänzer wrote: On

[PATCH] drm/amdgpu: Delete an unnecessary check before two function calls

2019-09-04 Thread Markus Elfring
From: Markus Elfring Date: Wed, 4 Sep 2019 12:30:23 +0200 The functions “debugfs_remove” and “kfree” test whether their argument is NULL and then return immediately. Thus the tests around the shown calls are not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH] drm/amdgpu: disable stutter mode for renoir

2019-09-04 Thread Liu, Aaron
With stutter mode enabled, NMI prints frequently. Disable stutter mode for renoir. Signed-off-by: Aaron Liu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

RE: [PATCH 1/2] drm/amd/powerplay: Add UMD PState Renoir Msg Parameters

2019-09-04 Thread Liang, Prike
Thanks review . Initial thoughts use this patch for overall initializing the UMD_PSATET_* assignment and some Pstate definitions are not used for patch#2. But combine those two patches also seems well. Thanks, Prike From: Wang, Kevin(Yang) Sent: Wednesday, September 4, 2019 2:32 PM To: Liang,

Re: [PATCH RFC v4 01/16] drm: Add drm_minor_for_each

2019-09-04 Thread Daniel Vetter
On Tue, Sep 03, 2019 at 04:43:45PM -0400, Kenny Ho wrote: > On Tue, Sep 3, 2019 at 4:12 PM Daniel Vetter wrote: > > On Tue, Sep 3, 2019 at 9:45 PM Kenny Ho wrote: > > > On Tue, Sep 3, 2019 at 3:57 AM Daniel Vetter wrote: > > > > Iterating over minors for cgroups sounds very, very wrong. Why do

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-04 Thread Michel Dänzer
On 2019-09-03 10:16 p.m., Daniel Vetter wrote: > On Tue, Sep 3, 2019 at 10:01 PM Sasha Levin wrote: >> On Tue, Sep 03, 2019 at 07:03:47PM +0200, Greg KH wrote: >>> On Tue, Sep 03, 2019 at 06:40:43PM +0200, Michel Dänzer wrote: On 2019-09-03 6:23 p.m., Sasha Levin wrote: > From: Yu Zhao

Re: gnome-shell stuck because of amdgpu driver [5.3 RC5]

2019-09-04 Thread Daniel Vetter
On Wed, Sep 04, 2019 at 09:17:16AM +0800, Hillf Danton wrote: > Daniel Vetter > >> > >> Now 11:01pm and "gnome shell stuck warning" not appear since 19:17. So > >> looks like issue happens only when computer blocked and monitor in > >> power save mode. > > > > I'd bet on runtime pm or some other

Re: [PATCH 2/2] drm/amdgpu: cleanup PTE flag generation

2019-09-04 Thread Christian König
the  mapping  structure still keep the  UAPI flag and  all the HW specific PTE setting is in the last step before real set to HW ? I thought about that approach as well, but that would unfortunately not work correctly. The problem is that we have some mapping flags which don't have an

Re: [PATCH 2/2] drm/amdgpu: cleanup PTE flag generation

2019-09-04 Thread Christian König
Am 03.09.19 um 22:28 schrieb Kuehling, Felix: On 2019-09-02 10:57 a.m., Christian König wrote: Move the ASIC specific code into a new callback function. NAK. I believe the BUG_ONs you're adding will trigger with ROCm on Hawaii and Kaveri. See inline ... Those are the flags as generated by

Re: gnome-shell stuck because of amdgpu driver [5.3 RC5]

2019-09-04 Thread Hillf Danton
Daniel Vetter >> >> Now 11:01pm and "gnome shell stuck warning" not appear since 19:17. So >> looks like issue happens only when computer blocked and monitor in >> power save mode. > > I'd bet on runtime pm or some other power saving feature in amdgpu > shutting the interrupt handling down before

Re: gnome-shell stuck because of amdgpu driver [5.3 RC5]

2019-09-04 Thread Hillf Danton
On Tue, 3 Sep 2019 11:48:12 +0500 From: Mikhail Gavrilov > On Fri, 30 Aug 2019 at 08:30, Hillf Danton wrote: > > > > Add a warning to show if it makes sense in field: neither regression nor > > problem will have been observed with the warning printed. > > I caught the problem. > > >

System error

2019-09-04 Thread 1577332900
Hi ALL, Some processes transfer to D status. This stack is: #0 [0001343e3a40] __switch_to at 08088870 /usr/src/linux-4.19.36-1.2.159.aarch64/arch/arm64/kernel/process.c: 491 #1 [0001343e3a60] __schedule at 08bf8508

Bug: amdgpu drm driver cause process into Disk sleep state

2019-09-04 Thread 78666679
Hi, Sirs: I have a wx5100 amdgpu card, It randomly come into failure. sometimes, it will cause processes into uninterruptible wait state. cps-new-ondemand-0587:~ # ps aux|grep -w D root 11268 0.0 0.0 260628 3516 ?Ssl 8月26 0:00 /usr/sbin/gssproxy -D root 136482

?????? ?????? ?????? Bug: amdgpu drm driver cause process into Disk sleep state

2019-09-04 Thread 78666679
The bug url is: https://bugs.freedesktop.org/show_bug.cgi?id=111551 -- -- ??: "Koenig, Christian"; : 2019??9??3??(??) 9:19 ??: ""<78666...@qq.com>;"amd-gfx"; : "Deucher, Alexander"; : Re: ?? ?? Bug: amdgpu drm

?????? Bug: amdgpu drm driver cause process into Disk sleep state

2019-09-04 Thread 78666679
Hi Christian, Sometimes the thread blocked disk sleeping in call to amdgpu_sa_bo_new. following is the stack trace. it seems the sa bo is used up , so the caller blocked waiting someone to free sa resources. D 206833 227656 [surfaceflinger] Binder:45_5 cat

?????? Bug: amdgpu drm driver cause process into Disk sleep state

2019-09-04 Thread 78666679
Hi, Christian: Thanks very much for you so fast reply. I will try this commit patch first. My kernel version is 4.19.36(for some reasons, this version should not be upgraded). yanhua -- -- ??: "Koenig, Christian"; :

?????? ?????? Bug: amdgpu drm driver cause process into Disk sleep state

2019-09-04 Thread 78666679
Yes, with dmesg|grep drm , I get following. 348571.880718] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring sdma1 timeout, signaled seq=24423862, emitted seq=24423865 -- -- ??: "Koenig, Christian"; : 2019??9??3??(??) 9:07 ??:

Re: [PATCH 1/2] drm/amd/powerplay: Add UMD PState Renoir Msg Parameters

2019-09-04 Thread Wang, Kevin(Yang)
i think it's better to merge these two patches into one patch. after fixed: Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Liang, Prike Sent: Wednesday, September 4, 2019 2:01 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander

[PATCH 2/2] drm/amd/display: update renoir_ip_offset.h

2019-09-04 Thread Liu, Aaron
This patch updates MP1_BASE in renoir_ip_offset.h Signed-off-by: Aaron Liu --- drivers/gpu/drm/amd/include/renoir_ip_offset.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/include/renoir_ip_offset.h b/drivers/gpu/drm/amd/include/renoir_ip_offset.h

[PATCH 1/2] drm/amd/display: bypass stereo programming

2019-09-04 Thread Liu, Aaron
From: Roman Li hack to avoid crash on renoir should be resolved after upcoming gpio refactoring promotion Signed-off-by: Roman Li --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 2/2] drm/amd/powerplay: implement sysfs for getting dpm clock

2019-09-04 Thread Liang, Prike
With the common interface print_clk_levels can get the following dpm clock: -pp_dpm_dcefclk -pp_dpm_fclk -pp_dpm_mclk -pp_dpm_sclk -pp_dpm_socclk Signed-off-by: Prike Liang Reviewed-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 70 ++

[PATCH 1/2] drm/amd/powerplay: Add UMD PState Renoir Msg Parameters

2019-09-04 Thread Liang, Prike
Add UMD PState macro definition for PState update. Signed-off-by: Prike Liang reviewed-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/renoir_ppt.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.h b/drivers/gpu/drm/amd/powerplay/renoir_ppt.h