Re: [PATCH] Revert "drm/radeon: Fix EEH during kexec"

2019-10-13 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.3.5, v5.2.20, v4.19.78, v4.14.148, v4.9.196, v4.4.196. v5.3.5: Build OK!

RE: [PATCH 00/19] Enable BACO for power savings

2019-10-13 Thread Quan, Evan
Patch 1 - 16 are Reviewed-by: Evan Quan Patch 17 - 19 are acked-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, October 11, 2019 9:45 AM To: amd-gfx@lists.freedesktop.org; ti...@suse.de; lu...@wunner.de Cc: Deucher, Alexander Subject: [PATCH

[PATCH 7/8] drm/amdgpu: reserve vram for memory training(v3)

2019-10-13 Thread Tianci Yin
From: "Tianci.Yin" memory training using specific fixed vram segment, reserve these segments before anyone may allocate it. Change-Id: I1436755813a565608a2857a683f535377620a637 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 95

[PATCH 8/8] drm/amdgpu/psp: add psp memory training implementation

2019-10-13 Thread Tianci Yin
From: "Tianci.Yin" add memory training implementation code to save resume time. Change-Id: I625794a780b11d824ab57ef39cc33b872c6dc6c9 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 9 ++

[PATCH 5/8] drm/amdgpu/atomfirmware: add memory training related helper functions(v3)

2019-10-13 Thread Tianci Yin
From: "Tianci.Yin" parse firmware to get memory training capability and fb location. Change-Id: I147c1d48e255e0191be4beb1ad6b637da607bf75 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 8 ++

[PATCH 2/8] drm/amdgpu: add a generic fb accessing helper function(v3)

2019-10-13 Thread Tianci Yin
From: "Tianci.Yin" add a generic helper function for accessing framebuffer via MMIO Change-Id: I4baa0aa53c93a94c2eff98c6211a61f369239982 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH 6/8] drm/amdgpu: add psp memory training callbacks and macro

2019-10-13 Thread Tianci Yin
From: "Tianci.Yin" add interface for memory training. Change-Id: Ibb6d1d24eb651df796bc2bb3419a44937af60242 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 18 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 55 + 2

[PATCH 4/8] drm/amdgpu: update atomfirmware header with memory training related members(v3)

2019-10-13 Thread Tianci Yin
From: "Tianci.Yin" add new vram_reserve_block structure and atomfirmware_internal_constants enumeration Change-Id: I6ba642ecd7ad94250162ae5c322ed8d85de9c35a Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/include/atomfirmware.h | 27 +- 1 file

[PATCH 1/8] drm/amdgpu: update amdgpu_discovery to handle revision

2019-10-13 Thread Tianci Yin
From: "Tianci.Yin" update amdgpu_discovery to get IP revision. Change-Id: If8152103d03b58e1dc0f32db63625e290f5f08a0 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h | 2 +- 2 files

[PATCH 3/8] drm/amdgpu: introduce psp_v11_0_is_sos_alive interface(v2)

2019-10-13 Thread Tianci Yin
From: "Tianci.Yin" introduce psp_v11_0_is_sos_alive func for common use. Change-Id: Iee0a6dd924d6a4b164eb751c0bec49fcb7d79483 Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 22 +- 1 file changed, 13 insertions(+), 9

[PATCH] drm/amdgpu: No need to check gfxoff status after enable gfxoff feature

2019-10-13 Thread chen gong
smu_send_smc_msg(smu, SMU_MSG_AllowGfxOff) Just turn on a switch. As to when GPU get into "GFXoff" will be up to drawing load. So we can not sure which state GPU should be in after enable gfxoff feature. Signed-off-by: chen gong --- drivers/gpu/drm/amd/powerplay/smu_v12_0.c | 9 - 1

Re: [PATCH v2] drm/amd/powerplay: bug fix for pcie parameters override

2019-10-13 Thread Wang, Kevin(Yang)
Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Kenneth Feng Sent: Friday, October 11, 2019 6:33 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH v2] drm/amd/powerplay: bug fix for pcie parameters override Bug

RE: [PATCH v2] drm/amd/powerplay: bug fix for pcie parameters override

2019-10-13 Thread Quan, Evan
Reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Kenneth Feng Sent: Friday, October 11, 2019 6:34 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH v2] drm/amd/powerplay: bug fix for pcie parameters override Bug fix for pcie paramerers override

RE: [PATCH] drm/amdgpu/powerplay: add renoir funcs to support dc

2019-10-13 Thread Quan, Evan
Please split the get_dpm_clock_table relates into a separate patch. Other than that, the patch is reviewed-by: Evan Quan Regards, Evan -Original Message- From: amd-gfx On Behalf Of Hersen Wu Sent: Thursday, October 10, 2019 10:58 PM To: amd-gfx@lists.freedesktop.org Cc: Wu, Hersen ;

Re: [PATCH 02/19] drm/amdgpu: add supports_baco callback for soc15 asics.

2019-10-13 Thread Alex Deucher
On Sat, Oct 12, 2019 at 7:45 AM Lukas Wunner wrote: > > On Thu, Oct 10, 2019 at 08:45:19PM -0500, Alex Deucher wrote: > > Check the BACO capabilities from the powerplay table. > > > > Signed-off-by: Alex Deucher > [...] > > @@ -997,6 +1020,7 @@ static const struct amdgpu_asic_funcs > >

Re: [PATCH v3] drm/amdgpu: user pages array memory leak fix

2019-10-13 Thread Joe Barnett
Confirming that v3 patch still fixes the bug. Thanks, -Joe On Fri, Oct 11, 2019 at 7:36 AM Yang, Philip wrote: > user_pages array should always be freed after validation regardless if > user pages are changed after bo is created because with HMM change parse > bo always allocate user pages

Issues with gpu_busy_percent? Unstable performance / sclk on AMD Fury X.

2019-10-13 Thread Witold Baryluk
Hi, I filled the bug in the bugzilla, but I am not sure, if I filled it in the right component, so I am posting it here too. Unstable performance (periodic and repeating patterns of fps change) and changing VDDGFX https://bugs.freedesktop.org/show_bug.cgi?id=111987 I suspect issue is with