It is tested/verified by Xiaojie on nv14 against S3 issues.
Thanks
_
Monk Liu|GPU Virtualization Team |AMD
-Original Message-
From: Koenig, Christian
Sent: Friday, November 29, 2019 3:46 PM
To: Liu, Monk ; Yuan, Xiaojie ;
Deucher, Alexander
Cc:
@Zhang, Hawking @Deucher, Alexander
Can you help to review it for me
_
Monk Liu|GPU Virtualization Team |AMD
-Original Message-
From: amd-gfx On Behalf Of Liu, Monk
Sent: Thursday, November 28, 2019 10:21 AM
To: amd-gfx@lists.freedesktop.org
Subject:
@Zhang, Hawking@Deucher, Alexander
Can you help to review it for me ?
_
Monk Liu|GPU Virtualization Team |AMD
-Original Message-
From: amd-gfx On Behalf Of Liu, Monk
Sent: Thursday, November 28, 2019 10:22 AM
To: amd-gfx@lists.freedesktop.org
Subjec
In this case feel free to add an Acked-by: Christian König
to your patch.
But I would recommend to get an rb from somebody which knows that stuff
better than I do.
Regards,
Christian.
Am 29.11.19 um 02:58 schrieb Liu, Monk:
The content of CSIB is always static, I submitted a patch to use t
Hi Felix,
yes that is exactly my thinking as well. Problem is that getting this to
work was much harder than I thought.
We can't use a mutex cause TTM is calling the eviction callback in
atomic context. A spinlock doesn't looked like a good idea either
because we potentially need to wait for
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Liu, Monk
Sent: 2019年11月29日 14:43
To: Yuan, Xiaojie ; amd-gfx@lists.freedesktop.org;
Koenig, Christian ; Deucher, Alexander
; Zhang, Hawking
Subject: RE: [PATCH]
On Tue, Oct 1, 2019 at 10:30 AM Michal Koutný wrote:
> On Thu, Aug 29, 2019 at 02:05:24AM -0400, Kenny Ho wrote:
> > drm.buffer.default
> > A read-only flat-keyed file which exists on the root cgroup.
> > Each entry is keyed by the drm device's major:minor.
> >
> > Default
@Koenig, Christian @Deucher, Alexander@Zhang, Hawking
Can you guys help to review the patch for me ? thanks for Xiaojie who helped to
verify the S3 issue testing against this patch
_
Monk Liu|GPU Virtualization Team |AMD
-Original Message-
From: Yua
[AMD Official Use Only - Internal Distribution Only]
Tested on navi14 and s3/baco works fine with patch applied.
Reviewed-by: Xiaojie Yuan
BR,
Xiaojie
From: amd-gfx on behalf of Monk Liu
Sent: Thursday, November 28, 2019 2:57 PM
To: amd-gfx@lists.fre
On Tue, Oct 1, 2019 at 10:31 AM Michal Koutný wrote:
> On Thu, Aug 29, 2019 at 02:05:19AM -0400, Kenny Ho wrote:
> > +struct cgroup_subsys drm_cgrp_subsys = {
> > + .css_alloc = drmcg_css_alloc,
> > + .css_free = drmcg_css_free,
> > + .early_init = false,
> > + .leg
Reducing audience since this is AMD specific.
On Tue, Oct 8, 2019 at 3:11 PM Kuehling, Felix wrote:
>
> On 2019-08-29 2:05 a.m., Kenny Ho wrote:
> > The number of logical gpu (lgpu) is defined to be the number of compute
> > unit (CU) for a device. The lgpu allocation limit only applies to
> > c
The content of CSIB is always static, I submitted a patch to use the re-init
and get rid of pin/unpin CSIB in hw_ini/fini, (my purpose is to fix the double
unpin warning during unload )
_
Monk Liu|GPU Virtualization Team |AMD
-Original Message-
From:
[AMD Official Use Only - Internal Distribution Only]
Is kmalloc with GFP_NOWAIT an option here?
Regards,
Oak
From: amd-gfx On Behalf Of Sierra
Guiza, Alejandro (Alex)
Sent: Wednesday, November 27, 2019 9:55 AM
To: Koenig, Christian ; Kuehling, Felix
Cc: amd-gfx@lists.freedesktop.org
Subject:
Hi Christian,
I'm thinking about this problem, trying to come up with a solution. The
fundamental problem is that we need low-overhead access to the page
table in the MMU notifier, without much memory management or locking.
There is one "driver lock" that we're supposed to take in the MMU
no
On 2019-11-28 3:20 p.m., Bhawanpreet Lakha wrote:
> Hey Harry can you please take a look thanks
>
> On 2019-11-08 5:01 p.m., Deucher, Alexander wrote:
>> Acked-by: Alex Deucher
>>
>> *From:* amd-gfx on behalf of
>> Bhawan
Hey Harry can you please take a look thanks
On 2019-11-08 5:01 p.m., Deucher, Alexander wrote:
Acked-by: Alex Deucher
*From:* amd-gfx on behalf of
Bhawanpreet Lakha
*Sent:* Friday, November 8, 2019 4:57 PM
*To:* amd-gf
On 2019-11-28 11:33 a.m., Harry Wentland wrote:
We don't use this upstream in the Linux kernel.
Signed-off-by: Harry Wentland
Reviewed-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/dc/dc_dsc.h | 2 --
drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 8
drivers/gpu
We don't use this upstream in the Linux kernel.
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/dc_dsc.h | 2 --
drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 8
drivers/gpu/drm/amd/display/dc/dc_types.h| 4
3 files changed, 14 deletions(-)
diff --git a/
Series is
Reviewed-by: Harry Wentland
Harry
On 2019-11-27 9:31 p.m., zhengbin wrote:
> zhengbin (4):
> drm/amd/display: Remove unneeded semicolon in bios_parser.c
> drm/amd/display: Remove unneeded semicolon in bios_parser2.c
> drm/amd/display: Remove unneeded semicolon in hdcp.c
> drm/a
On 2019-11-28 3:27 a.m., Takashi Iwai wrote:
> Currently, gcc spews a warning as:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubbub.c: In function
> ‘hubbub1_verify_allow_pstate_change_high’:
> ./include/drm/drm_print.h:316:2: warning: ‘debug_data’ may be used
> uninitialized in t
On Fri, 22 Nov 2019, wrote:
> From: Mikita Lipski
>
> We shouldn't compare int with unsigned long to find the max value
> and since we are not expecting negative value returned from
> compute_offset we should make this function return unsigned long
> so we can compare the values when computing rc
Am 27.11.19 um 21:56 schrieb Alex Deucher:
So it's not mixed up with the CTX stuff.
Signed-off-by: Alex Deucher
Reviewed-by: Christian König
---
include/uapi/drm/amdgpu_drm.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/uapi/drm/amdgpu_drm.h b/includ
Hi Monk,
if the content of the CSIB is constant then it is certainly better to
just re-initialize it.
This also prevents from corruption because of VRAM lost.
Christian.
Am 28.11.19 um 03:53 schrieb Liu, Monk:
Hi Xiaojie
For SRIOV we don't use suspend so I didn't think to that part, thanks
The same workaround is used for gfx7.
Both PAL and Mesa use it for gfx8 too, so port this commit to
gfx_v8_0_ring_emit_fence_gfx.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
dif
-Original Message-
From: Grodzovsky, Andrey
Sent: Wednesday, November 27, 2019 11:46 PM
To: Ma, Le ; amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun ; Zhou1, Tao ;
Deucher, Alexander ; Li, Dennis ;
Zhang, Hawking
Subject: Re: [PATCH 07/10] drm/amdgpu: add concurrent baco reset suppor
Fixes coccicheck warning:
drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c:1525:144-145:
Unneeded semicolon
drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c:1526:142-143:
Unneeded semicolon
Reported-by: Hulk Robot
Signed-off-by: zhengbin
---
drivers/gpu/drm/
Fixes coccicheck warning:
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c:995:2-3: Unneeded semicolon
Reported-by: Hulk Robot
Signed-off-by: zhengbin
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/am
Fixes coccicheck warning:
drivers/gpu/drm/amd/display/modules/hdcp/hdcp.c:506:2-3: Unneeded semicolon
Reported-by: Hulk Robot
Signed-off-by: zhengbin
---
drivers/gpu/drm/amd/display/modules/hdcp/hdcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/disp
Fixes coccicheck warning:
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:2192:2-3: Unneeded semicolon
Reported-by: Hulk Robot
Signed-off-by: zhengbin
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd
zhengbin (4):
drm/amd/display: Remove unneeded semicolon in bios_parser.c
drm/amd/display: Remove unneeded semicolon in bios_parser2.c
drm/amd/display: Remove unneeded semicolon in hdcp.c
drm/amd/display: Remove unneeded semicolon in display_rq_dlg_calc_21.c
drivers/gpu/drm/amd/display/dc
Currently, gcc spews a warning as:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubbub.c: In function
‘hubbub1_verify_allow_pstate_change_high’:
./include/drm/drm_print.h:316:2: warning: ‘debug_data’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
This is because t
31 matches
Mail list logo
