Am 11.12.19 um 17:21 schrieb Alex Deucher:
Rename to SECURE to align with the CS flag naming.
Signed-off-by: Alex Deucher
I was rather close to given an acked-by, but then thought if that
actually makes sense.
The flags describe what should happen to the buffer and CS, and
considering tha
Am 11.12.19 um 17:42 schrieb Alex Deucher:
This reverts commit f2efc6e60089c99c342a6b7da47f1037e06c4296.
This was fixed properly for 5.5, but came back via 5.4 merge
into drm-next, so revert it again.
Signed-off-by: Alex Deucher
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgp
Am 11.12.19 um 20:48 schrieb Leo Liu:
Since it's only needed with VCN1.0 when HW has no its
own JPEG HW IP block
Wouldn't it be simpler/cleaner to just define a
vcn_v1_0_ring_begin_use() and vcn_v1_0_idle_work_handler() instead?
Regards,
Christian.
Signed-off-by: Leo Liu
---
drivers/gp
Am 11.12.19 um 21:19 schrieb Alex Deucher:
On Wed, Dec 11, 2019 at 3:07 PM Andrey Grodzovsky
wrote:
It is used to synchronize N threads at a rendevouz point before execution
of critical code that has to be started by all the threads at approximatly
the same time.
Signed-off-by: Andrey Grodzovs
Am 12.12.19 um 09:24 schrieb Christian König:
Am 11.12.19 um 21:19 schrieb Alex Deucher:
On Wed, Dec 11, 2019 at 3:07 PM Andrey Grodzovsky
wrote:
It is used to synchronize N threads at a rendevouz point before
execution
of critical code that has to be started by all the threads at
approximatl
Hi Felix,
yeah, I've also found a corner case which would raise a warning now.
Need to rework how dependencies for the PTE update are generated.
Going to take care of this in the next few days,
Christian.
Am 12.12.19 um 01:20 schrieb Felix Kuehling:
Hi Christian,
Alex started trying to inval
On Thu, Dec 05, 2019 at 03:03:56PM -0800, John Hubbard wrote:
> No advice, just a naming idea similar in spirit to Jerome's suggestion
> (use a longer descriptive word, and don't try to capture the entire phrase):
> use "notif" in place of the unloved "mmn". So partially, approximately like
> thi
On Thu, Dec 05, 2019 at 11:03:24AM -0500, Jerome Glisse wrote:
> > struct mmu_notifier_mm (ie the mm->mmu_notifier_mm)
> >-> mmn_mm
> > struct mm_struct
> >-> mm
> > struct mmu_notifier (ie the user subscription to the mm_struct)
> >-> mn
> > struct mmu_interval_notifier (the other ki
From: changzhu
When smu version is larger than 0x41e2b, it will load
raven_kicker_rlc.bin.To enable gfxoff for raven_kicker_rlc.bin,it
needs to avoid adev->pm.pp_feature &= ~PP_GFXOFF_MASK when it loads
raven_kicker_rlc.bin.
Change-Id: I4dffa1783c9ceb5d40df9756d821e2cd7feff84d
Signed-off-by: cha
[AMD Official Use Only - Internal Distribution Only]
On Thu, Dec 12, 2019 at 06:01:55PM +0800, Zhu, Changfeng wrote:
> From: changzhu
>
> When smu version is larger than 0x41e2b, it will load
> raven_kicker_rlc.bin.To enable gfxoff for raven_kicker_rlc.bin,it
> needs to avoid adev->pm.pp_feature
Hi
Please can amdgpu/raven_ta.bin be published somewhere
Thanks
Mike
On Wed, 11 Dec 2019 at 22:30, Alex Deucher wrote:
>
> Hi Dave, Daniel,
>
> Kicking off 5.6 with new stuff from AMD. There is a UAPI addition. We
> added a new firmware for display, and this just adds the version query
> to
Hi Christian,
FYI, remove amdgpu_bo_reserve(root, true) before calling
amdgpu_vm_bo_update_mapping, I got this warning backtrace:
[ 182.390072] WARNING: CPU: 12 PID: 4376 at
/home/yangp/git/compute_staging/kernel/drivers/gpu/drm/ttm/ttm_bo.c:1229
ttm_bo_validate+0x14d/0x1b0 [ttm]
[AMD Official Use Only - Internal Distribution Only]
__
From: Christian König
Sent: 12 December 2019 03:31
To: Alex Deucher; Grodzovsky, Andrey
Cc: Deucher, Alexander; Ma, Le; Quan, Evan; amd-gfx list; Zhang, Hawking
Subject: Re: [PATCH 2/5] drm: Add Reusable t
Because queue_work schedule the work on the same CPU the interrupt
handler is running, if there are many interrupts pending, it takes
longer time for work queue to start, or even worse system will hang.
Signed-off-by: Philip Yang
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 3 ++-
1 file change
On 12/11/19 11:04 PM, Ma, Le wrote:
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: Andrey Grodzovsky
Sent: Thursday, December 12, 2019 4:39 AM
To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Ma, Le
; Zhang, Ha
It fixes cpu stuck issue in some extreme test cases.
Reviewed-by: Eric Huang
On 2019-12-12 9:51 a.m., Philip Yang wrote:
Because queue_work schedule the work on the same CPU the interrupt
handler is running, if there are many interrupts pending, it takes
longer time for work queue to start, or
Am 12.12.19 um 15:50 schrieb Grodzovsky, Andrey:
[AMD Official Use Only - Internal Distribution Only]
__
From: Christian König
Sent: 12 December 2019 03:31
To: Alex Deucher; Grodzovsky, Andrey
Cc: Deucher, Alexander; Ma, Le; Quan, Evan; amd-gfx list; Zhang, H
On 12/12/19 10:09 AM, Christian König wrote:
Am 12.12.19 um 15:50 schrieb Grodzovsky, Andrey:
[AMD Official Use Only - Internal Distribution Only]
__
From: Christian König
Sent: 12 December 2019 03:31
To: Alex Deucher; Grodzovsky, Andrey
Cc: Deucher, Alexan
Hi Philip,
that is an expected result. You can only invalidate page tables without
holding the reservation lock.
What you do here is adding a new mapping and that one needs to allocate
a new page tables and won't work like this.
Regards,
Christian.
Am 12.12.19 um 15:38 schrieb Philip Yang:
On 12/11/19 11:05 PM, Ma, Le wrote:
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: Andrey Grodzovsky
Sent: Thursday, December 12, 2019 4:39 AM
To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Ma, Le
; Zhang, Ha
Am 12.12.19 um 16:57 schrieb Leo Liu:
On 2019-12-12 3:18 a.m., Christian König wrote:
Am 11.12.19 um 20:48 schrieb Leo Liu:
Since it's only needed with VCN1.0 when HW has no its
own JPEG HW IP block
Wouldn't it be simpler/cleaner to just define a
vcn_v1_0_ring_begin_use() and vcn_v1_0_idle_
Because VCN1.0 power management and DPG mode are managed together with
JPEG1.0 under both HW and FW, so separated them from general VCN code.
Also the multiple instances case got removed, since VCN1.0 HW just have
a single instance.
Signed-off-by: Leo Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vc
For VCN2.0 and above, VCN has been separated from JPEG
Signed-off-by: Leo Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 28 +
1 file changed, 5 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vc
On 2019-12-12 3:18 a.m., Christian König wrote:
Am 11.12.19 um 20:48 schrieb Leo Liu:
Since it's only needed with VCN1.0 when HW has no its
own JPEG HW IP block
Wouldn't it be simpler/cleaner to just define a
vcn_v1_0_ring_begin_use() and vcn_v1_0_idle_work_handler() instead?
Yeah, this wa
From: Xiaodong Yan
[Why]
Some combined docks will always trigger CP_IRQ but there's nothing the driver
needs to take care of, but the CP_IRQ breaks the original hdcp state and
triggers the driver to restart the authentication.
[How]
Add the event type check before restart the authentication or r
From: Michael Strauss
[WHY]
Some monitors trigger HDCP2.x timeout after reinitializing (e.g. toggling HDR)
by taking longer than expected to return h' (h prime)
Previously the 200ms watchdog timer retry count would hit
MAX_NUM_OF_ATTEMPTS (4), causing fallback to HDCP1.x
[HOW]
Adding a 1s delay
Summary of changes
*Fix return codes
*Fix some displays failing authentication
Bhawanpreet Lakha (3):
drm/amd/display: fix psp return condition for hdcp module
drm/amd/display: Fix hdcp1 create session
drm/amd/display: Return correct Error code for validate h_prime
Jing Zhou (1):
drm/amd/
From: Jing Zhou
[why]
Most DP/HDMI monitors need more time to response rx_validation
request.
[how]
Add generic 1000ms delay.
Signed-off-by: Jing Zhou
Reviewed-by: Wenjing Liu
---
.../display/modules/hdcp/hdcp1_transition.c | 20 +++
1 file changed, 16 insertions(+), 4 dele
[Why]
PSP needs session ID to destroy a session, In the case where we fail
create session we don't have a session ID
[How]
Set the session ID before returning
Signed-off-by: Bhawanpreet Lakha
---
drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 3 ++-
1 file changed, 2 insertions(+), 1 del
We are returning SUCCESS when hdcp_status != Success. Fix it.
Signed-off-by: Bhawanpreet Lakha
---
drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
b/drivers/gpu/drm/amd/di
[Why]
We are returning incorrect error code for validate h prime
[How]
Return the right Error code
Signed-off-by: Bhawanpreet Lakha
---
drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/modules/hdc
Reviewed-by: James Zhu for the series.
On 2019-12-12 11:06 a.m., Leo Liu wrote:
Because VCN1.0 power management and DPG mode are managed together with
JPEG1.0 under both HW and FW, so separated them from general VCN code.
Also the multiple instances case got removed, since VCN1.0 HW just have
a
Because queue_work schedule the work on the same CPU the interrupt
handler is running, if there are many interrupts pending, it takes
longer time for work queue to start, or even worse system will hang.
v2: queue work to same NUMA node for better cache locality
Signed-off-by: Philip Yang
Reviewe
Patches 1-3 are
Reviewed-by: Harry Wentland
Patches 4-6 are
Acked-by: Harry Wentland
Harry
On 2019-12-12 12:06 p.m., Bhawanpreet Lakha wrote:
> From: Xiaodong Yan
>
> [Why]
> Some combined docks will always trigger CP_IRQ but there's nothing the driver
> needs to take care of, but the CP_IRQ
Because queue_work schedule the work on the same CPU the interrupt
handler is running, if there are many interrupts pending, it takes
longer time for work queue to start, or even worse system will hang.
v2: queue work to same NUMA node for better cache locality
v3: handle cpumask_next wraparound c
From: Colin Ian King
There are several occurrances of the pointer hwmgr being dereferenced
before it is null checked. Fix these by performing the dereference
of hwmgr after it has been null checked.
Addresses-Coverity: ("Dereference before null check")
Fixes: 8497d2bcdee1 ("drm/amd/powerplay: e
Hi Dave, Daniel,
Fixes for 5.5.
The following changes since commit b53bd16fec3d52ff7be1648a9b0a747288f52cf8:
Merge tag 'drm-misc-next-fixes-2019-12-04' of
git://anongit.freedesktop.org/drm/drm-misc into drm-next (2019-12-05 11:11:11
+1000)
are available in the Git repository at:
git://pe
On Thu, Dec 12, 2019 at 1:17 PM Colin King wrote:
>
> From: Colin Ian King
>
> There are several occurrances of the pointer hwmgr being dereferenced
> before it is null checked. Fix these by performing the dereference
> of hwmgr after it has been null checked.
>
> Addresses-Coverity: ("Dereferen
On Sat, Dec 7, 2019 at 5:47 PM Timothy Pearson
wrote:
>
> arch support
>
> Introduce DC_FP_START()/DC_FP_END() macros to help enable floating
> point kernel mode support across various architectures.
>
> Signed-off-by: Timothy Pearson
Applied with a bit of tweaking. Thanks!
Alex
> ---
> ...
Geetings amd-gfx!
I beg your forgiveness in advance if you feel spammed a bit by me emailing
amd-gfx after submitting 2 issues.
My issues have been entered as ROC 961 and 962.
By no means do i expect that any of you would have read those yet (or at all 🙂 )
I wanted to reach out directly to yo
I agree with Christian's comments on patch 1. With those fixed, the
series is
Reviewed-by: Felix Kuehling
Regards,
Felix
On 2019-12-02 20:42, Yong Zhao wrote:
Since Arcturus has it own function pointer, we can move Arcturus
specific logic to there rather than leaving it entangled with
othe
The first one was already fixed and pushed a week ago.
Regards,
Yong
On 2019-12-12 7:25 p.m., Felix Kuehling wrote:
I agree with Christian's comments on patch 1. With those fixed, the
series is
Reviewed-by: Felix Kuehling
Regards,
Felix
On 2019-12-02 20:42, Yong Zhao wrote:
Since Arctu
From: changzhu
When smu version is larger than 0x41e2b, it will load
raven_kicker_rlc.bin.To enable gfxoff for raven_kicker_rlc.bin,it
needs to avoid adev->pm.pp_feature &= ~PP_GFXOFF_MASK when it loads
raven_kicker_rlc.bin.
Change-Id: I4dffa1783c9ceb5d40df9756d821e2cd7feff84d
Signed-off-by: cha
43 matches
Mail list logo
