Re: [PATCH] drm/amdgpu/vcn: add shared menory restore after wake up from sleep.

2020-04-06 Thread Christian König
Am 03.04.20 um 17:54 schrieb James Zhu: On 2020-04-03 11:37 a.m., Alex Deucher wrote: On Fri, Apr 3, 2020 at 8:52 AM James Zhu wrote: VCN shared memory needs restore after wake up during S3 test. How big is the shared memory?  It might be better to allocate the memory once at sw_init and the

[PATCH 1/1] drm/amd/powerplay: fix a typo

2020-04-06 Thread Nirmoy Das
Util -> Until Fixes: 720de5122254e86 (drm/amd/powerplay: implement the is_dpm_running()) Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c b/drivers/gpu/drm/amd/

[PATCH net-next] drm/amd/display: Fix link_detect_sink()

2020-04-06 Thread Dan Carpenter
This TODO stub originally had curly braces but we deleted them as part of a clean up. Unfortunately that changes the behavior of the code because now the switch statement is part of the if statement. Smatch complains that the indenting doesn't make sense. drivers/gpu/drm/amd/amdgpu/../displa

[bug report] drm/amd/display: Add ABM driver implementation

2020-04-06 Thread Dan Carpenter
Hello Wyatt Wood, This is a semi-automatic email about new static checker warnings. The patch 16012806e697: "drm/amd/display: Add ABM driver implementation" from Feb 20, 2020, leads to the following Smatch complaint: drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:661 dm

Re: [PATCH] drm/amdgpu/vcn: add shared menory restore after wake up from sleep.

2020-04-06 Thread James Zhu
On 2020-04-06 3:03 a.m., Christian König wrote: Am 03.04.20 um 17:54 schrieb James Zhu: On 2020-04-03 11:37 a.m., Alex Deucher wrote: On Fri, Apr 3, 2020 at 8:52 AM James Zhu wrote: VCN shared memory needs restore after wake up during S3 test. How big is the shared memory?  It might be bet

Re: [PATCH] drm/amdgpu/vcn: add shared menory restore after wake up from sleep.

2020-04-06 Thread Christian König
Am 06.04.20 um 14:31 schrieb James Zhu: On 2020-04-06 3:03 a.m., Christian König wrote: Am 03.04.20 um 17:54 schrieb James Zhu: On 2020-04-03 11:37 a.m., Alex Deucher wrote: On Fri, Apr 3, 2020 at 8:52 AM James Zhu wrote: VCN shared memory needs restore after wake up during S3 test. How b

Re: AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection

2020-04-06 Thread Peter Zijlstra
On Sun, Apr 05, 2020 at 12:19:30PM +0900, Masami Hiramatsu wrote: > > @@ -269,14 +269,14 @@ d4: AAM Ib (i64) > > d5: AAD Ib (i64) > > d6: > > d7: XLAT/XLATB > > -d8: ESC > > -d9: ESC > > -da: ESC > > -db: ESC > > -dc: ESC > > -dd: ESC > > -de: ESC > > -df: ESC > > +d8: FPU > > +d9: FPU > > +da:

Re: [PATCH 1/1] drm/amd/powerplay: fix a typo

2020-04-06 Thread Alex Deucher
On Mon, Apr 6, 2020 at 4:08 AM Nirmoy Das wrote: > > Util -> Until > Fixes: 720de5122254e86 (drm/amd/powerplay: implement the is_dpm_running()) > > Signed-off-by: Nirmoy Das Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 2 +- > 1 file changed, 1 insertion(+),

[PATCH] drm/amdgpu: add SPM golden settings for Navi10(v2)

2020-04-06 Thread Tianci Yin
From: "Tianci.Yin" Add RLC_SPM golden settings Change-Id: I616e127171293d915cb3a05dee02f51cec8d8f6f Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1059 1 file changed, 1059 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/d

Re: [PATCH] drm/amdgpu: add SPM golden settings for Navi10

2020-04-06 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Thanks Alex! I send it again, please help review. BR, Rico From: Alex Deucher Sent: Friday, April 3, 2020 22:53 To: Yin, Tianci (Rico) Cc: amd-gfx list ; Deucher, Alexander ; Xu, Feifei ; Zhang, Hawking ; He

Re: [PATCH] drm/amdgpu: add SPM golden settings for Navi10(v2)

2020-04-06 Thread Alex Deucher
On Mon, Apr 6, 2020 at 10:26 AM Tianci Yin wrote: > > From: "Tianci.Yin" > > Add RLC_SPM golden settings > > Change-Id: I616e127171293d915cb3a05dee02f51cec8d8f6f > Signed-off-by: Tianci.Yin Reviewed-by: Alex Deucher ___ amd-gfx mailing list amd-gfx@l

Re: [PATCH] drm/amdgpu: add SPM golden settings for Navi10(v2)

2020-04-06 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Thanks very much Alex! From: Alex Deucher Sent: Monday, April 6, 2020 22:29 To: Yin, Tianci (Rico) Cc: amd-gfx list ; Deucher, Alexander ; Xu, Feifei ; Zhang, Hawking ; Hesik, Christopher Subject: Re: [PATCH

Re: [PATCH] drm/amdgpu/display: fix logic inversion in program_timing_sync()

2020-04-06 Thread Alex Deucher
Ping again? Alex On Thu, Feb 20, 2020 at 8:27 AM Alex Deucher wrote: > > On Tue, Feb 4, 2020 at 9:06 AM Kazlauskas, Nicholas > wrote: > > > > Comments inline. > > > > On 2020-02-03 4:07 p.m., Alex Deucher wrote: > > > Ping? > > > > > > On Fri, Jan 10, 2020 at 3:11 PM Alex Deucher > > > wrote:

Re: [PATCH 30/36] drm/amd/display: Avoid create MST prop after registration

2020-04-06 Thread Michel Dänzer
On 2020-04-05 10:41 p.m., Rodrigo Siqueira wrote: > From: "Jerry (Fangzhi) Zuo" > > [Why] > Prop are created at boot stage, and not allowed to create new prop > after device registration. > > [How] > Reuse the connector property from SST if exist. > > Signed-off-by: Jerry (Fangzhi) Zuo > Revie

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Adam Jackson
On Sat, 2020-04-04 at 08:11 -0700, Rob Clark wrote: > On Fri, Apr 3, 2020 at 7:12 AM Michel Dänzer wrote: > > On 2020-03-01 6:46 a.m., Marek Olšák wrote: > > > For Mesa, we could run CI only when Marge pushes, so that it's a strictly > > > pre-merge CI. > > > > Thanks for the suggestion! I implem

[PATCH] drm/amdgpu: Re-enable FRU check for most models v4

2020-04-06 Thread Kent Russell
There is 1 VG20 DID that does not have the FRU on there, and trying to read that will cause a hang. For now, check for the gaming DID until a proper fix can be implemented. This re-enables serial number reporting for server cards v2: Add ASIC check v3: Don't default to true for pre-VG20 v4: Use DI

[PATCH] drm/amdgpu: Re-enable FRU check for most models v4

2020-04-06 Thread Kent Russell
There is at least 1 VG20 DID that does not have an FRU, and trying to read that will cause a hang. For now, explicitly support reading the FRU for Arcturus and for the WKS VG20 DIDs, and skip for everything else. This re-enables serial number reporting for server cards v2: Add ASIC check v3: Don't

RE: [PATCH] drm/amdgpu: Re-enable FRU check for most models v4

2020-04-06 Thread Russell, Kent
[AMD Official Use Only - Internal Distribution Only] Ignore this one, needed to update the commit Kent > -Original Message- > From: Russell, Kent > Sent: Monday, April 6, 2020 11:51 AM > To: amd-gfx@lists.freedesktop.org > Cc: Russell, Kent > Subject: [PATCH] drm/amdgpu: Re-enable FRU

Re: [PATCH 1/6] amdgpu: a NULL ->mm does not mean a thread is a kthread

2020-04-06 Thread Felix Kuehling
Am 2020-04-04 um 5:40 a.m. schrieb Christoph Hellwig: > Use the proper API instead. > > Fixes: 70539bd795002 ("drm/amd: Update MEC HQD loading code for KFD") > Signed-off-by: Christoph Hellwig Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 2 +- > 1 file chan

Re: [PATCH 5/6] kernel: better document the use_mm/unuse_mm API contract

2020-04-06 Thread Felix Kuehling
Am 2020-04-04 um 5:41 a.m. schrieb Christoph Hellwig: > Switch the function documentation to kerneldoc comments, and add > WARN_ON_ONCE asserts that the calling thread is a kernel thread and > does not have ->mm set (or has ->mm set in the case of unuse_mm). > > Also give the functions a kthread_ p

Re: [PATCH 4/6] kernel: move use_mm/unuse_mm to kthread.c

2020-04-06 Thread Felix Kuehling
Am 2020-04-04 um 5:40 a.m. schrieb Christoph Hellwig: > These helpers are only for use with kernel threads, and I will tie them > more into the kthread infrastructure going forward. Also move the > prototypes to kthread.h - mmu_context.h was a little weird to start with > as it otherwise contains

Re: [PATCH net-next] drm/amd/display: Fix link_detect_sink()

2020-04-06 Thread Kazlauskas, Nicholas
On 2020-04-06 5:19 a.m., Dan Carpenter wrote: This TODO stub originally had curly braces but we deleted them as part of a clean up. Unfortunately that changes the behavior of the code because now the switch statement is part of the if statement. Smatch complains that the indenting doesn't make

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Rob Clark
On Mon, Apr 6, 2020 at 8:43 AM Adam Jackson wrote: > > On Sat, 2020-04-04 at 08:11 -0700, Rob Clark wrote: > > On Fri, Apr 3, 2020 at 7:12 AM Michel Dänzer wrote: > > > On 2020-03-01 6:46 a.m., Marek Olšák wrote: > > > > For Mesa, we could run CI only when Marge pushes, so that it's a > > > > st

Re: gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Michel Dänzer
On 2020-04-06 6:34 p.m., Rob Clark wrote: > > The ideal thing would be to be able to click any jobs that we want to > run, say "arm64_a630_gles31", and for gitlab to realize that it needs > to automatically trigger dependencies of that job (meson-arm64, and > arm_build+arm_test). But not sure if t

[PATCH] drm/amdgpu: Print UTCL2 client ID on a gpuvm fault

2020-04-06 Thread Oak Zeng
UTCL2 client ID is useful information to get which UTCL2 client caused the gpuvm fault. Print it out for debug purpose Change-Id: I733d0127b0ee53aa788f194cefa53cbb55b49c11 Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++ drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 +++

Re: gitlab.fd.o financial situation and impact on services

2020-04-06 Thread Rob Clark
On Mon, Apr 6, 2020 at 10:04 AM Michel Dänzer wrote: > > On 2020-04-06 6:34 p.m., Rob Clark wrote: > > > > The ideal thing would be to be able to click any jobs that we want to > > run, say "arm64_a630_gles31", and for gitlab to realize that it needs > > to automatically trigger dependencies of th

Re: [PATCH 30/36] drm/amd/display: Avoid create MST prop after registration

2020-04-06 Thread Rodrigo Siqueira
Hi Michel, I'm going to apply the patchset by the end of the day at AMD repository. Is that ok for you? Or do you need this patch on drm-misc-next? Best Regards On 04/06, Michel Dänzer wrote: > On 2020-04-05 10:41 p.m., Rodrigo Siqueira wrote: > > From: "Jerry (Fangzhi) Zuo" > > > > [Why] > >

Re: [PATCH] drm/amdgpu: Print UTCL2 client ID on a gpuvm fault

2020-04-06 Thread Alex Deucher
On Mon, Apr 6, 2020 at 1:42 PM Oak Zeng wrote: > > UTCL2 client ID is useful information to get which > UTCL2 client caused the gpuvm fault. Print it out > for debug purpose > > Change-Id: I733d0127b0ee53aa788f194cefa53cbb55b49c11 > Signed-off-by: Oak Zeng Reviewed-by: Alex Deucher > --- > d

Re: [PATCH 30/36] drm/amd/display: Avoid create MST prop after registration

2020-04-06 Thread Alex Deucher
On Mon, Apr 6, 2020 at 2:44 PM Rodrigo Siqueira wrote: > > Hi Michel, > > I'm going to apply the patchset by the end of the day at AMD repository. > Is that ok for you? Or do you need this patch on drm-misc-next? I can cherry-pick the changes over to 5.7 fixes once we've addressed all the issues.

Re: [PATCH 30/36] drm/amd/display: Avoid create MST prop after registration

2020-04-06 Thread Rodrigo Siqueira
Ok, I'll just push the patch to our repository. Thanks On 04/06, Alex Deucher wrote: > On Mon, Apr 6, 2020 at 2:44 PM Rodrigo Siqueira > wrote: > > > > Hi Michel, > > > > I'm going to apply the patchset by the end of the day at AMD repository. > > Is that ok for you? Or do you need this patch on

Re: [PATCH 30/36] drm/amd/display: Avoid create MST prop after registration

2020-04-06 Thread Alex Deucher
On Mon, Apr 6, 2020 at 2:52 PM Rodrigo Siqueira wrote: > > Ok, I'll just push the patch to our repository. Sounds good. Please note the other issue Michel mentioned below. We need a fix for that as well for 5.7. Thanks, Alex > > Thanks > > On 04/06, Alex Deucher wrote: > > On Mon, Apr 6, 202

Re: [PATCH 1/2] drm/amd/display: query hdcp capability during link detect

2020-04-06 Thread Mikita Lipski
Both patches look good to me. The series is Reviewed-by: Mikita Lipski Thanks, Mikita On 2020-04-01 5:00 p.m., Bhawanpreet Lakha wrote: [Why] Query the hdcp caps of a link, it is useful and can be reported to the user [How] Create a query function and call it during link detect Signed-off-b

Re: [PATCH] drm/amdgpu: Print UTCL2 client ID on a gpuvm fault

2020-04-06 Thread Christian König
Am 06.04.20 um 20:46 schrieb Alex Deucher: On Mon, Apr 6, 2020 at 1:42 PM Oak Zeng wrote: UTCL2 client ID is useful information to get which UTCL2 client caused the gpuvm fault. Print it out for debug purpose Change-Id: I733d0127b0ee53aa788f194cefa53cbb55b49c11 Signed-off-by: Oak Zeng Review

[PATCH] PCI/P2PDMA: Add additional AMD ZEN root ports to the whitelist

2020-04-06 Thread Alex Deucher
According to the hw architect, pre-ZEN parts support p2p writes and ZEN parts support both p2p reads and writes. Add entries for Zen parts Raven (0x15d0) and Renoir (0x1630). Cc: Christian König Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/pci/p2pdma.c | 2 ++ 1 file chan

Re: [PATCH] device_cgroup: Cleanup cgroup eBPF device filter code

2020-04-06 Thread Daniel Borkmann
On 4/4/20 12:37 AM, Roman Gushchin wrote: On Fri, Apr 03, 2020 at 07:55:28PM +0200, Odin Ugedal wrote: Original cgroup v2 eBPF code for filtering device access made it possible to compile with CONFIG_CGROUP_DEVICE=n and still use the eBPF filtering. Change commit 4b7d4d453fc4 ("device_cgroup: Ex

[PATCH v3] drm/amdkfd: Provide SMI events watch

2020-04-06 Thread Amber Lin
When the compute is malfunctioning or performance drops, the system admin will use SMI (System Management Interface) tool to monitor/diagnostic what went wrong. This patch provides an event watch interface for the user space to register events they are interested. After the event is registered, the

Re: [PATCH 6/6] kernel: set USER_DS in kthread_use_mm

2020-04-06 Thread Michael S. Tsirkin
On Sat, Apr 04, 2020 at 11:41:01AM +0200, Christoph Hellwig wrote: > Some architectures like arm64 and s390 require USER_DS to be set for > kernel threads to access user address space, which is the whole purpose > of kthread_use_mm, but other like x86 don't. That has lead to a huge > mess where so

Re: [PATCH 1/2] drm/amd/display: query hdcp capability during link detect

2020-04-06 Thread Rodrigo Siqueira
Reviewed-by: Rodrigo Siqueira On 04/01, Bhawanpreet Lakha wrote: > [Why] > Query the hdcp caps of a link, it is useful and can be reported to the user > > [How] > Create a query function and call it during link detect > > Signed-off-by: Bhawanpreet Lakha > --- > drivers/gpu/drm/amd/display/dc

Re: [PATCH 2/2] drm/amd/display: add HDCP caps debugfs

2020-04-06 Thread Rodrigo Siqueira
Reviewed-by: Rodrigo Siqueira On 04/01, Bhawanpreet Lakha wrote: > Add debugfs to get HDCP capability. This is also useful for > kms_content_protection igt test. > > Use: > cat /sys/kernel/debug/dri/0/DP-1/hdcp_sink_capability > cat /sys/kernel/debug/dri/0/HDMI-A-1/hdcp_sink_capabili

Re: [PATCH] PCI/P2PDMA: Add additional AMD ZEN root ports to the whitelist

2020-04-06 Thread Huang Rui
On Mon, Apr 06, 2020 at 03:42:01PM -0400, Alex Deucher wrote: > According to the hw architect, pre-ZEN parts support > p2p writes and ZEN parts support both p2p reads and writes. > > Add entries for Zen parts Raven (0x15d0) and Renoir (0x1630). > > Cc: Christian König > Acked-by: Christian König

[PATCH] drm/amdgpu: resolve mGPU RAS query instability

2020-04-06 Thread Clements, John
[AMD Official Use Only - Internal Distribution Only] Submitting patch to resolve issue when upon receiving an uncorrectable ras error, RAS ISR gets triggered on all GPU node creating a race condition between querying the RAS errors and entering the GPU reset sequence 0001-drm-amdgpu-resolve-mG

RE: [PATCH] drm/amdgpu: resolve mGPU RAS query instability

2020-04-06 Thread Zhang, Hawking
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Hawking Zhang Per discussion, please have a separated patch to replace all the "DRM_INFO" with "dev_info" in per IP query_ras_error_count callback function so that we will have clear picture on which errors are from which nodes

RE: [PATCH] drm/amdgpu: fix gfx hang during suspend with video playback

2020-04-06 Thread Liang, Prike
> -Original Message- > From: Huang, Ray > Sent: Friday, April 3, 2020 6:29 PM > To: Liang, Prike > Cc: Deucher, Alexander ; Kuehling, Felix > ; Quan, Evan ; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: fix gfx hang during suspend with video > playback > > On Fri

[PATCH 3/3] drm/amdkfd Avoid destroy hqd when GPU is on reset

2020-04-06 Thread Jack Zhang
porting to gfx10 from commit 1b0bfcff463f390c4032ebe36a4d5fb777c00a4c Originally, MEC is touched without GPU initialized first. Signed-off-by: Jack Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdg

[PATCH 1/3] Revert "drm/amdgpu/sriov add amdgpu_amdkfd_pre_reset in gpu reset"

2020-04-06 Thread Jack Zhang
This reverts commit 8a468ab2d75a6b0bacfb5da6a9036642436fc666. --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c | 3 --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 3 --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 -- 3 files changed, 8 deletions(-) diff --git a/drivers

[PATCH 2/3] drm/amdgpu/sriov add amdgpu_amdkfd_pre_reset in gpu reset

2020-04-06 Thread Jack Zhang
kfd_pre_reset will free mem_objs allocated by kfd_gtt_sa_allocate Without this change, sriov tdr code path will never free those allocated memories and get memory leak. Signed-off-by: Jack Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH 1/2] drm/amdgpu: add SPM golden settings for Navi14

2020-04-06 Thread Tianci Yin
From: "Tianci.Yin" Add RLC_SPM golden settings Change-Id: I5d3564aae13a7352514c0795b7d087d1534fe374 Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 627 + 1 file changed, 627 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/dr

[PATCH 2/2] drm/amdgpu: add SPM golden settings for Navi12

2020-04-06 Thread Tianci Yin
From: "Tianci.Yin" Add RLC_SPM golden settings Change-Id: I276699f6b77f3d0751349af09eec482584091f89 Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1059 1 file changed, 1059 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/d

[PATCH 2/2] drm/ttm: abstract all ttm prefix into ttm_debug header

2020-04-06 Thread Huang Rui
Using the debug header instead of macro at the start of the files. Signed-off-by: Huang Rui --- drivers/gpu/drm/ttm/ttm_agp_backend.c| 3 +-- drivers/gpu/drm/ttm/ttm_bo.c | 3 +-- drivers/gpu/drm/ttm/ttm_bo_vm.c | 3 +-- drivers/gpu/drm/ttm/ttm_memory.c | 3 +--

[PATCH 1/2] drm/ttm: clean up ttm_trace_dma_map/ttm_trace_dma_unmap

2020-04-06 Thread Huang Rui
ttm_trace_dma_map/ttm_trace_dma_unmap is never used anymore. Move the pr_fmt prefix into this header. Signed-off-by: Huang Rui --- include/drm/ttm/ttm_debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/ttm/ttm_debug.h b/include/drm/ttm/ttm_debug.h index b

[PATCH 5/5] drm/amdgpu: utilize subconnector property for DP through DisplayManager

2020-04-06 Thread Jeevan B
From: Oleg Vasilev Since DP-specific information is stored in driver's structures, every driver needs to implement subconnector property by itself. Display Core already has the subconnector information, we only need to expose it through DRM property. v2:rebase Cc: Alex Deucher Cc: Christian Kö

[PATCH 4/5] drm/amdgpu: utilize subconnector property for DP through atombios

2020-04-06 Thread Jeevan B
From: Oleg Vasilev Since DP-specific information is stored in driver's structures, every driver needs to implement subconnector property by itself. v2: rebase Cc: Alex Deucher Cc: Christian König Cc: David (ChunMing) Zhou Cc: amd-gfx@lists.freedesktop.org Signed-off-by: Jeevan B Signed-off-