RE: [PATCH 1/2] drm/amdgpu: Add ReadSerial defines for Arcturus

[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Kent Russell Sent: Tuesday, April 28, 2020 12:48 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH 1/2] drm/amdgpu: Add ReadSerial defines for

RE: [PATCH 2/2] drm/amdgpu: Add unique_id for Arcturus

[AMD Official Use Only - Internal Distribution Only] arcturus_tables_init() is performed on ip sw_init when the SMU hw may be not ready for message handling. I would suggest to put this in some API of later SMU hw_init. Regards, Evan -Original Message- From: amd-gfx On Behalf Of Kent

[PATCH 3/3] drm/amdgpu: remove set but not used variable 'direct_poll' in vcn_v2_5.c

Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:1170:39: warning: variable ‘direct_poll’ set but not used [-Wunused-but-set-variable] It is introduced by commit 7daaebfea5e5 ("drm/amdgpu: add VCN2.5 sriov start for Arctrus"), but never used, so remove it.

[PATCH 2/3] drm/amdgpu: remove set but not used variable 'direct_poll' in vcn_v2_0.c

Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:1848:39: warning: variable ‘direct_poll’ set but not used [-Wunused-but-set-variable] It is introduced by commit dd26858a9cd8 ("drm/amdgpu: implement initialization part on VCN2.0 for SRIOV"), but never used,

[PATCH 1/3] drm/amdgpu: remove set but not used variable 'priority'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1211:26: warning: variable ‘priority’ set but not used It is not used since commit 33abcb1f5a17 ("drm/amdgpu: set compute queue priority at mqd_init") Reported-by: Hulk Robot Signed-off-by: Zheng Bin ---

[PATCH 0/3] drm/amdgpu: remove set but not used variables

Zheng Bin (3): drm/amdgpu: remove set but not used variable 'priority' drm/amdgpu: remove set but not used variable 'direct_poll' in vcn_v2_0.c drm/amdgpu: remove set but not used variable 'direct_poll' in vcn_v2_5.c drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 --

Re: [PATCH hmm 5/5] mm/hmm: remove the customizable pfn format from hmm_range_fault

On Wed, Apr 22, 2020 at 01:52:32PM -0400, Felix Kuehling wrote: > [+Philip Yang] > > Am 2020-04-21 um 8:21 p.m. schrieb Jason Gunthorpe: > > From: Jason Gunthorpe > > > > Presumably the intent here was that hmm_range_fault() could put the data > > into some HW specific format and thus avoid some

[PATCH 4/4] drm/amdgpu: Add missing parameter description in comments

Kerneldoc comments should describe all function parameters. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 1 + drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c

[PATCH 1/4] drm/amdkfd: Report domain with topology

From: Ori Messinger PCI domain has moved to 32-bits to accommodate virtualization, so a 32-bit integer is exposed for domain to reflect this change. Domain can be found in here: /sys/class/kfd/kfd/topology/nodes/X/properties Where X is the card number Signed-off-by: Ori Messinger Reviewed-by:

[PATCH 0/4] KFD upstreaming

A few small patches found during DKMS branch rebasing that were missing from amd-staging-drm-next for no good reason. Felix Kuehling (2): drm/amdkfd: Fix comment formatting drm/amdgpu: Add missing parameter description in comments Oak Zeng (1): drm/amdgpu: Changed CU reservation golden

[PATCH 3/4] drm/amdkfd: Fix comment formatting

Corrected two function names. Added a missing space. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 ++-- include/uapi/linux/kfd_ioctl.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c

[PATCH 2/4] drm/amdgpu: Changed CU reservation golden settings

From: Oak Zeng With previous golden settings, compute task can't use reserved LDS (32K) on CU0 and CU1. On 64K LDS system, if compute work group allocate more than 32K LDS, then it can't be dispatched to CU0 and CU1 because of the reservation. This enables compute task to use reserved LDS on CU0

[pull] amdgpu drm-fixes-5.7

Hi Dave, Daniel, Fixes for 5.7. The following changes since commit e32b2484b3e00170b6cf57d99a18972e174e10ea: Merge tag 'drm-misc-fixes-2020-04-23' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2020-04-24 10:14:04 +1000) are available in the Git repository at:

Re: [PATCH] [v2] amdgpu: fix gcc-4.8 build warnings

On Wed, Apr 29, 2020 at 3:42 PM Kazlauskas, Nicholas wrote: > > On 2020-04-29 5:20 a.m., Arnd Bergmann wrote: > > Older compilers warn about initializers with incorrect curly > > braces: > > > > drivers/gpu/drm/drm_dp_mst_topology.c: In function > > 'drm_dp_mst_dsc_aux_for_port': > >

Re: [PATCH hmm 2/5] mm/hmm: make hmm_range_fault return 0 or -1

On Wed, Apr 22, 2020 at 07:52:29AM +0200, Christoph Hellwig wrote: > On Tue, Apr 21, 2020 at 09:21:43PM -0300, Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > > > hmm_vma_walk->last is supposed to be updated after every write to the > > pfns, so that it can be returned by hmm_range_fault().

Re: [PATCH] drm: Correct DP DSC macro typo

On 2020-04-29 2:41 p.m., Rodrigo Siqueira wrote: > In the file drm_dp_helper.h we have a macro named > DP_DSC_THROUGHPUT_MODE_{0,1}_UPSUPPORTED, the correct name should be > DP_DSC_THROUGHPUT_MODE_{0,1}_UNSUPPORTED. This commits adjusts this typo > in the header file and in other places that

[PATCH] drm: Correct DP DSC macro typo

In the file drm_dp_helper.h we have a macro named DP_DSC_THROUGHPUT_MODE_{0,1}_UPSUPPORTED, the correct name should be DP_DSC_THROUGHPUT_MODE_{0,1}_UNSUPPORTED. This commits adjusts this typo in the header file and in other places that attempt to access this macro. Signed-off-by: Rodrigo Siqueira

Re: amdgpu, dc, backlight brightness

On Wed, Apr 29, 2020 at 3:29 AM Andriy Gapon wrote: > > > I see that amdgpu_atif_handler() has this comment and code: > /* todo: add DC handling */ > if ((req.pending & ATIF_PANEL_BRIGHTNESS_CHANGE_REQUEST) && >

[PATCH] drm/amd/display: Add dm support for DP 1.4 Compliance edid corruption test

It works together with drm framework "drm: Add support for DP 1.4 Compliance edid corruption test" Signed-off-by: Jerry (Fangzhi) Zuo --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 40 ++- 1 file changed, 13 insertions(+), 27 deletions(-) diff --git

RE: [PATCH 2/2] drm/amdgpu: Add unique_id for Arcturus

[AMD Official Use Only - Internal Distribution Only] > -Original Message- > From: Alex Deucher > Sent: Wednesday, April 29, 2020 1:39 PM > To: Russell, Kent > Cc: amd-gfx list > Subject: Re: [PATCH 2/2] drm/amdgpu: Add unique_id for Arcturus > > On Mon, Apr 27, 2020 at 12:47 PM Kent

Re: [PATCH 2/2] drm/amdgpu: Add unique_id for Arcturus

On Mon, Apr 27, 2020 at 12:47 PM Kent Russell wrote: > > Add support for unique_id for Arcturus, since we only have the ppsmc > definitions for that added at the moment > > Signed-off-by: Kent Russell > Change-Id: I66f8e9ff41521d6c13ff673587d6061c1f3f4b7a > --- >

RE: [PATCH 1/2] drm/amdgpu: Add ReadSerial defines for Arcturus

[AMD Official Use Only - Internal Distribution Only] Friendly ping > -Original Message- > From: Russell, Kent > Sent: Monday, April 27, 2020 12:48 PM > To: amd-gfx@lists.freedesktop.org > Cc: Russell, Kent > Subject: [PATCH 1/2] drm/amdgpu: Add ReadSerial defines for Arcturus > > Add

[PATCH] drm/amdgpu/dc: Use WARN_ON_ONCE for ASSERT

From: Michel Dänzer Once should generally be enough for diagnosing what lead up to it, repeating it over and over can be pretty annoying. Signed-off-by: Michel Dänzer --- drivers/gpu/drm/amd/display/dc/os_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

On Wed, Apr 29, 2020 at 12:05 PM Takashi Iwai wrote: > > On Wed, 29 Apr 2020 17:47:47 +0200, > Alex Deucher wrote: > > > > On Wed, Apr 29, 2020 at 11:27 AM Nicholas Johnson > > wrote: > > > > > > On Wed, Apr 29, 2020 at 09:37:41AM +0200, Takashi Iwai wrote: > > > > On Tue, 28 Apr 2020 16:48:45

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

On Wed, 29 Apr 2020 17:47:47 +0200, Alex Deucher wrote: > > On Wed, Apr 29, 2020 at 11:27 AM Nicholas Johnson > wrote: > > > > On Wed, Apr 29, 2020 at 09:37:41AM +0200, Takashi Iwai wrote: > > > On Tue, 28 Apr 2020 16:48:45 +0200, > > > Nicholas Johnson wrote: > > > > > > > > > > > > > > > > > >

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

On Wed, Apr 29, 2020 at 11:27 AM Nicholas Johnson wrote: > > On Wed, Apr 29, 2020 at 09:37:41AM +0200, Takashi Iwai wrote: > > On Tue, 28 Apr 2020 16:48:45 +0200, > > Nicholas Johnson wrote: > > > > > > > > > > > > > > > > > FWIW, I have a fiji board in a desktop system and it worked fine > > >

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

On Wed, 29 Apr 2020 17:27:17 +0200, Nicholas Johnson wrote: > > On Wed, Apr 29, 2020 at 09:37:41AM +0200, Takashi Iwai wrote: > > On Tue, 28 Apr 2020 16:48:45 +0200, > > Nicholas Johnson wrote: > > > > > > > > > > > > > > > > > FWIW, I have a fiji board in a desktop system and it worked fine >

Re: [PATCH] drm/amdgpu/smu10: remove duplicate assignment of smu10_hwmgr_funcs members

On Tue, Apr 28, 2020 at 8:47 AM Jason Yan wrote: > > The struct member 'asic_setup' was assigned twice, let's remove one: > > static const struct pp_hwmgr_func smu10_hwmgr_funcs = { > .. > .asic_setup = NULL, > .. > .asic_setup = smu10_setup_asic_task, >

Re: [PATCH] drm/amd/display: remove duplicate assignment of dcn21_funcs members

On Tue, Apr 28, 2020 at 8:46 AM Jason Yan wrote: > > Fix the following coccicheck warning: > > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c:31:51-52: > exit_optimized_pwr_state: first occurrence line 86, second occurrence > line 92 >

[PATCH 1/1] drm/amd/display: work around fp code being emitted outside of DC_FP_START/END

The dcn20_validate_bandwidth function would have code touching the incorrect registers emitted outside of the boundaries of the DC_FP_START/END macros, at least on ppc64le. Work around the problem by wrapping the whole function instead. Signed-off-by: Daniel Kolesa ---

[PATCH 0/1] Fix Navi cards crashing with FP exception on 5.6+

This is not a real fix, but rather a workaround that should be applied to the 5.6 tree and newer. The idea here is to work around the compiler emitting FP instructions outside the DC_FP_START/DC_FP_END blocks, which it currently does, which causes crashes at least on ppc64le. A proper solution

Re: [PATCH] drm/amdgpu: Add autodump debugfs node for gpu reset v4

Am 29.04.20 um 16:04 schrieb Pierre-Eric Pelloux-Prayer: Hi Jiange, This version seems to work fine. Tested-by: Pierre-Eric Pelloux-Prayer On 29/04/2020 07:08, Zhao, Jiange wrote: [AMD Official Use Only - Internal Distribution Only] Hi all, I worked out the race condition and here is

Re: [PATCH] drm/amdgpu: Add autodump debugfs node for gpu reset v4

Hi Jiange, This version seems to work fine. Tested-by: Pierre-Eric Pelloux-Prayer On 29/04/2020 07:08, Zhao, Jiange wrote: > [AMD Official Use Only - Internal Distribution Only] > > > Hi all, > > I worked out the race condition and here is version 5. Please have a look. > > Jiange >

[PATCH] [v2] amdgpu: fix gcc-4.8 build warnings

Older compilers warn about initializers with incorrect curly braces: drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_dp_mst_dsc_aux_for_port': drivers/gpu/drm/drm_dp_mst_topology.c:5497:9: error: missing braces around initializer [-Werror=missing-braces] struct drm_dp_desc desc = { 0

Re: [PATCH] [v2] amdgpu: fix gcc-4.8 build warnings

On 2020-04-29 5:20 a.m., Arnd Bergmann wrote: Older compilers warn about initializers with incorrect curly braces: drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_dp_mst_dsc_aux_for_port': drivers/gpu/drm/drm_dp_mst_topology.c:5497:9: error: missing braces around initializer

RE: drm/amdgpu: invalidate L2 before SDMA IBs (on gfx10)

Hi Monk, because some parallel execution could load the GL2C. See you need to insert cache invalidations before you start reading something which another engine has written. And you need cache flushes to make sure that something your engine has written has reached memory before you signal

RE: drm/amdgpu: invalidate L2 before SDMA IBs (on gfx10)

>> Well from my understanding I think that a G2LC invalidation is still >> necessary before an IB executes. Agree, I think before an IB executes the only thing we need on GL2C is the invalidation, not the flush . >> The problem is that the memory of the IB could also be cached because of >>

Re: drm/amdgpu: invalidate L2 before SDMA IBs (on gfx10)

Well from my understanding I think that a G2LC invalidation is still necessary before an IB executes. The problem is that the memory of the IB could also be cached because of some activity of the GFX or Compute rings. Regards, Christian. Am 29.04.20 um 11:35 schrieb Liu, Monk: Here is the

RE: drm/amdgpu: invalidate L2 before SDMA IBs (on gfx10)

Here is the reason we should always insert a “sync mem” packet at the FENCE place of SDMA, not before IB emit. By always inserting “sync mem” in the FENCE place we can make sure:1 1. data is really flushed to system memory before CPU try to read it 2. all the G2LC is invalidated by “sync

RE: drm/amdgpu: invalidate L2 before SDMA IBs (on gfx10)

Hi @Koenig, Christian & Marek I still have some concerns regarding Marek’s patch, correct me if I’m wrong See that Marek put a SDMA_OP_GCR_REQ before emitting IB, to make sure SDMA won’t get stale cache data during the IB execution. But that “SDMA_OP_GCR_REQ”

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

On Tue, 28 Apr 2020 16:48:45 +0200, Nicholas Johnson wrote: > > > > > > > > > > > FWIW, I have a fiji board in a desktop system and it worked fine when > > > > > this code was enabled. > > > > > > > > Is the new DC code used for Fiji boards? IIRC, the audio component > > > > binding from amdgpu

amdgpu, dc, backlight brightness

I see that amdgpu_atif_handler() has this comment and code: /* todo: add DC handling */ if ((req.pending & ATIF_PANEL_BRIGHTNESS_CHANGE_REQUEST) && !amdgpu_device_has_dc_support(adev)) { ... } So, this makes me curious how a

[PATCH] amdgpu: fix gcc-4.8 build warnings

Older compilers warn about initializers with incorrect curly braces: drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_dp_mst_dsc_aux_for_port': drivers/gpu/drm/drm_dp_mst_topology.c:5497:9: error: missing braces around initializer [-Werror=missing-braces] struct drm_dp_desc desc = { 0