Am 07.05.20 um 04:02 schrieb Chunming Zhou:
Glad to spend time on kernel driver in past years.
I've moved to new focus in umd and couldn't commit
enough time to discussions.
Signed-off-by: Chunming Zhou
So Long, and Thanks for All the Fish :)
Reviewed-by: Christian König
---
MAINTAINERS
Am 06.05.20 um 21:01 schrieb Joe Perches:
On Tue, 2020-05-05 at 16:01 +0200, Arnd Bergmann wrote:
After the structure was padded to 1024 bytes, it is no longer
suitable for being a local variable, as the function surpasses
the warning limit for 32-bit architectures:
drivers/gpu/drm/amd/amdgpu/a
Glad to spend time on kernel driver in past years.
I've moved to new focus in umd and couldn't commit
enough time to discussions.
Signed-off-by: Chunming Zhou
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 938316092634..4ca508bd4c9e 100644
---
Hi Dave, Daniel,
Fixes for 5.7.
The following changes since commit e3dcd86b3b4c045a4db17c02340138a4c514fe20:
Merge tag 'amd-drm-fixes-5.7-2020-04-29' of
git://people.freedesktop.org/~agd5f/linux into drm-fixes (2020-05-01 11:19:55
+1000)
are available in the Git repository at:
git://peop
On Wed, May 6, 2020 at 3:03 AM ChenTao wrote:
>
> Fixes warning because size is uint32_t and can never be negtative
>
> drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1296:12: warning:
> comparison of unsigned expression < 0 is always false [-Wtype-limits]
>if (size < 0)
>
> Reported-by:
[Why]
We're the drm vblank event a frame too early in the case where the
pageflip happens close to VUPDATE and ends up blocking the signal.
The implementation in DM was previously correct *before* we started
sending vblank events from VSTARTUP unconditionally to handle cases
where HUBP was off, OT
On Fri, May 01, 2020 at 03:20:43PM -0300, Jason Gunthorpe wrote:
> From: Jason Gunthorpe
>
> The API is a bit complicated for the uses we actually have, and
> disucssions for simplifying have come up a number of times.
>
> This small series removes the customizable pfn format and simplifies the
On Tue, 2020-05-05 at 16:01 +0200, Arnd Bergmann wrote:
> After the structure was padded to 1024 bytes, it is no longer
> suitable for being a local variable, as the function surpasses
> the warning limit for 32-bit architectures:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:587:5: error: stack fra
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Alex Sierra
-Original Message-
From: amd-gfx On Behalf Of Christian
König
Sent: Wednesday, May 6, 2020 3:12 AM
To: Kuehling, Felix ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/1] drm/amdgpu: Use GEM obj referenc
Am 06.05.2020 18:00 schrieb Alex Deucher :
On Wed, May 6, 2020 at 10:27 AM Zheng Bin wrote:
>
> Zheng Bin (14):
> drm/radeon: remove comparison to bool in btc_dpm.c
> drm/radeon: remove comparison to bool in ci_dpm.c
> drm/radeon: remove comparison to bool in ni_dpm.c
> drm/radeon: remov
On Sat, May 02, 2020 at 12:09:13PM +0200, Takashi Iwai wrote:
> On Sat, 02 May 2020 09:27:31 +0200,
> Takashi Iwai wrote:
> >
> > On Sat, 02 May 2020 09:17:28 +0200,
> > Lukas Wunner wrote:
> > >
> > > On Sat, May 02, 2020 at 09:11:58AM +0200, Takashi Iwai wrote:
> > > > --- a/drivers/gpu/drm/amd
On Mon, May 04, 2020 at 06:30:00PM -0700, John Hubbard wrote:
> On 2020-05-01 11:20, Jason Gunthorpe wrote:
> > From: Jason Gunthorpe
> >
> > Presumably the intent here was that hmm_range_fault() could put the data
> > into some HW specific format and thus avoid some work. However, nothing
> > ac
On Fri, May 01, 2020 at 05:53:26PM -0700, Ralph Campbell wrote:
> > Acked-by: Felix Kuehling
> > Tested-by: Ralph Campbell
> > Signed-off-by: Jason Gunthorpe
> > Signed-off-by: Christoph Hellwig
> > Documentation/vm/hmm.rst| 26 ++--
> > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm
On Wed, May 6, 2020 at 10:27 AM Zheng Bin wrote:
>
> Zheng Bin (14):
> drm/radeon: remove comparison to bool in btc_dpm.c
> drm/radeon: remove comparison to bool in ci_dpm.c
> drm/radeon: remove comparison to bool in ni_dpm.c
> drm/radeon: remove comparison to bool in radeon_atpx_handler.c
[AMD Official Use Only - Internal Distribution Only]
Perhaps it's too much churn for this patch set, but I'd like to unify the pp
func callbacks between powerplay and swsmu so we can drop all of the
is_swsmu_supported() and function pointer checks sprinkled all through the code.
Alex
__
Am 06.05.20 um 16:14 schrieb Alex Deucher:
We set the fb smem pointer to the offset into the BAR, so keep
the fbdev bo in vram.
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=207581
Fixes: 6c8d74caa2fa33 ("drm/amdgpu: Enable scatter gather display support")
Signed-off-by: Alex Deucher
Revie
Fixes coccicheck warning:
drivers/gpu/drm/radeon/ni_dpm.c:807:5-26: WARNING: Comparison to bool
drivers/gpu/drm/radeon/ni_dpm.c:2466:5-36: WARNING: Comparison to boo
drivers/gpu/drm/radeon/ni_dpm.c:3146:5-22: WARNING: Comparison to bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
driv
Fixes coccicheck warning:
drivers/gpu/drm/radeon/rs600.c:1132:5-37: WARNING: Comparison to bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
drivers/gpu/drm/radeon/rs600.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/rs600.c b/drivers/gpu/d
Fixes coccicheck warning:
drivers/gpu/drm/radeon/ci_dpm.c:814:5-26: WARNING: Comparison to bool
drivers/gpu/drm/radeon/ci_dpm.c:2916:6-21: WARNING: Comparison to bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
drivers/gpu/drm/radeon/ci_dpm.c | 4 ++--
1 file changed, 2 insertions(+),
Fixes coccicheck warning:
drivers/gpu/drm/radeon/btc_dpm.c:2115:5-26: WARNING: Comparison to bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
drivers/gpu/drm/radeon/btc_dpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/btc_dpm.c b/drivers
Fixes coccicheck warning:
drivers/gpu/drm/radeon/rs690.c:190:6-35: WARNING: Comparison to bool
drivers/gpu/drm/radeon/rs690.c:844:5-37: WARNING: Comparison to bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
drivers/gpu/drm/radeon/rs690.c | 3 ++-
1 file changed, 2 insertions(+), 1 de
Fixes coccicheck warning:
drivers/gpu/drm/radeon/radeon_ttm.c:141:6-62: WARNING: Comparison to bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c
Fixes coccicheck warning:
drivers/gpu/drm/radeon/rv515.c:666:5-37: WARNING: Comparison to bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
drivers/gpu/drm/radeon/rv515.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/rv515.c b/drivers/gpu/dr
Fixes coccicheck warning:
drivers/gpu/drm/radeon/radeon_atpx_handler.c:561:15-49: WARNING: Comparison to
bool
drivers/gpu/drm/radeon/radeon_atpx_handler.c:571:15-49: WARNING: Comparison to
bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
drivers/gpu/drm/radeon/radeon_atpx_handler.c
Fixes coccicheck warning:
drivers/gpu/drm/radeon/radeon_object.c:427:6-35: WARNING: Comparison to bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
drivers/gpu/drm/radeon/radeon_object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_o
Fixes coccicheck warning:
drivers/gpu/drm/radeon/si_dpm.c:1885:7-44: WARNING: Comparison to bool
drivers/gpu/drm/radeon/si_dpm.c:2463:5-22: WARNING: Comparison to bool
drivers/gpu/drm/radeon/si_dpm.c:3015:5-26: WARNING: Comparison to bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
dr
Zheng Bin (14):
drm/radeon: remove comparison to bool in btc_dpm.c
drm/radeon: remove comparison to bool in ci_dpm.c
drm/radeon: remove comparison to bool in ni_dpm.c
drm/radeon: remove comparison to bool in radeon_atpx_handler.c
drm/radeon: remove comparison to bool in radeon_object.c
Fixes coccicheck warning:
drivers/gpu/drm/radeon/r100.c:4065:5-37: WARNING: Comparison to bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
drivers/gpu/drm/radeon/r100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/
Fixes coccicheck warning:
drivers/gpu/drm/radeon/rv6xx_dpm.c:1571:5-20: WARNING: Comparison to bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
drivers/gpu/drm/radeon/rv6xx_dpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/rv6xx_dpm.c
b/
Fixes coccicheck warning:
drivers/gpu/drm/radeon/r300.c:1544:5-37: WARNING: Comparison to bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
drivers/gpu/drm/radeon/r300.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/r300.c b/drivers/gpu/drm/
Fixes coccicheck warning:
drivers/gpu/drm/radeon/r600.c:1494:8-37: WARNING: Comparison to bool
Reported-by: Hulk Robot
Signed-off-by: Zheng Bin
---
drivers/gpu/drm/radeon/r600.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/dr
We set the fb smem pointer to the offset into the BAR, so keep
the fbdev bo in vram.
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=207581
Fixes: 6c8d74caa2fa33 ("drm/amdgpu: Enable scatter gather display support")
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 3 +--
On Wed, May 06, 2020 at 10:10:56AM +, Pan, Xinhui wrote:
> [AMD Official Use Only - Internal Distribution Only]
>
> no. below function checks if block is valid or not.
> I think you need check your code_checker. or you were checking on a very old
> codebase?
>
> /* check if ras is supported
[AMD Official Use Only - Internal Distribution Only]
From: Zhang, Hawking
Sent: Wednesday, May 6, 2020 5:26 PM
To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Liu, Monk
; Feng, Kenneth
Subject: RE: [PATCH 2/3] drm/amdgpu: optimi
Yes, exactly that one.
Regards,
Christian.
Am 06.05.20 um 12:35 schrieb Zhou, Tiecheng:
[AMD Official Use Only - Internal Distribution Only]
Thanks, Christian,
Is this the fix that you are mentioning:
commit 1675c3a24d075d484377003789245f48c2114a0b
Author: Christian König
Date: Fri Feb 21
[AMD Official Use Only - Internal Distribution Only]
Thanks, Christian,
Is this the fix that you are mentioning:
commit 1675c3a24d075d484377003789245f48c2114a0b
Author: Christian König
Date: Fri Feb 21 15:10:31 2020 +0100
drm/amdgpu: stop disable the scheduler during HW fini
When we
[AMD Official Use Only - Internal Distribution Only]
no. below function checks if block is valid or not.
I think you need check your code_checker. or you were checking on a very old
codebase?
/* check if ras is supported on block, say, sdma, gfx */
static inline int amdgpu_ras_is_supported(stru
NAK, the fundamental problem was that we disabled the SDMA paging queue
during reset:
[ 885.694682] [drm] schedpage0 is not ready, skipping
[ 885.694682] [drm] schedpage1 is not ready, skipping
This is fixed by now, so the problem should not happen any more.
Regards,
Christian.
Am 06.05.20
WHY:
For V320 passthrough and "modprobe amdgpu lockup_timeout=500", there will be
kernel NULL pointer when using quark ~ BACO reset, for instance:
hang_vm_compute0_bad_cs_dispatch.lua
hang_vm_dma0_corrupted_header.lua
etc.
-
[ 884.792885] [drm:amdgpu_job_timedout
[AMD Official Use Only - Internal Distribution Only]
Hi Kelvin,
Thanks for the series that remove the duplicated one_vf mode check in all the
amdgpu_dpm functions.
Can we split the patch into two? One for amdgpu device sysfs attr code refine,
with the new dev_attr structures, the other for ret
On Wed, May 06, 2020 at 07:26:16AM +, Zhou1, Tao wrote:
> [AMD Public Use]
>
> Hi Dan:
>
> Please check the following piece of code in
> amdgpu_ras_debugfs_ctrl_parse_data:
>
> if (op != -1) {
> if (amdgpu_ras_find_block_id_by_name(block_name, &block_id))
>
[AMD Public Use]
Reviewed-by: John Clements
-Original Message-
From: Zhou1, Tao
Sent: Wednesday, May 6, 2020 4:39 PM
To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org;
Deucher, Alexander ; Clements, John
; Gao, Likun ; Chen, Guchun
; Li, Dennis
Cc: Zhang, Hawking
Subject: RE: [PA
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: John Clements
-Original Message-
From: Hawking Zhang
Sent: Wednesday, May 6, 2020 2:42 PM
To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
; Clements, John
Cc: Zhang, Hawking
Subject: [PATCH] drm/amdgpu: use node
[AMD Public Use]
The series is:
Reviewed-by: Tao Zhou
> -Original Message-
> From: Hawking Zhang
> Sent: 2020年5月6日 14:39
> To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
> ; Clements, John
> ; Gao, Likun ; Chen,
> Guchun ; Li, Dennis ;
> Zhou1, Tao
> Cc: Zhang, Hawking
> Subje
Am 06.05.20 um 02:59 schrieb Felix Kuehling:
Releasing the AMDGPU BO ref directly leads to problems when BOs were
exported as DMA bufs. Releasing the GEM reference makes sure that the
AMDGPU/TTM BO is not freed too early.
Also take a GEM reference when importing BOs from DMABufs to keep
referenc
Am 06.05.20 um 05:45 schrieb Zhao, Jiange:
[AMD Official Use Only - Internal Distribution Only]
Hi Christian,
Hi Jiange, well that looks correct to me, but seems to be a bit to complicated.
What exactly was wrong with version 3?
(1) If you open amdgpu_autodump, use it and close it, then you
[AMD Public Use]
Hi Dan:
Please check the following piece of code in amdgpu_ras_debugfs_ctrl_parse_data:
if (op != -1) {
if (amdgpu_ras_find_block_id_by_name(block_name, &block_id))
return -EINVAL;
data->head.block = block_id;
amd
Am 05.05.20 um 19:29 schrieb Felix Kuehling:
What we could probably do to detect this is adding a BUG_ON() in TTMs
release function and checking if the GEM reference count is really dead.
The problem is, that we have to guess whether there are still any
dmabuf references to the GEM BO. There
Fixes warning because size is uint32_t and can never be negtative
drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1296:12: warning:
comparison of unsigned expression < 0 is always false [-Wtype-limits]
if (size < 0)
Reported-by: Hulk Robot
Signed-off-by: ChenTao
---
drivers/gpu/drm/amd
[AMD Public Use]
One spelling typo in the commit message, 'functon' should be 'function'. Apart
from this, series is: Reviewed-by: Guchun Chen
' drop IP specific psp functon for rlc autoload since the autoload_supported '
Regards,
Guchun
-Original Message-
From: Hawking Zhang
Sent:
50 matches
Mail list logo