Re: [PATCH 1/3] gpu/drm: Fix spelling of *sequence* and *frequency*

2020-05-11 Thread Alex Deucher
On Mon, May 11, 2020 at 5:42 PM Alex Deucher wrote: > > On Mon, May 11, 2020 at 3:18 AM Paul Menzel wrote: > > > > Fix all occurrences with the commands below. > > > > $ git grep -l equnce drivers/gpu/ | xargs sed -i 's/equnce/equence/g' > > > > Cc: Alex Deucher > > Cc: Christian König > >

Re: [PATCH] drm/amd/amdgpu: remove defined but not used 'crtc_offsets'

2020-05-11 Thread Alex Deucher
Applied. thanks! Alex On Sat, May 9, 2020 at 5:05 AM Jason Yan wrote: > > Fix the following gcc warning: > > drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:65:18: warning: ‘crtc_offsets’ > defined but not used [-Wunused-const-variable=] > static const u32 crtc_offsets[6] = >

Re: [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-11 Thread Emil Velikov
On Mon, 11 May 2020 at 21:43, Dave Airlie wrote: > > On Tue, 12 May 2020 at 06:28, Alex Deucher wrote: > > > > On Mon, May 11, 2020 at 4:22 PM Al Dunsmuir > > wrote: > > > > > > On Monday, May 11, 2020, 1:17:19 PM, "Christian König" wrote: > > > > Hi guys, > > > > > > > Well let's face it AGP

Re: [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-11 Thread Al Dunsmuir
Hello Dave, On Monday, May 11, 2020, 4:43:01 PM, Dave Airlie wrote: > On Tue, 12 May 2020 at 06:28, Alex Deucher wrote: >> >> On Mon, May 11, 2020 at 4:22 PM Al Dunsmuir wrote: >> Note there is no loss of functionality here, at least on radeon >> hardware. It just comes down to which MMU gets

Re: [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-11 Thread Al Dunsmuir
On Monday, May 11, 2020, 4:27:55 PM, Alex Deucher wrote: > On Mon, May 11, 2020 at 4:22 PM Al Dunsmuir wrote: >> >> On Monday, May 11, 2020, 1:17:19 PM, "Christian König" wrote: >> > Hi guys, >> >> > Well let's face it AGP is a total headache to maintain and dead for at >> > least 10+ years. >>

Re: [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-11 Thread Dave Airlie
On Tue, 12 May 2020 at 06:28, Alex Deucher wrote: > > On Mon, May 11, 2020 at 4:22 PM Al Dunsmuir wrote: > > > > On Monday, May 11, 2020, 1:17:19 PM, "Christian König" wrote: > > > Hi guys, > > > > > Well let's face it AGP is a total headache to maintain and dead for at > > > least 10+ years. >

Re: [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-11 Thread Alex Deucher
On Mon, May 11, 2020 at 4:22 PM Al Dunsmuir wrote: > > On Monday, May 11, 2020, 1:17:19 PM, "Christian König" wrote: > > Hi guys, > > > Well let's face it AGP is a total headache to maintain and dead for at > > least 10+ years. > > > We have a lot of x86 specific stuff in the architecture

Re: [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-11 Thread Al Dunsmuir
On Monday, May 11, 2020, 1:17:19 PM, "Christian König" wrote: > Hi guys, > Well let's face it AGP is a total headache to maintain and dead for at least > 10+ years. > We have a lot of x86 specific stuff in the architecture independent > graphics memory management to get the caching right,

RE: [PATCH] drm/amd/amdgpu: Update update_config() logic

2020-05-11 Thread Ma, Hanghong
[AMD Official Use Only - Internal Distribution Only] [AMD Official Use Only - Internal Distribution Only] Merged. Thanks for review. -Leo From: Lakha, Bhawanpreet Sent: Monday, May 11, 2020 3:51 PM To: Ma, Hanghong ; Wentland, Harry Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH]

Re: [PATCH 1/3] drm/radeon: remove AGP support

2020-05-11 Thread Alex Deucher
On Mon, May 11, 2020 at 1:17 PM Christian König wrote: > > AGP is deprecated for 10+ years now and not used any more on modern hardware. > > Old hardware should continue to work in PCI mode. Might want to clarify that there is no loss of functionality here. Something like: "There is no loss of

Re: [PATCH] drm/amd/amdgpu: Update update_config() logic

2020-05-11 Thread Lakha, Bhawanpreet
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Bhawanpreet Lakha From: Ma, Hanghong Sent: May 11, 2020 3:48 PM To: Wentland, Harry Cc: Lakha, Bhawanpreet ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/amdgpu: Update

RE: [PATCH] drm/amd/amdgpu: Update update_config() logic

2020-05-11 Thread Ma, Hanghong
[AMD Official Use Only - Internal Distribution Only] Thanks Harry. I will drop the Change-Id before merging. -Leo -Original Message- From: Wentland, Harry Sent: Monday, May 11, 2020 3:46 PM To: Ma, Hanghong ; Lakha, Bhawanpreet ; amd-gfx@lists.freedesktop.org Cc: Wentland, Harry

Re: [PATCH] drm/amd/amdgpu: Update update_config() logic

2020-05-11 Thread Harry Wentland
On 2020-05-11 3:28 p.m., Leo (Hanghong) Ma wrote: > [Why] > For MST case: when update_config is called to disable a stream, > this clears the settings for all the streams on that link. > We should only clear the settings for the stream that was disabled. > > [How] > Clear the settings after the

[PATCH] drm/amd/amdgpu: Update update_config() logic

2020-05-11 Thread Leo (Hanghong) Ma
[Why] For MST case: when update_config is called to disable a stream, this clears the settings for all the streams on that link. We should only clear the settings for the stream that was disabled. [How] Clear the settings after the call to remove display is called. Change-Id:

Re: [PATCH 2/2] drm/amd/powerplay: shutdown on HW CTF

2020-05-11 Thread Alex Deucher
On Sat, May 9, 2020 at 3:47 AM Evan Quan wrote: > > To prevent further damage. > > Change-Id: Iae0399001694bb7446bcc6071cd03d8fa47c9d02 > Signed-off-by: Evan Quan Series is: Reviewed-by: Alex Deucher > --- > .../gpu/drm/amd/powerplay/hwmgr/smu_helper.c | 16 +-- >

[PATCH 3/3] drm/ttm: remove AGP support

2020-05-11 Thread Christian König
Not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/Makefile | 1 - drivers/gpu/drm/ttm/ttm_agp_backend.c | 150 -- include/drm/ttm/ttm_set_memory.h | 44 include/drm/ttm/ttm_tt.h | 22 4 files changed,

[PATCH 2/3] drm/nouveau: remove AGP support

2020-05-11 Thread Christian König
AGP is deprecated for 10+ years now and not used any more on modern hardware. Old hardware should continue to work in PCI mode. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 16 +- drivers/gpu/drm/nouveau/nouveau_bo.c | 46 +

[RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-11 Thread Christian König
Hi guys, Well let's face it AGP is a total headache to maintain and dead for at least 10+ years. We have a lot of x86 specific stuff in the architecture independent graphics memory management to get the caching right, abusing the DMA API on multiple occasions, need to distinct between AGP and

[PATCH 1/3] drm/radeon: remove AGP support

2020-05-11 Thread Christian König
AGP is deprecated for 10+ years now and not used any more on modern hardware. Old hardware should continue to work in PCI mode. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/Makefile| 4 +- drivers/gpu/drm/radeon/evergreen.c | 7 - drivers/gpu/drm/radeon/r100.c

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Andrey Grodzovsky
On 5/11/20 5:26 AM, Pekka Paalanen wrote: On Sat, 9 May 2020 14:51:44 -0400 Andrey Grodzovsky wrote: This RFC is a more of a proof of concept then a fully working solution as there are a few unresolved issues we are hopping to get advise on from people on the mailing list. Until now

Re: [PATCH] drm/amd/amdgpu: Add missing GRBM bits for GFX 10.1

2020-05-11 Thread Alex Deucher
On Mon, May 11, 2020 at 6:29 AM Tom St Denis wrote: > > Requested bits for UMR support > > Signed-off-by: Tom St Denis Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/include/asic_reg/gc/gc_10_1_0_sh_mask.h | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Daniel Vetter
On Mon, May 11, 2020 at 4:08 PM Lukas Wunner wrote: > > On Mon, May 11, 2020 at 02:21:57PM +0200, Daniel Vetter wrote: > > On Mon, May 11, 2020 at 1:43 PM Lukas Wunner wrote: > > > On Mon, May 11, 2020 at 11:54:33AM +0200, Daniel Vetter wrote: > > > > - One unfortunate thing with drm_dev_unplug

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Lukas Wunner
On Mon, May 11, 2020 at 02:21:57PM +0200, Daniel Vetter wrote: > On Mon, May 11, 2020 at 1:43 PM Lukas Wunner wrote: > > On Mon, May 11, 2020 at 11:54:33AM +0200, Daniel Vetter wrote: > > > - One unfortunate thing with drm_dev_unplug is that the driver core is > > > very opinionated and doesn't

Re: [PATCH hmm v2 1/5] mm/hmm: make CONFIG_DEVICE_PRIVATE into a select

2020-05-11 Thread Jason Gunthorpe
On Sat, May 09, 2020 at 05:16:12PM -0700, Andrew Morton wrote: > On Fri, 1 May 2020 15:20:44 -0300 Jason Gunthorpe wrote: > > > From: Jason Gunthorpe > > > > There is no reason for a user to select this or not directly - it should > > be selected by drivers that are going to use the feature,

Re:RE: [PATCH v2] drm/amd/amdgpu: cleanup coding style a bit

2020-05-11 Thread Bernard
发件人:"Ruhl, Michael J" 发送日期:2020-05-08 23:45:07 收件人:Bernard Zhao ,Alex Deucher ,"Christian König" ,"David (ChunMing) Zhou" ,David Airlie ,Daniel Vetter ,Tom St Denis ,Sam Ravnborg ,Ori Messinger ,"amd-gfx@lists.freedesktop.org" ,"dri-de...@lists.freedesktop.org"

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Daniel Vetter
On Mon, May 11, 2020 at 2:34 PM Christian König wrote: > > Am 11.05.20 um 13:19 schrieb Daniel Vetter: > > On Mon, May 11, 2020 at 11:54:33AM +0200, Daniel Vetter wrote: > >> On Sat, May 09, 2020 at 02:51:44PM -0400, Andrey Grodzovsky wrote: > >>> This RFC is a more of a proof of concept then a

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Christian König
Am 11.05.20 um 13:19 schrieb Daniel Vetter: On Mon, May 11, 2020 at 11:54:33AM +0200, Daniel Vetter wrote: On Sat, May 09, 2020 at 02:51:44PM -0400, Andrey Grodzovsky wrote: This RFC is a more of a proof of concept then a fully working solution as there are a few unresolved issues we are

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Christian König
Am 11.05.20 um 11:26 schrieb Pekka Paalanen: On Sat, 9 May 2020 14:51:44 -0400 Andrey Grodzovsky wrote: This RFC is a more of a proof of concept then a fully working solution as there are a few unresolved issues we are hopping to get advise on from people on the mailing list. Until now

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Daniel Vetter
On Mon, May 11, 2020 at 1:43 PM Lukas Wunner wrote: > > On Mon, May 11, 2020 at 11:54:33AM +0200, Daniel Vetter wrote: > > - One unfortunate thing with drm_dev_unplug is that the driver core is > > very opinionated and doesn't tell you whether it's a hotunplug or a > > driver unload. In the

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Lukas Wunner
On Mon, May 11, 2020 at 11:54:33AM +0200, Daniel Vetter wrote: > - One unfortunate thing with drm_dev_unplug is that the driver core is > very opinionated and doesn't tell you whether it's a hotunplug or a > driver unload. In the former case trying to shut down hw just wastes > time (and

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Daniel Vetter
On Mon, May 11, 2020 at 11:54:33AM +0200, Daniel Vetter wrote: > On Sat, May 09, 2020 at 02:51:44PM -0400, Andrey Grodzovsky wrote: > > This RFC is a more of a proof of concept then a fully working solution as > > there are a few unresolved issues we are hopping to get advise on from > > people

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Daniel Vetter
On Mon, May 11, 2020 at 11:19:30AM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2020-05-11 10:54:33) > > - worse, neither vk nor gl (to my knowledge) have a concept of events > > for when the gpu died. The only stuff you have is things like > > arb_robustness which says a)

[PATCH] drm/amd/amdgpu: Add missing GRBM bits for GFX 10.1

2020-05-11 Thread Tom St Denis
Requested bits for UMR support Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/include/asic_reg/gc/gc_10_1_0_sh_mask.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/include/asic_reg/gc/gc_10_1_0_sh_mask.h

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Chris Wilson
Quoting Daniel Vetter (2020-05-11 10:54:33) > - worse, neither vk nor gl (to my knowledge) have a concept of events > for when the gpu died. The only stuff you have is things like > arb_robustness which says a) everything continues as if nothing > happened b) there's a function where

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Daniel Vetter
On Sat, May 09, 2020 at 02:51:44PM -0400, Andrey Grodzovsky wrote: > This RFC is a more of a proof of concept then a fully working solution as > there are a few unresolved issues we are hopping to get advise on from people > on the mailing list. > Until now extracting a card either by physical

Re: [PATCH 0/6] RFC Support hot device unplug in amdgpu

2020-05-11 Thread Pekka Paalanen
On Sat, 9 May 2020 14:51:44 -0400 Andrey Grodzovsky wrote: > This RFC is a more of a proof of concept then a fully working > solution as there are a few unresolved issues we are hopping to get > advise on from people on the mailing list. Until now extracting a > card either by physical

[BUG] general protection fault, probably for non-canonical address 0xfe5d6f0af7831e5e: 0000 [#1] SMP NOPTI (5.7RC4 GIT 79dede78c057)

2020-05-11 Thread Mikhail Gavrilov
Hi folks. I didn’t do anything unusual, I just restarted the computer after the update, launched all the applications that I usually launch and went to drink tea. When I returned, I found that the monitor was on (it should have turned off since I had set the energy-saving mode for 5 minutes in DE)

Re: [PATCH hmm v2 1/5] mm/hmm: make CONFIG_DEVICE_PRIVATE into a select

2020-05-11 Thread Andrew Morton
On Fri, 1 May 2020 15:20:44 -0300 Jason Gunthorpe wrote: > From: Jason Gunthorpe > > There is no reason for a user to select this or not directly - it should > be selected by drivers that are going to use the feature, similar to how > CONFIG_HMM_MIRROR works. > > Currently all drivers

[PATCH 1/3] gpu/drm: Fix spelling of *sequence* and *frequency*

2020-05-11 Thread Paul Menzel
Fix all occurrences with the commands below. $ git grep -l equnce drivers/gpu/ | xargs sed -i 's/equnce/equence/g' Cc: Alex Deucher Cc: Christian König Cc: David (ChunMing) Zhou Cc: amd-gfx@lists.freedesktop.org Signed-off-by: Paul Menzel --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 4

[PATCH 2/3] gpu/drm: Fix spelling of *frequency*

2020-05-11 Thread Paul Menzel
Fix all occurrences with the command below. git grep -l frequencey | xargs sed -i 's/frequencey/frequency/g' Cc: Rob Clark Cc: Sean Paul Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Cc: Alex Deucher Cc: Christian König Cc: David (ChunMing) Zhou Cc:

Re: [PATCH 5/6] drm/ttm: Add destroy flag in TTM BO eviction interface

2020-05-11 Thread Christian König
While this looks rather nice it is most likely the wrong approach since it doesn't handles other concurrent evictions. It would most likely be better to add a check calling drm_dev_is_unplugged() into amdgpu_bo_move(). Regards, Christian. Am 09.05.20 um 20:51 schrieb Andrey Grodzovsky:

Re: [PATCH 3/6] drm/amdgpu: Wait for all user clients

2020-05-11 Thread Christian König
A commit message would be nice, apart from that the patch looks clean to me. But question for Daniel and others: Is that in general the right approach? It can happen that device removal is delayed indefinitely if userspace doesn't close the file descriptors. Regards, Christian. Am 09.05.20

Re: [PATCH 2/6] drm/amdgpu: Force unmap all user VMAs on device removal.

2020-05-11 Thread Christian König
Am 09.05.20 um 20:51 schrieb Andrey Grodzovsky: Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 14 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 3 files changed, 17

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-05-11 Thread Christian König
Am 09.05.20 um 20:51 schrieb Andrey Grodzovsky: Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/ttm/ttm_bo.c| 22 +- include/drm/ttm/ttm_bo_driver.h | 2 ++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c

RE: [PATCH] drm/amd/powerplay: skip judging if baco support for Arcturus sriov

2020-05-11 Thread Quan, Evan
Acked-by: Evan Quan -Original Message- From: Jian, Jane Sent: Monday, May 11, 2020 2:26 PM To: Jian, Jane ; amd-gfx@lists.freedesktop.org; Quan, Evan Cc: Min, Frank Subject: RE: [PATCH] drm/amd/powerplay: skip judging if baco support for Arcturus sriov [AMD Official Use Only -

RE: [PATCH] drm/amd/powerplay: skip judging if baco support for Arcturus sriov

2020-05-11 Thread Jian, Jane
[AMD Official Use Only - Internal Distribution Only] Hi @Quan, Evan, Could you please help to review this patch? Since this is previously your patch here. Thanks, Jane -Original Message- From: Jane Jian Sent: Saturday, May 9, 2020 4:07 PM To: amd-gfx@lists.freedesktop.org; Quan, Evan