Re: [PATCH v3 07/15] drm/amdgpu: Use PCI_IRQ_MSI_TYPES where appropriate

2020-06-09 Thread Alex Deucher
On Tue, Jun 9, 2020 at 5:18 AM Piotr Stankiewicz wrote: > > Seeing as there is shorthand available to use when asking for any type > of interrupt, or any type of message signalled interrupt, leverage it. > > Signed-off-by: Piotr Stankiewicz > Reviewed-by: Andy Shevchenko Acked-by: Alex Deucher

Re: [PATCH 2/3] drm/amd/powerplay: revise the calling chain on sensor reading

2020-06-09 Thread Alex Deucher
On Tue, Jun 9, 2020 at 6:21 AM Evan Quan wrote: > > Update the calling chain from "amdgpu_smu.c -> ${asic}_ppt.c -> > smu_v11/12_0.c -> amdgpu_smu.c (smu_common_read_sensor())" to " > "amdgpu_smu.c -> ${asic}_ppt.c -> smu_v11/12_0.c". This can help > to maintain clear code layers. More similar

Re: [PATCH 3/3] drm/amd/powerplay: maximum code sharing on sensor reading

2020-06-09 Thread Alex Deucher
On Tue, Jun 9, 2020 at 6:21 AM Evan Quan wrote: > > Move the common code to amdgpu_smu.c instead of having one > copy in both smu_v11_0.c and smu_v12_0.c. > > Change-Id: Idc59c6f686139d034348a613f1a7b9213198312d > Signed-off-by: Evan Quan Reviewed-by: Alex Deucher > --- >

Re: [PATCH 1/3] drm/amd/powerplay: drop unnecessary SMU_MSG_GetDpmClockFreq check

2020-06-09 Thread Alex Deucher
On Tue, Jun 9, 2020 at 6:20 AM Evan Quan wrote: > > Since SMU_MSG_GetDpmClockFreq is known to be supported for Vega20 > and before ASICs only. For those ASICs supporting swSMU, it is not > supported. > > Change-Id: I8ee71664baa32e40df5bb793550785120f3770c6 > Signed-off-by: Evan Quan

Re: [PATCH 2/2] drm/amd/powerplay: drop unnecessary wrapper .populate_smc_tables

2020-06-09 Thread Alex Deucher
On Tue, Jun 9, 2020 at 6:10 AM Evan Quan wrote: > > Since .populate_smc_tables is just a wrapper of .set_default_dpm_table. > > Change-Id: I80e89146359d6cf5d80f1887878d371b41b41cb0 > Signed-off-by: Evan Quan Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c

Re: [PATCH 1/2] drm/amd/powerplay: drop redundant .set_min_dcefclk_deep_sleep API

2020-06-09 Thread Alex Deucher
On Tue, Jun 9, 2020 at 6:10 AM Evan Quan wrote: > > It has exactly the same functionality as .set_deep_sleep_dcefclk. > > Change-Id: Ib4d2d604ca014e194cb2b61ac770e4370ecad74d > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 11 +-- >

Re: [PATCH] drm/amd/amdgpu: Add SQ debug registers to GFX10 headers

2020-06-09 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Might as well add it for gfx9 as well. With that fixed: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Tom St Denis Sent: Tuesday, June 9, 2020 1:59 PM To: amd-gfx@lists.freedesktop.org Cc: StDenis,

[PATCH] drm/amd/amdgpu: Add SQ debug registers to GFX10 headers

2020-06-09 Thread Tom St Denis
Requested for UMR support. Signed-off-by: Tom St Denis --- .../include/asic_reg/gc/gc_10_1_0_offset.h| 1 + .../include/asic_reg/gc/gc_10_1_0_sh_mask.h | 20 +++ .../include/asic_reg/gc/gc_10_3_0_offset.h| 1 + .../include/asic_reg/gc/gc_10_3_0_sh_mask.h | 19

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-09 Thread Koenig, Christian
Am 09.06.2020 18:37 schrieb "Grodzovsky, Andrey" : On 6/5/20 2:40 PM, Christian König wrote: > Am 05.06.20 um 16:29 schrieb Andrey Grodzovsky: >> >> On 5/11/20 2:45 AM, Christian König wrote: >>> Am 09.05.20 um 20:51 schrieb Andrey Grodzovsky: Signed-off-by: Andrey Grodzovsky ---

Re: close() on some Intel CNP-LP PCI devices takes up to 2.7 s

2020-06-09 Thread Mika Westerberg
On Tue, Jun 09, 2020 at 05:39:21PM +0200, Paul Menzel wrote: > Dear Linux folks, > > > On the Intel Cannon Point-LP laptop Dell Precision 3540 with a dedicated AMD > graphics card (both graphics devices can be used) with Debian Sid/unstable > with Linux 5.6.14, running lspci takes quite some

Re: [PATCH 1/6] drm/ttm: Add unampping of the entire device address space

2020-06-09 Thread Andrey Grodzovsky
On 6/5/20 2:40 PM, Christian König wrote: Am 05.06.20 um 16:29 schrieb Andrey Grodzovsky: On 5/11/20 2:45 AM, Christian König wrote: Am 09.05.20 um 20:51 schrieb Andrey Grodzovsky: Signed-off-by: Andrey Grodzovsky ---   drivers/gpu/drm/ttm/ttm_bo.c    | 22 +-  

[PATCH v3 07/15] drm/amdgpu: Use PCI_IRQ_MSI_TYPES where appropriate

2020-06-09 Thread Piotr Stankiewicz
Seeing as there is shorthand available to use when asking for any type of interrupt, or any type of message signalled interrupt, leverage it. Signed-off-by: Piotr Stankiewicz Reviewed-by: Andy Shevchenko --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 11 +-- 1 file changed, 1

[PATCH v3 00/15] Forward MSI-X vector enable error code in pci_alloc_irq_vectors_affinity()

2020-06-09 Thread Piotr Stankiewicz
The primary objective of this patch series is to change the behaviour of pci_alloc_irq_vectors_affinity() such that it forwards the MSI-X enable error code when appropriate. In the process, though, it was pointed out that there are multiple places in the kernel which check/ask for message

[PATCH v3 02/15] PCI: Add macro for message signalled interrupt types

2020-06-09 Thread Piotr Stankiewicz
There are several places in the kernel which check/ask for MSI or MSI-X interrupts. It would make sense to have a macro which defines all types of message signalled interrupts, to use in such situations. Add PCI_IRQ_MSI_TYPES, for this purpose. Signed-off-by: Piotr Stankiewicz Suggested-by: Andy

RE: [PATCH] drm/amd/amdgpu: handle return value of amdgpu_driver_load_kms

2020-06-09 Thread Chauhan, Madhav
-Original Message- From: amd-gfx On Behalf Of Liu ChengZhe Sent: Tuesday, June 9, 2020 2:50 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Cheng Zhe Subject: [PATCH] drm/amd/amdgpu: handle return value of amdgpu_driver_load_kms [CAUTION: External Email] if guest driver failed to enter

[PATCH] drm/amdgpu: remove distinction between explicit and implicit sync (v2)

2020-06-09 Thread Marek Olšák
Hi, This enables a full pipeline sync for implicit sync. It's Christian's patch with the driver version bumped. With this, user mode drivers don't have to wait for idle at the end of gfx IBs. Any concerns? Thanks, Marek From 2216e2db0994f1fdeb74353bd669f8981280188e Mon Sep 17 00:00:00 2001

[PATCH 2/3] drm/amd/powerplay: revise the calling chain on sensor reading

2020-06-09 Thread Evan Quan
Update the calling chain from "amdgpu_smu.c -> ${asic}_ppt.c -> smu_v11/12_0.c -> amdgpu_smu.c (smu_common_read_sensor())" to " "amdgpu_smu.c -> ${asic}_ppt.c -> smu_v11/12_0.c". This can help to maintain clear code layers. More similar changes will be coming. Change-Id:

[PATCH 3/3] drm/amd/powerplay: maximum code sharing on sensor reading

2020-06-09 Thread Evan Quan
Move the common code to amdgpu_smu.c instead of having one copy in both smu_v11_0.c and smu_v12_0.c. Change-Id: Idc59c6f686139d034348a613f1a7b9213198312d Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 4 drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 4

[PATCH 1/3] drm/amd/powerplay: drop unnecessary SMU_MSG_GetDpmClockFreq check

2020-06-09 Thread Evan Quan
Since SMU_MSG_GetDpmClockFreq is known to be supported for Vega20 and before ASICs only. For those ASICs supporting swSMU, it is not supported. Change-Id: I8ee71664baa32e40df5bb793550785120f3770c6 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 17 +++-- 1

[PATCH 2/2] drm/amd/powerplay: drop unnecessary wrapper .populate_smc_tables

2020-06-09 Thread Evan Quan
Since .populate_smc_tables is just a wrapper of .set_default_dpm_table. Change-Id: I80e89146359d6cf5d80f1887878d371b41b41cb0 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 -

[PATCH 1/2] drm/amd/powerplay: drop redundant .set_min_dcefclk_deep_sleep API

2020-06-09 Thread Evan Quan
It has exactly the same functionality as .set_deep_sleep_dcefclk. Change-Id: Ib4d2d604ca014e194cb2b61ac770e4370ecad74d Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 11 +-- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 3 +--

Re: [PATCH] drm/amd/amdgpu: handle return value of amdgpu_driver_load_kms

2020-06-09 Thread Nirmoy
Acked-by: Nirmoy Das On 6/9/20 11:20 AM, Liu ChengZhe wrote: if guest driver failed to enter full GPU access, amdgpu_driver_load_kms will unload kms and free dev->dev_private, drm_dev_register would access null pointer. Driver will enter an error state and can't be unloaded. Signed-off-by:

[PATCH] drm/amd/amdgpu: handle return value of amdgpu_driver_load_kms

2020-06-09 Thread Liu ChengZhe
if guest driver failed to enter full GPU access, amdgpu_driver_load_kms will unload kms and free dev->dev_private, drm_dev_register would access null pointer. Driver will enter an error state and can't be unloaded. Signed-off-by: Liu ChengZhe --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +++-

Re: [PATCH v5 06/13] drm/amd: Gate i2c transaction logs on drm_debug_syslog

2020-06-09 Thread Christian König
Am 08.06.20 um 23:04 schrieb Sean Paul: From: Sean Paul Since the logs protected by these checks specifically target syslog, use the new drm_debug_syslog_enabled() call to avoid triggering these prints when only trace is enabled. Mhm, of hand that doesn't looks like something which belongs