On Wed, Jun 17, 2020 at 6:00 PM Sonny Jiang wrote:
>
For the entire series, please add a patch description and your
signed-off-by. With that fixed, the series is:
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/sid.h | 7 ---
> 1 file changed, 4 insertions(+), 3
On Wed, Jun 17, 2020 at 6:00 PM Sonny Jiang wrote:
>
Please add a patch description and add your signed-off-by. With that fixed:
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 26 +
> 1 file changed, 26 insertions(+)
>
> diff --git
[AMD Official Use Only - Internal Distribution Only]
Acked-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Thursday, June 18, 2020 3:02 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 1/4] drm/amdgpu/debugfs: fix ref count
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Thursday, June 18, 2020 3:02 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 2/4] drm/amdgpu/pm: fix ref count leak
[AMD Official Use Only - Internal Distribution Only]
Series is reviewed-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Thursday, June 18, 2020 9:49 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 2/2] drm/amdgpu/display:
On Thu, Jun 18, 2020 at 12:10 AM Quan, Evan wrote:
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi Alex,
>
> This was raised by Pramendra. He got plenty of questions from customer about
> this.
> The customer saw these mismatch messages and did not know whether it's an
>
[AMD Official Use Only - Internal Distribution Only]
Hi Alex,
This was raised by Pramendra. He got plenty of questions from customer about
this.
The customer saw these mismatch messages and did not know whether it's an
indication of some critical error.
The mismatch messages were update to be
It's only applicable on newer asics. We could end up here when
using DC on older asics like SI or KV.
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1170
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 4 ++--
1 file changed, 2 insertions(+), 2
If there are no supported callbacks. We'll fall back to the
nominal clocks.
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1170
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
From: Nicholas Kazlauskas
[ Upstream commit a24eaa5c51255b344d5a321f1eeb3205f2775498 ]
[Why]
Whenever we switch between tiled formats without also switching pixel
formats or doing anything else that recreates the DC plane state we
can run into underflow or hangs since we're not updating the
DML
From: Nicholas Kazlauskas
[ Upstream commit a24eaa5c51255b344d5a321f1eeb3205f2775498 ]
[Why]
Whenever we switch between tiled formats without also switching pixel
formats or doing anything else that recreates the DC plane state we
can run into underflow or hangs since we're not updating the
DML
Hi Dave, Daniel,
Fixes for 5.8.
The following changes since commit 8d286e2ff4400d313955b4203fc640ca6fd9228b:
Merge tag 'drm-intel-next-fixes-2020-06-04' of
git://anongit.freedesktop.org/drm/drm-intel into drm-next (2020-06-08 11:59:57
+1000)
are available in the Git repository at:
---
drivers/gpu/drm/amd/amdgpu/si.c | 26 --
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
index 153db3f763bc..f1c33395e3fe 100644
--- a/drivers/gpu/drm/amd/amdgpu/si.c
+++
---
drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 792 ++
drivers/gpu/drm/amd/amdgpu/uvd_v3_1.h | 29 +
2 files changed, 821 insertions(+)
create mode 100644 drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c
create mode 100644 drivers/gpu/drm/amd/amdgpu/uvd_v3_1.h
diff --git
---
drivers/gpu/drm/amd/amdgpu/sid.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sid.h b/drivers/gpu/drm/amd/amdgpu/sid.h
index 7cf12adb3915..75b5d441b628 100644
--- a/drivers/gpu/drm/amd/amdgpu/sid.h
+++ b/drivers/gpu/drm/amd/amdgpu/sid.h
---
.../drm/amd/include/asic_reg/uvd/uvd_3_1_d.h | 98 +++
.../include/asic_reg/uvd/uvd_3_1_sh_mask.h| 804 ++
2 files changed, 902 insertions(+)
create mode 100644 drivers/gpu/drm/amd/include/asic_reg/uvd/uvd_3_1_d.h
create mode 100644
---
drivers/gpu/drm/amd/amdgpu/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile
b/drivers/gpu/drm/amd/amdgpu/Makefile
index bfcfb034aed5..403ec3db29df 100644
--- a/drivers/gpu/drm/amd/amdgpu/Makefile
+++
---
drivers/gpu/drm/amd/amdgpu/si.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
index f1c33395e3fe..e21561fbfb82 100644
--- a/drivers/gpu/drm/amd/amdgpu/si.c
+++ b/drivers/gpu/drm/amd/amdgpu/si.c
@@
---
drivers/gpu/drm/amd/amdgpu/si.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
index e21561fbfb82..cda9aa5e4b9e 100644
--- a/drivers/gpu/drm/amd/amdgpu/si.c
+++ b/drivers/gpu/drm/amd/amdgpu/si.c
@@ -2196,7
---
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 26 +
1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
index 5100ebe8858d..f8bebf18ee36 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
+++
[AMD Public Use]
sure
Thanks & Best Regards!
James Zhu
From: Deucher, Alexander
Sent: Wednesday, June 17, 2020 4:53 PM
To: Zhu, James ; amd-gfx@lists.freedesktop.org
Cc: kernel test robot
Subject: Re: [PATCH] drm/amdgpu: vcn_v2_5_mc_resume_dpg_mode() can
On Wed, Jun 17, 2020 at 5:45 AM Evan Quan wrote:
>
> So that user knows it's just a warning and can be safely ignored.
I'm not sure I follow this logic. I think a warning would cause more
concern than just printing it as info. Why would you ignore a
warning?
Alex
>
> Change-Id:
[AMD Public Use]
James, please feel free to commit this.
Alex
From: amd-gfx on behalf of James Zhu
Sent: Wednesday, June 17, 2020 4:41 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhu, James ; kernel test robot
Subject: [PATCH] drm/amdgpu:
From: kernel test robot
Fixes: c422a628925d ("drm/amdgpu: rename macro for VCN2.0 2.5 and 3.0")
Signed-off-by: kernel test robot
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Rajneesh Bhardwaj
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Wednesday, June 17, 2020 3:02 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 3/4] drm/amdgpu/fence: fix ref
[AMD Official Use Only - Internal Distribution Only]
Acked-by: Rajneesh Bhardwaj
-Original Message-
From: Kuehling, Felix
Sent: Wednesday, June 17, 2020 4:17 PM
To: Alex Deucher ; amd-gfx@lists.freedesktop.org;
Bhardwaj, Rajneesh
Cc: Deucher, Alexander
Subject: Re: [PATCH 4/4]
[+Rajneesh]
Am 2020-06-17 um 3:02 p.m. schrieb Alex Deucher:
> The call to pm_runtime_get_sync increments the counter even in case of
> failure, leading to incorrect ref count.
> In case of failure, decrement the ref count before returning.
>
> Signed-off-by: Alex Deucher
Reviewed-by: Felix
The call to pm_runtime_get_sync increments the counter even in case of
failure, leading to incorrect ref count.
In case of failure, decrement the ref count before returning.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 95 +++--
1 file changed,
The call to pm_runtime_get_sync increments the counter even in case of
failure, leading to incorrect ref count.
In case of failure, decrement the ref count before returning.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 +++-
1 file changed, 3 insertions(+), 1
The call to pm_runtime_get_sync increments the counter even in case of
failure, leading to incorrect ref count.
In case of failure, decrement the ref count before returning.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 220 ++---
1 file changed,
The call to pm_runtime_get_sync increments the counter even in case of
failure, leading to incorrect ref count.
In case of failure, decrement the ref count before returning.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +++-
1 file changed, 3 insertions(+), 1
Applied. Thanks!
Alex
On Wed, Jun 17, 2020 at 9:10 AM Chen Tao wrote:
>
> Fix memory leak in amdgpu_debugfs_gpr_read not freeing data when
> amdgpu_virt_enable_access_debugfs failed.
>
> Fixes: 95a2f917387a2 ("drm/amdgpu: restrict debugfs register accessunder
> SR-IOV")
> Signed-off-by: Chen
On Wed, Jun 17, 2020 at 3:34 AM Paul Menzel wrote:
>
> Currently, besides there is no explicit message, that DPM is disabled.
> The user would need to know, that the missing success line is an
> indicator.
>
> [drm] amdgpu: dpm initialized
>
> So, add an explicit message, and make it log
Fixes: c422a628925d ("drm/amdgpu: rename macro for VCN2.0 2.5 and 3.0")
Signed-off-by: kernel test robot
---
vcn_v2_5.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
index
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: 5fcb9628fd1227a5f11d87171cb1b8b5c414d9d9
commit: c422a628925d9733b0807d803133fb78a0a0f707 [953/2089] drm/amdgpu: rename
macro for VCN2.0 2.5 and 3.0
config: i386-randconfig-s001-20200617 (attached
On Wed, Jun 17, 2020 at 08:48:50AM +0200, Daniel Vetter wrote:
> Now my understanding for rdma is that if you don't have hw page fault
> support,
The RDMA ODP feature is restartable HW page faulting just like nouveau
has. The classical MR feature doesn't have this. Only mlx5 HW supports
ODP
On Wed, Jun 17, 2020 at 09:57:54AM +0200, Daniel Vetter wrote:
> > At the very least I think there should be some big warning that
> > dma_fence in notifiers should be avoided.
>
> Yeah I'm working on documentation, and also the notifiers here
> hopefully make it clear it's massive pain. I think
On Wed, Jun 17, 2020 at 7:41 AM Nirmoy Das wrote:
>
> Fixes below warning:
> drivers/gpu/drm/amd/amdgpu/df_v3_6.c: In function
> ‘df_v3_6_reset_perfmon_cntr’:
> drivers/gpu/drm/amd/amdgpu/df_v3_6.c:571:2: warning: ‘hi_base_addr’ may be
> used
> uninitialized in this function
On Wed, Jun 17, 2020 at 12:00 AM Evan Quan wrote:
>
> To follow conventional style. And this unnecessary "@" confuses
> our userspace tool.
>
> Change-Id: Id4cdc611d63e800cf5a93449b6331a1e8323e727
> Signed-off-by: Evan Quan
Acked-by: Alex Deucher
> ---
>
On Tue, Jun 16, 2020 at 04:23:46PM -0700, Fenghua Yu wrote:
> Hi, Peter,
>
> On Mon, Jun 15, 2020 at 09:09:28PM +0200, Peter Zijlstra wrote:
> > On Mon, Jun 15, 2020 at 11:55:29AM -0700, Fenghua Yu wrote:
> >
> > > Or do you suggest to add a random new flag in struct thread_info instead
> > > of
Fix memory leak in amdgpu_debugfs_gpr_read not freeing data when
pm_runtime_get_sync failed.
Fixes: a9ffe2a983383 ("drm/amdgpu/debugfs: properly handle runtime pm")
Signed-off-by: Chen Tao
---
v1->v2:
- remove the duplication of result and r here and then use "goto err"
Fix memory leak in amdgpu_debugfs_gpr_read not freeing data when
amdgpu_virt_enable_access_debugfs failed.
Fixes: 95a2f917387a2 ("drm/amdgpu: restrict debugfs register accessunder
SR-IOV")
Signed-off-by: Chen Tao
---
v1->v2:
- remove the duplication of result and r here and then use "goto err"
Fixes below warning:
drivers/gpu/drm/amd/amdgpu/df_v3_6.c: In function ‘df_v3_6_reset_perfmon_cntr’:
drivers/gpu/drm/amd/amdgpu/df_v3_6.c:571:2: warning: ‘hi_base_addr’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
571 | df_v3_6_perfmon_wreg(adev, lo_base_addr, 0,
So that user knows it's just a warning and can be safely ignored.
Change-Id: Ic518ec3eb68c6bd6682e6131e32cfe90843341ff
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Paul Menzel
Sent: Wednesday, June 17, 2020 3:17 PM
To: Deucher, Alexander ; Koenig, Christian
Cc: Paul Menzel ; amd-gfx@lists.freedesktop.org
Subject: [PATCH]
On Wed, Jun 17, 2020 at 9:27 AM Jason Gunthorpe wrote:
>
> On Tue, Jun 16, 2020 at 02:07:19PM +0200, Daniel Vetter wrote:
> > > > I've pinged a bunch of armsoc gpu driver people and ask them how much
> > > > this
> > > > hurts, so that we have a clear answer. On x86 I don't think we have much
>
Currently, besides there is no explicit message, that DPM is disabled.
The user would need to know, that the missing success line is an
indicator.
[drm] amdgpu: dpm initialized
So, add an explicit message, and make it log level warning, as disabling
dpm is not the default.
Resolves:
On Tue, Jun 16, 2020 at 2:07 PM Daniel Vetter wrote:
>
> Hi Jason,
>
> Somehow this got stuck somewhere in the mail queues, only popped up just
> now ...
>
> On Thu, Jun 11, 2020 at 11:15:15AM -0300, Jason Gunthorpe wrote:
> > On Thu, Jun 11, 2020 at 10:34:30AM +0200, Daniel Vetter wrote:
> > > >
48 matches
Mail list logo
