Hi,
Everything looks fine to me, I just noticed that the amdgpu patches did
not apply smoothly, however it was trivial to fix the issues.
Reviewed-by: Rodrigo Siqueira
Melissa,
Since you are using vkms regularly, could you test this patch and review
it? Remember to add your Tested-by when you f
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: amd-gfx On Behalf Of Rodrigo
Siqueira
Sent: Saturday, July 11, 2020 4:33 AM
To: amd-gfx@lists.freedesktop.org
Cc: Laktyushkin, Dmytro ; Brol, Eryk
; Li, Sun peng (Leo) ; Wentland, Harry
; Zhuo, Qingqing ; Si
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: amd-gfx On Behalf Of Wenhui Sheng
Sent: Friday, July 10, 2020 10:17 PM
To: amd-gfx@lists.freedesktop.org
Cc: Gao, Likun ; Sheng, Wenhui ;
Zhang, Hawking
Subject: [PATCH 1/3] drm/amd/powerplay: add SMU mode1
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: amd-gfx On Behalf Of Wenhui Sheng
Sent: Friday, July 10, 2020 10:17 PM
To: amd-gfx@lists.freedesktop.org
Cc: Gao, Likun ; Sheng, Wenhui ;
Zhang, Hawking
Subject: [PATCH 1/3] drm/amd/powerplay: add SMU mode1 re
[AMD Official Use Only - Internal Distribution Only]
It seems this patch contains different changes. Better to split into several
patches:
One for amdgpu_ras_need_emergency_restart() changes.
One for the following changes:
+if (amdgpu_dpm_is_mode1_reset_supported(adev)) {
+dev_info(adev->dev, "GP
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: amd-gfx On Behalf Of Wenhui Sheng
Sent: Friday, July 10, 2020 10:17 PM
To: amd-gfx@lists.freedesktop.org
Cc: Gao, Likun ; Sheng, Wenhui ;
Zhang, Hawking
Subject: [PATCH 3/3] drm/amdgpu: add module parameter ch
On 7/12/20 1:31 AM, Li, Dennis wrote:
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: Grodzovsky, Andrey
Sent: Friday, July 10, 2020 10:33 PM
To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander
; Zhou1, Tao ; Zhang, Hawking
; Chen, Guch
[AMD Official Use Only - Internal Distribution Only]
Ok, will refine it.
Brs
Wenhui
-Original Message-
From: Li, Dennis
Sent: Monday, July 13, 2020 11:10 AM
To: Sheng, Wenhui ; amd-gfx@lists.freedesktop.org
Cc: Gao, Likun ; Sheng, Wenhui ;
Zhang, Hawking
Subject: RE: [PATCH 1/3] drm
[AMD Official Use Only - Internal Distribution Only]
[AMD Official Use Only - Internal Distribution Only]
Ok will refine it.
Brs
Wenhui
-Original Message-
From: Quan, Evan
Sent: Monday, July 13, 2020 11:19 AM
To: Sheng, Wenhui ; amd-gfx@lists.freedesktop.org
Cc: Gao, Likun ; Sheng, Wen
[AMD Official Use Only - Internal Distribution Only]
Ping for this one and patch12, patch2 and patch3
BR
Evan
-Original Message-
From: Quan, Evan
Sent: Friday, July 10, 2020 12:48 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Quan, Evan
Subject: [PATCH 13/16] drm/amd/po
[AMD Official Use Only - Internal Distribution Only]
[AMD Official Use Only - Internal Distribution Only]
Ok will refine it
Brs
Wenhui
-Original Message-
From: Quan, Evan
Sent: Monday, July 13, 2020 11:26 AM
To: Sheng, Wenhui ; amd-gfx@lists.freedesktop.org
Cc: Gao, Likun ; Sheng, Wenh
[AMD Official Use Only - Internal Distribution Only]
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: Quan, Evan
Sent: Monday, July 13, 2020 11:30 AM
To: Sheng, Wenhui ; amd-gfx@lists.freedesktop.org
Cc: Gao, Likun ; Sheng, Wenhui ;
Zhang, Hawking
Subject
[AMD Public Use]
V2 looks good to me expect for the following that can be improved
+ if (need_emergency_restart && amdgpu_ras_get_context(adev)->reboot) {
The check of reboot could be centralized to the new function
amdgpu_ras_need_emergency_restart you added in amdgpu_ras.c. And it would
[AMD Public Use]
So first make a patch to refine need_emergency_resetart logic in
amdgpu_device_gpu_recover function. Then apply you next series to add new mode1
reset support
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Zhang,
Hawking
Sent: Monday, July 13, 2020 13
[AMD Public Use]
RE - [Dennis Li] It is better change to use RREG32_SOC15_NO_KIQ, because when
GPU hang, RREG32_SOC15 will fail if it use RREG32_KIQ to read register
RREG32_SOC15_NO_KIQ should have no difference from RREG32_SOC15 for this use
scenario. This is the feature only supported in bare
[AMD Public Use]
Hi Wenhui,
I think we shall deal with the case where user specify an
unexpected/unsupported reset method via the module parameter.
So in each asic_reset_method function, rule out this case, force to auto, and
print warning message to inform user.
Regards,
Hawking
-Origina
[AMD Public Use]
V2 looks good to me except for the following nitpicks
+#define SMU11_MODE1_RESET_WAIT_TIME 500 //500ms
It would be better explicitly call ms units out in the macro name, say
SMU11_MODE1_RESET_WAIT_TIMEOUT_IN_MS.
Regards,
Hawking
-Original Message-
From: Sheng, Wenhui
to easily add new debugfs file w/o changing the hardcoded list count.
Signed-off-by: Xiaojie Yuan
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 6 --
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c| 3 ++-
3 files changed, 8 insertions(+), 4 de
[AMD Public Use]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Xiaojie Yuan
Sent: Monday, July 13, 2020 14:00
To: amd-gfx@lists.freedesktop.org
Cc: Yuan, Xiaojie
Subject: [PATCH] drm/amdgpu: use ARRAY_SIZE() to add amdgpu debugfs files
to ea
[AMD Public Use]
HI Hawking
I have merged in_ras_intr & use_baco to the function
amdgpu_ras_need_emergency_restart, If I also move the check of reboot logic
code to the new added function, variable need_emergency_restart Couldn't be
used for the following if check in function amdgpu_device_gp
[AMD Public Use]
Hi, Hawking,
Got it. Thanks for your expiation. It looks good to me now.
Reviewed-by: Dennis Li
Best Regards
Dennis Li
-Original Message-
From: Zhang, Hawking
Sent: Monday, July 13, 2020 1:44 PM
To: Sheng, Wenhui ; Li, Dennis ;
amd-gfx@lists.freedesktop.org
Cc:
[AMD Public Use]
Hi Hawking,
Not sure If there is a situation that we pass through the physical device to a
vm, the condition check " if (!(acc_flags & AMDGPU_REGS_NO_KIQ) &&
amdgpu_sriov_runtime(adev)) " in function amdgpu_mm_rreg should be true when
we call RREG32_SOC15, is it correct?
B
[AMD Public Use]
Ok got it.
Brs
Wenhui
-Original Message-
From: Zhang, Hawking
Sent: Monday, July 13, 2020 1:52 PM
To: Sheng, Wenhui ; amd-gfx@lists.freedesktop.org
Cc: Gao, Likun
Subject: RE: [PATCH 3/3] drm/amdgpu: add module parameter choose reset mode
[AMD Public Use]
Hi Wenhui,
[AMD Public Use]
Good suggestion, will refine the name.
Brs
Wenhui
-Original Message-
From: Zhang, Hawking
Sent: Monday, July 13, 2020 1:55 PM
To: Sheng, Wenhui ; amd-gfx@lists.freedesktop.org
Cc: Gao, Likun
Subject: RE: [PATCH 1/3] drm/amd/powerplay: add SMU mode1 reset
[AMD Public
24 matches
Mail list logo
