RE: [PATCH 01/17] drm/amd/powerplay: move the API shared by SMU v11 to smu_v11_0.c

2020-07-15 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Updated in the new patch. BR, Evan -Original Message- From: Alex Deucher Sent: Thursday, July 16, 2020 1:58 AM To: Quan, Evan Cc: amd-gfx list ; Deucher, Alexander Subject: Re: [PATCH 01/17] drm/amd/powerplay: move the API shared

[PATCH] drm/amd/powerplay: widely share the API for data table retrieving

2020-07-15 Thread Evan Quan
Considering the data table retrieving can be more widely shared, amdgpu_atombios.c is the right place. Change-Id: Id89476c14709b5676bbf043371a27f27b94a58ed Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c| 17 +

Re: [PATCH 10/10] drm/amd/display: handle failed allocation during stream construction

2020-07-15 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.7.8, v5.4.51, v4.19.132, v4.14.188, v4.9.230, v4.4.230. v5.7.8: Build OK!

Re: [PATCH 04/10] drm/amd/display: OLED panel backlight adjust not work with external display connected

2020-07-15 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.7.8, v5.4.51, v4.19.132, v4.14.188, v4.9.230, v4.4.230. v5.7.8: Build OK!

[pull] amdgpu drm-fixes-5.8

2020-07-15 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.8. The following changes since commit 38794a5465b752118098e36cf95c59083f9f1f88: Merge tag 'amd-drm-fixes-5.8-2020-07-09' of git://people.freedesktop.org/~agd5f/linux into drm-fixes (2020-07-10 07:02:02 +1000) are available in the Git repository at:

Re: [PATCH 01/17] drm/amd/powerplay: move the API shared by SMU v11 to smu_v11_0.c

2020-07-15 Thread Alex Deucher
On Tue, Jul 14, 2020 at 4:04 AM Evan Quan wrote: > > To fit our original desgin and this can help to maintain > clear code layer. > > Change-Id: Id89476c14709b5676bbf043371a27f27b94a58ed > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 16 --- >

Re: [PATCH 01/42] drm/amdgpu: expand to add multiple trap event irq id

2020-07-15 Thread Alex Deucher
On Wed, Jul 15, 2020 at 9:24 AM Alex Deucher wrote: > > On Wed, Jul 15, 2020 at 5:21 AM Christian König > wrote: > > > > Am 14.07.20 um 20:23 schrieb Alex Deucher: > > > From: Huang Rui > > > > > > Sienna_cichlid has four sdma instances, but other chips don't. > > > So we need expand to add

Re: [PATCH] drm/amd/powerplay: suppress compile error around BUG_ON

2020-07-15 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: Quan, Evan Sent: Wednesday, July 15, 2020 2:52 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH] drm/amd/powerplay: suppress compile error around BUG_ON To suppress the

Re: Failed to find memory space for buffer eviction

2020-07-15 Thread Felix Kuehling
Am 2020-07-15 um 5:28 a.m. schrieb Christian König: > Am 15.07.20 um 04:49 schrieb Felix Kuehling: >> Am 2020-07-14 um 4:28 a.m. schrieb Christian König: >>> Hi Felix, >>> >>> yes I already stumbled over this as well quite recently. >>> >>> See the following patch which I pushed to drm-misc-next

Re: Failed to find memory space for buffer eviction

2020-07-15 Thread Deucher, Alexander
[AMD Public Use] Maybe we should re-test the problematic piglit test and if it's no longer an issue, revert: commit 24562523688bebc7ec17a88271b4e8c3fc337b74 Author: Andrey Grodzovsky Date: Fri Dec 15 12:09:16 2017 -0500 Revert "drm/amd/amdgpu: set gtt size according to system memory

RE: [PATCH 5/5] drm/amd/sriov skip vcn powergating and dec_ring_test

2020-07-15 Thread Liu, Leo
Reviewed-by: Leo Liu -Original Message- From: Jack Zhang Sent: July 15, 2020 1:50 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jack (Jian) ; Zhang, Hawking ; Liu, Leo Subject: [PATCH 5/5] drm/amd/sriov skip vcn powergating and dec_ring_test 1.Skip decode_ring test in VF, because

Re: [PATCH 01/42] drm/amdgpu: expand to add multiple trap event irq id

2020-07-15 Thread Alex Deucher
On Wed, Jul 15, 2020 at 5:21 AM Christian König wrote: > > Am 14.07.20 um 20:23 schrieb Alex Deucher: > > From: Huang Rui > > > > Sienna_cichlid has four sdma instances, but other chips don't. > > So we need expand to add multiple trap event irq id in sdma > > v5.2. > > > > Signed-off-by: Huang

Re: [PATCH 19/25] drm/amdgpu: s/GFP_KERNEL/GFP_ATOMIC in scheduler code

2020-07-15 Thread Daniel Vetter
On Wed, Jul 15, 2020 at 11:17 AM Christian König wrote: > > Am 14.07.20 um 16:31 schrieb Daniel Vetter: > > On Tue, Jul 14, 2020 at 01:40:11PM +0200, Christian König wrote: > >> Am 14.07.20 um 12:49 schrieb Daniel Vetter: > >>> On Tue, Jul 07, 2020 at 10:12:23PM +0200, Daniel Vetter wrote: >

Re: Failed to find memory space for buffer eviction

2020-07-15 Thread Christian König
Am 15.07.20 um 04:49 schrieb Felix Kuehling: Am 2020-07-14 um 4:28 a.m. schrieb Christian König: Hi Felix, yes I already stumbled over this as well quite recently. See the following patch which I pushed to drm-misc-next just yesterday: commit e04be2310b5eac683ec03b096c0e22c4c2e23593 Author:

Re: [PATCH 01/42] drm/amdgpu: expand to add multiple trap event irq id

2020-07-15 Thread Christian König
Am 14.07.20 um 20:23 schrieb Alex Deucher: From: Huang Rui Sienna_cichlid has four sdma instances, but other chips don't. So we need expand to add multiple trap event irq id in sdma v5.2. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Reviewed-by:

Re: [PATCH 19/25] drm/amdgpu: s/GFP_KERNEL/GFP_ATOMIC in scheduler code

2020-07-15 Thread Christian König
Am 14.07.20 um 16:31 schrieb Daniel Vetter: On Tue, Jul 14, 2020 at 01:40:11PM +0200, Christian König wrote: Am 14.07.20 um 12:49 schrieb Daniel Vetter: On Tue, Jul 07, 2020 at 10:12:23PM +0200, Daniel Vetter wrote: My dma-fence lockdep annotations caught an inversion because we allocate

Re: [PATCH 4/4] drm/amdgpu: add module parameter choose reset mode

2020-07-15 Thread Christian König
In second case, two conditions could be true at the same, so when we want to indicate that the program should choose either one or none of the options, the first one should be much more cleaner and better. When you check two independent conditions which just happen to use the same value?

RE: [PATCH] drm/amdgpu: resolve bug in ta microcode init

2020-07-15 Thread Chen, Guchun
[AMD Public Use] Hi John, The patch is good. However, maybe it's better we can improve the patch commit message title/body together a bit. Generally, original title 'resolve bug...' is not pretty clear to audience. If possible, we can modify the title to 'correct fw start address', and in

[PATCH] drm/amd/powerplay: suppress compile error around BUG_ON

2020-07-15 Thread Evan Quan
To suppress the compile error below for "ARCH=arc". drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c: In function 'arcturus_fill_eeprom_i2c_req': >> arch/arc/include/asm/bug.h:22:2: error: implicit declaration of function >> 'pr_warn'; did you mean 'pci_warn'?

[PATCH] drm/amdgpu: resolve bug in ta microcode init

2020-07-15 Thread Clements, John
[AMD Public Use] Submitting patch for review to resolve bug when calculating FW offset within binaries with PSP TA v2 header. Thank you, John Clements 0001-drm-amdgpu-resolve-bug-in-ta-microcode-init.patch Description: 0001-drm-amdgpu-resolve-bug-in-ta-microcode-init.patch