[PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

1. For Navi12, CHIP_SIENNA_CICHLID, skip tmr load operation; 2. Check pointer before release firmware. v2: use CHIP_SIENNA_CICHLID instead v3: remove local "bool ret"; fix grammer issue v4: use my name instead of "root" Signed-off-by: Liu ChengZhe ---

[PATCH 1/2] drm/amdgpu: add interface amdgpu_gfx_init_spm_golden for Navi1x

From: "Tianci.Yin" On Navi1x, the SPM golden settings will be lost after GFXOFF enter/exit, reconfiguration is needed. Make the configuration code as an interface for future use. Change-Id: I172f3dc7f59da69b0364052dcad75a9c9aab019e Signed-off-by: Tianci.Yin ---

[PATCH 2/2] drm/amdgpu: reconfigure spm golden settings on Navi1x after GFXOFF exit

From: "Tianci.Yin" On Navi1x, the SPM golden settings will be lost after GFXOFF enter/exit, reconfigure the golden settings after GFXOFF exit. Change-Id: I9358ba9c65f241c36f8a35916170b19535148ee9 Signed-off-by: Tianci.Yin --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 11 +++ 1 file

[PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

From: root 1. For Navi12, CHIP_SIENNA_CICHLID, skip tmr load operation; 2. Check pointer before release firmware. v2: use CHIP_SIENNA_CICHLID instead v3: remove local "bool ret"; fix grammer issue Signed-off-by: root --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 35

RE: [PATCH] drm/amdgpu: enable umc 8.7 functions in gmc v10

[AMD Public Use] Reviewed-by: Guchun Chen Regards, Guchun From: Clements, John Sent: Tuesday, July 28, 2020 10:56 AM To: Chen, Guchun ; amd-gfx list ; Zhang, Hawking Subject: RE: [PATCH] drm/amdgpu: enable umc 8.7 functions in gmc v10 [AMD Public Use] Thank you for the feedback @Chen,

RE: [PATCH] drm/amdgpu: add umv v8.7 source to makefile

[AMD Public Use] I would suggest you combine the patch with your previous series. and send them out for the review if you haven't completed the review yet. Regards, Hawking From: Clements, John Sent: Tuesday, July 28, 2020 10:42 To: amd-gfx list ; Zhang, Hawking Subject: [PATCH] drm/amdgpu:

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

On 2020-07-27 5:32 p.m., Daniel Vetter wrote: On Mon, Jul 27, 2020 at 11:11 PM Mazin Rezk wrote: On Monday, July 27, 2020 4:29 PM, Daniel Vetter wrote: On Mon, Jul 27, 2020 at 9:28 PM Christian König wrote: Am 27.07.20 um 16:05 schrieb Kazlauskas, Nicholas: On 2020-07-27 9:39 a.m.,

[PATCH] drm/amdgpu: add umv v8.7 source to makefile

[AMD Public Use] Submitting patch to add UMC 8.7 source file to makefile 0001-drm-amdgpu-add-umv-v8.7-source-to-makefile.patch Description: 0001-drm-amdgpu-add-umv-v8.7-source-to-makefile.patch ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org

[PATCH] drm/amdgpu: fix PSP autoload twice in FLR

the block->status.hw = false assignment will overwrite PSP's previous hw status, which will cause PSP execute resume operation after hw init. v2: remove the braces Signed-off-by: Liu ChengZhe --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH] drm/amdkfd: Add GPU reset SMI event

Add support for reporting GPU reset events through SMI. Signed-off-by: Mukul Joshi --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 ++ drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 18 ++ drivers/gpu/drm/amd/amdkfd/kfd_smi_events.h | 1 + include/uapi/linux/kfd_ioctl.h

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

On Monday, July 27, 2020 9:26 AM, Kazlauskas, Nicholas wrote: > On 2020-07-27 1:40 a.m., Mazin Rezk wrote: > > This patch fixes a race condition that causes a use-after-free during > > amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits > > are requested and the second one

Re: [PATCH] drm/amdkfd: Replace bitmask with event idx in SMI event msg

Am 2020-07-26 um 5:24 p.m. schrieb Mukul Joshi: > Event bitmask is a 64-bit mask with only 1 bit set. Sending this > event bitmask in KFD SMI event message is both wasteful of memory > and potentially limiting to only 64 events. Instead send event > index in SMI event message. Please add a

Re: [PATCH] drm/amdgpu: introduce a new parameter to configure how many KCQ we want(v2)

Am 2020-07-27 um 6:47 a.m. schrieb Monk Liu: > what: > the MQD's save and restore of kernel compute queues cost lots of clocks > during world switch which impacts a lot to multi-VF performance > > how: > introduce a paramter to control the number of kernel compute queues to > avoid performance

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

On Mon, Jul 27, 2020 at 11:11 PM Mazin Rezk wrote: > > On Monday, July 27, 2020 4:29 PM, Daniel Vetter wrote: > > > On Mon, Jul 27, 2020 at 9:28 PM Christian König > > wrote: > > > > > > Am 27.07.20 um 16:05 schrieb Kazlauskas, Nicholas: > > > > On 2020-07-27 9:39 a.m., Christian König wrote: >

[PATCH] drm/amdgpu/dc: Stop dma_resv_lock inversion in commit_tail

Trying to grab dma_resv_lock while in commit_tail before we've done all the code that leads to the eventual signalling of the vblank event (which can be a dma_fence) is deadlock-y. Don't do that. Here the solution is easy because just grabbing locks to read something races anyway. We don't need

Re: [PATCH 11/15] drm/amd/display: dchubbub p-state warning during surface planes switch

Hi [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.7.10, v5.4.53, v4.19.134, v4.14.189, v4.9.231, v4.4.231. v5.7.10: Build OK!

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

On Mon, Jul 27, 2020 at 10:29 PM Daniel Vetter wrote: > > On Mon, Jul 27, 2020 at 9:28 PM Christian König > wrote: > > > > Am 27.07.20 um 16:05 schrieb Kazlauskas, Nicholas: > > > On 2020-07-27 9:39 a.m., Christian König wrote: > > >> Am 27.07.20 um 07:40 schrieb Mazin Rezk: > > >>> This patch

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

On Mon, Jul 27, 2020 at 9:28 PM Christian König wrote: > > Am 27.07.20 um 16:05 schrieb Kazlauskas, Nicholas: > > On 2020-07-27 9:39 a.m., Christian König wrote: > >> Am 27.07.20 um 07:40 schrieb Mazin Rezk: > >>> This patch fixes a race condition that causes a use-after-free during > >>>

Re:

On Mon, Jul 27, 2020 at 3:46 PM Mauro Rossi wrote: > > > > On Mon, Jul 27, 2020 at 8:31 PM Alex Deucher wrote: >> >> On Sun, Jul 26, 2020 at 11:31 AM Mauro Rossi wrote: >> > >> > Hello, >> > >> > On Fri, Jul 24, 2020 at 8:31 PM Alex Deucher wrote: >> >> >> >> On Wed, Jul 22, 2020 at 3:57 AM

Re:

On Mon, Jul 27, 2020 at 8:31 PM Alex Deucher wrote: > On Sun, Jul 26, 2020 at 11:31 AM Mauro Rossi > wrote: > > > > Hello, > > > > On Fri, Jul 24, 2020 at 8:31 PM Alex Deucher > wrote: > >> > >> On Wed, Jul 22, 2020 at 3:57 AM Mauro Rossi > wrote: > >> > > >> > Hello, > >> > re-sending and

Re: [PATCH] drm/amdgpu/si: initial support for GPU reset

Am 27.07.20 um 19:34 schrieb Alex Deucher: Ported from radeon. Signed-off-by: Alex Deucher Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/si.c | 92 - 1 file changed, 90 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] drm/amdgpu: introduce a new parameter to configure how many KCQ we want

Am 27.07.20 um 18:02 schrieb Felix Kuehling: Am 2020-07-27 um 5:26 a.m. schrieb Christian König: Am 27.07.20 um 10:21 schrieb Monk Liu: what: KCQ cost many clocks during world switch which impacts a lot to multi-VF performance how: introduce a paramter to control the number of KCQ to avoid

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

Am 27.07.20 um 16:05 schrieb Kazlauskas, Nicholas: On 2020-07-27 9:39 a.m., Christian König wrote: Am 27.07.20 um 07:40 schrieb Mazin Rezk: This patch fixes a race condition that causes a use-after-free during amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits are

Re: [PATCH] drm/amdgpu: fix PSP autoload twice in FLR

On 2020-07-27 7:03 a.m., Liu ChengZhe wrote: > the block->status.hw = false assignment will overwrite PSP's previous > hw status, which will cause PSP execute resume operation after hw init. > > Signed-off-by: Liu ChengZhe > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 - > 1 file

Re: [PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

On 2020-07-27 6:57 a.m., Liu ChengZhe wrote: > From: root > > 1. For Navi12, CHIP_SIENNA_CICHLID, skip tmr load operation; > 2. Check pointer before release firmware. > > Signed-off-by: root > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 40 + > 1 file

Re:

On Sun, Jul 26, 2020 at 11:31 AM Mauro Rossi wrote: > > Hello, > > On Fri, Jul 24, 2020 at 8:31 PM Alex Deucher wrote: >> >> On Wed, Jul 22, 2020 at 3:57 AM Mauro Rossi wrote: >> > >> > Hello, >> > re-sending and copying full DL >> > >> > On Wed, Jul 22, 2020 at 4:51 AM Alex Deucher wrote: >>

Re: [PATCH 1/2] drm/radeon: switch from 'pci_' to 'dma_' API

Applied. Thanks! Alex On Mon, Jul 27, 2020 at 9:42 AM Christian König wrote: > > Am 27.07.20 um 12:34 schrieb Christophe JAILLET: > > The wrappers in include/linux/pci-dma-compat.h should go away. > > > > The patch has been generated with the coccinelle script below and has been > > hand

Re: [PATCH 2/2] drm/radeon: avoid a useless memset

Applied. Thanks! Alex On Mon, Jul 27, 2020 at 9:41 AM Christian König wrote: > > Am 27.07.20 um 12:34 schrieb Christophe JAILLET: > > Avoid a memset after a call to 'dma_alloc_coherent()'. > > This is useless since > > commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*")

[PATCH] drm/amdgpu/si: initial support for GPU reset

Ported from radeon. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/si.c | 92 - 1 file changed, 90 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c index 1b449291f068..a7a45f06c8f3 100644

Re: [PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

[AMD Official Use Only - Internal Distribution Only] Please fix your git setup to use your name rather than "root" as the author. Alex From: Liu ChengZhe Sent: Monday, July 27, 2020 6:57 AM To: amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Koenig,

Re: [PATCH] drm/amdgpu: introduce a new parameter to configure how many KCQ we want

Am 2020-07-27 um 5:26 a.m. schrieb Christian König: > Am 27.07.20 um 10:21 schrieb Monk Liu: >> what: >> KCQ cost many clocks during world switch which impacts a lot to multi-VF >> performance >> >> how: >> introduce a paramter to control the number of KCQ to avoid performance >> drop if there is

Re: [PATCH] drm/amd/display: Use proper abm/backlight functions for DCN3

On 2020-07-27 11:23 a.m., Alex Deucher wrote: On Mon, Jul 27, 2020 at 11:22 AM Bhawanpreet Lakha wrote: Use DCN21 functions instead of DCE110 Signed-off-by: Bhawanpreet Lakha Acked-by: Alex Deucher Reviewed-by: Nicholas Kazlauskas Regards, Nicholas Kazlauskas ---

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

On Mon, 27 Jul 2020 10:05:01 -0400 "Kazlauskas, Nicholas" wrote: > On 2020-07-27 9:39 a.m., Christian König wrote: > > Am 27.07.20 um 07:40 schrieb Mazin Rezk: > >> This patch fixes a race condition that causes a use-after-free > >> during amdgpu_dm_atomic_commit_tail. This can occur when 2 > >>

Re: [PATCH] drm/amd/display: Use proper abm/backlight functions for DCN3

On Mon, Jul 27, 2020 at 11:22 AM Bhawanpreet Lakha wrote: > > Use DCN21 functions instead of DCE110 > > Signed-off-by: Bhawanpreet Lakha Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff

[PATCH] drm/amd/display: Use proper abm/backlight functions for DCN3

Use DCN21 functions instead of DCE110 Signed-off-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

On 2020-07-27 9:39 a.m., Christian König wrote: Am 27.07.20 um 07:40 schrieb Mazin Rezk: This patch fixes a race condition that causes a use-after-free during amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits are requested and the second one finishes before the first.

Re: [PATCH 1/2] drm/radeon: switch from 'pci_' to 'dma_' API

Am 27.07.20 um 12:34 schrieb Christophe JAILLET: The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in

[PATCH] drm/amd/powerplay: off by one bugs in smu_cmn_to_asic_specific_index()

These tables have _COUNT number of elements so the comparisons should be >= instead of > to prevent reading one element beyond the end of the array. Fixes: 8264ee69f0d8 ("drm/amd/powerplay: drop unused code") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/powerplay/smu_cmn.c | 10

Re: [PATCH 2/2] drm/radeon: avoid a useless memset

Am 27.07.20 um 12:34 schrieb Christophe JAILLET: Avoid a memset after a call to 'dma_alloc_coherent()'. This is useless since commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*") Signed-off-by: Christophe JAILLET Reviewed-by: Christian König ---

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

Am 27.07.20 um 07:40 schrieb Mazin Rezk: This patch fixes a race condition that causes a use-after-free during amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits are requested and the second one finishes before the first. Essentially, this bug occurs when the following

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

On 2020-07-27 1:40 a.m., Mazin Rezk wrote: This patch fixes a race condition that causes a use-after-free during amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits are requested and the second one finishes before the first. Essentially, this bug occurs when the following

[PATCH] drm/amdkfd: option to disable system mem limit

If multiple process share system memory through /dev/shm, KFD allocate memory should not fail if it reachs the system memory limit because one copy of physical system memory are shared by multiple process. Add module parameter to provide user option to disable system memory limit check, to run

[PATCH 2/2] drm/radeon: avoid a useless memset

Avoid a memset after a call to 'dma_alloc_coherent()'. This is useless since commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*") Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/radeon/radeon_gart.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 1/2] drm/radeon: switch from 'pci_' to 'dma_' API

The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'radeon_gart_table_ram_alloc()' GFP_KERNEL can be

[PATCH] drm/amdgpu: fix PSP autoload twice in FLR

the block->status.hw = false assignment will overwrite PSP's previous hw status, which will cause PSP execute resume operation after hw init. Signed-off-by: Liu ChengZhe --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

On Monday, July 27, 2020 1:40 AM, Mazin Rezk wrote: > This patch fixes a race condition that causes a use-after-free during > amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits > are requested and the second one finishes before the first. Essentially, > this bug occurs when

[PATCH] drm/amd/display: Clear dm_state for fast updates

This patch fixes a race condition that causes a use-after-free during amdgpu_dm_atomic_commit_tail. This can occur when 2 non-blocking commits are requested and the second one finishes before the first. Essentially, this bug occurs when the following sequence of events happens: 1. Non-blocking

[PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

From: root 1. For Navi12, CHIP_SIENNA_CICHLID, skip tmr load operation; 2. Check pointer before release firmware. Signed-off-by: root --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 40 + 1 file changed, 34 insertions(+), 6 deletions(-) diff --git

[PATCH] drm/amdgpu: introduce a new parameter to configure how many KCQ we want(v2)

what: the MQD's save and restore of kernel compute queues cost lots of clocks during world switch which impacts a lot to multi-VF performance how: introduce a paramter to control the number of kernel compute queues to avoid performance drop if there is no kernel compute queue needed notes: this

[PATCH] drm amdgpu: Skip tmr load for SRIOV

From: root 1. For Navi12, Navi21, skip tmr load operation; 2. Check pointer before release firmware. Signed-off-by: root --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 40 + 1 file changed, 34 insertions(+), 6 deletions(-) diff --git

Re: [PATCH] drm/amdgpu: enable umc 8.7 functions in gmc v10

Please use the "git send-email" command to send patches to the mailing list. Christian. Am 27.07.20 um 10:32 schrieb Clements, John: [AMD Public Use] Submitting patch to enable UMC 8.7 GECC functions in GMC v10 ___ amd-gfx mailing list

Re: [PATCH -next 1/2] drm: Remove redundant NULL check

On Thu, Jul 23, 2020 at 11:27:42AM +0800, Li Heng wrote: > Fix below warnings reported by coccicheck: > ./drivers/gpu/drm/drm_drv.c:819:2-7: WARNING: NULL check before some freeing > functions is not needed. > > Fixes: 5dad34f3c444 ("drm: Cleanups after drmm_add_final_kfree rollout") >

Re: [PATCH] drm/amdgpu: introduce a new parameter to configure how many KCQ we want

Am 27.07.20 um 10:21 schrieb Monk Liu: what: KCQ cost many clocks during world switch which impacts a lot to multi-VF performance how: introduce a paramter to control the number of KCQ to avoid performance drop if there is no KQC needed notes: this paramter only affects gfx 8/9/10 Sounds

RE: [PATCH] drm/amdgpu: enable umc 8.7 functions in gmc v10

[AMD Public Use] One typo in commit subject. add support for umc 8.7 initialzation and RAS interrupt s/initialzation /initialization With this fixed, the patch is: Reviewed-by: Guchun Chen guchun.c...@amd.com Regards, Guchun From: amd-gfx On Behalf Of Clements,

Re: [PATCH] drm/amdgpu: skip crit temperature values on APU

[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Huang Rui Sent: Monday, July 27, 2020 4:23 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray Subject: [PATCH] drm/amdgpu: skip crit

[PATCH] drm/amdgpu: enable umc 8.7 functions in gmc v10

[AMD Public Use] Submitting patch to enable UMC 8.7 GECC functions in GMC v10 0001-drm-amdgpu-enable-umc-8.7-functions-in-gmc-v10.patch Description: 0001-drm-amdgpu-enable-umc-8.7-functions-in-gmc-v10.patch ___ amd-gfx mailing list

[PATCH] drm/amdgpu: skip crit temperature values on APU

It doesn't expose PPTable descriptor on APU platform. So max/min temperature values cannot be got from APU platform. Signed-off-by: Huang Rui --- This patch needs to backport to stable tree. Thanks, Ray --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 6 ++ 1 file changed, 6 insertions(+)

[PATCH] drm/amdgpu: introduce a new parameter to configure how many KCQ we want

what: KCQ cost many clocks during world switch which impacts a lot to multi-VF performance how: introduce a paramter to control the number of KCQ to avoid performance drop if there is no KQC needed notes: this paramter only affects gfx 8/9/10 Signed-off-by: Monk Liu ---