Re: [PATCH v6 09/12] x86/process: Clear PASID state for a newly forked/cloned thread

2020-07-31 Thread Andy Lutomirski
On Mon, Jul 13, 2020 at 4:48 PM Fenghua Yu wrote: > > The PASID state has to be cleared on forks, since the child has a > different address space. The PASID is also cleared for thread clone. While > it would be correct to inherit the PASID in this case, it is unknown > whether the new task will us

Re: [PATCH v6 12/12] x86/traps: Fix up invalid PASID

2020-07-31 Thread Andy Lutomirski
On Mon, Jul 13, 2020 at 4:48 PM Fenghua Yu wrote: > > A #GP fault is generated when ENQCMD instruction is executed without > a valid PASID value programmed in the current thread's PASID MSR. The > #GP fault handler will initialize the MSR if a PASID has been allocated > for this process. Let's ta

Re: [PATCH v6 12/12] x86/traps: Fix up invalid PASID

2020-07-31 Thread Andy Lutomirski
On Mon, Jul 13, 2020 at 4:48 PM Fenghua Yu wrote: > > A #GP fault is generated when ENQCMD instruction is executed without > a valid PASID value programmed in the current thread's PASID MSR. The > #GP fault handler will initialize the MSR if a PASID has been allocated > for this process. > > Decod

Re: [PATCH] drm/amdgpu: Fix regression in adjusting power table/profile

2020-07-31 Thread Matt Coffin
My bisect resulted in the same conclusion, that the problem began with edad8312cbbf9a33c86873fc4093664f150dd5c1. That commit has a LOT of changes, so I'm having problems following what might be relevant, so in case Hawking or Dennis have any insight they could contribute towards letting us know wh

Re: [PATCH] drm/amdgpu: Fix regression in adjusting power table/profile

2020-07-31 Thread Matt Coffin
I actually *just* finished my bisect, and arrived at the same conclusion. The hang appears to be introduced in edad8312cbbf9a33c86873fc4093664f150dd5c1. There are some conflicts with an automatic `git revert`, so I'm picking through the changes now to fully understand what happened and come up wit

Re: [PATCH 08/17] drm/amd/powerplay: add Renoir support for gpu metrics export(V2)

2020-07-31 Thread Nirmoy
Acked-by: Nirmoy Das On 7/31/20 4:43 AM, Evan Quan wrote: Add Renoir gpu metrics export interface. V2: use memcpy to make code more compact Change-Id: Ic83265536eeaa9e458dc395b2be18ea49da4c68a Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/inc/smu_v12

Re: [PATCH 1/2] drm/amdgpu: fix reload KMD hang on KIQ

2020-07-31 Thread Felix Kuehling
In gfx_v10_0_sw_fini the KIQ ring gets freed. Wouldn't that be the right place to stop the KIQ? Otherwise KIQ will hang as soon as someone allocates the memory that was previously used for the KIQ ring buffer and overwrites it with something that's not a valid PM4 packet. Regards,   Felix Am 2020

Re: [PATCH 2/2] drm/amdgpu: introduce a new parameter to configure how many KCQ we want(v5)

2020-07-31 Thread Felix Kuehling
Am 2020-07-31 um 3:51 a.m. schrieb Monk Liu: > what: > the MQD's save and restore of KCQ (kernel compute queue) > cost lots of clocks during world switch which impacts a lot > to multi-VF performance > > how: > introduce a paramter to control the number of KCQ to avoid > performance drop if there i

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-31 Thread Christian König
Am 31.07.20 um 09:10 schrieb Greg Kroah-Hartman: On Fri, Jul 31, 2020 at 08:57:53AM +0200, Christian König wrote: Am 31.07.20 um 08:53 schrieb Greg Kroah-Hartman: On Thu, Jul 30, 2020 at 05:09:07PM -0400, Luben Tuikov wrote: On 2020-07-29 9:49 a.m., Alex Deucher wrote: On Wed, Jul 29, 2020 at

[PATCH 2/2] drm/amdgpu: introduce a new parameter to configure how many KCQ we want(v5)

2020-07-31 Thread Monk Liu
what: the MQD's save and restore of KCQ (kernel compute queue) cost lots of clocks during world switch which impacts a lot to multi-VF performance how: introduce a paramter to control the number of KCQ to avoid performance drop if there is no kernel compute queue needed notes: this paramter only

[PATCH 1/2] drm/amdgpu: fix reload KMD hang on KIQ

2020-07-31 Thread Monk Liu
KIQ will hang if we try below steps: modprobe amdgpu rmmod amdgpu modprobe amdgpu sched_hw_submission=4 the cause is that due to KIQ is always living there even after we unload KMD thus when doing the realod of KMD KIQ will crash upon its register programed with different values with the previous

RE: [PATCH] drm/amdgpu: introduce a new parameter to configure how many KCQ we want(v4)

2020-07-31 Thread Liu, Monk
[AMD Official Use Only - Internal Distribution Only] Please check V5 and see if it looks better I use automatic indentation on those lines _ Monk Liu|GPU Virtualization Team |AMD -Original Message- From: amd-gfx On Behalf Of Liu, Monk Sent: Friday,

RE: [PATCH] drm/amdgpu: introduce a new parameter to configure how many KCQ we want(v4)

2020-07-31 Thread Liu, Monk
[AMD Official Use Only - Internal Distribution Only] Felix I cannot let the indentation look perfect when it goes out from the email , don't know why It looks well in my VIM although _ Monk Liu|GPU Virtualization Team |AMD -Original Message- From:

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-31 Thread Greg Kroah-Hartman
On Fri, Jul 31, 2020 at 08:57:53AM +0200, Christian König wrote: > Am 31.07.20 um 08:53 schrieb Greg Kroah-Hartman: > > On Thu, Jul 30, 2020 at 05:09:07PM -0400, Luben Tuikov wrote: > > > On 2020-07-29 9:49 a.m., Alex Deucher wrote: > > > > On Wed, Jul 29, 2020 at 4:11 AM Christian König > > > > w

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-31 Thread Greg Kroah-Hartman
On Thu, Jul 30, 2020 at 05:09:07PM -0400, Luben Tuikov wrote: > On 2020-07-29 9:49 a.m., Alex Deucher wrote: > > On Wed, Jul 29, 2020 at 4:11 AM Christian König > > wrote: > >> > >> Am 28.07.20 um 21:29 schrieb Peilin Ye: > >>> Compiler leaves a 4-byte hole near the end of `dev_info`, causing > >>