[PATCH] drm/amdgpu: refine create and release logic of hive info

Change to dynamically create and release hive info object, which help driver support more hives in the future. Signed-off-by: Dennis Li diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 8a55b0bc044a..fdfdc2f678c9 100644 --- a/drivers/gpu/

RE: [PATCH 4/4] drm/amdgpu/pm: only hide average power on SI and pre-RENOIR APUs

[AMD Official Use Only - Internal Distribution Only] Series is reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Tuesday, August 18, 2020 3:53 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 4/4] drm/amdgpu/pm: only hide

RE: [PATCH] drm/amd/pm: update driver if version for navy_flounder

[AMD Public Use] Reviewed-by: Tao Zhou > -Original Message- > From: Jiansong Chen > Sent: Tuesday, August 18, 2020 11:01 AM > To: amd-gfx@lists.freedesktop.org > Cc: Feng, Kenneth ; Zhou1, Tao > ; Chen, Jiansong (Simon) > Subject: [PATCH] drm/amd/pm: update driver if version for navy_f

[PATCH] drm/amd/pm: update driver if version for navy_flounder

It's in accordance with pmfw 65.7.0 for navy_flounder. Signed-off-by: Jiansong Chen Change-Id: Iaac4c591f92c9a00891a29757d142c0109dcd676 --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/inc/smu_v11_0.h b/driver

RE: [PATCH] drm/amdgpu: Fix repeatly flr issue

[AMD Official Use Only - Internal Distribution Only] >-Original Message- >From: Das, Nirmoy >Sent: Wednesday, August 12, 2020 8:18 PM >To: Deng, Emily ; amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH] drm/amdgpu: Fix repeatly flr issue > > >On 8/12/20 11:19 AM, Emily.Deng wrote: >> Fr

RE: [PATCH] Revert "drm/amdgpu: disable gfxoff for navy_flounder"

[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kenneth Feng -Original Message- From: Jiansong Chen Sent: Monday, August 17, 2020 10:46 PM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Feng, Kenneth ; Chen, Jiansong (Simon) Subject: [PATCH] Revert "drm/amdgpu:

RE: [PATCH] Revert "drm/amdgpu: disable gfxoff for navy_flounder"

[AMD Public Use] Reviewed-by: Tao Zhou > -Original Message- > From: Jiansong Chen > Sent: Monday, August 17, 2020 10:46 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhou1, Tao ; Feng, Kenneth > ; Chen, Jiansong (Simon) > Subject: [PATCH] Revert "drm/amdgpu: disable gfxoff for navy_flou

Re: [PATCH v2] drm/amdkfd: sparse: Fix warning in reading SDMA counters

Sorry, more bike-shedding. Am 2020-08-17 um 7:58 p.m. schrieb Mukul Joshi: > Add __user annotation to fix related sparse warning while reading > SDMA counters from userland. > > Reported-by: kernel test robot > Signed-off-by: Mukul Joshi > --- > drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manag

[PATCH v2] drm/amdkfd: sparse: Fix warning in reading SDMA counters

Add __user annotation to fix related sparse warning while reading SDMA counters from userland. Reported-by: kernel test robot Signed-off-by: Mukul Joshi --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers

Re: [PATCH] drm/amdkfd: sparse: Fix warning in reading SDMA counters

Am 2020-08-17 um 4:45 p.m. schrieb Mukul Joshi: > Add __user annotation to fix related sparse warning while reading > SDMA counters from userland. > > Reported-by: kernel test robot > Signed-off-by: Mukul Joshi > --- > drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 8 +--- > 1 file

[PATCH] drm/amdkfd: sparse: Fix warning in reading SDMA counters

Add __user annotation to fix related sparse warning while reading SDMA counters from userland. Reported-by: kernel test robot Signed-off-by: Mukul Joshi --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/

Re: [PATCH 1/2] drm/scheduler: Scheduler priority fixes (v2)

On 2020-08-17 9:53 a.m., Christian König wrote: > Am 15.08.20 um 04:48 schrieb Luben Tuikov: >> Remove DRM_SCHED_PRIORITY_LOW, as it was used >> in only one place. >> >> Rename and separate by a line >> DRM_SCHED_PRIORITY_MAX to DRM_SCHED_PRIORITY_COUNT >> as it represents a (total) count of said >

[PATCH 1/4] drm/amdgpu/pm: remove duplicate check

FAMILY_KV is APUs and we already check for APUs. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c index 5fc6a9a13096..f2e70655e8d9 1006

[PATCH 3/4] drm/amdgpu/swsmu: implement power metrics for RENOIR

Grab the data from the SMU metrics table. Signed-off-by: Alex Deucher --- Can someone with a renoir system verify this? .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 21 +++ 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c b/driv

[PATCH 4/4] drm/amdgpu/pm: only hide average power on SI and pre-RENOIR APUs

We can get this on RENOIR and newer via the SMU metrics table. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c index f2e70655e8

[PATCH 2/4] drm/amdgpu/swsmu: implement voltage metrics for RENOIR

Grab the data from the SMU metrics table. Signed-off-by: Alex Deucher --- .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 29 +++ 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c inde

Re: [PATCH] drm/amd/display: Add dsc_to_stream_resource for dcn3

On Mon, Aug 17, 2020 at 3:33 PM Bhawanpreet Lakha wrote: > > Without this, enabling dsc will cause a nullptr > > Reviewed-by: Mikita Lipski > Signed-off-by: Bhawanpreet Lakha Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 1 + > 1 file changed, 1 inser

[PATCH] drm/amd/display: Add dsc_to_stream_resource for dcn3

Without this, enabling dsc will cause a nullptr Reviewed-by: Mikita Lipski Signed-off-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c b/drivers/gpu/drm/amd/

Re: [PATCH v2] drm/amd/display: use correct scale for actual_brightness

On Mon, Aug 17, 2020 at 3:09 AM Alexander Monakov wrote: > > Ping. Patch looks good to me: Reviewed-by: Alex Deucher Nick, unless you have any objections, I'll go ahead and apply it. Alex > > On Tue, 4 Aug 2020, Alexander Monakov wrote: > > > Documentation for sysfs backlight level interface

Re: [PATCH] drm/amdkfd: Initialize SDMA activity counter to 0

Am 2020-08-17 um 1:05 p.m. schrieb Mukul Joshi: > To prevent reporting erroneous SDMA usage, initialize SDMA > activity counter to 0 before using. > > Signed-off-by: Mukul Joshi Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_process.c | 1 + > 1 file changed, 1 insertion(+

[PATCH] drm/amdkfd: Initialize SDMA activity counter to 0

To prevent reporting erroneous SDMA usage, initialize SDMA activity counter to 0 before using. Signed-off-by: Mukul Joshi --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_pr

[PATCH 5.7 125/393] drm/amdgpu: use the unlocked drm_gem_object_put

From: Emil Velikov [ Upstream commit 1a87f67a66de4ad0c0d79fd86b6c5273143387c3 ] The driver does not hold struct_mutex, thus using the locked version of the helper is incorrect. Cc: Alex Deucher Cc: Christian König Cc: amd-gfx@lists.freedesktop.org Fixes: a39414716ca0 ("drm/amdgpu: add indepen

[PATCH 5.8 143/464] drm/amdgpu: use the unlocked drm_gem_object_put

From: Emil Velikov [ Upstream commit 1a87f67a66de4ad0c0d79fd86b6c5273143387c3 ] The driver does not hold struct_mutex, thus using the locked version of the helper is incorrect. Cc: Alex Deucher Cc: Christian König Cc: amd-gfx@lists.freedesktop.org Fixes: a39414716ca0 ("drm/amdgpu: add indepen

Re: [PATCH] drm/dp_mst: Don't return error code when crtc is null

Oh-just noticed this is also missing a CC for sta...@vger.kernel.org. I'll add it before pushing but please make sure to follow the guidelines here when submitting fixes, since otherwise they might not get backported automatically to older kernels: https://www.kernel.org/doc/html/latest/process/st

Re: [PATCH] drm/dp_mst: Don't return error code when crtc is null

Reviewed-by: Lyude Paul I will go ahead and push this to drm-misc-fixes, thanks! On Fri, 2020-08-14 at 13:01 -0400, Bhawanpreet Lakha wrote: > [Why] > In certain cases the crtc can be NULL and returning -EINVAL causes > atomic check to fail when it shouln't. This leads to valid > configurations

Re: [PATCH] Revert "drm/amdgpu: disable gfxoff for navy_flounder"

[AMD Public Use] Acked-by: Alex Deucher From: amd-gfx on behalf of Jiansong Chen Sent: Monday, August 17, 2020 10:45 AM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Feng, Kenneth ; Chen, Jiansong (Simon) Subject: [PATCH] Revert "drm/amdgpu: disable gfx

[PATCH] Revert "drm/amdgpu: disable gfxoff for navy_flounder"

This reverts commit 6a72ad7e387c6fec821c230fda3460f79fc0f877. Newly released sdma fw (51.52) provides a fix for the issue. --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0

Re: [PATCH 1/5] drm/amd/pm: disable/enable deep sleep features on UMD pstate enter/exit

[AMD Public Use] You can probably just squash patches 2-5 into one patch. Either way, series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Monday, August 17, 2020 4:29 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject:

Re: [PATCH 1/5] drm/amd/pm: disable/enable gfx ulv on UMD pstate enter/exit

[AMD Official Use Only - Internal Distribution Only] You can probably just squash patches 2-5 into one patch. Either way, series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Monday, August 17, 2020 3:49 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher,

Re: [PATCH 1/2] drm/scheduler: Scheduler priority fixes (v2)

Am 15.08.20 um 04:48 schrieb Luben Tuikov: Remove DRM_SCHED_PRIORITY_LOW, as it was used in only one place. Rename and separate by a line DRM_SCHED_PRIORITY_MAX to DRM_SCHED_PRIORITY_COUNT as it represents a (total) count of said priorities and it is used as such in loops throughout the code. (0

Re: [PATCH v2] drm/amdgpu: add condition check for trace_amdgpu_cs()

Am 17.08.20 um 12:34 schrieb Kevin Wang: v1: add trace event enabled check to avoid nop loop when submit multi ibs in amdgpu_cs_ioctl() function. v2: add a new wrapper function to trace all amdgpu cs ibs. Signed-off-by: Kevin Wang Reviewed-by: Christian König --- drivers/gpu/drm/amd/amd

[PATCH v2] drm/amdgpu: add condition check for trace_amdgpu_cs()

v1: add trace event enabled check to avoid nop loop when submit multi ibs in amdgpu_cs_ioctl() function. v2: add a new wrapper function to trace all amdgpu cs ibs. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 16 +--- 1 file changed, 13 insertions(+), 3 del

Re: [PATCH] drm/amdgpu: add condition check for trace_amdgpu_cs()

Am 17.08.20 um 11:04 schrieb Kevin Wang: add trace event enabled check to avoid nop loop when submit multi ibs in amdgpu_cs_ioctl() function. Maybe we should change the trace point instead to trace all IBs with just a single call. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu

Re: [PATCH] drm/amdgpu: fix amdgpu_bo_release_notify() comment error

Am 17.08.20 um 09:35 schrieb Kevin Wang: fix amdgpu_bo_release_notify() comment error. Signed-off-by: Kevin Wang Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amd

[PATCH] drm/amdgpu: add condition check for trace_amdgpu_cs()

add trace event enabled check to avoid nop loop when submit multi ibs in amdgpu_cs_ioctl() function. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu

Re: [PATCH] drm/amdgpu: fix amdgpu_bo_release_notify() comment error

Acked-by: Nirmoy Das On 8/17/20 9:35 AM, Kevin Wang wrote: fix amdgpu_bo_release_notify() comment error. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

RE: [PATCH] drm/amdgpu: fix amdgpu_bo_release_notify() comment error

[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Dennis Li -Original Message- From: amd-gfx On Behalf Of Kevin Wang Sent: Monday, August 17, 2020 3:36 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Wang, Kevin(Yang) ; Koenig, Christian Subject: [PATCH] dr

[PATCH 5/5] drm/amd/pm: widely share the logic for deep sleep control

Considering the same logic can be applied to Arcturus, Navi1X and Sienna Cichlid. Change-Id: I9b80956fee5b094ea0e102601add6c02e3429719 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h| 3 ++ .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 35 +-- .../g

[PATCH 3/5] drm/amd/pm: add Arcturus deep sleep control interface

This is needed for UMD pstate switch. Change-Id: I8e753c682c29fe420167b14b23f526ea9b0db42b Signed-off-by: Evan Quan --- .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 34 +++ 1 file changed, 34 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c b/driv

[PATCH 1/5] drm/amd/pm: disable/enable deep sleep features on UMD pstate enter/exit

Add deep sleep disablement/enablement on UMD pstate entering/exiting. Change-Id: I4fbc02bb4a390ab82293a5ff9c91f2a8beb0a3c9 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h | 1 + drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 ++ drivers/gpu/drm/amd/pm/swsmu/smu_internal

[PATCH 2/5] drm/amd/pm: add Navi1x deep sleep control interface

This is needed for UMD pstate switch. Change-Id: Icd5d207359b7b83c1dd689a41fd9b48f537cde9a Signed-off-by: Evan Quan --- .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 34 +++ 1 file changed, 34 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/driver

[PATCH 4/5] drm/amd/pm: add Sienna Cichlid deep sleep control interface

This is needed for UMD pstate switch. Change-Id: I97ee3af60f4a3e4c2f575ce8c8e1a2866ed37f02 Signed-off-by: Evan Quan --- .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 34 +++ 1 file changed, 34 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c

[PATCH 5/5] drm/amd/pm: widely share the logic for gfx ulv control

Considering the same logic can be applied to Arcturus, Navi1X and Sienna Cichlid. Change-Id: I16958d114afbb2433789ca350019fea9b50e1218 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h | 3 +++ drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 13 +

[PATCH 3/5] drm/amd/pm: add Arcturus gfx ulv control interface

This is needed for UMD pstate switch. Change-Id: I40e235add95d6abbf99186112673a411edf2bb39 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c b/drivers

[PATCH 4/5] drm/amd/pm: add Sienna Cichlid gfx ulv control interface

This is needed for UMD pstate switch. Change-Id: I23d68bc291960118c799366cbb3fc89ccb42f98c Signed-off-by: Evan Quan --- .../gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c

[PATCH 1/5] drm/amd/pm: disable/enable gfx ulv on UMD pstate enter/exit

Add gfx ulv disablement/enablement on UMD pstate entering/exiting. Change-Id: Ieb38fdb5975b563f24c0b172fedd01acf99afb10 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h | 1 + drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 ++ drivers/gpu/drm/amd/pm/swsmu/smu_internal.h

[PATCH 2/5] drm/amd/pm: add Navi1x gfx ulv control interface

This is needed for UMD pstate switch. Change-Id: Id14399d3a5e4b24bb8a72a298ec4e96717444741 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu

[PATCH] drm/amdgpu: fix amdgpu_bo_release_notify() comment error

fix amdgpu_bo_release_notify() comment error. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index 3d95b3edb635..

[PATCH] drm/amd/display: should check error using DC_OK

core_link_read_dpcd returns only DC_OK(1) and DC_ERROR_UNEXPECTED(-1), the caller should check error using DC_OK instead of checking against 0 Signed-off-by: Tong Zhang --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v2] drm/amd/display: use correct scale for actual_brightness

Ping. On Tue, 4 Aug 2020, Alexander Monakov wrote: > Documentation for sysfs backlight level interface requires that > values in both 'brightness' and 'actual_brightness' files are > interpreted to be in range from 0 to the value given in the > 'max_brightness' file. > > With amdgpu, max_brightn