This commit introduces a trace mechanism for struct pipe_ctx by adding a
middle layer struct in the amdgpu_dm_trace.h for capturing the most
important data from struct pipe_ctx and showing its data via tracepoint.
This tracepoint was added to dc.c and dcn10_hw_sequencer, however, it
can be added
amdgpu_dc_rreg and amdgpu_dc_wreg are very similar, for this reason,
this commits abstract these two events by using DECLARE_EVENT_CLASS and
create an instance of it for each one of these events.
Signed-off-by: Rodrigo Siqueira
---
.../amd/display/amdgpu_dm/amdgpu_dm_trace.h | 55
Debug amdgpu_dm could be a complicated task, therefore, this commit adds
tracepoints in some convenient functions such as plane and connector
check inside amdgpu_dm.
Co-developed-by: Nicholas Kazlauskas
Signed-off-by: Nicholas Kazlauskas
Signed-off-by: Rodrigo Siqueira
---
On 2020-09-09 5:13 a.m., Christian König wrote:
> Am 09.09.20 um 10:56 schrieb Liu ChengZhe:
>> In function flr_work, do gpu recovery when no job is running
>> instead of when some job is running. Because if there is job
^a
>> in list,
On 2020-09-09 10:28 a.m., Aurabindo Pillai wrote:
[Why]
Since there is no need for accessing crtc state in the interrupt
handler, interrupts need not be disabled well in advance, and
can be moved to commit_tail where it should be.
Signed-off-by: Aurabindo Pillai
This patch is fine in idea,
On 2020-09-09 10:28 a.m., Aurabindo Pillai wrote:
[Why]
Currently commit_tail holds global locks and wait for dependencies which is
against the DRM API contracts. Inorder to fix this, IRQ handler should be able
to run without having to access crtc state. Required parameters are copied over
so
On 2020-09-09 10:28 a.m., Aurabindo Pillai wrote:
[Why]
To refactor DM IRQ management, all fields used by IRQ is best moved
to a separate struct so that main amdgpu_crtc struct need not be changed
Location of the new struct shall be in DM
Signed-off-by: Aurabindo Pillai
Reviewed-by: Nicholas
Interrupts are disabled too early in DM's atomic_commit() which can
cause issues in certain situations with non blocking commits timing
out on flip_done interrupt. The early disabling of interrupts were
necessary due to interrupts accessing crtc state directly. This
refactor removes direct access
[Why]
To refactor DM IRQ management, all fields used by IRQ is best moved
to a separate struct so that main amdgpu_crtc struct need not be changed
Location of the new struct shall be in DM
Signed-off-by: Aurabindo Pillai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 4 ++-
[Why]
Currently commit_tail holds global locks and wait for dependencies which is
against the DRM API contracts. Inorder to fix this, IRQ handler should be able
to run without having to access crtc state. Required parameters are copied over
so that they can be directly accessed from the interrupt
[Why]
Since there is no need for accessing crtc state in the interrupt
handler, interrupts need not be disabled well in advance, and
can be moved to commit_tail where it should be.
Signed-off-by: Aurabindo Pillai
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 38 +--
1 file
Acked-by: Christian König for the series.
Am 09.09.20 um 15:07 schrieb Zheng Bin:
Zheng Bin (8):
drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v9_0.c
drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v10_0.c
drm/amd/amdgpu: fix comparison pointer to bool
[AMD Public Use]
+if (!adev->psp.ras.ras_initialized)
+ return -EINVAL;
+
if (!con)
return -EINVAL;
I suggest squashing the new check into below one.
Regards,
Guchun
From: amd-gfx On Behalf Of Clements,
John
Sent:
Turns out this breaks a lot of different hardware.
This reverts commit 522ff3a8b6d73a31084b4b087b458f7fa0ac1e14.
Signed-off-by: Christian König
---
drivers/gpu/drm/radeon/radeon_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Am 09.09.20 um 11:39 schrieb Tiezhu Yang:
On 09/09/2020 12:21 PM, Huacai Chen wrote:
Though RADEON_GEM_GTT_WC is initially used for GTT, but this flag is
bound to drm_arch_can_wc_memory(), and if arch doesn't support WC, then
VRAM should not use WC.
+cc RADEON and AMDGPU DRM DRIVERS
[AMD Public Use]
The patch is
Reviewed-by: Hawking Zhang
BTW, please use the git-send mail for code review going forward, instead of
attached the patch.
Regards,
Hawking
From: Clements, John
Sent: Wednesday, September 9, 2020 17:24
To: amd-gfx list ; Zhang, Hawking
Subject: [PATCH]
In function flr_work, we should do gpu recovery when no job
is running. Fix the logic by inverting it.
v2: modify the description
Signed-off-by: Liu ChengZhe
---
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c | 2 +-
2 files changed, 3 insertions(+), 2
[AMD Official Use Only - Internal Distribution Only]
0001-drm-amdgpu-Update-RAS-init-handling.patch
Description: 0001-drm-amdgpu-Update-RAS-init-handling.patch
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
Yes, that is an already known issue.
We are most likely going to revert the patch ASAP.
Christian.
Am 08.09.20 um 18:27 schrieb Mikael Pettersson:
Starting with linux-5.9-rc4, the Dell monitor on my desktop PC goes
black during boot
when the kernel activates the framebuffer console, except
Am 09.09.20 um 10:56 schrieb Liu ChengZhe:
In function flr_work, do gpu recovery when no job is running
instead of when some job is running. Because if there is job
in list, amdgpu_job_timedout will do the gpu recovery.
Maybe write something like "Fix the logic by inverting it".
With that the
In function flr_work, do gpu recovery when no job is running
instead of when some job is running. Because if there is job
in list, amdgpu_job_timedout will do the gpu recovery.
Signed-off-by: Liu ChengZhe
---
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c |
Remove duplicate header which is included twice.
Signed-off-by: Chen Zhou
---
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c
b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c
index
Though RADEON_GEM_GTT_WC is initially used for GTT, but this flag is
bound to drm_arch_can_wc_memory(), and if arch doesn't support WC, then
VRAM should not use WC.
Signed-off-by: Huacai Chen
---
drivers/gpu/drm/radeon/radeon_object.c | 14 ++
1 file changed, 10 insertions(+), 4
Though AMDGPU_GEM_CREATE_CPU_GTT_USWC is initially used for GTT, but
this flag is bound to drm_arch_can_wc_memory(), and if arch doesn't
support WC, then VRAM should not use WC.
Signed-off-by: Huacai Chen
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 --
1 file changed, 4
Starting with linux-5.9-rc4, the Dell monitor on my desktop PC goes
black during boot
when the kernel activates the framebuffer console, except for this
error message shown
in the center of the screen:
"Dell U2412M
The current input timing is not supported by the monitor display. Please
change
From: Randy Dunlap
Fix spellos of "function" in drivers/gpu/drm/amd/display/.
Signed-off-by: Randy Dunlap
Cc: Harry Wentland
Cc: Leo Li
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.h |2 +-
On Tue, 8 Sep 2020 at 18:41, Hans Verkuil wrote:
>
> On 01/09/2020 08:22, Sam McNally wrote:
> > From: Hans Verkuil
> >
> > Signed-off-by: Hans Verkuil
> > [sa...@chromium.org:
> > - rebased
> > - removed polling-related changes
> > - moved the calls to drm_dp_cec_(un)set_edid() into the
On Wed, 2 Sep 2020 at 04:12, Lyude Paul wrote:
>
> Super minor nitpicks:
>
> On Tue, 2020-09-01 at 16:22 +1000, Sam McNally wrote:
> > From: Hans Verkuil
> >
> > Signed-off-by: Hans Verkuil
> > [sa...@chromium.org:
> > - rebased
> > - removed polling-related changes
> > - moved the calls to
28 matches
Mail list logo
