[PATCH 3/3] drm/amd/amdkfd: Surface files in Sysfs to allow users to get number of compute units that are in use.

2020-09-25 Thread Ramesh Errabolu
[Why] Allow user to know how many compute units (CU) are in use at any given moment. [How] Surface files in Sysfs that allow user to determine the number of compute units that are in use for a given process. One Sysfs file is used per device. Signed-off-by: Ramesh Errabolu ---

[PATCH 2/3] drm/amd/amdgpu: Define and implement a function that collects number of waves that are in flight.

2020-09-25 Thread Ramesh Errabolu
[Why] Allow user to know how many compute units (CU) are in use at any given moment. [How] Read registers of SQ that give number of waves that are in flight of various queues. Use this information to determine number of CU's in use. Signed-off-by: Ramesh Errabolu ---

[PATCH 1/3] drm/amd/amdgpu: Prepare implementation to support reporting of CU usage

2020-09-25 Thread Ramesh Errabolu
[Why] Allow user to know number of compute units (CU) that are in use at any given moment. [How] Read registers of SQ that give number of waves that are in flight of various queues. Use this information to determine number of CU's in use. Signed-off-by: Ramesh Errabolu ---

Re: [PATCH] drm/amd/pm: fix screen flicker seen on Navi14 with 2*4K monitors

2020-09-25 Thread Alex Deucher
On Fri, Sep 25, 2020 at 5:13 PM Matt Coffin wrote: > > Thanks for the quick reply, > > Would it make sense, since there seem to be issues with both > before/after initialization, to (temporarily?) add a module parameter > for users so that they can switch between these two behaviors easily >

Re: [PATCH] drm/amdgpu/dc: Pixel encoding DRM property and module parameter

2020-09-25 Thread Alex Deucher
On Tue, Sep 22, 2020 at 4:51 PM James Ettle wrote: > > On 22/09/2020 21:33, Alex Deucher wrote: > >> +/** > >> + * DOC: pixel_encoding (string) > >> + * Specify the initial pixel encoding used by a connector. > >> + */ > >> +static char amdgpu_pixel_encoding[MAX_INPUT]; > >>

Re: [PATCH] drm/amd/pm: fix screen flicker seen on Navi14 with 2*4K monitors

2020-09-25 Thread Matt Coffin
Thanks for the quick reply, Would it make sense, since there seem to be issues with both before/after initialization, to (temporarily?) add a module parameter for users so that they can switch between these two behaviors easily based on what works for them? If so, if you can toss me a hint at

Re: [PATCH] drm/amd/pm: fix screen flicker seen on Navi14 with 2*4K monitors

2020-09-25 Thread Alex Deucher
On Fri, Sep 25, 2020 at 5:05 PM Matt Coffin wrote: > > Sorry to bother you guys, but trying to learn about some of these > things, and I'm tracking the issue this relates to pretty closely on GitLab. > > What does DAL stand for in this context? DAL is the name of the display team within AMD.

Re: [PATCH] drm/amd/pm: fix screen flicker seen on Navi14 with 2*4K monitors

2020-09-25 Thread Matt Coffin
Sorry to bother you guys, but trying to learn about some of these things, and I'm tracking the issue this relates to pretty closely on GitLab. What does DAL stand for in this context? Thanks in advance for the help, Matt On 9/24/20 9:38 PM, Quan, Evan wrote: > [AMD Official Use Only - Internal

[PATCH 35/45] drm/amdgpu: add TOC firmware definition

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch is to add TOC firmware definition on uapi. Signed-off-by: Huang Rui Acked-by: Alex Deucher Signed-off-by: Alex Deucher --- include/uapi/drm/amdgpu_drm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/drm/amdgpu_drm.h

[PATCH 33/45] drm/amd/powerplay: add vangogh ppt into swSMU

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch is to add vangogh ppt funcions into swSMU block. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 4 drivers/gpu/drm/amd/pm/swsmu/smu11/Makefile | 1 + 2 files changed, 5

[PATCH 37/45] drm/amdgpu: enable psp support for vangogh

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch is to enable psp support for vangogh Signed-off-by: Huang Rui Acked-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 3 +-- drivers/gpu/drm/amd/amdgpu/nv.c | 2

[PATCH 41/45] drm/amdgpu: add gfx power gating for gfx10

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch is to add power gating handle for gfx10. Signed-off-by: Huang Rui Acked-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 27 ++ 1 file changed, 27 insertions(+) diff --git

[PATCH 42/45] drm/amdgpu: enable gfx clock gating and power gating for vangogh

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch is to enable the gfx cg and pg for vangogh. Signed-off-by: Huang Rui Acked-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c

[PATCH 39/45] drm/amdgpu: IP discovery table is not ready yet for VG

2020-09-25 Thread Alex Deucher
Fallback to legacy path for now. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index 568e33b7fda8..4bd2e2f35fa4 100644 ---

[PATCH 44/45] drm/amd/display: Add dcn3.01 support to DM

2020-09-25 Thread Alex Deucher
From: Roman Li Update dm for vangogh support. Signed-off-by: Roman Li Signed-off-by: Alex Deucher --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26 +++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH 29/45] drm/amdgpu/powerplay: add smu v11.5 smc header for vangogh

2020-09-25 Thread Alex Deucher
From: Xiaojian Du This patch is to add smu v11.5 smc header for vangogh. Signed-off-by: Xiaojian Du Reviewed-by: Kevin Wang Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/inc/smu_v11_5_ppsmc.h | 86 1 file changed, 86 insertions(+)

[PATCH 30/45] drm/amdgpu/powerplay: add vangogh asic name in smu v11 (v2)

2020-09-25 Thread Alex Deucher
From: Xiaojian Du This patch is to add vangogh asic name in smu v11. v2: drop smu firmware name (N/A for VG) Signed-off-by: Xiaojian Du Reviewed-by: Kevin Wang Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h | 1 +

[PATCH 32/45] drm/amd/powerplay: partially enable swsmu for vangogh

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch is to partially enable swSMU for vangogh for the moment. Signed-off-by: Huang Rui Acked-by: Alex Deucher Reviewed-by: Aaron Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 34/45] drm/amdgpu: add smu ip block for vangogh

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch is to add ip block for vangogh. Signed-off-by: Huang Rui Acked-by: Alex Deucher Reviewed-by: Aaron Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c

[PATCH 45/45] drm/amdgpu: add van gogh pci id

2020-09-25 Thread Alex Deucher
From: Huang Rui Add Van Gogh PCI id support. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

[PATCH 31/45] drm/amdgpu/powerplay: add smu initialize funcitons for vangogh (v2)

2020-09-25 Thread Alex Deucher
From: Xiaojian Du This patch is to add smu initialize functions for vangogh. v2: squash in updates Signed-off-by: Xiaojian Du Reviewed-by: Kevin Wang Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 355 ++

[PATCH 40/45] drm/amdgpu/mmhub2.3: print client id string for mmhub

2020-09-25 Thread Alex Deucher
Print the name of the client rather than the number. This makes it easier to debug what block is causing the fault. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c | 49 ++--- 1 file changed, 43 insertions(+), 6 deletions(-) diff --git

[PATCH 36/45] drm/amdgpu: add TOC firmware support for apu (v2)

2020-09-25 Thread Alex Deucher
From: Huang Rui APU needs load toc firmware for gfx10 series on psp front door loading. v2: rebase against latest code Signed-off-by: Huang Rui Acked-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 11

[PATCH 38/45] drm/amdgpu: disable gfxoff on vangogh for the moment (v2)

2020-09-25 Thread Alex Deucher
From: Huang Rui GFXOFF will be enabled once it's verified on real asic. v2: move check into gfx10 module. Signed-off-by: Huang Rui Reviewed-by: Aaron Liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 07/45] drm/amdgpu: skip sdma1 in nv_allowed_read_registers list for van gogh (v2)

2020-09-25 Thread Alex Deucher
From: Huang Rui Van gogh only has one sdma. v2: use num_instances rather than APU flag Signed-off-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c

[PATCH 13/45] drm/amdgpu: get the correct vram type for van gogh

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch is to get the correct vram type from atombios for van gogh. Signed-off-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 1 + 2 files changed, 5 insertions(+)

[PATCH 26/45] drm/amdgpu/powerplay: add new smu messages and feature masks for vangogh (v2)

2020-09-25 Thread Alex Deucher
From: Xiaojian Du This patch is to add new smu messages and feature masks for vangogh. v2: squash in updates and typo fixes Signed-off-by: Xiaojian Du Reviewed-by: Kevin Wang Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/inc/smu_types.h | 53

[PATCH 27/45] drm/admgpu/powerplay: add smu v11.5 driver interface header for vangogh

2020-09-25 Thread Alex Deucher
From: Xiaojian Du This patch is to add smu v11.5 driver interface header for vangogh. Signed-off-by: Xiaojian Du Reviewed-by: Kevin Wang Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- .../drm/amd/pm/inc/smu11_driver_if_vangogh.h | 239 ++ 1 file changed, 239

[PATCH 23/45] drm/amdgpu: enable vcn3.0 for van gogh

2020-09-25 Thread Alex Deucher
From: Thong Thai Same as other VCN 3.0 asics. Signed-off-by: Thong Thai Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 8 drivers/gpu/drm/amd/amdgpu/nv.c | 2 ++ 2 files changed, 10 insertions(+) diff --git

[PATCH 22/45] drm/amdgpu: add mmhub v2.3 for vangogh (v4)

2020-09-25 Thread Alex Deucher
From: Huang Rui There are too many register offset mismatch between mmhub v2.0 and v2.3. E.X: mmMM_ATC_L2_MISC_CG: 0x064a(v2.0) 0x06cd(v2.3) mmMMVM_L2_PROTECTION_FAULT_CNTL: 0x0688(v2.0) 0x0708(v2.3) mmMMVM_CONTEXT0_PAGE_TABLE_BASE_ADDR_LO32: 0x072b(v2.0) 0x0940(v2.3)

[PATCH 15/45] drm/amdgpu: set fw load type for van gogh

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch sets fw load type as direct for van gogh for the moment. Will switch to psp when psp is ready. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH 24/45] drm/amdgpu: add pcie port indirect read and write on nv

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch is to add pcie port indirect read/write callback for nv series. They will be used for new asic. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h | 2 ++ drivers/gpu/drm/amd/amdgpu/nv.c

[PATCH 21/45] drm/amdkfd: add Van Gogh KFD support

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch is to add GFX10 based APU Van Gogh KFD support. We will treat Van Gogh as "dgpu" (bypass IOMMU v2). Signed-off-by: Huang Rui Acked-by: Alex Deucher Reviewed-by: Yong Zhao Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 5 +

[PATCH 05/45] drm/amdgpu: add vangogh_reg_base_init function for van gogh

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch adds vangogh_reg_base_init function to init the register base for van gogh. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile |2 +- drivers/gpu/drm/amd/amdgpu/nv.h |

[PATCH 11/45] drm/amdgpu: update new memory types in atomfirmware header

2020-09-25 Thread Alex Deucher
From: Huang Rui Add new nemory types in atomfirmware header. Signed-off-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/include/atomfirmware.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/include/atomfirmware.h

[PATCH 14/45] drm/amdgpu: add gmc v10 supports for van gogh (v3)

2020-09-25 Thread Alex Deucher
From: Huang Rui Add gfx memory controller support for van gogh. v2: don't use dynamic invalidate eng allocation for van gogh. v3: squash in other fixes Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 33

[PATCH 08/45] drm/amdgpu: add van gogh support for ih block

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch adds the support for van gogh ih block. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c

[PATCH 28/45] drm/amdgpu/powerplay: add smu v11.5 firmware header for vangogh (v2)

2020-09-25 Thread Alex Deucher
From: Xiaojian Du This patch is to add smu v11.5 firmware header for vangogh v2: squash in updates Signed-off-by: Xiaojian Du Reviewed-by: Kevin Wang Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/inc/smu_v11_5_pmfw.h | 120 1 file

[PATCH 10/45] drm/amdgpu: add uapi to define van gogh memory type

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch adds van gogh memory type as DDR5. Signed-off-by: Huang Rui Signed-off-by: Alex Deucher --- include/uapi/drm/amdgpu_drm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h index

[PATCH 09/45] drm/amdgpu: use gpu virtual address for interrupt packet write space for vangogh

2020-09-25 Thread Alex Deucher
From: Huang Rui The interrupts are not stable while uses guest physical address (GPA) for interrupt packet write space even on direct loading case. Signed-off-by: Huang Rui Acked-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 5 - 1 file

[PATCH 19/45] drm/amdgpu: add sdma support for van gogh

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch adds the sdma v5.2 support for van gogh. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH 25/45] drm/amdgpu: add nbio v7.2 for vangogh (v2)

2020-09-25 Thread Alex Deucher
From: Huang Rui VanGogh uses nbio v7.2, and a couple of offsets are changed since nbio v2.3 for navi series, so add new nbio v7.2 block. v2: squash in fix for sdma and vcn instances Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher ---

[PATCH 04/45] drm/amdgpu: add van gogh support for gpu_info and ip block setting

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch adds van gogh support for gpu_info firmware and ip block setting. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff

[PATCH 06/45] drm/amdgpu: add nv common ip block support for van gogh

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch adds common ip support for van gogh. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c

[PATCH 20/45] drm/amdgpu: set ip blocks for van gogh

2020-09-25 Thread Alex Deucher
From: Huang Rui Enable ip blocks for van gogh. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c

[PATCH 00/45] Add support for vangoh

2020-09-25 Thread Alex Deucher
This patch set adds initial support for vangoh, a new GPU from AMD. I did not send out the register header change due to size. The full patch set is available in git here: https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm-next-vangogh Alex Deucher (3): drm/amdgpu/gfx10: add

[PATCH 12/45] drm/amdgpu/atomfirmware: Add edp and integrated info v2.1 tables

2020-09-25 Thread Alex Deucher
From: Roman Li Required for vangogh. Signed-off-by: Roman Li Reviewed-by: Alex Deucher Reviewed-by: Harry Wentland Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/include/atomfirmware.h | 62 +- 1 file changed, 61 insertions(+), 1 deletion(-) diff --git

[PATCH 16/45] drm/amdgpu: add gfx support for van gogh (v2)

2020-09-25 Thread Alex Deucher
From: Huang Rui Add van gogh checks to gfx10 code. v2: squash in fixes Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 29 +- 1 file changed, 28 insertions(+), 1 deletion(-) mode change

[PATCH 18/45] drm/amdgpu/gfx10: add updated register offsets for VGH

2020-09-25 Thread Alex Deucher
Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c index 6999228cd6c0..83183541865f 100755 ---

[PATCH 03/45] drm/amdgpu: add uapi to define van gogh series

2020-09-25 Thread Alex Deucher
From: Huang Rui Add a flag to define van gogh series. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- include/uapi/drm/amdgpu_drm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h index

[PATCH 17/45] drm/amdgpu: add gfx golden settings for vangogh (v3)

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch is to add gfx golden settings for vangogh post si. v2: squash in updates v3: fix SPI register offset Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 36 +- 1 file

[PATCH 02/45] drm/amdgpu: add van gogh asic_type enum (v2)

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch adds van gogh to amd_asic_type enum and amdgpu_asic_name[]. v2: add missing comma Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + include/drm/amd_asic_type.h| 1 +

Re: [PATCH] drm/amdgpu: fix a warning in amdgpu_ras.c (v2)

2020-09-25 Thread Nirmoy
Acked-by: Nirmoy Das On 9/25/20 9:23 PM, Alex Deucher wrote: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value of ‘sysfs_create_group’, declared with attribute warn_unused_result

Re: [PATCH] drm/amdgpu: fix a warning in amdgpu_ras.c (v2)

2020-09-25 Thread Luben Tuikov
Reviewed-by: Luben Tuikov That's what I had in mind. No error--let the system survive as much as it can. Regards, Luben On 2020-09-25 15:23, Alex Deucher wrote: > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’: > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2:

Re: [PATCH] drm/amdgpu: fix a warning in amdgpu_ras.c

2020-09-25 Thread Luben Tuikov
On 2020-09-25 15:01, Nirmoy wrote: > > On 9/25/20 7:36 PM, Luben Tuikov wrote: >> On 2020-09-25 11:00, Nirmoy wrote: >>> Acked-by: Nirmoy Das >>> >>> On 9/25/20 4:31 PM, Alex Deucher wrote: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’:

[PATCH] drm/amdgpu: fix a warning in amdgpu_ras.c (v2)

2020-09-25 Thread Alex Deucher
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value of ‘sysfs_create_group’, declared with attribute warn_unused_result [-Wunused-result] 1284 | sysfs_create_group(>dev->kobj, ); |

Re: [PATCH] drm/amdgpu: fix a warning in amdgpu_ras.c

2020-09-25 Thread Nirmoy
On 9/25/20 7:36 PM, Luben Tuikov wrote: On 2020-09-25 11:00, Nirmoy wrote: Acked-by: Nirmoy Das On 9/25/20 4:31 PM, Alex Deucher wrote: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value

RE: [PATCH 7/9] drm/amd/display: Revert check for flip pending before locking pipes

2020-09-25 Thread Cyr, Aric
[AMD Official Use Only - Internal Distribution Only] It's already un-reverted in latest. They could be squashed IMO. -Original Message- From: Michel Dänzer Sent: Friday, September 25, 2020 11:53 To: Siqueira, Rodrigo ; amd-gfx@lists.freedesktop.org Cc: Cyr, Aric ; Brol, Eryk ; Li, Sun

Re: [PATCH] drm/amdgpu: fix a warning in amdgpu_ras.c

2020-09-25 Thread Luben Tuikov
On 2020-09-25 11:00, Nirmoy wrote: > Acked-by: Nirmoy Das > > On 9/25/20 4:31 PM, Alex Deucher wrote: >> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’: >> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return >> value of ‘sysfs_create_group’,

Re: [PATCH 7/9] drm/amd/display: Revert check for flip pending before locking pipes

2020-09-25 Thread Michel Dänzer
On 2020-09-25 4:54 p.m., Rodrigo Siqueira wrote: From: Aric Cyr This reverts commit e82d8eae9e81af243256f70bec593baed50b0bdb. Every revert should explain in the commit log why the change is being reverted. (Your future selves might thank you for that someday :) -- Earthling Michel Dänzer

Re: CONFIG_AMDGPU triggers full rebuild

2020-09-25 Thread Thomas Zimmermann
Hi Christian Am 25.09.20 um 16:54 schrieb Christian König: > Maybe MMU notifiers? But honestly I don't know for sure. I checked. In my current config MMU_NOTIFIERS is y and DRM_AMDGPU is n. So it shouldn't have triggered the rebuilds, I guess. Anyway, thanks for trying to help. Best regards

Re: [PATCH] drm/amdgpu: fix a warning in amdgpu_ras.c

2020-09-25 Thread Nirmoy
Acked-by: Nirmoy Das On 9/25/20 4:31 PM, Alex Deucher wrote: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value of ‘sysfs_create_group’, declared with attribute warn_unused_result

[PATCH 0/9] DC Patches September 25, 2020

2020-09-25 Thread Rodrigo Siqueira
This DC patchset brings improvements in multiple areas. In summary, we highlight: * P-state refinements; * Improvements on DSC * Updates on NV1x Best Regards Alvin Lee (1): drm/amd/display: Update NV1x SR latency values Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.35 Aric

[PATCH 7/9] drm/amd/display: Revert check for flip pending before locking pipes

2020-09-25 Thread Rodrigo Siqueira
From: Aric Cyr This reverts commit e82d8eae9e81af243256f70bec593baed50b0bdb. Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc.c | 11 +-- .../drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c| 12

[PATCH 8/9] drm/amd/display: [FW Promotion] Release 0.0.35

2020-09-25 Thread Rodrigo Siqueira
From: Anthony Koo [Header Changes] - Definition for retaining ABM settings during disable - Addition of some new AUX interface definitions - Addition of some outbox definitions Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Rodrigo Siqueira ---

[PATCH 5/9] drm/amd/display: Calc DLG from dummy p-state if full p-state unsupported

2020-09-25 Thread Rodrigo Siqueira
From: Joshua Aberback [Why] Currently, when full p-state changes are not supported, DLG parameters are calculated for no p-state support at all. However, we are required to always support dummy p-state changes, so we should instead calculate DLG based on dummy p-state latency when full p-state

[PATCH 2/9] drm/amd/display: Add dp_set_dsc_pps_info_packet to virtual stream encoder

2020-09-25 Thread Rodrigo Siqueira
From: Eric Bernstein Signed-off-by: Eric Bernstein Reviewed-by: Dmytro Laktyushkin Acked-by: Rodrigo Siqueira --- .../drm/amd/display/dc/core/dc_link_hwss.c| 21 ++- .../dc/virtual/virtual_stream_encoder.c | 7 +++ 2 files changed, 18 insertions(+), 10

[PATCH 6/9] drm/amd/display: Add debug param to force dio disable

2020-09-25 Thread Rodrigo Siqueira
From: Wesley Chalmers [WHY] At the moment, some tests are failing because cur_link_settings is invalid. As a workaround, add an option to force dio disable. Signed-off-by: Wesley Chalmers Reviewed-by: Martin Leung Acked-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc.c | 2

[PATCH 1/9] drm/amd/display: Update NV1x SR latency values

2020-09-25 Thread Rodrigo Siqueira
From: Alvin Lee [Why] HW team measurement requires updating values [How] Update bounding box values Signed-off-by: Alvin Lee Reviewed-by: Jun Lei Acked-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: CONFIG_AMDGPU triggers full rebuild

2020-09-25 Thread Christian König
Maybe MMU notifiers? But honestly I don't know for sure. Christian. Am 25.09.20 um 16:29 schrieb Thomas Zimmermann: Hi, whenever I change the option CONFIG_AMDGPU, I have to rebuild the whole kernel. I guess it auto-selects some architecture-specific feature. That full rebuild might be

[PATCH 3/9] drm/amd/display: Ensure all debug bits are passed to fw

2020-09-25 Thread Rodrigo Siqueira
From: Wyatt Wood [Why] Some debug bits are not being copied from driver to fw. [How] Copy debug bits properly. Signed-off-by: Wyatt Wood Reviewed-by: Anthony Koo Acked-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 9/9] drm/amd/display: disable stream if pixel clock changed with link active

2020-09-25 Thread Rodrigo Siqueira
From: Chiawen Huang [Why] Vbios uses preferred timing to turn on edp but OS could use other timing. If change pixel clock when link active, there is unexpected garbage on monitor. [How] Once pixel clock changed, the driver needs to disable stream. Signed-off-by: Chiawen Huang Reviewed-by:

[PATCH 4/9] drm/amd/display: disable stream if pixel clock changed with link active

2020-09-25 Thread Rodrigo Siqueira
From: Chiawen Huang [Why] Vbios uses preferred timing to turn on edp but OS could use other timing. If change pixel clock when link active, there is unexpected garbage on monitor. [How] Once pixel clock changed, the driver needs to disable stream. Signed-off-by: Chiawen Huang Reviewed-by:

[PATCH] drm/amdgpu: fix a warning in amdgpu_ras.c

2020-09-25 Thread Alex Deucher
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value of ‘sysfs_create_group’, declared with attribute warn_unused_result [-Wunused-result] 1284 | sysfs_create_group(>dev->kobj, ); |

CONFIG_AMDGPU triggers full rebuild

2020-09-25 Thread Thomas Zimmermann
Hi, whenever I change the option CONFIG_AMDGPU, I have to rebuild the whole kernel. I guess it auto-selects some architecture-specific feature. That full rebuild might be avoidable if I could enable that feature permanently. Any ideas what this could be and how to avoid the full rebuilt? Best

Re: amd-staging-drm-next has a compilation issue

2020-09-25 Thread Rodrigo Siqueira
Thanks Alex, I already tested the patch and everything looks fine from the compilation perspective. Best Regards On 09/25, Alex Deucher wrote: >

Re: [PATCH] drm/amdgpu/virt: fix the build

2020-09-25 Thread Rodrigo Siqueira
Tested-by: Rodrigo Siqueira On 09/24, Alex Deucher wrote: > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c: In function > ‘amdgpu_virt_init_data_exchange’: > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:586:10: error: ‘struct > amdgpu_device’ has no member named ‘fw_vram_usage’ > 586 | if

Re: amd-staging-drm-next has a compilation issue

2020-09-25 Thread Alex Deucher
https://patchwork.freedesktop.org/patch/392192/ Alex On Fri, Sep 25, 2020 at 9:55 AM Rodrigo Siqueira wrote: > > Hi, > > When I tried to build the latest code from amd-staging-drm-next, I got > the following build failure: > > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c: In function >

amd-staging-drm-next has a compilation issue

2020-09-25 Thread Rodrigo Siqueira
Hi, When I tried to build the latest code from amd-staging-drm-next, I got the following build failure: drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c: In function ‘amdgpu_virt_init_data_exchange’: drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:586:10: error: ‘struct amdgpu_device’ has no member named

RE: [PATCH] amdgpu/drm: cleanup navi10 ih logic about older ASIC

2020-09-25 Thread Zhang, Hawking
[AMD Public Use] Hi Likun, Let's take a step back to check with Alex S why he add the ASIC type check here. I'm under impression there was a change to use navi10_ih block for arcturus, but haven't followed up closely yet. Regards, Hawking -Original Message- From: Gao, Likun Sent:

[PATCH] amdgpu/drm: cleanup navi10 ih logic about older ASIC

2020-09-25 Thread Likun Gao
From: Likun Gao The ASIC which is older than navi10 will not call into navi10_ih related function, so cleanup the related code path. Signed-off-by: Likun Gao Change-Id: Idf73b73f1f4f19031260c220798e5fffbb2cecd2 --- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 105 +++-- 1 file

Re: [PATCH v3 00/22] Convert all remaining drivers to GEM object functions

2020-09-25 Thread Thomas Zimmermann
Hi Am 23.09.20 um 16:33 schrieb Christian König: > Feel free to add an Acked-by: Christian König > to all patches which I haven't explicitly reviewed. Done, thanks. > > I would say we should just push this to drm-misc-next now. It's merged now. Best regards Thomas > > Thanks for the nice

RE: [PATCH] drm/amdgpu/virt: fix the build

2020-09-25 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Reviewed-and-tested-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, September 25, 2020 3:32 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Bokun Subject: [PATCH]