[PATCH] drm/amd/display: [FIX] Compilation error

2020-10-02 Thread Qingqing Zhuo
[Why] ifdef mismatch. [How] Update to the correct flag. Signed-off-by: Qingqing Zhuo Cc: --- drivers/gpu/drm/amd/display/dc/dce/dce_abm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h b/drivers/gpu/drm/amd/display/dc/dce/dce_a

[PATCH] drm/amd/display: [FIX] Compilation error

2020-10-02 Thread Qingqing Zhuo
[Why] ifdef mismatch. [How] Update to the correct flag. Signed-off-by: Qingqing Zhuo Cc: --- drivers/gpu/drm/amd/display/dc/dce/dce_abm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_abm.h b/drivers/gpu/drm/amd/display/dc/dce/dce_a

RE: [PATCH 3/3] drm/amdgpu: add xgmi perfmons for arcturus

2020-10-02 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] This series Acked-by: Harish Kasiviswanathan -Original Message- From: Kim, Jonathan Sent: Friday, October 2, 2020 4:19 PM To: amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish ; Kim, Jonathan Subject: [PATCH 3/3] drm/amdgpu

[PATCH 2/3] drm/amdgpu: add per device user friendly xgmi events for vega20

2020-10-02 Thread Jonathan Kim
Non-outbound data metrics are non useful so mark them as legacy. Bucket new perf counters into device and not device ip. Bind events to chip instead of IP. Report available event counters and not number of hw counter banks. Move DF public macros to private since not needed outside of IP version. v

[PATCH 3/3] drm/amdgpu: add xgmi perfmons for arcturus

2020-10-02 Thread Jonathan Kim
Add xgmi perfmons for Arcturus. Signed-off-by: Jonathan Kim v4: Align with patch 2 with struct improvements v3: Align with patch 2 streamlining perf types versus event config types. v2: Resend for re-review with alignment for v3 in patch 2. --- drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 49 +

[PATCH 1/3] drm/amdgpu: fix xgmi perfmon a-b-a problem

2020-10-02 Thread Jonathan Kim
Mapping hw counters per event config will cause ABA problems so map per event instead. v2: Discontinue starting perf counters if add fails. Make it clear what's happening with pmc_start. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_df.h | 6 +- drivers/gpu/drm/amd/amdgp

Re: [PATCH] PCI/ACPI: Whitelist hotplug ports for D3 if power managed by ACPI

2020-10-02 Thread Michal Rostecki
Lukas Wunner writes: > Recent laptops with dual AMD GPUs fail to suspend the discrete GPU, thus > causing lockups on system sleep and high power consumption at runtime. > The discrete GPU would normally be suspended to D3cold by turning off > ACPI _PR3 Power Resources of the Root Port above the GPU

Re: [PATCH v3 7/7] drm/todo: Update entries around struct dma_buf_map

2020-10-02 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 05:14:37PM +0200, Thomas Zimmermann wrote: > Instances of struct dma_buf_map should be useful throughout DRM's > memory management code. Furthermore, several drivers can now use > generic fbdev emulation. > > Signed-off-by: Thomas Zimmermann Acked-by: Daniel Vetter > --

Re: [PATCH v3 6/7] drm/fb_helper: Support framebuffers in I/O memory

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 8:05 PM Daniel Vetter wrote: > > On Tue, Sep 29, 2020 at 05:14:36PM +0200, Thomas Zimmermann wrote: > > At least sparc64 requires I/O-specific access to framebuffers. This > > patch updates the fbdev console accordingly. > > > > For drivers with direct access to the framebuf

Re: [PATCH v3 6/7] drm/fb_helper: Support framebuffers in I/O memory

2020-10-02 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 05:14:36PM +0200, Thomas Zimmermann wrote: > At least sparc64 requires I/O-specific access to framebuffers. This > patch updates the fbdev console accordingly. > > For drivers with direct access to the framebuffer memory, the callback > functions in struct fb_ops test for t

[PATCH 5/7] drm/amdgpu/sdma: add sdma engine support for green_sardine (v2)

2020-10-02 Thread Alex Deucher
From: Prike Liang Initialize the SDMA IP for green_sardine. v2: use apu flags Signed-off-by: Prike Liang Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH 7/7] drm/amdgpu: enable vcn support for green_sardine (v2)

2020-10-02 Thread Alex Deucher
From: Thong Thai Enable Green_Sardine VCN support and VCN firmware loading v2: use apu flags Signed-off-by: Thong Thai Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 1/7] drm/amdgpu: add Green_Sardine APU flag

2020-10-02 Thread Alex Deucher
Will be used for Green_Sardine which is a new APU. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/include/amd_shared.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h index 10dc481ecbc4..06c1aabf10ce 10

[PATCH 6/7] drm/amdgpu: enable green_sardine_asd.bin loading (v2)

2020-10-02 Thread Alex Deucher
From: Aaron Liu This patch enable green_sardine_asd.bin loading. v2: use apu flags Signed-off-by: Aaron Liu Reviewed-by: Huang Rui Reviewed-by: Prike Liang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/psp_v12_0.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) dif

[PATCH 3/7] drm/amdgpu: add soc15 common ip block support for green_sardine (v3)

2020-10-02 Thread Alex Deucher
From: Prike Liang This patch adds common ip support for green_sardine. v2: use apu flags, squash in CG/PG enablement v3: rebase Signed-off-by: Prike Liang Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 11 +-- 1

[PATCH 4/7] drm/amdgpu: add gfx support for green_sardine (v2)

2020-10-02 Thread Alex Deucher
From: Prike Liang Enable the gfx base HW function of green_sardine. v2: use apu flags Signed-off-by: Prike Liang Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 12 +++- 1 file changed, 11 insertions(+), 1 del

[PATCH 2/7] drm/amdgpu: add green_sardine support for gpu_info and ip block setting (v2)

2020-10-02 Thread Alex Deucher
From: Prike Liang This patch adds green_sardine support for gpu_info firmware and ip block setting. v2: use apu flag Signed-off-by: Prike Liang Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +- 1 file ch

RE: [PATCH] PCI/ACPI: Whitelist hotplug ports for D3 if power managed by ACPI

2020-10-02 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Rafael J. Wysocki > Sent: Friday, October 2, 2020 10:25 AM > To: Deucher, Alexander > Cc: Rafael J. Wysocki ; Lukas Wunner > ; Aaron Zakhrov ; Michal > Rostecki ; Linux PCI ; > Rafael J. Wysocki ; amd-gfx list g...@lists.freedesktop.org>;

Re: [PATCH] PCI/ACPI: Whitelist hotplug ports for D3 if power managed by ACPI

2020-10-02 Thread Rafael J. Wysocki
On Fri, Oct 2, 2020 at 4:20 PM Deucher, Alexander wrote: > > [AMD Public Use] > > > -Original Message- > > From: amd-gfx On Behalf Of > > Rafael J. Wysocki > > Sent: Friday, October 2, 2020 10:17 AM > > To: Lukas Wunner > > Cc: Aaron Zakhrov ; Michal Rostecki > > ; Linux PCI ; Rafael J.

RE: [PATCH] PCI/ACPI: Whitelist hotplug ports for D3 if power managed by ACPI

2020-10-02 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: amd-gfx On Behalf Of > Rafael J. Wysocki > Sent: Friday, October 2, 2020 10:17 AM > To: Lukas Wunner > Cc: Aaron Zakhrov ; Michal Rostecki > ; Linux PCI ; Rafael J. > Wysocki ; amd-gfx list g...@lists.freedesktop.org>; ACPI Devel Maling List

Re: [PATCH] PCI/ACPI: Whitelist hotplug ports for D3 if power managed by ACPI

2020-10-02 Thread Rafael J. Wysocki
On Fri, Oct 2, 2020 at 7:17 AM Lukas Wunner wrote: > > Recent laptops with dual AMD GPUs fail to suspend the discrete GPU, thus > causing lockups on system sleep and high power consumption at runtime. > The discrete GPU would normally be suspended to D3cold by turning off > ACPI _PR3 Power Resourc

RE: [PATCH] PCI/ACPI: Whitelist hotplug ports for D3 if power managed by ACPI

2020-10-02 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Lukas Wunner > Sent: Friday, October 2, 2020 1:10 AM > To: Bjorn Helgaas ; Rafael J. Wysocki > ; Len Brown > Cc: Deucher, Alexander ; Mika Westerberg > ; linux-...@vger.kernel.org; linux- > a...@vger.kernel.org; amd-gfx@lists.freedesktop.org;

Re: [PATCH v3 5/7] drm/gem: Store client buffer mappings as struct dma_buf_map

2020-10-02 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 05:14:35PM +0200, Thomas Zimmermann wrote: > Kernel DRM clients now store their framebuffer address in an instance > of struct dma_buf_map. Depending on the buffer's location, the address > refers to system or I/O memory. > > Callers of drm_client_buffer_vmap() receive a co

Re: [PATCH v3 4/7] drm/gem: Update internal GEM vmap/vunmap interfaces to use struct dma_buf_map

2020-10-02 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 05:14:34PM +0200, Thomas Zimmermann wrote: > GEM's vmap and vunmap interfaces now wrap memory pointers in struct > dma_buf_map. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_client.c | 18 +++--- > drivers/gpu/drm/drm_gem.c | 28 +

Re: [PATCH v3 3/7] drm/gem: Use struct dma_buf_map in GEM vmap ops and convert GEM backends

2020-10-02 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 05:14:33PM +0200, Thomas Zimmermann wrote: > This patch replaces the vmap/vunmap's use of raw pointers in GEM object > functions with instances of struct dma_buf_map. GEM backends are > converted as well. > > For most GEM backends, this simply change the returned type. GEM

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 1:30 PM Christian König wrote: > > Am 02.10.20 um 11:58 schrieb Daniel Vetter: > > On Wed, Sep 30, 2020 at 02:51:46PM +0200, Daniel Vetter wrote: > >> On Wed, Sep 30, 2020 at 2:34 PM Christian König > >> wrote: > >>> Am 30.09.20 um 11:47 schrieb Daniel Vetter: > On Wed

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-10-02 Thread Christian König
Am 02.10.20 um 11:58 schrieb Daniel Vetter: On Wed, Sep 30, 2020 at 02:51:46PM +0200, Daniel Vetter wrote: On Wed, Sep 30, 2020 at 2:34 PM Christian König wrote: Am 30.09.20 um 11:47 schrieb Daniel Vetter: On Wed, Sep 30, 2020 at 10:34:31AM +0200, Christian König wrote: Am 30.09.20 um 10:19

Re: [PATCH v3 2/7] drm/ttm: Add ttm_kmap_obj_to_dma_buf_map() for type conversion

2020-10-02 Thread Daniel Vetter
On Wed, Sep 30, 2020 at 02:51:46PM +0200, Daniel Vetter wrote: > On Wed, Sep 30, 2020 at 2:34 PM Christian König > wrote: > > > > Am 30.09.20 um 11:47 schrieb Daniel Vetter: > > > On Wed, Sep 30, 2020 at 10:34:31AM +0200, Christian König wrote: > > >> Am 30.09.20 um 10:19 schrieb Thomas Zimmermann

Re: [PATCH v3 1/7] drm/vram-helper: Remove invariant parameters from internal kmap function

2020-10-02 Thread Daniel Vetter
On Tue, Sep 29, 2020 at 05:14:31PM +0200, Thomas Zimmermann wrote: > The parameters map and is_iomem are always of the same value. Removed them > to prepares the function for conversion to struct dma_buf_map. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter > --- > drivers/gpu/

Re: [PATCH RFC 0/1] drm/ttm: Allocate transparent huge pages without clearing __GFP_COMP

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 8:41 AM Christian König wrote: > > Hi Alex, > > adding Daniel as well. > > Am 01.10.20 um 20:45 schrieb Alex Goins: > > Hi Christian, > > > > On Thu, 1 Oct 2020, Christian König wrote: > > > >> Hi Alex, > >> > >> first of all accessing the underlying page of an exported DMA-