On Mon, Oct 12, 2020 at 09:02:54PM +0100, Matthew Wilcox wrote:
> On Mon, Oct 12, 2020 at 12:53:54PM -0700, Ira Weiny wrote:
> > On Mon, Oct 12, 2020 at 05:44:38PM +0100, Matthew Wilcox wrote:
> > > On Mon, Oct 12, 2020 at 09:28:29AM -0700, Dave Hansen wrote:
> > > > kmap_atomic() is always preferr
On Mon, Oct 12, 2020 at 12:53:54PM -0700, Ira Weiny wrote:
> On Mon, Oct 12, 2020 at 05:44:38PM +0100, Matthew Wilcox wrote:
> > On Mon, Oct 12, 2020 at 09:28:29AM -0700, Dave Hansen wrote:
> > > kmap_atomic() is always preferred over kmap()/kmap_thread().
> > > kmap_atomic() is _much_ more lightwe
On Mon, Oct 12, 2020 at 05:44:38PM +0100, Matthew Wilcox wrote:
> On Mon, Oct 12, 2020 at 09:28:29AM -0700, Dave Hansen wrote:
> > kmap_atomic() is always preferred over kmap()/kmap_thread().
> > kmap_atomic() is _much_ more lightweight since its TLB invalidation is
> > always CPU-local and never b
[AMD Public Use]
Hi Jack,
How about improving the patch a bit like below? As the code for raven and
default case is totally the same, maybe we could squash both together with
adding the comment for RAVEN and other default ASICs for readiness.
switch (adev->asic_type) {
case CHIP_VEGA20
[AMD Public Use]
Hi Guchun,
It's fine.
I will address the patch according to your suggestion.
BR,
Jack
-Original Message-
From: Chen, Guchun
Sent: Tuesday, October 13, 2020 3:45 PM
To: Gui, Jack ; amd-gfx@lists.freedesktop.org; Deucher,
Alexander
Cc: Gui, Jack ; Zhou1, Tao ; Huang,
Use LLVM_INCLUDE_DIRS instead of LLVM_INCLUDE_DIR to support
local builds of LLVM where source and binaries are separate.
---
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index a8c08d6..8bf69a8 100644
--- a/CMakeLists.txt
+++ b/
The driver needn't load smu binary on APU platforms.
Signed-off-by: Huang Rui
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 9d31f9339e02..042ad5
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Kevin Wang
Best Regards,
Kevin
From: amd-gfx on behalf of Huang Rui
Sent: Tuesday, October 13, 2020 7:45 PM
To: amd-gfx@lists.freedesktop.org
Cc: Huang, Ray
Subject: [PATCH] drm/amdgpu: fix t
As warned when running "make htmldocs":
./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:345: warning:
Function parameter or member 'force_timing_sync' not described in
'amdgpu_display_manager'
This new struct member was not documented at kernel-doc markup.
Fixes: 3d4e52d0cf24 ("drm
GPU reset might get called during init time, before
sw_init has been called.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
b/drivers/gpu/drm/amd/pm/sw
Running "make htmldocs: produce lots of warnings on those files:
./drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:177: warning: Excess
function parameter 'man' description in 'amdgpu_vram_mgr_init'
./drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:177: warning: Excess
function paramete
[AMD Public Use]
-Original Message-
From: Koenig, Christian
Sent: Monday, October 12, 2020 4:24 PM
To: Patel, Mihir ; amd-gfx@lists.freedesktop.org
Cc: Chauhan, Madhav ; Deucher, Alexander
; Kamliya, Prakash ;
Surampalli, Kishore
Subject: Re: [PATCH v3] drm/amdgpu: Add debugfs entry f
> - kaddr = kmap(pp);
> + kaddr = kmap_thread(pp);
> memcpy(kaddr, vip->vii_immed.vi_immed + offset, PAGE_SIZE);
> - kunmap(pp);
> + kunmap_thread(pp);
You only Cced me on this particular patch, which means I have absolutely
no idea what kmap_thread and kunmap_thread actually
[AMD Official Use Only - Internal Distribution Only]
Acked-by: Alex Deucher
From: Quan, Evan
Sent: Tuesday, October 13, 2020 2:45 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Quan, Evan
Subject: [PATCH] drm/amd/pm: increase mclk switch thresho
Reviewed-by: Kevin Wang
> 在 2020年10月13日，20:15，Alex Deucher 写道：
>
> GPU reset might get called during init time, before
> sw_init has been called.
>
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
Am 13.10.20 um 14:14 schrieb Mauro Carvalho Chehab:
Running "make htmldocs: produce lots of warnings on those files:
./drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c:177: warning: Excess
function parameter 'man' description in 'amdgpu_vram_mgr_init'
./drivers/gpu/drm/amd/amdgpu/amd
Applied. Thanks!
Alex
On Mon, Oct 12, 2020 at 9:44 AM Bernard Zhao wrote:
>
> Functions (disable_all_writeback_pipes_for_stream &
> dc_enable_stereo & dc_post_update_surfaces_to_stream)
> always return true, there is no need to keep the return value.
> This change is to make the code a bit more
Applied. Thanks!
Alex
On Tue, Oct 13, 2020 at 7:54 AM Mauro Carvalho Chehab
wrote:
>
> As warned when running "make htmldocs":
>
> ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:345: warning:
> Function parameter or member 'force_timing_sync' not described in
> 'amdgpu_display_ma
[AMD Public Use]
-Original Message-
From: amd-gfx On Behalf Of Huang Rui
Sent: Tuesday, October 13, 2020 5:15 PM
To: amd-gfx@lists.freedesktop.org
Cc: Huang, Ray
Subject: [PATCH] drm/amdgpu: fix the issue that apu has no smu firmware binary
The driver needn't load smu binary on APU plat
Do you have more details about those test failures. In theory that test
should pass with noretry=0. If it fails, I'd rather look into the
problem than hiding it with a workaround.
Regards,
Felix
Am 2020-10-13 um 11:13 a.m. schrieb Chengming Gui:
> noretry = 0 cause some dGPU's kfd page fault te
[SNIP]
Thinking a bit more about it, when you also look at
bo->preferred_domains and compare that with the current domain you can
also figure out if a BO is swapped out or not.
Christian.
Thanks Christian for quick review/help and details. Summarizing your inputs
and some queries:
1. Adding B
Merge the functionality mostly into amdgpu_vm_bo_update_mapping.
This way we can even handle small contiguous system pages without
to much extra CPU overhead.
Large contiguous allocations (1GB) still improve from 1.2 to 0.3 seconds.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu
Ideally this should be a multiple of the VM block size.
2MB should at least fit for Vega/Navi.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
b/drivers/gpu/d
On Tue, Oct 13, 2020 at 11:44:29AM -0700, Dan Williams wrote:
> On Fri, Oct 9, 2020 at 12:52 PM wrote:
> >
> > From: Ira Weiny
> >
> > The kmap() calls in this FS are localized to a single thread. To avoid
> > the over head of global PKRS updates use the new kmap_thread() call.
> >
> > Cc: Nicol
On Tue, Oct 13, 2020 at 08:36:43PM +0100, Matthew Wilcox wrote:
> static inline void copy_to_highpage(struct page *to, void *vfrom, unsigned
> int size)
> {
> char *vto = kmap_atomic(to);
>
> memcpy(vto, vfrom, size);
> kunmap_atomic(vto);
> }
>
> in linux/highmem.h ?
You mea
On Fri, Oct 9, 2020 at 12:52 PM wrote:
>
> From: Ira Weiny
>
> The kmap() calls in this FS are localized to a single thread. To avoid
> the over head of global PKRS updates use the new kmap_thread() call.
>
> Cc: Nicolas Pitre
> Signed-off-by: Ira Weiny
> ---
> fs/cramfs/inode.c | 10 +---
On Tue, Oct 13, 2020 at 12:37 PM Matthew Wilcox wrote:
>
> On Tue, Oct 13, 2020 at 11:44:29AM -0700, Dan Williams wrote:
> > On Fri, Oct 9, 2020 at 12:52 PM wrote:
> > >
> > > From: Ira Weiny
> > >
> > > The kmap() calls in this FS are localized to a single thread. To avoid
> > > the over head
On Fri, 9 Oct 2020, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> The kmap() calls in this FS are localized to a single thread. To avoid
> the over head of global PKRS updates use the new kmap_thread() call.
>
> Cc: Nicolas Pitre
> Signed-off-by: Ira Weiny
Acked-by: Nicolas Pitre
> fs
On Tue, Oct 13, 2020 at 09:01:49PM +0100, Al Viro wrote:
> On Tue, Oct 13, 2020 at 08:36:43PM +0100, Matthew Wilcox wrote:
>
> > static inline void copy_to_highpage(struct page *to, void *vfrom, unsigned
> > int size)
> > {
> > char *vto = kmap_atomic(to);
> >
> > memcpy(vto, vfrom, size
On Tue, Oct 13, 2020 at 08:36:43PM +0100, Matthew Wilcox wrote:
> On Tue, Oct 13, 2020 at 11:44:29AM -0700, Dan Williams wrote:
> > On Fri, Oct 9, 2020 at 12:52 PM wrote:
> > >
> > > From: Ira Weiny
> > >
> > > The kmap() calls in this FS are localized to a single thread. To avoid
> > > the over
On Tue, Oct 13, 2020 at 12:25:44PM +0100, Christoph Hellwig wrote:
> > - kaddr = kmap(pp);
> > + kaddr = kmap_thread(pp);
> > memcpy(kaddr, vip->vii_immed.vi_immed + offset, PAGE_SIZE);
> > - kunmap(pp);
> > + kunmap_thread(pp);
>
> You only Cced me on this particular patch, which mean
As for other clock domains.
Change-Id: I0a78c133f00cd11133bc755bf0443505088f024c
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h| 1 +
drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 5 +
2 files changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/inc/
Populate current link speed, width and clock domain frequency.
Change-Id: Ic342fbd8f5e2495d212eaa4b85b4e146838e0525
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 3 ---
.../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 18 ++
2 files changed, 18 in
33 matches
Mail list logo
