Re: [PATCH] drm/amd/display: Initialize num_pkrs on VANGOGH.

2020-10-20 Thread Huang Rui
On Tue, Oct 20, 2020 at 07:47:42PM -0400, Marek Olšák wrote: > FYI, this fixes tiling on VanGogh. > > Reviewed-by: Marek Olšák > > Marek > > On Tue, Oct 20, 2020 at 6:31 PM Bas Nieuwenhuizen > wrote: > > > As far a I can tell uses a variant of DCN3xx which uses num_pkrs. > > > > If we do not

Re: [PATCH] drm/amd/display: Initialize num_pkrs on VANGOGH.

2020-10-20 Thread Marek Olšák
FYI, this fixes tiling on VanGogh. Reviewed-by: Marek Olšák Marek On Tue, Oct 20, 2020 at 6:31 PM Bas Nieuwenhuizen wrote: > As far a I can tell uses a variant of DCN3xx which uses num_pkrs. > > If we do not initialize the variable we will set the register field > to ilog2(0) = -1, though

[PATCH] drm/amd/display: Initialize num_pkrs on VANGOGH.

2020-10-20 Thread Bas Nieuwenhuizen
As far a I can tell uses a variant of DCN3xx which uses num_pkrs. If we do not initialize the variable we will set the register field to ilog2(0) = -1, though the mask will reduce that to 7. Pretty sure 7 is not the value we want here. Signed-off-by: Bas Nieuwenhuizen --- Found while rebasing

Re: [RFC] treewide: cleanup unreachable breaks

2020-10-20 Thread Joe Perches
On Mon, 2020-10-19 at 12:42 -0700, Nick Desaulniers wrote: > On Sat, Oct 17, 2020 at 10:43 PM Greg KH wrote: > > On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > This is a upcoming change to clean up a new warning treewide. > > > I am wondering if

[PATCH 3/3] drm/amdgpu/display: add MALL support

2020-10-20 Thread Alex Deucher
From: Bhawanpreet Lakha Enable Memory Access at Last Level (MALL) feature for display. Signed-off-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher --- .../drm/amd/display/dc/clk_mgr/dcn30/dalsmc.h | 1 + .../display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c | 10 +++

[PATCH 2/3] drm/amdgpu: add support to configure MALL for sienna_cichlid (v2)

2020-10-20 Thread Alex Deucher
From: Likun Gao Enable Memory Access at Last Level (MALL) feature for sienna_cichlid. v2: drop module option. We need to add UAPI so userspace can request MALL per buffer. Signed-off-by: Likun Gao Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher ---

[PATCH 1/3] drm/amdgpu: add GC 10.3 NOALLOC registers

2020-10-20 Thread Alex Deucher
This adds the NOALLOC registers. Signed-off-by: Alex Deucher --- .../include/asic_reg/gc/gc_10_3_0_default.h | 1 + .../include/asic_reg/gc/gc_10_3_0_offset.h| 2 ++ .../include/asic_reg/gc/gc_10_3_0_sh_mask.h | 33 +++ 3 files changed, 36 insertions(+) diff --git

Re: [RFC] treewide: cleanup unreachable breaks

2020-10-20 Thread Tom Rix
On 10/19/20 12:42 PM, Nick Desaulniers wrote: > On Sat, Oct 17, 2020 at 10:43 PM Greg KH wrote: >> On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: >>> From: Tom Rix >>> >>> This is a upcoming change to clean up a new warning treewide. >>> I am wondering if the change could be

Re: [RFC] treewide: cleanup unreachable breaks

2020-10-20 Thread Tom Rix
On 10/19/20 4:05 PM, Jason Gunthorpe wrote: > On Mon, Oct 19, 2020 at 12:42:15PM -0700, Nick Desaulniers wrote: >> On Sat, Oct 17, 2020 at 10:43 PM Greg KH wrote: >>> On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: From: Tom Rix This is a upcoming change to

Re: [PATCH] drm/amd/display: Fix the display corruption issue on Navi10

2020-10-20 Thread Matt Coffin
Thanks for the quick resolution! Might want to add a Fixes header just for reference when people are reading commit messages? I can confirm that this fixed the issue introduced by that previous patch, though! Patch is Tested-by: Matt Coffin On 10/20/20 12:48 AM, Yifan Zhang wrote: > [Why] >

Re: [PATCH v5 05/10] drm/ttm: Add vmap/vunmap to TTM and TTM GEM helpers

2020-10-20 Thread Christian König
Am 20.10.20 um 14:20 schrieb Thomas Zimmermann: The new functions ttm_bo_{vmap,vunmap}() map and unmap a TTM BO in kernel address space. The mapping's address is returned as struct dma_buf_map. Each function is a simplified version of TTM's existing kmap code. Both functions respect the memory's

Re: [PATCH] drm/amd/display: Fix the display corruption issue on Navi10

2020-10-20 Thread Alex Deucher
On Tue, Oct 20, 2020 at 2:49 AM Yifan Zhang wrote: > > [Why] > Screen corruption on Navi10 card > > [How] > Set system context in DCN only on Renoir and Cezanne > > Signed-off-by: Yifan Zhang Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 +--- > 1

Re: [Ocfs2-devel] [RFC] treewide: cleanup unreachable breaks

2020-10-20 Thread John Haxby
> On 19 Oct 2020, at 20:42, Nick Desaulniers wrote: > > We probably should add all 3 to W=2 builds (wrapped in cc-option). > I've filed https://github.com/ClangBuiltLinux/linux/issues/1180 to > follow up on. It looks as though the URL mangling has been fixed. If anyone sees that specific

[PATCH v5 10/10] drm/fb_helper: Support framebuffers in I/O memory

2020-10-20 Thread Thomas Zimmermann
At least sparc64 requires I/O-specific access to framebuffers. This patch updates the fbdev console accordingly. For drivers with direct access to the framebuffer memory, the callback functions in struct fb_ops test for the type of memory and call the rsp fb_sys_ of fb_cfb_ functions. Read and

[PATCH v5 09/10] dma-buf-map: Add memcpy and pointer-increment interfaces

2020-10-20 Thread Thomas Zimmermann
To do framebuffer updates, one needs memcpy from system memory and a pointer-increment function. Add both interfaces with documentation. v5: * include to build on sparc64 (Sam) Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg Tested-by: Sam Ravnborg ---

[PATCH v5 07/10] drm/gem: Update internal GEM vmap/vunmap interfaces to use struct dma_buf_map

2020-10-20 Thread Thomas Zimmermann
GEM's vmap and vunmap interfaces now wrap memory pointers in struct dma_buf_map. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Tested-by: Sam Ravnborg --- drivers/gpu/drm/drm_client.c | 18 +++--- drivers/gpu/drm/drm_gem.c | 26 +-

[PATCH v5 08/10] drm/gem: Store client buffer mappings as struct dma_buf_map

2020-10-20 Thread Thomas Zimmermann
Kernel DRM clients now store their framebuffer address in an instance of struct dma_buf_map. Depending on the buffer's location, the address refers to system or I/O memory. Callers of drm_client_buffer_vmap() receive a copy of the value in the call's supplied arguments. It can be accessed and

[PATCH v5 05/10] drm/ttm: Add vmap/vunmap to TTM and TTM GEM helpers

2020-10-20 Thread Thomas Zimmermann
The new functions ttm_bo_{vmap,vunmap}() map and unmap a TTM BO in kernel address space. The mapping's address is returned as struct dma_buf_map. Each function is a simplified version of TTM's existing kmap code. Both functions respect the memory's location ani/or writecombine flags. On top TTM's

[PATCH v5 00/10] Support GEM object mappings from I/O memory

2020-10-20 Thread Thomas Zimmermann
DRM's fbdev console uses regular load and store operations to update framebuffer memory. The bochs driver on sparc64 requires the use of I/O-specific load and store operations. We have a workaround, but need a long-term solution to the problem. This patchset changes GEM's vmap/vunmap interfaces

[PATCH v5 06/10] drm/gem: Use struct dma_buf_map in GEM vmap ops and convert GEM backends

2020-10-20 Thread Thomas Zimmermann
This patch replaces the vmap/vunmap's use of raw pointers in GEM object functions with instances of struct dma_buf_map. GEM backends are converted as well. For most of them, this simply changes the returned type. TTM-based drivers now return information about the location of the memory, either

[PATCH v5 01/10] drm/vram-helper: Remove invariant parameters from internal kmap function

2020-10-20 Thread Thomas Zimmermann
The parameters map and is_iomem are always of the same value. Removed them to prepares the function for conversion to struct dma_buf_map. v4: * don't check for !kmap->virtual; will always be false Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Reviewed-by: Christian König

[PATCH v5 04/10] drm/exynos: Remove empty exynos_drm_gem_prime_{vmap, vunmap}()

2020-10-20 Thread Thomas Zimmermann
The functions exynos_drm_gem_prime_{vmap,vunmap}() are empty. Remove them before changing the interface to use struct drm_buf_map. As a side effect of removing drm_gem_prime_vmap(), the error code changes from ENOMEM to EOPNOTSUPP. Signed-off-by: Thomas Zimmermann Acked-by: Christian König

[PATCH v5 02/10] drm/cma-helper: Remove empty drm_gem_cma_prime_vunmap()

2020-10-20 Thread Thomas Zimmermann
The function drm_gem_cma_prime_vunmap() is empty. Remove it before changing the interface to use struct drm_buf_map. Signed-off-by: Thomas Zimmermann Reviewed-by: Christian König Tested-by: Sam Ravnborg --- drivers/gpu/drm/drm_gem_cma_helper.c | 17 -

[PATCH v5 03/10] drm/etnaviv: Remove empty etnaviv_gem_prime_vunmap()

2020-10-20 Thread Thomas Zimmermann
The function etnaviv_gem_prime_vunmap() is empty. Remove it before changing the interface to use struct drm_buf_map. Signed-off-by: Thomas Zimmermann Acked-by: Christian König Tested-by: Sam Ravnborg --- drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 - drivers/gpu/drm/etnaviv/etnaviv_gem.c

Re: [PATCH] drm/amd/pm: fix pcie information for sienna cichlid

2020-10-20 Thread Feng, Kenneth
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kenneth Feng 在 2020/10/20 下午4:57,“Gao, Likun” 写入: From: Likun Gao Fix the function used for sienna cichlid to get correct PCIE information by pp_dpm_pcie. Signed-off-by: Likun Gao Change-Id:

Re: [PATCH] drm/amd/pm: update driver if version for dimgrey_cavefish

2020-10-20 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking Sent from my iPhone > On Oct 20, 2020, at 17:34, Zhou1, Tao wrote: > > Per PMFW 59.9.0. > > Signed-off-by: Tao Zhou > --- > drivers/gpu/drm/amd/pm/inc/smu_v11_0.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH] drm/amd/pm: update driver if version for dimgrey_cavefish

2020-10-20 Thread Tao Zhou
Per PMFW 59.9.0. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/inc/smu_v11_0.h b/drivers/gpu/drm/amd/pm/inc/smu_v11_0.h index 2fba050b3180..76c5b5d8ebbb 100644 ---

RE: [PATCH] drm/amd/pm: update driver if file for sienna cichlid

2020-10-20 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Gao, Likun Sent: Tuesday, October 20, 2020 16:57 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Feng, Kenneth ; Gao, Likun Subject: [PATCH] drm/amd/pm: update driver if file for sienna

RE: [PATCH] drm/amd/pm: fix pcie information for sienna cichlid

2020-10-20 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Gao, Likun Sent: Tuesday, October 20, 2020 16:57 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Feng, Kenneth ; Gao, Likun Subject: [PATCH] drm/amd/pm: fix pcie information for sienna

[PATCH] drm/amd/pm: update driver if file for sienna cichlid

2020-10-20 Thread Likun Gao
From: Likun Gao Update driver if file for sienna cichlid. Signed-off-by: Likun Gao Change-Id: Ie386abcd0a00fd904155361c9aa8c0861473552a --- .../amd/pm/inc/smu11_driver_if_sienna_cichlid.h| 14 -- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h | 2 +- 2 files changed, 13

[PATCH] drm/amd/pm: fix pcie information for sienna cichlid

2020-10-20 Thread Likun Gao
From: Likun Gao Fix the function used for sienna cichlid to get correct PCIE information by pp_dpm_pcie. Signed-off-by: Likun Gao Change-Id: I81e529be6e96f083eb7aa244c16700422bde5fec --- drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] drm/amd/display: Fix the display corruption issue on Navi10

2020-10-20 Thread Yifan Zhang
[Why] Screen corruption on Navi10 card [How] Set system context in DCN only on Renoir and Cezanne Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git