[AMD Official Use Only - Internal Distribution Only]
Fix performace drop while streaming Doom
Signed-off-by: Li, Xin (Justin) mailto:xin2...@amd.com>>
Signed-off-by: Zhao, Jiange mailto:jiange.z...@amd.com>>
---
drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 14 ++
1 file changed
[AMD Official Use Only - Internal Distribution Only]
Add checksum checking for pf2vf message
Signed-off-by: Li, Xin (Justin) mailto:xin2...@amd.com>>
Signed-off-by: Zhou, Tiecheng
mailto:tiecheng.z...@amd.com>>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 5 ++---
1 file changed, 2 insertions
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Evan Quan mailto:evan.q...@amd.com>>
From: amd-gfx On Behalf Of Lei Guo
Sent: Friday, October 23, 2020 11:03 AM
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH] Fix bug to get average GPU power
>From 0277318fc1799d17878d9f4072
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Tuesday, October 27, 2020 5:34 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu/swsmu: drop smu i2c bus on
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Tuesday, October 27, 2020 5:43 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu/pm: fix the fan speed in f
Which can be used for S4(hibernation) support.
Change-Id: I6e4962c120a3baed14cea04ed1742ff11a273d34
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/amdgpu/cik.c | 4 +++-
drivers/gpu/drm/amd/pm/powerplay/hwmgr/ci_baco.c | 7 ---
2 files changed, 7 insertions(+), 4 deletions(
This reverts commit f87812284172a9809820d10143b573d833cd3f75 "drm/amdgpu:
Fix bug where DPM is not enabled after hibernate and resume".
It was intended to fix Hawaii S4(hibernation) issue but break S3. As
ixFEATURE_STATUS is filled with garbage data on resume which can be
only cleared by reloading
From: Fangzhi Zuo
[ Upstream commit 95d620adb48f7728e67d82f56f756e8d451cf8d2 ]
[Why]
Currently mode validation is bypassed if remote sink exists. That
leads to mode set issue when a BW bottle neck exists in the link path,
e.g., a DP-to-HDMI converter that only supports HDMI 1.4.
Any invalid mod
From: Fangzhi Zuo
[ Upstream commit 95d620adb48f7728e67d82f56f756e8d451cf8d2 ]
[Why]
Currently mode validation is bypassed if remote sink exists. That
leads to mode set issue when a BW bottle neck exists in the link path,
e.g., a DP-to-HDMI converter that only supports HDMI 1.4.
Any invalid mod
From: Rodrigo Siqueira
[ Upstream commit 2f8be0e516803cc3fd87c1671247896571a5a8fb ]
[Why]
Sometimes CRTCs can be disabled due to display unplugging or temporarily
transition in the userspace; in these circumstances, DCE tries to set
the minimum clock threshold. When we have this situation, the f
From: Fangzhi Zuo
[ Upstream commit 95d620adb48f7728e67d82f56f756e8d451cf8d2 ]
[Why]
Currently mode validation is bypassed if remote sink exists. That
leads to mode set issue when a BW bottle neck exists in the link path,
e.g., a DP-to-HDMI converter that only supports HDMI 1.4.
Any invalid mod
From: Rodrigo Siqueira
[ Upstream commit 4b4f21ff7f5d11bb77e169b306dcbc5b216f5db5 ]
During the load processes for Renoir, our display code needs to retrieve
the SMU clock and voltage table, however, this operation can fail which
means that we have to check this scenario. Currently, we are not
ha
From: Luben Tuikov
[ Upstream commit 5aea5327ea2ddf544cbeff096f45fc2319b0714e ]
Not being able to create amdgpu sysfs attributes
is not a fatal error warranting not to continue
to try to bring up the display. Thus, if we get
an error trying to create amdgpu sysfs attrs,
report it and continue on
From: Guchun Chen
[ Upstream commit bf0b91b78f002faa1be1902a75eeb0797f9fbcf3 ]
RAS flags needs to be cleaned as well when user requires
one clean eeprom.
v2: RAS flags shall be restored after eeprom reset succeeds.
Signed-off-by: Guchun Chen
Reviewed-by: Hawking Zhang
Signed-off-by: Alex Deu
From: Luben Tuikov
[ Upstream commit e2d732fdb7a9e421720a644580cd6a9400f97f60 ]
Remove DRM_SCHED_PRIORITY_LOW, as it was used
in only one place.
Rename and separate by a line
DRM_SCHED_PRIORITY_MAX to DRM_SCHED_PRIORITY_COUNT
as it represents a (total) count of said
priorities and it is used as
From: Fangzhi Zuo
[ Upstream commit 95d620adb48f7728e67d82f56f756e8d451cf8d2 ]
[Why]
Currently mode validation is bypassed if remote sink exists. That
leads to mode set issue when a BW bottle neck exists in the link path,
e.g., a DP-to-HDMI converter that only supports HDMI 1.4.
Any invalid mod
From: Rodrigo Siqueira
[ Upstream commit 2f8be0e516803cc3fd87c1671247896571a5a8fb ]
[Why]
Sometimes CRTCs can be disabled due to display unplugging or temporarily
transition in the userspace; in these circumstances, DCE tries to set
the minimum clock threshold. When we have this situation, the f
From: Rodrigo Siqueira
[ Upstream commit 4b4f21ff7f5d11bb77e169b306dcbc5b216f5db5 ]
During the load processes for Renoir, our display code needs to retrieve
the SMU clock and voltage table, however, this operation can fail which
means that we have to check this scenario. Currently, we are not
ha
From: Luben Tuikov
[ Upstream commit 5aea5327ea2ddf544cbeff096f45fc2319b0714e ]
Not being able to create amdgpu sysfs attributes
is not a fatal error warranting not to continue
to try to bring up the display. Thus, if we get
an error trying to create amdgpu sysfs attrs,
report it and continue on
From: Luben Tuikov
[ Upstream commit e2d732fdb7a9e421720a644580cd6a9400f97f60 ]
Remove DRM_SCHED_PRIORITY_LOW, as it was used
in only one place.
Rename and separate by a line
DRM_SCHED_PRIORITY_MAX to DRM_SCHED_PRIORITY_COUNT
as it represents a (total) count of said
priorities and it is used as
From: Guchun Chen
[ Upstream commit bf0b91b78f002faa1be1902a75eeb0797f9fbcf3 ]
RAS flags needs to be cleaned as well when user requires
one clean eeprom.
v2: RAS flags shall be restored after eeprom reset succeeds.
Signed-off-by: Guchun Chen
Reviewed-by: Hawking Zhang
Signed-off-by: Alex Deu
On 2020-10-20 4:26 p.m., Alex Deucher wrote:
> From: Likun Gao
>
> Enable Memory Access at Last Level (MALL) feature for sienna_cichlid.
>
> v2: drop module option. We need to add UAPI so userspace can
> request MALL per buffer.
>
> Signed-off-by: Likun Gao
> Reviewed-by: Hawking Zhang
> Sig
Consolidating DCN seems like a good idea.
Reviewed-by: Luben Tuikov
Regards,
Luben
On 2020-10-26 12:35 p.m., Alex Deucher wrote:
> Ping again?
>
> On Thu, Oct 22, 2020 at 1:31 AM Alex Deucher wrote:
>>
>> Ping on this series?
>>
>> Alex
>>
>> On Fri, Oct 16, 2020 at 12:50 PM Alex Deucher wro
It has been confirmed that the SMU metrics table should always reflect
the current fan speed even in manual mode.
Fixes: 3033e9f1c2de ("drm/amdgpu/swsmu: handle manual fan readback on SMU11")
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 11 +++
1 file
Stop registering the SMU i2c bus on navi1x. This leads to instability
issues when userspace processes mess with the bus and also seems to
cause display stability issues in some cases.
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1314
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/13
Excerpts from Alex Deucher's message of October 26, 2020 10:30 am:
> It looks this was accidently lost in a follow up patch.
> dc context is large and we don't need contiguous pages.
>
> Fixes: e4863f118a7d ("drm/amd/display: Multi display cause system lag on mode
> change")
> Signed-off-by: Alex
From: Arnd Bergmann
gcc -Wextra warns about a function taking an enum argument
being called with a bool:
drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: In function
'apply_degamma_for_user_regamma':
drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c:1617:29:
w
From: Arnd Bergmann
gcc -Wextra warns about an incorrect prototype causing multiple
mismatched enums:
display/dc/gpio/gpio_service.c: In function 'dal_gpio_service_create':
display/dc/gpio/gpio_service.c:70:50: warning: implicit conversion from 'enum
dce_environment' to 'enum dce_version' [-Wen
From: Arnd Bergmann
Building with 'make W=1' produces countless warnings like
amdgpu/../include/vega10_ip_offset.h:276:51: warning: initialized field
overwritten [-Woverride-init]
Shut these up by disabling the particular warning in the
amdgpu driver.
Signed-off-by: Arnd Bergmann
---
driver
From: Arnd Bergmann
core_link_write_dpcd() returns enum dc_status, not ddc_result:
display/dc/core/dc_link_dp.c: In function 'dp_set_panel_mode':
display/dc/core/dc_link_dp.c:4237:11: warning: implicit conversion from 'enum
dc_status' to 'enum ddc_result'
[-Wenum-conversion]
Avoid the warning
From: Arnd Bergmann
A conversion from 'bool' to 'enum odm_combine_mode' was incomplete,
and gcc warns about this with many instances of
display/dc/dml/dcn20/display_mode_vba_20.c:3899:44: warning: implicit
conversion from 'enum ' to 'enum
odm_combine_mode' [-Wenum-conversion]
3899 | locals
Applied. Thanks!
Alex
On Mon, Oct 26, 2020 at 4:22 PM Kazlauskas, Nicholas
wrote:
>
> Reviewed-by: Nicholas Kazlauskas
>
> Looks fine to me. Feel free to apply.
>
> Regards,
> Nicholas Kazlauskas
>
> On 2020-10-26 3:34 p.m., Alex Deucher wrote:
> > Yes, looks good to me as well. Series is:
>
Applied. Thanks!
Alex
On Mon, Oct 26, 2020 at 2:14 PM Sumera Priyadarsini
wrote:
>
> Bool initialisation should use 'true' and 'false' values instead of 0
> and 1.
>
> Modify amdgpu_amdkfd_gpuvm.c to initialise variable is_imported
> to false instead of 0.
>
> Issue found with Coccinelle.
>
> S
Upstream commit 6d90a208cfff ("drm/amd/display: Move disable interrupt
into commit tail") has introduced the following kernel warning on my
system with a RX 560 (Polaris 11) GPU. The warning is printed
immediately after I login.
amdgpu :01:00.0: drm_WARN_ON_ONCE(drm_drv_uses_atomic_modeset(dev
Reviewed-by: Nicholas Kazlauskas
Looks fine to me. Feel free to apply.
Regards,
Nicholas Kazlauskas
On 2020-10-26 3:34 p.m., Alex Deucher wrote:
Yes, looks good to me as well. Series is:
Acked-by: Alex Deucher
I'll give the display guys a few more days to look this over, but if
there are no
Yes, looks good to me as well. Series is:
Acked-by: Alex Deucher
I'll give the display guys a few more days to look this over, but if
there are no objections, I'll apply them.
Thanks!
Alex
On Fri, Oct 23, 2020 at 7:16 PM Luben Tuikov wrote:
>
> On 2020-10-23 03:46, Takashi Iwai wrote:
> > Hi,
Excerpts from Deucher, Alexander's message of October 26, 2020 10:34 am:
> It was using kvzalloc, but was accidently dropped when that code was
> refactored. I just sent a patch to fix it.
Ah, that explains why I wasn't seeing it before. I was only looking at
changes in amdgpu_dm_atomic_commit_
Bool initialisation should use 'true' and 'false' values instead of 0
and 1.
Modify amdgpu_amdkfd_gpuvm.c to initialise variable is_imported
to false instead of 0.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
1 fil
Fixes this warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c: In function
‘defer_delay_converter_wa’:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_ddc.c:285:2: warning:
this ‘if’ clause does not guard... [-Wmisleading-indentation]
285 | if (link->dpcd_caps.branch_de
Will do. Thanks!
Alex
On Mon, Oct 26, 2020 at 12:56 PM Alex Xu (Hello71) wrote:
>
> Excerpts from Alex Deucher's message of October 26, 2020 10:30 am:
> > It looks this was accidently lost in a follow up patch.
> > dc context is large and we don't need contiguous pages.
> >
> > Fixes: e4863f118
Ping again?
On Thu, Oct 22, 2020 at 1:31 AM Alex Deucher wrote:
>
> Ping on this series?
>
> Alex
>
> On Fri, Oct 16, 2020 at 12:50 PM Alex Deucher wrote:
> >
> > No need for a separate config option at this point.
> >
> > Signed-off-by: Alex Deucher
> > ---
> > drivers/gpu/drm/amd/display/Kco
Applied. Thanks!
Alex
On Mon, Oct 26, 2020 at 11:31 AM Zhang Qilong wrote:
>
> The 'break' is unnecessary because of previous
> 'return', discard it.
>
> Signed-off-by: Zhang Qilong
> ---
> drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 6 --
> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
On Mon, Oct 26, 2020 at 11:51 AM Bas Nieuwenhuizen
wrote:
>
> On Tue, Oct 20, 2020 at 10:26 PM Alex Deucher wrote:
> >
> > From: Bhawanpreet Lakha
> >
> > Enable Memory Access at Last Level (MALL) feature for display.
> >
> > Signed-off-by: Bhawanpreet Lakha
> > Signed-off-by: Alex Deucher
> >
This is required for MALL. Was accidently removed in PRS update.
Fixes: 48e48e598478 ("drm/amd/display: Disable idle optimization when PSR is
enabled")
Fixes: 52f2e83e2fe5 ("drm/amdgpu/display: add MALL support (v2)")
Signed-off-by: Alex Deucher
---
.../gpu/drm/amd/display/dc/dcn30/dcn30_hwseq
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Slava Abramov
From: amd-gfx on behalf of Alex Deucher
Sent: Monday, October 26, 2020 11:57 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 1/2] drm/amdgpu/display: f
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Slava Abramov
From: amd-gfx on behalf of Alex Deucher
Sent: Monday, October 26, 2020 11:57 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH 2/2] drm/amdgpu/display: d
Was missed in a later update.
Fixes: 4d269c40066e ("drm/amd/display: Update GSL state if leaving immediate
flip")
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/dc/dcn301/dcn301_init.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_i
Updating these were missed.
Fixes: 2c8193fc72b1c5 ("drm/amd/display: Refactor ABM_MASK_SH_LIST_DCN301
naming")
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 4 ++--
drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 4 ++--
2 files changed, 4 i
On Tue, Oct 20, 2020 at 10:26 PM Alex Deucher wrote:
>
> From: Bhawanpreet Lakha
>
> Enable Memory Access at Last Level (MALL) feature for display.
>
> Signed-off-by: Bhawanpreet Lakha
> Signed-off-by: Alex Deucher
> ---
> .../drm/amd/display/dc/clk_mgr/dcn30/dalsmc.h | 1 +
> .../display/dc/
The 'break' is unnecessary because of previous
'return', discard it.
Signed-off-by: Zhang Qilong
---
drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 6 --
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 4
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 7 ---
3 files changed, 17
On 2020-10-26 10:30 a.m., Alex Deucher wrote:
It looks this was accidently lost in a follow up patch.
dc context is large and we don't need contiguous pages.
Fixes: e4863f118a7d ("drm/amd/display: Multi display cause system lag on mode
change")
Signed-off-by: Alex Deucher
Cc: Aric Cyr
Cc: Ale
[AMD Public Use]
-Original Message-
From: amd-gfx On Behalf Of Huang Rui
Sent: Monday, October 26, 2020 6:22 PM
To: amd-gfx@lists.freedesktop.org
Cc: Huang, Ray
Subject: [PATCH] drm/amdgpu: add vangogh apu flag
This patch is to add vangogh apu flag to support more kickers that belongs
[AMD Public Use]
Acked-by: Alex Deucher
From: amd-gfx on behalf of Huang Rui
Sent: Monday, October 26, 2020 8:51 AM
To: amd-gfx@lists.freedesktop.org
Cc: Huang, Ray
Subject: [PATCH] drm/amdgpu: add vangogh apu flag
This patch is to add vangogh apu flag to su
[AMD Public Use]
> -Original Message-
> From: Michel Dänzer
> Sent: Monday, October 26, 2020 7:04 AM
> To: Alex Xu (Hello71) ; Kazlauskas, Nicholas
> ; Deucher, Alexander
> ; Wentland, Harry
> ; Li, Sun peng (Leo) ;
> amd-gfx@lists.freedesktop.org
> Cc: linux-ker...@vger.kernel.org
> Subj
It looks this was accidently lost in a follow up patch.
dc context is large and we don't need contiguous pages.
Fixes: e4863f118a7d ("drm/amd/display: Multi display cause system lag on mode
change")
Signed-off-by: Alex Deucher
Cc: Aric Cyr
Cc: Alex Xu
---
drivers/gpu/drm/amd/display/dc/core/d
[AMD Public Use]
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Christian
König
Sent: Monday, October 26, 2020 5:29 AM
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH] drm/amdgpu: drop mem_global_referenced
Not used any more.
Signed-off-by: Christian
On 2020-10-21 7:31 p.m., Bas Nieuwenhuizen wrote:
Prepare for inserting modifiers based configuration, while sharing
a bunch of DCC validation & initializing the device-based configuration.
Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Nicholas Kazlauskas
Regards,
Nicholas Kazlauskas
---
On 2020-10-21 7:31 p.m., Bas Nieuwenhuizen wrote:
This moves the tiling_flags to the framebuffer creation.
This way the time of the "tiling" decision is the same as it
would be with modifiers.
Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Nicholas Kazlauskas
Regards,
Nicholas Kazlauskas
-
On 2020-10-21 7:31 p.m., Bas Nieuwenhuizen wrote:
With modifiers I'd like to support non-dedicated buffers for
images.
Signed-off-by: Bas Nieuwenhuizen
Cc: sta...@vger.kernel.org # 5.1.0
Reviewed-by: Nicholas Kazlauskas
Regards,
Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu
On 2020-10-21 7:31 p.m., Bas Nieuwenhuizen wrote:
Otherwise the field ends up being used uninitialized when
enabling modifiers, failing validation with high likelyhood.
Signed-off-by: Bas Nieuwenhuizen
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
On 2020-10-21 7:31 p.m., Bas Nieuwenhuizen wrote:
Silently accepting it could result in corruption.
Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
This patch is to add vangogh apu flag to support more kickers that
belongs vangogh series.
Signed-off-by: Huang Rui
---
drivers/gpu/drm/amd/amdgpu/nv.c | 4 +++-
drivers/gpu/drm/amd/include/amd_shared.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
Hi,
I frequently encounter OOM on my system, mostly due to my own fault.
Recently, I noticed that not only does a swap storm happen and OOM
killer gets invoked, but the graphics output freezes permanently.
Checking the kernel messages, I see:
kworker/u24:4: page allocation failure: order:5,
m
On 2020-10-26 5:29 a.m., Alex Xu (Hello71) wrote:
Hi,
I frequently encounter OOM on my system, mostly due to my own fault.
Recently, I noticed that not only does a swap storm happen and OOM
killer gets invoked, but the graphics output freezes permanently.
Checking the kernel messages, I see:
kw
Not used any more.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h
index 68c5e3662b87..d808b2a58b28 100644
--- a/drivers/gpu/drm/amd/am
Hi Bas,
I've been using v2 for a while so you can tag the series as:
Tested-by: Pierre-Eric Pelloux-Prayer
On 22/10/2020 01:31, Bas Nieuwenhuizen wrote:
> This adds modifier support to the amdgpu kernel drivers for GFX9 and
> later GPUs. It has been tested on
>
> - VEGA10, RAVEN, NAVI14
> - w
Keep sparse happy by preserving the __user annotation when casting.
Reported-by: kernel test robot
Signed-off-by: Rasmus Villemoes
---
kernel test robot has already started spamming me due to 9c5743dff. If
I don't fix those warnings I'll keep getting those emails for
months, so let me do the ea
Hi
Am 24.10.20 um 22:38 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Tue, Oct 20, 2020 at 02:20:46PM +0200, Thomas Zimmermann wrote:
>> At least sparc64 requires I/O-specific access to framebuffers. This
>> patch updates the fbdev console accordingly.
>>
>> For drivers with direct access to the fram
Am 24.10.20 um 01:19 schrieb Luben Tuikov:
On 2020-10-23 03:12, Christian König wrote:
Am 23.10.20 um 07:41 schrieb xinhui pan:
Size is page count here.
Signed-off-by: xinhui pan
Ah yes that one again. At some point we really need to clean that up.
Patch is Reviewed-by: Christian König
-
69 matches
Mail list logo
