Dear Roy,
Am 13.01.21 um 07:36 schrieb Roy Sun:
This fix bug where when the engine hang, the fence ring will wait without quit
and cause kernel crash
Please wrap commit message body after 75 characters. (checkpatch.pl
should have shown you that.)
Some typos:
1. fix*es*
2. hang*s*
3. P
[AMD Official Use Only - Internal Distribution Only]
>-Original Message-
>From: amd-gfx On Behalf Of Roy
>Sun
>Sent: Wednesday, January 13, 2021 2:36 PM
>To: amd-gfx@lists.freedesktop.org
>Cc: Sun, Roy
>Subject: [PATCH] drm/amdgpu: change the fence ring wait timeout
>
>This fix bug where
This fix bug where when the engine hang, the fence ring will wait without quit
and cause kernel crash
Signed-off-by: Roy Sun
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 48 ---
1 file changed, 43 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdg
[AMD Public Use]
One comment from coding-style's perspective.
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Jinzhou Su
Sent: Wednesday, January 13, 2021 11:44 AM
To: amd-gfx@lists.freedesktop.org
Cc: Su, Jinzhou (Joe) ; Huang, Ray
Subject: [PATCH 2/2] drm/amdgpu: Add se
[AMD Public Use]
Copyright year should be 2021.
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Huang Rui
Sent: Wednesday, January 13, 2021 11:52 AM
To: Su, Jinzhou (Joe)
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/amdgpu: Add Secure Display TA header f
On Wed, Jan 13, 2021 at 01:02:30PM +0800, Du, Xiaojian wrote:
> From: Xiaojian Du
>
> From: Xiaojian Du
>
> This patch is to add the workload map for vangogh.
>
> Signed-off-by: Xiaojian Du
Reviewed-by: Huang Rui
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 1 +
> 1 file cha
From: Xiaojian Du
From: Xiaojian Du
This patch is to add the workload map for vangogh.
Signed-off-by: Xiaojian Du
---
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
b/drivers/gpu/drm/amd/p
On 1/4/21 1:01 AM, Xiaogang.Chen wrote:
From: Xiaogang Chen
amdgpu DM handles INTERRUPT_LOW_IRQ_CONTEXT interrupt(hpd, hpd_rx) by
using work queue and uses single work_struct. If previous interrupt
has not been handled new interrupts(same type) will be discarded and
driver just sends "amdgpu_d
On Wed, Jan 13, 2021 at 11:43:53AM +0800, Su, Jinzhou (Joe) wrote:
> Add file ta_secureDisplay_if.h for Secure Display TA
>
> Signed-off-by: Jinzhou Su
> Reviewed-by: Huang Rui
> Reviewed-by: Alex Deucher
> ---
> .../gpu/drm/amd/amdgpu/ta_secureDisplay_if.h | 154 ++
> 1 file
Add interface to load, unload, invoke command for
secure display TA.
v2: Add debugfs interface for secure display TA
Signed-off-by: Jinzhou.Su
Reviewed-by: Huang Rui
---
drivers/gpu/drm/amd/amdgpu/Makefile | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 3 +
drivers/gpu/d
Add file ta_secureDisplay_if.h for Secure Display TA
Signed-off-by: Jinzhou Su
Reviewed-by: Huang Rui
Reviewed-by: Alex Deucher
---
.../gpu/drm/amd/amdgpu/ta_secureDisplay_if.h | 154 ++
1 file changed, 154 insertions(+)
create mode 100644 drivers/gpu/drm/amd/amdgpu/ta_secure
Modified Functions
smu_sys_set_pp_table()- modifed signature to match Powerplay API
set_pp_table
smu_force_performance_level() - modifed arg0 to match Powerplay API
force_performance_level
smu_od_edit_dpm_table() - modifed arg0 to match Powerplay API
odn_edit_dpm_table
Other
v2: fix errors and warnings flagged by checkpatch
New Functions
smu_get_mclk- implementation of the Powerplay API function get_mclk
smu_get_sclk- implementation of the Powerplay API function get_sclk
smu_handle_dpm_task - implementation of the Powerplay API function
dispatch
v2: add comment to highlight assignment that changes uint32_t value to int
fix errors flagged by checkpatch.pl
New Functions
smu_get_baco_capability() - Implement Powerplay API get_asic_baco_capability
smu_baco_set_state() - Implement Powerplay API set_asic_baco_state
Modified Functi
v2: fix errors flagged by checkpatch
New Functions
smu_bump_power_profile_mode() - changes profile mode assuming calling
function already has mutex
smu_force_ppclk_levels() - accepts Powerplay enum pp_clock_type to
specify clock to change
smu_print_ppclk_levels() - accepts Powerp
v2: updated the structure name to swsmu_pm_funcs
Modified Functions
smu_get_performance_level() - modifed arg0 to match Powerplay API
get_performance_level
Other Changes
added a new structure swsmu_dpm_funcs to hold smu functions for Powerplay API
removed special smu handling from amdgpu_g
v2: remove check for error during swsmu amdgpu_dpm_get_pp_num_states() call to
match previous powerplay behaviour
Modified Files
smu_get_power_limit() - modifed arg0 to match Powerplay API
get_power_limit
smu_set_power_limit() - modifed arg0 to match Powerplay API
set_power_
Modified Functions
smu_set_xgmi_pstate() - modifed arg0 to match Powerplay API
set_xgmi_pstate
smu_mode2_reset() - modifed arg0 to match Powerplay API
asic_reset_mode_2
smu_switch_power_profile() - modifed arg0 to match Powerplay API
switch_power_profile
smu_set_mp1_stat
v2: changed error return value of smu_get_fan_control_mode to AMD_FAN_CTRL_NONE
fixed type in amdgpu_hwmon_get_pwm1_enable() print statement
fixed indent flagged by checkpatch.pl
Modified Functions
smu_set_fan_speed_rpm() - modifed arg0 to match Powerplay API
set_fan_speed_rpm
smu
=== Description ===
Patches to add the Powerplay API to smu and simplify dpm/pm calling code
* Version 2 Updates
0001: updated the structure name to swsmu_pm_funcs
0002: No Changes
0003: changed error return value of smu_get_fan_control_mode to
AMD_FAN_CTRL_NONE
fixed type in amdgpu_hw
On Wed, Jan 13, 2021 at 10:21:26AM +0800, Huang Rui wrote:
> On Wed, Jan 13, 2021 at 10:13:02AM +0800, Alex Deucher wrote:
> > On Tue, Jan 12, 2021 at 8:19 PM Huang Rui wrote:
> > >
> > > On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote:
> > > > kernel test robot throws below warni
On Wed, Jan 13, 2021 at 10:13:02AM +0800, Alex Deucher wrote:
> On Tue, Jan 12, 2021 at 8:19 PM Huang Rui wrote:
> >
> > On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote:
> > > kernel test robot throws below warnings ->
> > >
> > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vango
On Tue, Jan 12, 2021 at 8:19 PM Huang Rui wrote:
>
> On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote:
> > kernel test robot throws below warnings ->
> >
> > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
> > warning: no previous prototype for 'vangogh_clk_dpm_is
[AMD Public Use]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Kazlauskas, Nicholas
Sent: Wednesday, January 13, 2021 12:21 AM
To: Lakha, Bhawanpreet ; Chen, Guchun
; Deucher, Alexander
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amd/display: Fix d
On Wed, Jan 13, 2021 at 09:45:31AM +0800, Feng, Kenneth wrote:
> [AMD Official Use Only - Internal Distribution Only]
>
> This can fix the problem of the below commit.
> But I'm not sure what is the real purpose of the below commit. Or can we
> revert it?
We perfer to print firmware return value
[AMD Official Use Only - Internal Distribution Only]
This can fix the problem of the below commit.
But I'm not sure what is the real purpose of the below commit. Or can we revert
it?
Thanks.
commit 72a33b4b7433780df5334f9cfb23ff51669431a0
Author: Huang Rui
Date: Fri Jan 8 16:27:15 2021 +0800
On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote:
> kernel test robot throws below warnings ->
>
> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
> warning: no previous prototype for 'vangogh_clk_dpm_is_enabled'
> [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdg
[AMD Official Use Only - Internal Distribution Only]
Would you give review?
Thanks
Xiaogang
PS: Remove drm mailing list as this patch addresses amd display specific.
-Original Message-
From: Chen, Xiaogang
Sent: Tuesday, January 12, 2021 12:38 AM
To: amd-gfx@lists.freedesktop.org; Wen
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c:253: warning:
> Function parameter or member 'pStream' not described in
> 'dc_optimize_timing_for_fsft'
> drivers/gpu/drm/amd/amdg
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:119: warning:
> Cannot understand
> *
>
> Cc: Harry W
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:522:17:
> warning: no previous prototype for ‘dce60_aux_engine_create’
> [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu
On Mon, Jan 11, 2021 at 2:55 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:54:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:614:22:
> warning: no prev
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_timing_generator.c:192:6:
> warning: no previous prototype for ‘dce60_configure_crc’
> [-Wmissing-prototypes]
>
> Cc: Harry Wentland
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_transform_v.c:228:
> warning: bad line:void
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_transform_v.c:233:
> warning
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:262:15:
> warning: initialized field overwritten [-Woverride-init]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:66:
>
> drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_0_sh_mask.h:5936:51:
> warning:
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:1034:6:
> warning: no previous prototype for ‘dce110_mem_input_v_construct’
> [-Wmissing-prototypes]
>
> Cc: Harry Wentl
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator_v.c:54:
> warning: Function parameter or member 'tg' not described in
> 'dce110_timing_generator_v_enable_crtc'
>
On Mon, Jan 11, 2021 at 2:55 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:620:22:
> warning: no previous prototype for ‘dce112_link_encoder_create’
> [-Wmissing-prototypes]
> drivers/gpu/drm/amd/a
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.c:429:14:
> warning: no previous prototype for ‘controller_id_to_index’
> [-Wmissing-prototypes]
>
> Cc: Harry Wentland
>
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:79:
> warning: Cannot understand
>
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:602:13:
> warning: ‘dce120_timing_generator_get_position’ defined but not used
> [-Wunused-function]
>
> Cc: Har
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:613:6: warning:
> no previous prototype for ‘vangogh_clk_dpm_is_enabled’ [-Wmissing-prototypes]
>
> Cc: Alex Deucher
> Cc: "Christ
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:471:6:
> warning: no previous prototype for ‘dce_mem_input_v_is_surface_pending’
> [-Wmissing-prototypes]
> drivers/gpu
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1639:
> warning: Function parameter or member 'dc' not described in
> 'dce110_enable_accelerated_mode'
> drivers/gpu/d
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.c:415:6:
> warning: no previous prototype for
> ‘dce110_get_required_compressed_surfacesize’ [-Wmissing-prototypes]
>
> Cc:
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:
> In function ‘dce110_timing_generator_tear_down_global_swap_lock’:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59:
>
> drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10480:62:
> warning
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> This file uses a complex abstracted set of hierarchical macros to
> setup its applicable register lists within constant structures.
> However in the case of TMDS_CNTL we wish to mark it as not applicable
> for this use-case.
>
> One method would
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59:
>
> drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10014:58:
> warning
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:602:13:
> warning: ‘dce120_timing_generator_get_position’ defined but not used
> [-Wunused-function]
>
> drive
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_resource.c:426:32:
> warning: no previous prototype for ‘dce120_opp_create’ [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../dis
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> This file uses a complex abstracted set of hierarchical macros to
> setup its applicable register lists within constant structures.
> However in the case of TMDS_CNTL we wish to mark it as not applicable
> for this use-case.
>
> One method would
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:101:6:
> warning: no previous prototype for ‘dce120_timing_generator_validate_timing’
> [-Wmissing-prototypes]
>
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote:
>
> Ideally someone should strip-out all these garbage 'if 0's.
>
> Tempted to carry out the work myself on principle!
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_hw_sequencer.c:53
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.c:50:6:
> warning: no previous prototype for ‘dal_hw_factory_diag_fpga_init’
> [-Wmissing-prototypes]
>
> Cc: Ha
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:43:
> warning: ‘struct hw_factory’ declared inside parameter list will not be
> visible outside of this def
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/irq/irq_service.c:82:31: warning:
> no previous prototype for ‘find_irq_source_info’ [-Wmissing-prototypes]
>
> Cc: Harry Wentland
> Cc: Leo Li
> C
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_translate_diag.c:37:6:
> warning: no previous prototype for ‘dal_hw_translate_diag_fpga_init’
> [-Wmissing-prototypes]
>
> Cc
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote:
>
> The header doesn't provide any additional parameter descriptions.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c:1104: warning:
> Cannot understand
>
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:109: warning:
> Function parameter or member 'opp110' not described in 'set_truncation'
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c: In function
> ‘dce110_link_encoder_update_mst_stream_allocation_table’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_l
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c: In function
> ‘dce_aux_transfer_raw’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c:579:7: warning:
> variable ‘bytes_rep
On Tue, Jan 12, 2021 at 3:23 PM Souptick Joarder wrote:
>
> kernel test robot throws below warnings ->
>
> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
> warning: no previous prototype for 'vangogh_clk_dpm_is_enabled'
> [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../pm
kernel test robot throws below warnings ->
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for 'vangogh_clk_dpm_is_enabled'
[-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for f
This patch repaces drm_modeset_lock_all() and drm_modeset_unlock_all
with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END()
respectivley according to Documentation/gpu/todo.rst.
r is used for the ret value in DRM_MODESET_LOCK_ALL_BEGIN since r is set
before any branches.
Signed-off-by:
On 2021-01-12 11:13 a.m., Bhawanpreet Lakha wrote:
[Why]
during idle optimizations we acquire the dc_lock, this lock is also
acquired during gpu_reset so we end up hanging the system due to a
deadlock
[How]
If we are in gpu reset:
- disable idle optimizations and skip calls to the dc function
[Why]
during idle optimizations we acquire the dc_lock, this lock is also
acquired during gpu_reset so we end up hanging the system due to a
deadlock
[How]
If we are in gpu reset:
- disable idle optimizations and skip calls to the dc function
v2: skip idle optimizations calls
v3: add guard for D
[AMD Public Use]
sorry, I misread your email, I will post a v3
Bhawan
From: Lakha, Bhawanpreet
Sent: January 12, 2021 11:03 AM
To: Chen, Guchun ; Kazlauskas, Nicholas
; Deucher, Alexander
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amd/display:
[AMD Public Use]
No need since "dc_allow_idle_optimizations" will not do anything for asics
below dcn3
Bhawan
From: Chen, Guchun
Sent: January 11, 2021 10:01 PM
To: Lakha, Bhawanpreet ; Kazlauskas, Nicholas
; Deucher, Alexander
Cc: amd-gfx@lists.freedesktop.or
On 1/12/21 7:32 AM, Christian König wrote:
Am 12.01.21 um 10:10 schrieb Daniel Vetter:
On Mon, Jan 11, 2021 at 03:45:10PM -0500, Andrey Grodzovsky wrote:
On 1/11/21 11:15 AM, Daniel Vetter wrote:
On Mon, Jan 11, 2021 at 05:13:56PM +0100, Daniel Vetter wrote:
On Fri, Jan 08, 2021 at 04:49:55P
So - basically allocate the page and pass it as void* pointer to drmm_add_action
with a release function which will do the free page, right ?
Andrey
On 1/12/21 4:10 AM, Daniel Vetter wrote:
drm_add_action_or_reset (for better control flow) has both a void * data
and a cleanup function (and it i
On Tue, 12 Jan 2021 16:03:41 +0100,
Alex Deucher wrote:
>
> On Tue, Jan 12, 2021 at 10:00 AM Takashi Iwai wrote:
> >
> > On Tue, 05 Jan 2021 18:52:45 +0100,
> > Alex Deucher wrote:
> > >
> > > We are able to power down the GPU and audio via the GPU driver
> > > so flag these asics as supporting r
On Tue, Jan 12, 2021 at 10:00 AM Takashi Iwai wrote:
>
> On Tue, 05 Jan 2021 18:52:45 +0100,
> Alex Deucher wrote:
> >
> > We are able to power down the GPU and audio via the GPU driver
> > so flag these asics as supporting runtime pm.
> >
> > Reviewed-by: Evan Quan
> > Signed-off-by: Alex Deuche
On Tue, Jan 12, 2021 at 9:55 AM Rodrigo Siqueira
wrote:
>
> Hi,
>
> In the V1, Wayne pointed out two problems:
>
> 1. The revert patch included one extra line that does not belong to it;
> 2. The original patch also had other fixes in the same commit;
>
> I removed the extra line from the reverted
On Tue, 05 Jan 2021 18:52:45 +0100,
Alex Deucher wrote:
>
> We are able to power down the GPU and audio via the GPU driver
> so flag these asics as supporting runtime pm.
>
> Reviewed-by: Evan Quan
> Signed-off-by: Alex Deucher
I wanted to apply this one now, but noticed that the author addres
This reverts commit 110d586ba77ed573eb7464ca69b6490ec0b70c5f.
Cc: Wayne Lin
Cc: Alexander Deucher
Cc: Harry Wentland
Cc: Roman Li
Cc: Bindu R
Cc: Daniel Vetter
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 142 +-
.../gpu/drm/amd/displa
From: Wayne Lin
[Why]
Find out when we try to disable CRC calculation, crc generation is still
enabled. Main reason is that dc_stream_configure_crc() will never get
called when the source is AMDGPU_DM_PIPE_CRC_SOURCE_NONE.
[How]
Add checking condition that when source is
AMDGPU_DM_PIPE_CRC_SOURC
This reverts commit 1206904465c8a9eebff9ca5a65effc8cf8f3cb84.
Cc: Wayne Lin
Cc: Alexander Deucher
Cc: Harry Wentland
Cc: Roman Li
Cc: Bindu R
Cc: Daniel Vetter
Signed-off-by: Rodrigo Siqueira
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 21 +--
1 file changed, 1 inse
This reverts commit b5d8f1d02ba7021cad1bd5ad8460ce5611c479d8.
Cc: Wayne Lin
Cc: Alexander Deucher
Cc: Harry Wentland
Cc: Roman Li
Cc: Bindu R
Cc: Daniel Vetter
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++-
drivers/gpu/drm/amd/display/am
Hi,
In the V1, Wayne pointed out two problems:
1. The revert patch included one extra line that does not belong to it;
2. The original patch also had other fixes in the same commit;
I removed the extra line from the reverted patch for tackling this
issue, and I added one additional patch to this
Pushed to drm-misc-next with a re-formatted commit message, thanks for
your contribution!
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
On Mon, 11 Jan 2021, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function
> ‘bw_calcs_init’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2726:1: warning:
> the frame size of 1336 bytes
On Mon, 11 Jan 2021, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function
> ‘calculate_bandwidth’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2016:1: warning:
> the frame size of 1216
On Tue, Jan 12, 2021 at 10:56 AM Thomas Zimmermann wrote:
>
> Hi
>
> Am 12.01.21 um 09:59 schrieb Daniel Vetter:
> > On Tue, Jan 12, 2021 at 09:10:30AM +0100, Thomas Zimmermann wrote:
> >> The AGP wrapper functions serve no purpose.
> >>
> >> Signed-off-by: Thomas Zimmermann
> >
> > They do, with
On Tue, Jan 12, 2021 at 07:35:30PM +0800, Du, Xiaojian wrote:
> From: Xiaojian Du
>
> From: Xiaojian Du
>
> This patch is to fix one superfluous error for renoir.
> Renoir supports 5 kinds of power profile mode:
> "FULL SCREEN 3D", "VIDEO", "VR", "COMPUTE" and "CUSTOM".
> After loading amdgpu d
From: Dennis Li
[ Upstream commit 88e21af1b3f887d217f2fb14fc7e7d3cd87ebf57 ]
When GFXOFF is enabled and GPU is idle, driver will fail to access some
registers. Therefore change to disable power gating before all access
registers with MMIO.
Dmesg log is as following:
amdgpu :03:00.0: amdgpu:
From: Jiawei Gu
[ Upstream commit e6d5c64efaa34aae3815a9afeb1314a976142e83 ]
Navi12 HDCP & DTM deinitialization needs continue to free bo if already
created though initialized flag is not set.
Reviewed-by: Alex Deucher
Signed-off-by: Jiawei Gu
Signed-off-by: Alex Deucher
Signed-off-by: Sasha
From: Xiaojian Du
[ Upstream commit 44cb39e19a05ca711bcb6e776e0a4399223204a0 ]
This patch is to fix the failure when change power profile to
"profile_peak" for renoir.
Signed-off-by: Xiaojian Du
Reviewed-by: Huang Rui
Signed-off-by: Alex Deucher
Signed-off-by: Sasha Levin
---
drivers/gpu/d
From: Dennis Li
[ Upstream commit 88e21af1b3f887d217f2fb14fc7e7d3cd87ebf57 ]
When GFXOFF is enabled and GPU is idle, driver will fail to access some
registers. Therefore change to disable power gating before all access
registers with MMIO.
Dmesg log is as following:
amdgpu :03:00.0: amdgpu:
From: Kevin Wang
[ Upstream commit a7b5d9dd57298333e6e9f4c167f01385d922bbfb ]
fix NULL pointer issue when read sysfs amdgpu_current_backlight_pwm sysfs node.
Call Trace:
[ 248.273833] BUG: kernel NULL pointer dereference, address: 0130
[ 248.273930] #PF: supervisor read access in
Am 12.01.21 um 10:10 schrieb Daniel Vetter:
On Mon, Jan 11, 2021 at 03:45:10PM -0500, Andrey Grodzovsky wrote:
On 1/11/21 11:15 AM, Daniel Vetter wrote:
On Mon, Jan 11, 2021 at 05:13:56PM +0100, Daniel Vetter wrote:
On Fri, Jan 08, 2021 at 04:49:55PM +, Grodzovsky, Andrey wrote:
Ok then,
From: Xiaojian Du
From: Xiaojian Du
This patch is to fix one superfluous error for renoir.
Renoir supports 5 kinds of power profile mode:
"FULL SCREEN 3D", "VIDEO", "VR", "COMPUTE" and "CUSTOM".
After loading amdgpu driver, the driver will set "BOOTUP_DEFAULT"
mode to APU, and it will get one s
From: Xiaojian Du
From: Xiaojian Du
This patch is to support the function to change power profile mode for
vangogh. Vangogh supports 5 kinds of power profile mode:
"FULL SCREEN 3D", "VIDEO", "VR", "COMPUTE" and "CUSTOM".
Signed-off-by: Xiaojian Du
---
drivers/gpu/drm/amd/pm/swsmu/smu11/vango
Am 11.01.21 um 16:39 schrieb Jeremy Cline:
Hi,
On Mon, Jan 11, 2021 at 09:53:56AM +0100, Christian König wrote:
Am 08.01.21 um 22:58 schrieb Jeremy Cline:
dcn20_resource_construct() includes a number of kzalloc(GFP_KERNEL)
calls which can sleep, but kernel_fpu_begin() disables preemption and
s
Am 11.01.21 um 17:32 schrieb Daniel Vetter:
On Mon, Jan 11, 2021 at 09:53:56AM +0100, Christian König wrote:
Am 08.01.21 um 22:58 schrieb Jeremy Cline:
dcn20_resource_construct() includes a number of kzalloc(GFP_KERNEL)
calls which can sleep, but kernel_fpu_begin() disables preemption and
sleep
Am 11.01.21 um 16:05 schrieb Alex Deucher:
On Mon, Jan 11, 2021 at 4:25 AM Christian König
wrote:
Am 08.01.21 um 16:42 schrieb Nirmoy:
On 1/8/21 4:25 PM, Christian König wrote:
Am 18.12.20 um 15:40 schrieb Nirmoy Das:
Use amdgpu_sa_bo instead of amdgpu_bo.
v2:
* do not initialize bo to get
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Xiaojian Du
-Original Message-
From: Huang, Ray
Sent: 2021年1月12日 18:25
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Liu, Aaron
; Du, Xiaojian ; Hou, Xiaomeng
(Matthew) ; Quan, Evan ; Huang, Ray
Subject:
0 should be right driver return value, 0x1 is the right firmware
return value. So switch to 0 at last.
Signed-off-by: Huang Rui
---
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
b/drivers/gpu/drm/amd/pm/swsmu/sm
On Mon, Jan 11, 2021 at 11:46:38AM +, Colin King wrote:
> From: Colin Ian King
>
> A recent change added a new BOOTUP_DEFAULT power profile mode
> to the PP_SMC_POWER_PROFILE enum but omitted updating the
> corresponding profile_name array. Fix this by adding in the
> missing BOOTUP_DEFAULT
1 - 100 of 123 matches
Mail list logo
