Re: Enable fp16 display support for DCE8+, next try.

2021-01-20 Thread Mario Kleiner
On Mon, Jan 4, 2021 at 6:16 PM Alex Deucher wrote: > > On Mon, Dec 28, 2020 at 1:51 PM Mario Kleiner > wrote: > > > > Hi and happy post-christmas! > > > > I wrote a patch 1/1 that now checks plane scaling factors against > > the pixel-format specific limits in the asic specific dc_plane_cap > > s

[PATCH 2/2] drm/amd/display: Fix HDMI deep color output for DCE 6-11.

2021-01-20 Thread Mario Kleiner
This fixes corrupted display output in HDMI deep color 10/12 bpc mode at least as observed on AMD Mullins, DCE-8.3. It will hopefully also provide fixes for other DCE's up to DCE-11, assuming those will need similar fixes, but i could not test that for HDMI due to lack of suitable hw, so viewer di

[PATCH 1/2] drm/amd/display: Fix 10/12 bpc setup in DCE output bit depth reduction.

2021-01-20 Thread Mario Kleiner
In set_clamp(), the comments and definitions for the COLOR_DEPTH_101010 and COLOR_DEPTH_121212 cases directly contradict the code comment which explains how this should work, whereas the COLOR_DEPTH_888 case is consistent with the code comments. Comment says the bitmask should be chosen to align to

Some HDMI deep color output fixes for DC on DCE 6-11

2021-01-20 Thread Mario Kleiner
Hi, these two patches fix non-working HDMI deep color output on DCE-8.3, AMD Mullins when amdgpu-kms is used with Displaycore force-enabled, ie. for radeon.cik_support=0 amdgpu.cik_support=1 amdgpu.dc=1: I suspect they might fix similar problems on other older asics of DCE-11.0 and earlier. Patch

[PATCH 1/1] drm/amdgpu: Make contiguous pinning optional

2021-01-20 Thread Felix Kuehling
Enable pinning of VRAM without forcing it to be contiguous. When memory is already pinned, make sure it's contiguous if requested. Suggested-by: Christian König Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(

[PATCH v2] Revert "drm/amd/display: Tune min clk values for MPO for RV"

2021-01-20 Thread Pratik Vishwakarma
This reverts commit 6f3fca64cfb91fedf9b34ea27b2581e88d48c9b2. Original issue of flash line when MPO enabled on idle screen was fixed by raising clocks. This had negative effect of extra power being drained. With the upstream commit 9d03bb102028 ("drm/amd/display: disable dcn10 pipe split by default

RE: [PATCH] drm/amd/amdgpu: add error handling to amdgpu_virt_read_pf2vf_data

2021-01-20 Thread Chen, JingWen
[AMD Official Use Only - Approved for External Use] Ping Best Regards, JingWen Chen -Original Message- From: Jingwen Chen Sent: Tuesday, January 19, 2021 5:07 PM To: amd-gfx@lists.freedesktop.org Cc: Chen, JingWen ; Chen, JingWen Subject: [PATCH] drm/amd/amdgpu: add error handling to

RE: [PATCH] drm/amd/pm: print the timeout of smc message

2021-01-20 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan -Original Message- From: Huang, Ray Sent: Wednesday, January 20, 2021 8:13 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan ; Huang, Ray Subject: [PATCH] drm/amd/pm: print the timeout o

Re: [PATCH] drm/amdgpu: Allow GfxOff on Vangogh as default

2021-01-20 Thread Huang Rui
On Thu, Jan 21, 2021 at 10:13:40AM +0800, Su, Jinzhou (Joe) wrote: > Send allow GfxOff message to SMU to enter GfxOff > mode as default. > > Signed-off-by: Jinzhou Su Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[PATCH] drm/amdgpu: Allow GfxOff on Vangogh as default

2021-01-20 Thread Jinzhou Su
Send allow GfxOff message to SMU to enter GfxOff mode as default. Signed-off-by: Jinzhou Su --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c index dd102cc2516a..426a217c

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2021-01-20 Thread Alex Deucher
On Wed, Jan 20, 2021 at 3:20 AM Ard Biesheuvel wrote: > > On Tue, 5 Jan 2021 at 17:23, Alex Deucher wrote: > > > > On Tue, Jan 5, 2021 at 8:05 AM Will Deacon wrote: > > > > > > On Mon, Jan 04, 2021 at 11:27:24AM -0500, Alex Deucher wrote: > > > > On Tue, Dec 29, 2020 at 8:17 AM Ard Biesheuvel w

Re: [PATCH] drm/amd/display: Fix unused variable warning

2021-01-20 Thread Harry Wentland
On 2021-01-20 12:23 p.m., Bhawanpreet Lakha wrote: [Why] The dm struct is only being used if DCN config is defined and this causes a unused variable warning if DCN option is not set. [How] Remove the compile flag so the variable is used (there also seems to be a duplicate guard due to a bad reba

[PATCH] drm/amdgpu: Use free system memory size for kfd memory accounting

2021-01-20 Thread Oak Zeng
With the current kfd memory accounting scheme, kfd applications can use up to 15/16 of total system memory. For system which has small total system memory size it leaves small system memory for OS. For example, if the system has totally 16GB of system memory, this scheme leave OS and non-kfd applic

Re: [PATCH] drm/amdgpu: Assign boolean values to a bool variable

2021-01-20 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jan 20, 2021 at 10:05 AM Harry Wentland wrote: > > On 2021-01-20 2:16 a.m., Jiapeng Zhong wrote: > > Fix the following coccicheck warnings: > > > > ./drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c: > > 1009:6-16: WARNING: Assignment of 0/1 to boo

Re: [PATCH][next] drm/amd/display: Fix spelling mistake of function name

2021-01-20 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jan 20, 2021 at 9:46 AM Harry Wentland wrote: > > On 2021-01-20 4:26 a.m., Colin King wrote: > > From: Colin Ian King > > > > Reviewed-by: Harry Wentland > > Harry > > > There are two spelling mistakes of the function name, fix this > > by using __func__ instead

Re: [PATCH] drm/amd/display: Fix unused variable warning

2021-01-20 Thread Alex Deucher
On Wed, Jan 20, 2021 at 12:23 PM Bhawanpreet Lakha wrote: > > [Why] > The dm struct is only being used if DCN config is defined and this > causes a unused variable warning if DCN option is not set. > > [How] > Remove the compile flag so the variable is used (there also seems to be > a duplicate gu

Re: [PATCH 1/1] drm/scheduler: Job timeout handler returns status (v3)

2021-01-20 Thread Alyssa Rosenzweig
Panfrost hunks Acked-by: Alyssa Rosenzweig signature.asc Description: PGP signature ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 1/1] drm/scheduler: Job timeout handler returns status (v3)

2021-01-20 Thread Luben Tuikov
This patch does not change current behaviour. The driver's job timeout handler now returns status indicating back to the DRM layer whether the device (GPU) is no longer available, such as after it's been unplugged, or whether all is normal, i.e. current behaviour. All drivers which make use of th

[PATCH 0/1] Timeout handler now returns a value

2021-01-20 Thread Luben Tuikov
The driver's timeout handler now returns a value back up to DRM. This patch doesn't change current behaviour. I request it'd be applied so that Andrey G. can take advantage of the value sent back up to DRM from the GPU driver. This patch can be applied safely without changing the current DRM beha

Re: [PATCH v4 07/14] drm/amdgpu: Register IOMMU topology notifier per device.

2021-01-20 Thread Andrey Grodzovsky
Ping Andrey On 1/20/21 12:01 AM, Andrey Grodzovsky wrote: On 1/19/21 3:48 AM, Christian König wrote: Am 18.01.21 um 22:01 schrieb Andrey Grodzovsky: Handle all DMA IOMMU gropup related dependencies before the group is removed. Signed-off-by: Andrey Grodzovsky ---   drivers/gpu/drm/amd/amdg

Re: [PATCH v4 11/14] drm/amdgpu: Guard against write accesses after device removal

2021-01-20 Thread Andrey Grodzovsky
On 1/19/21 2:16 PM, Andrey Grodzovsky wrote: On 1/19/21 1:59 PM, Christian König wrote: Am 19.01.21 um 19:22 schrieb Andrey Grodzovsky: On 1/19/21 1:05 PM, Daniel Vetter wrote: On Tue, Jan 19, 2021 at 4:35 PM Andrey Grodzovsky wrote: There is really no other way according to this article

[PATCH] drm/amd/display: Fix unused variable warning

2021-01-20 Thread Bhawanpreet Lakha
[Why] The dm struct is only being used if DCN config is defined and this causes a unused variable warning if DCN option is not set. [How] Remove the compile flag so the variable is used (there also seems to be a duplicate guard due to a bad rebase) so remove the outer guard to fix the warning. Fi

Re: [pull] amdgpu drm-next-5.12

2021-01-20 Thread Alex Deucher
On Wed, Jan 20, 2021 at 7:10 AM Daniel Vetter wrote: > > On Wed, Jan 20, 2021 at 01:09:51AM -0500, Alex Deucher wrote: > > Hi Dave, Daniel, > > > > More new stuff for 5.12. Now with non-x86 fixed. > > > > The following changes since commit 044a48f420b9d3c19a135b821c34de5b2bee4075: > > > > drm/a

Re: [PATCH] drm/amdgpu: race issue when jobs on 2 ring timeout

2021-01-20 Thread Andrey Grodzovsky
On 1/20/21 9:12 AM, Horace Chen wrote: Fix a racing issue when jobs on 2 rings timeout simultaneously. If 2 rings timed out at the same time, the amdgpu_device_gpu_recover will be reentered. Then the adev->gmc.xgmi.head will be grabbed by 2 local linked list, which may cause wild pointer issue

Re: [PATCH v4 00/14] RFC Support hot device unplug in amdgpu

2021-01-20 Thread Daniel Vetter
On Wed, Jan 20, 2021 at 3:20 PM Andrey Grodzovsky wrote: > > > On 1/20/21 4:05 AM, Daniel Vetter wrote: > > On Tue, Jan 19, 2021 at 01:18:15PM -0500, Andrey Grodzovsky wrote: > >> On 1/19/21 1:08 PM, Daniel Vetter wrote: > >>> On Tue, Jan 19, 2021 at 6:31 PM Andrey Grodzovsky > >>> wrote: >

Re: [PATCH] drm/amdgpu: enable VCN PG and CG for yellow carp

2021-01-20 Thread Zhu, James
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: James Zhu Thanks & Best Regards! James Zhu From: Liu, Aaron Sent: Wednesday, January 20, 2021 2:51 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Zhang, Boyuan ;

Re: [PATCH] drm/amdgpu: Assign boolean values to a bool variable

2021-01-20 Thread Harry Wentland
On 2021-01-20 2:16 a.m., Jiapeng Zhong wrote: Fix the following coccicheck warnings: ./drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c: 1009:6-16: WARNING: Assignment of 0/1 to bool variable. ./drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c: 200:2-10: WARNIN

Re: [PATCH][next] drm/amd/display: Fix spelling mistake of function name

2021-01-20 Thread Harry Wentland
On 2021-01-20 4:26 a.m., Colin King wrote: From: Colin Ian King Reviewed-by: Harry Wentland Harry There are two spelling mistakes of the function name, fix this by using __func__ instead of a hard coded name string. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc/core

Re: [PATCH] drm/amd/display: Implement functions to let DC allocate GPU memory

2021-01-20 Thread Christian König
Am 20.01.21 um 15:16 schrieb Kazlauskas, Nicholas: On 2021-01-20 5:26 a.m., Christian König wrote: Am 19.01.21 um 21:40 schrieb Bhawanpreet Lakha: From: Harry Wentland [Why] DC needs to communicate with PM FW through GPU memory. In order to do so we need to be able to allocate memory from wit

[PATCH][next] drm/amd/display: Fix spelling mistake of function name

2021-01-20 Thread Colin King
From: Colin Ian King There are two spelling mistakes of the function name, fix this by using __func__ instead of a hard coded name string. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

Re: [PATCH v4 00/14] RFC Support hot device unplug in amdgpu

2021-01-20 Thread Andrey Grodzovsky
On 1/20/21 4:05 AM, Daniel Vetter wrote: On Tue, Jan 19, 2021 at 01:18:15PM -0500, Andrey Grodzovsky wrote: On 1/19/21 1:08 PM, Daniel Vetter wrote: On Tue, Jan 19, 2021 at 6:31 PM Andrey Grodzovsky wrote: On 1/19/21 9:16 AM, Daniel Vetter wrote: On Mon, Jan 18, 2021 at 04:01:09PM -0500, A

Re: [PATCH] drm/amd/display: Implement functions to let DC allocate GPU memory

2021-01-20 Thread Kazlauskas, Nicholas
On 2021-01-20 5:26 a.m., Christian König wrote: Am 19.01.21 um 21:40 schrieb Bhawanpreet Lakha: From: Harry Wentland [Why] DC needs to communicate with PM FW through GPU memory. In order to do so we need to be able to allocate memory from within DC. [How] Call amdgpu_bo_create_kernel to alloc

Re: [PATCH] drm/amd/pm: print the timeout of smc message

2021-01-20 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Huang Rui Sent: Wednesday, January 20, 2021 8:13 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan ; Huang, Ray Subject: [PATCH] drm/amd/pm: print the time

Re: [PATCH] drm/amdgpu: remove gpu info firmware of green sardine

2021-01-20 Thread Huang Rui
On Tue, Jan 19, 2021 at 10:11:54PM +0800, Alex Deucher wrote: > On Tue, Jan 19, 2021 at 2:20 AM Liang, Prike wrote: > > > > [AMD Official Use Only - Internal Distribution Only] > > > > > -Original Message- > > > From: Huang, Ray > > > Sent: Tuesday, January 19, 2021 2:57 PM > > > To: Lian

[PATCH] drm/amd/pm: print the timeout of smc message

2021-01-20 Thread Huang Rui
This patch is to help firmware designer to know the smc message timeout status. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/sws

Re: [pull] amdgpu drm-next-5.12

2021-01-20 Thread Daniel Vetter
On Wed, Jan 20, 2021 at 01:09:51AM -0500, Alex Deucher wrote: > Hi Dave, Daniel, > > More new stuff for 5.12. Now with non-x86 fixed. > > The following changes since commit 044a48f420b9d3c19a135b821c34de5b2bee4075: > > drm/amdgpu: fix DRM_INFO flood if display core is not supported (bug > 21

Re: [PATCH] drm/amd/display: Implement functions to let DC allocate GPU memory

2021-01-20 Thread Christian König
Am 19.01.21 um 21:40 schrieb Bhawanpreet Lakha: From: Harry Wentland [Why] DC needs to communicate with PM FW through GPU memory. In order to do so we need to be able to allocate memory from within DC. [How] Call amdgpu_bo_create_kernel to allocate GPU memory and use a list in amdgpu_display_m

Re: [PATCH v4 00/14] RFC Support hot device unplug in amdgpu

2021-01-20 Thread Daniel Vetter
On Tue, Jan 19, 2021 at 01:18:15PM -0500, Andrey Grodzovsky wrote: > > On 1/19/21 1:08 PM, Daniel Vetter wrote: > > On Tue, Jan 19, 2021 at 6:31 PM Andrey Grodzovsky > > wrote: > > > > > > On 1/19/21 9:16 AM, Daniel Vetter wrote: > > > > On Mon, Jan 18, 2021 at 04:01:09PM -0500, Andrey Grodzovsk

Re: [PATCH v4 07/14] drm/amdgpu: Register IOMMU topology notifier per device.

2021-01-20 Thread Daniel Vetter
On Wed, Jan 20, 2021 at 5:21 AM Andrey Grodzovsky wrote: > > > On 1/19/21 5:01 PM, Daniel Vetter wrote: > > On Tue, Jan 19, 2021 at 10:22 PM Andrey Grodzovsky > > wrote: > >> > >> On 1/19/21 8:45 AM, Daniel Vetter wrote: > >> > >> On Tue, Jan 19, 2021 at 09:48:03AM +0100, Christian König wrote: >

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2021-01-20 Thread Ard Biesheuvel
On Tue, 5 Jan 2021 at 17:23, Alex Deucher wrote: > > On Tue, Jan 5, 2021 at 8:05 AM Will Deacon wrote: > > > > On Mon, Jan 04, 2021 at 11:27:24AM -0500, Alex Deucher wrote: > > > On Tue, Dec 29, 2020 at 8:17 AM Ard Biesheuvel wrote: > > > > > > > > On Wed, 16 Dec 2020 at 23:26, Ard Biesheuvel w