[PATCH] drm/amd/display: Allow spatial dither to 10 bpc on all DCE

From: Mario Kleiner Spatial dithering to 10 bpc depth was disabled for all DCE's. Testing on DCE-8.3 and DCE-11.2 did not show any obvious ill effects, but a measureable precision improvement (via colorimeter) when displaying a fp16 framebuffer to a 10 bpc DP or HDMI connected HDR-10 monitor. v

[PATCH] drm/admgpu: Set reference clock to 100Mhz on Renoir (v2)

Fixes the rlc reference clock used for GPU timestamps. Value is 100Mhz. Confirmed with hardware team. v2: reword commit message. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1480 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v2] drm/scheduler: Fix hang when sched_entity released

Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in drm_sched_entity_flush. This is because drm_sched_entity_is_idle never becomes false. Fix: In drm_sched_fini detach all sched_entities from the scheduler's run queu

Re: [PATCH] drm/scheduler: Fix hang when sched_entity released

Will do. Andrey On 2/17/21 4:37 PM, Christian König wrote: Am 17.02.21 um 22:36 schrieb Andrey Grodzovsky: On 2/17/21 4:32 PM, Christian König wrote: Am 16.02.21 um 18:07 schrieb Andrey Grodzovsky: Problem: If scheduler is already stopped by the time sched_entity is released and entity's

Re: [PATCH] drm/scheduler: Fix hang when sched_entity released

Am 17.02.21 um 22:36 schrieb Andrey Grodzovsky: On 2/17/21 4:32 PM, Christian König wrote: Am 16.02.21 um 18:07 schrieb Andrey Grodzovsky: Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in drm_sched_entity_fl

Re: [PATCH] drm/scheduler: Fix hang when sched_entity released

On 2/17/21 4:32 PM, Christian König wrote: Am 16.02.21 um 18:07 schrieb Andrey Grodzovsky: Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in drm_sched_entity_flush. This is because drm_sched_entity_is_idle never

Re: [PATCH] drm/scheduler: Fix hang when sched_entity released

Am 16.02.21 um 18:07 schrieb Andrey Grodzovsky: Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in drm_sched_entity_flush. This is because drm_sched_entity_is_idle never becomes false. Fix: In drm_sched_fini detac

RE: [PATCH 1/8] drm/amdgpu: new resource cursor

[AMD Official Use Only - Internal Distribution Only] Very nice cleaning! Series is Acked-by: Oak Zeng Regards, Oak > -Original Message- > From: amd-gfx On Behalf Of > Christian König > Sent: Wednesday, February 17, 2021 2:00 PM > To: Errabolu, Ramesh ; amd- > g...@lists.freedesktop.org

[PATCH] drm/admgpu: Set reference clock to 100Mhz on Renoir

Fixes the rlc reference clock used for GPU timestamps. Hardcode for now. The proper fix would be to look up the values from the proper vbios table. This will be in a follow up patch. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1480 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/a

[PATCH 6/8] drm/amdgpu: use new cursor in amdgpu_mem_visible

Separate the drm_mm_node walking from the actual handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

[PATCH 5/8] drm/amdgpu: use the new cursor in amdgpu_ttm_access_memory

Separate the drm_mm_node walking from the actual handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 67 +++-- 1 file changed, 18 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amd

[PATCH 2/8] drm/amdgpu: use the new cursor in amdgpu_ttm_copy_mem_to_mem

Separate the drm_mm_node walking from the actual handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 83 +++-- 1 file changed, 24 insertions(+), 59 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amd

[PATCH 1/8] drm/amdgpu: new resource cursor

Allows to walk over the drm_mm nodes in a TTM resource object. Signed-off-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_res_cursor.h| 105 ++ 1 file changed, 105 insertions(+) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h diff --git a/drivers/gpu

[PATCH 7/8] drm/amdgpu: use the new cursor in amdgpu_ttm_bo_eviction_valuable

Separate the drm_mm_node walking from the actual handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_tt

[PATCH 8/8] drm/amdgpu: use the new cursor in the VM code

Separate the drm_mm_node walking from the actual handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 55 +- 1 file changed, 18 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdg

[PATCH 3/8] drm/amdgpu: use the new cursor in amdgpu_fill_buffer

Separate the drm_mm_node walking from the actual handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 65 ++--- 1 file changed, 15 insertions(+), 50 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amd

[PATCH 4/8] drm/amdgpu: use new cursor in amdgpu_ttm_io_mem_pfn

Separate the drm_mm_node walking from the actual handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c ind

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

On Mon 2021-02-15 16:39:26, Andy Shevchenko wrote: > +Cc: Sakari and printk people > > On Mon, Feb 15, 2021 at 4:28 PM Christian König > wrote: > > Am 15.02.21 um 15:21 schrieb Andy Shevchenko: > > > We have already few similar implementation and a lot of code that can > > > benefit > > > of the

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

On Wed, 17 Feb 2021, Petr Mladek wrote: > On Mon 2021-02-15 16:39:26, Andy Shevchenko wrote: >> +Cc: Sakari and printk people >> >> On Mon, Feb 15, 2021 at 4:28 PM Christian König >> wrote: >> > Am 15.02.21 um 15:21 schrieb Andy Shevchenko: >> > > We have already few similar implementation and a

Re: [PATCH] drm/amdgpu/display: restore AUX_DPHY_TX_CONTROL for DCN2.x

On 2021-02-16 12:28 p.m., Alex Deucher wrote: Commit 098214999c8f added fetching of the AUX_DPHY register values from the vbios, but it also changed the default values in the case when there are no values in the vbios. This causes problems with displays with high refresh rates. To fix this, swi

Re: [PATCH] drm/scheduler: Fix hang when sched_entity released

Ping Andrey On 2/16/21 12:07 PM, Andrey Grodzovsky wrote: Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in drm_sched_entity_flush. This is because drm_sched_entity_is_idle never becomes false. Fix: In drm_sche

Re: [PATCH] drm/amd/display: Old sequence for HUBP blank

On 2021-02-17 10:29 a.m., Rodrigo Siqueira wrote: On 02/17, Aurabindo Pillai wrote: On 2021-02-17 8:40 a.m., Rodrigo Siqueira wrote: Hi, Is this commit a direct revert from be7af780ef3cbb8fe1004db48dc66caf2da595cd ? If so, I recommend you to use the standard way to identify "revert" comm

Re: [PATCH] drm/amd/display: Old sequence for HUBP blank

On 02/17, Aurabindo Pillai wrote: > > > On 2021-02-17 8:40 a.m., Rodrigo Siqueira wrote: > > Hi, > > > > Is this commit a direct revert from > > be7af780ef3cbb8fe1004db48dc66caf2da595cd ? > > > > If so, I recommend you to use the standard way to identify "revert" > > commits by using 'Revert "C

lots of bugreports about a kernel-backtrace starting with amdgpu_dm_backlight_update_status

Hi All, Fedora has a (opt-in) system to automatically collect backtraces from software crashing on users systems. This includes collecting kernel backtraces (including once triggered by WARN macros) while looking a the top 10 of the most reported backtrace during the last 2 weeks report from ABR

[PATCH v2] Revert "drm/amd/display: New sequence for HUBP blank"

This reverts commit be7af780ef3cbb8fe1004db48dc66caf2da595cd because the new proposed sequence for HUBP blanking causes regressions. This change brings back the old sequence. Signed-off-by: Aurabindo Pillai Signed-off-by: Bhawanpreet Lakha --- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 36

Re: [PATCH] drm/amd/display: Old sequence for HUBP blank

On 2021-02-17 8:40 a.m., Rodrigo Siqueira wrote: Hi, Is this commit a direct revert from be7af780ef3cbb8fe1004db48dc66caf2da595cd ? If so, I recommend you to use the standard way to identify "revert" commits by using 'Revert "Commit header"' and the message "This reverts commit HASH" followe

Re: [PATCH] drm/amd/display: Old sequence for HUBP blank

Hi, Is this commit a direct revert from be7af780ef3cbb8fe1004db48dc66caf2da595cd ? If so, I recommend you to use the standard way to identify "revert" commits by using 'Revert "Commit header"' and the message "This reverts commit HASH" followed by the original commit description. Thanks Siqueira

Re: [PATCH] drm/amdgpu: fix an error code in init_pmu_entry_by_type_and_add()

On Tue, Feb 16, 2021 at 02:52:55PM -0500, Alex Deucher wrote: > On Tue, Feb 16, 2021 at 2:35 PM Dan Carpenter > wrote: > > > > If the kmemdup() fails then this should return a negative error code > > but it currently returns success. > > > > Fixes: b4a7db71ea06 ("drm/amdgpu: add per device user f