Re: [PATCH 1/1] drm/amdgpu: remove unused variable from struct amdgpu_bo

2021-02-18 Thread Christian König
Am 18.02.21 um 18:06 schrieb Nirmoy Das: Fixes: 62914a99dee5a("drm/amdgpu: Use mmu_interval_insert instead of hmm_mirror") Signed-off-by: Nirmoy Das Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] drm/ttm: Fix a memory leak

2021-02-18 Thread xinhui pan
Free the memory on failure. Also no need to re-alloc memory on retry. Signed-off-by: xinhui pan --- drivers/gpu/drm/ttm/ttm_bo.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index

Re: [PATCH] drm/amdgpu: fix shutdown with s0ix

2021-02-18 Thread Alex Deucher
On Thu, Feb 18, 2021 at 7:57 PM Liang, Prike wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Thanks Alex fix, I also have drafted the fix locally for the poweroff and > shutdown on the s0ix enablement. > Besides the shutdown opt fix for the reboot process and we also need a

Re: [PATCH] drm/amd/display: Allow spatial dither to 10 bpc on all DCE

2021-02-18 Thread Mario Kleiner
Your v2 has my Reviewed-by: Mario Kleiner thanks, -mario On Wed, Feb 17, 2021 at 11:51 PM Alex Deucher wrote: > From: Mario Kleiner > > Spatial dithering to 10 bpc depth was disabled for all DCE's. > > Testing on DCE-8.3 and DCE-11.2 did not show any obvious ill > effects, but a measureable

[PATCH 4/4] drm/amdgpu: Init the cp MQD if it's not be initialized before

2021-02-18 Thread shaoyunl
The MQD might not be initialized duirng first init period if the device need to be reset druing probe. Driver need to proper init them in gpu recovery period Signed-off-by: shaoyunl Change-Id: Iad58a050939af2afa46d1c74a90866c47ba9efd2 --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 20

[PATCH 3/4] drm/amdgpu: Add kfd init_complete flag to check from amdgpu side

2021-02-18 Thread shaoyunl
amdgpu driver may in reset state duirng init which will not initialize the kfd, driver need to initialize the KFD after reset by check the flag Signed-off-by: shaoyunl Change-Id: Ic1684b55b27e0afd42bee8b9b431c4fb0afcec15 --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 3 ++-

[PATCH 2/4] drm/amdgpu: get xgmi info at eary_init

2021-02-18 Thread shaoyunl
Driver need to get XGMI info function earlier before ip_init since driver need to check the XGMI setting to determine how to perform reset during init Signed-off-by: shaoyunl Change-Id: Ic37276bbb6640bb4e9360220fed99494cedd3ef5 --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 10 -- 1 file

[PATCH 1/4] drm/amdgpu: Reset the devices in the XGMI hive duirng probe

2021-02-18 Thread shaoyunl
In passthrough configuration, hypervisior will trigger the SBR(Secondary bus reset) to the devices without sync to each other. This could cause device hang since for XGMI configuration, all the devices within the hive need to be reset at a limit time slot. This serial of patches try to solve

RE: [PATCH] drm/amdgpu: fix shutdown with s0ix

2021-02-18 Thread Liang, Prike
[AMD Official Use Only - Internal Distribution Only] Thanks Alex fix, I also have drafted the fix locally for the poweroff and shutdown on the s0ix enablement. Besides the shutdown opt fix for the reboot process and we also need a similarity for the poweroff opt. So how about create a new

Re: [PATCH] drm/amd/pm/swsmu: Avoid using structure_size uninitialized in smu_cmn_init_soft_gpu_metrics

2021-02-18 Thread Wang, Kevin(Yang)
thanks, Reviewed-by: Kevin Wang Regards, Kevin > 在 2021年2月19日,06:49,Nathan Chancellor 写道: > > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:764:2: warning: > variable 'structure_size' is used uninitialized whenever switch default > is taken [-Wsometimes-uninitialized] >

[PATCH] drm/amd/pm/swsmu: Avoid using structure_size uninitialized in smu_cmn_init_soft_gpu_metrics

2021-02-18 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:764:2: warning: variable 'structure_size' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~ drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:770:23: note: uninitialized

Re: [PATCH 09/14] drm/amd/display: Add Freesync HDMI support to DM

2021-02-18 Thread Nathan Chancellor
On Thu, Feb 11, 2021 at 04:44:39PM -0500, Qingqing Zhuo wrote: > From: Stylon Wang > > [Why] > Add necessary support for Freesync HDMI in Linux DM > > [How] > - Support Freesync HDMI by calling DC interace > - Report Freesync capability to vrr_range debugfs from DRM > - Depends on coming

[pull] amdgpu, amdkfd, radeon drm-next-5.12

2021-02-18 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.12. The following changes since commit 4c3a3292730c56591472717d8c5c0faf74f6c6bb: drm/amd/display: fix unused variable warning (2021-02-05 09:49:44 +1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [PATCH v4 00/14] RFC Support hot device unplug in amdgpu

2021-02-18 Thread Andrey Grodzovsky
Looked a bit into it, I want to export sync_object to FD and import  from that FD such that I will wait on the imported sync object handle from one thread while signaling the exported sync object handle from another (post device unplug) ? My problem is how to create a sync object with a non

Re: [PATCH] drm/amd/display: Simplify bool conversion

2021-02-18 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Feb 18, 2021 at 9:23 AM Yang Li wrote: > > Fix the following coccicheck warning: > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8142:16-21: WARNING: > conversion to bool not needed here > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- >

[PATCH] drm/amdgpu: fix shutdown with s0ix

2021-02-18 Thread Alex Deucher
For shutdown needs to be handled differently and s0ix. Add a new flag to shutdown and use it to adjust behavior appropriately. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1499 Fixes: 628c36d7b238e2 ("drm/amdgpu: update amdgpu device suspend/resume sequence for s0i3 support")

[PATCH 1/1] drm/amdgpu: remove unused variable from struct amdgpu_bo

2021-02-18 Thread Nirmoy Das
Fixes: 62914a99dee5a("drm/amdgpu: Use mmu_interval_insert instead of hmm_mirror") Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h

Re: [PATCH v2] drm/scheduler: Fix hang when sched_entity released

2021-02-18 Thread Andrey Grodzovsky
On 2/18/21 10:15 AM, Christian König wrote: Am 18.02.21 um 16:05 schrieb Andrey Grodzovsky: On 2/18/21 3:07 AM, Christian König wrote: Am 17.02.21 um 22:59 schrieb Andrey Grodzovsky: Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not

Re: [PATCH v2] drm/scheduler: Fix hang when sched_entity released

2021-02-18 Thread Christian König
Am 18.02.21 um 16:05 schrieb Andrey Grodzovsky: On 2/18/21 3:07 AM, Christian König wrote: Am 17.02.21 um 22:59 schrieb Andrey Grodzovsky: Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in

Re: [PATCH v2] drm/scheduler: Fix hang when sched_entity released

2021-02-18 Thread Andrey Grodzovsky
On 2/18/21 3:07 AM, Christian König wrote: Am 17.02.21 um 22:59 schrieb Andrey Grodzovsky: Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in drm_sched_entity_flush. This is because drm_sched_entity_is_idle

RE: [PATCH] drm/amdgpu/vcn3.0: add wptr/rptr reset/update for share memory

2021-02-18 Thread Liu, Leo
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Leo Liu From: amd-gfx On Behalf Of Jiang, Sonny Sent: February 18, 2021 9:34 AM To: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu/vcn3.0: add wptr/rptr reset/update for share memory [AMD Official Use Only -

Re: [PATCH] drm/amdgpu/vcn3.0: add wptr/rptr reset/update for share memory

2021-02-18 Thread Jiang, Sonny
[AMD Official Use Only - Internal Distribution Only] Ping. From: Jiang, Sonny Sent: Wednesday, February 10, 2021 8:31 PM To: amd-gfx@lists.freedesktop.org Cc: Jiang, Sonny Subject: [PATCH] drm/amdgpu/vcn3.0: add wptr/rptr reset/update for share memory Because

[PATCH] drm/amd/display: Simplify bool conversion

2021-02-18 Thread Yang Li
Fix the following coccicheck warning: ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8142:16-21: WARNING: conversion to bool not needed here Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH 1/8] drm/amdgpu: new resource cursor

2021-02-18 Thread Nirmoy
Tested on RX 580. The series is Tested-by: Nirmoy Das On 2/17/21 8:00 PM, Christian König wrote: Allows to walk over the drm_mm nodes in a TTM resource object. Signed-off-by: Christian König --- .../gpu/drm/amd/amdgpu/amdgpu_res_cursor.h| 105 ++ 1 file changed, 105

Re: [PATCH] drm/admgpu: Set reference clock to 100Mhz on Renoir (v2)

2021-02-18 Thread Christian König
Am 17.02.21 um 23:20 schrieb Alex Deucher: Fixes the rlc reference clock used for GPU timestamps. Value is 100Mhz. Confirmed with hardware team. v2: reword commit message. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1480 Signed-off-by: Alex Deucher Acked-by: Christian König ---

Re: [PATCH v2] drm/scheduler: Fix hang when sched_entity released

2021-02-18 Thread Christian König
Am 17.02.21 um 22:59 schrieb Andrey Grodzovsky: Problem: If scheduler is already stopped by the time sched_entity is released and entity's job_queue not empty I encountred a hang in drm_sched_entity_flush. This is because drm_sched_entity_is_idle never becomes false. Fix: In drm_sched_fini