RE: [PATCH v2] drm/amdgpu: reserve backup pages for bad page retirment

[AMD Public Use] Please fix the commit description since this has nothing to do with user experience. This is to ensure user have a constant of HBM memory to accessible to them in run-time. With that fixed, the patch is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message-

[PATCH v2] drm/amdgpu: reserve backup pages for bad page retirment

it's not user friendly that users' visiable unused memories are decreased when bad pages are retired. Therefore reserve limit backup pages when init, and return ones when bad pages retired, to keep no change of unused memory size. v2: refine codes to calculate badpags threshold Signed-off-by:

[PATCH 3/8] amdgpu/pm: Powerplay API for smu , changed 6 pm hwmon fan functions to use API

v2: changed error return value of smu_get_fan_control_mode to AMD_FAN_CTRL_NONE fixed type in amdgpu_hwmon_get_pwm1_enable() print statement fixed indent flagged by checkpatch.pl Modified Functions smu_set_fan_speed_rpm() - modifed arg0 to match Powerplay API set_fan_speed_rpm

[PATCH 5/8] amdgpu/pm: Powerplay API for smu , changed 5 dpm powergating & sensor functions to use API

v2: add comment to highlight assignment that changes uint32_t value to int fix errors flagged by checkpatch.pl New Functions smu_get_baco_capability() - Implement Powerplay API get_asic_baco_capability smu_baco_set_state() - Implement Powerplay API set_asic_baco_state Modified

[PATCH 7/8] amdgpu/pm: Powerplay API for smu , changed 4 dpm functions to use API

v2: fix errors and warnings flagged by checkpatch v3: Context mismatch with revision v3 to patch 0003 New Functions smu_get_mclk- implementation of the Powerplay API function get_mclk smu_get_sclk- implementation of the Powerplay API function get_sclk smu_handle_dpm_task -

[PATCH 8/8] amdgpu/pm: Powerplay API for smu , updates to some pm functions

v3: updated to include new clocks od_vddgfx_offset, od_cclk Context mismatch with revision v3 to patch 0003 Modified Functions smu_sys_set_pp_table()- modifed signature to match Powerplay API set_pp_table smu_force_performance_level() - modifed arg0 to match Powerplay API

[PATCH 6/8] amdgpu/pm: Powerplay API for smu , changes to clock and profile mode functions

v3: updated to include new clocks vclk, dclk, od_vddgfx_offset, od_cclk added in commits 771fc82ffc710 & f40074fde207e Added forward declaration for function smu_force_smuclk_levels to resolve clash with commit 9485ed36411b7 Resolved context clashes with commit dfb3bb7fccb37 and v3

[PATCH 4/8] amdgpu/pm: Powerplay API for smu , changed 9 pm power functions to use API

v2: remove check for error during swsmu amdgpu_dpm_get_pp_num_states() call to match previous powerplay behaviour v3: removed smu implementation of powerplay get_power_limit, which clashed with commit dfb3bb7fccb37 Resolved context clashes caused by commits 9485ed36411b7, 766e03739bce7

[PATCH 2/8] amdgpu/pm: Powerplay API for smu , changed 6 dpm reset functions to use API

Modified Functions smu_set_xgmi_pstate() - modifed arg0 to match Powerplay API set_xgmi_pstate smu_mode2_reset() - modifed arg0 to match Powerplay API asic_reset_mode_2 smu_switch_power_profile() - modifed arg0 to match Powerplay API switch_power_profile

[PATCH 1/8] amdgpu/pm: Powerplay API for smu , added get_performance_level

v2: updated the structure name to swsmu_pm_funcs Modified Functions smu_get_performance_level() - modifed arg0 to match Powerplay API get_performance_level Other Changes added a new structure swsmu_dpm_funcs to hold smu functions for Powerplay API removed special smu handling from

[PATCH 0/8] amdgpu/pm: Powerplay API for smu

=== Description === Patches to add the Powerplay API to smu and simplify dpm/pm calling code === Patch Summary === linux: (g...@gitlab.freedesktop.org:agd5f/linux.git) origin/amd-staging-drm-next @ 317990c7e076 + linux-d0f58ed28940 0001 amdgpu/pm: Powerplay API for smu , added

RE: [PATCH 2/2] drm/amd/pm: optimize the link width/speed retrieving

[AMD Official Use Only - Internal Distribution Only] PMFW of Arcturus does not expose us those information. So, we have to stick to current implementation(smu_v11_0_get_current_pcie_link_width/speed) for Arcturus. Regards Evan -Original Message- From: Alex Deucher Sent: Tuesday,

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

I think Alex moved to gitlab for his branches On Tue, Feb 23, 2021, 12:50 AM Simon Ser wrote: > On Tuesday, February 23rd, 2021 at 12:44 AM, Nathan Chancellor < > nat...@kernel.org> wrote: > > > On Mon, Feb 22, 2021 at 11:05:17PM +, Simon Ser wrote: > > > On Monday, February 22nd, 2021 at

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

On Mon, Feb 22, 2021 at 11:50:06PM +, Simon Ser wrote: > On Tuesday, February 23rd, 2021 at 12:44 AM, Nathan Chancellor > wrote: > > > On Mon, Feb 22, 2021 at 11:05:17PM +, Simon Ser wrote: > > > On Monday, February 22nd, 2021 at 8:25 PM, Souptick Joarder > > > wrote: > > > > > > > >>

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

On Tuesday, February 23rd, 2021 at 12:44 AM, Nathan Chancellor wrote: > On Mon, Feb 22, 2021 at 11:05:17PM +, Simon Ser wrote: > > On Monday, February 22nd, 2021 at 8:25 PM, Souptick Joarder > > wrote: > > > > > >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9804:38: > > >

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

On Mon, Feb 22, 2021 at 11:05:17PM +, Simon Ser wrote: > On Monday, February 22nd, 2021 at 8:25 PM, Souptick Joarder > wrote: > > > >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9804:38: > > >> warning: variable 'i' is uninitialized when used here > > >> [-Wuninitialized] >

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

On Monday, February 22nd, 2021 at 8:25 PM, Souptick Joarder wrote: > >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9804:38: > >> warning: variable 'i' is uninitialized when used here > >> [-Wuninitialized] >timing = >detailed_timings[i]; >

RE: Overlay issues

On Monday, February 22nd, 2021 at 9:59 PM, Cornij, Nikola wrote: > [AMD Official Use Only - Approved for External Use] > > Hi Simon, > > Yes, I did have a chance to wrap this up, indeed :-) > > It turned out this and other similar setup was hitting a legit HW > limitation. I added a patch

Re: [PATCH 2/2] drm/amd/pm: optimize the link width/speed retrieving

On Sun, Feb 21, 2021 at 11:04 PM Evan Quan wrote: > > By using the information provided by PMFW when available. > > Change-Id: I1afec4cd07ac9608861ee07c449e320e3f36a932 > Signed-off-by: Evan Quan What about arcturus? Acked-by: Alex Deucher > --- > .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c

Re: [PATCH 1/2] drm/amd/pm: correct gpu metrics related data structures

On Sun, Feb 21, 2021 at 11:03 PM Evan Quan wrote: > > To make sure they are naturally aligned. > > Change-Id: I496a5b79158bdbd2e17f179098939e050b2ad489 > Signed-off-by: Evan Quan Won't this break existing apps that query this info? We need to make sure umr and rocm-smi can handle this. Alex

Re: [PATCH] drm/amdgpu/sdma5.2: Remove unnecessary conversion to bool

Applied. Thanks! Alex On Sat, Feb 20, 2021 at 3:35 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:1621:40-45: WARNING: conversion > to bool not needed here. > > ./drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:1619:40-45: WARNING:

Re: [PATCH] drm/amd/display/dc/core/dc_link_ddc: Remove unnecessary conversion to bool

Applied. Thanks! Alex On Sat, Feb 20, 2021 at 2:16 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c:544:34-39: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong

Re: [PATCH v2] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion to bool

Applied. Thanks! Alex On Sun, Feb 21, 2021 at 10:15 PM Quan, Evan wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Reviewed-by: Evan Quan > > -Original Message- > From: amd-gfx On Behalf Of Jiapeng > Chong > Sent: Saturday, February 20, 2021 10:55 AM > To:

Re: [PATCH] drm/amd/pm/swsmu: Avoid using structure_size uninitialized in smu_cmn_init_soft_gpu_metrics

Applied. Thanks! Alex On Thu, Feb 18, 2021 at 6:12 PM Wang, Kevin(Yang) wrote: > > thanks, > > Reviewed-by: Kevin Wang > > Regards, > Kevin > > > 在 2021年2月19日，06:49，Nathan Chancellor 写道： > > > > Clang warns: > > > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:764:2: warning: > >

2021 X.Org Board of Directors Elections Nomination period is NOW

We are seeking nominations for candidates for election to the X.Org Foundation Board of Directors. All X.Org Foundation members are eligible for election to the board. Nominations for the 2021 election are now open and will remain open until Sunday, the 7th of March. The Board consists of

RE: Overlay issues

[AMD Official Use Only - Approved for External Use] Hi Simon, Yes, I did have a chance to wrap this up, indeed :-) It turned out this and other similar setup was hitting a legit HW limitation. I added a patch (please see attached) that'd fail this config at validation time. The patch has been

[PATCH] drm/amdgpu/display: initialize the variable 'i'

>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9804:38: >> warning: variable 'i' is uninitialized when used here >> [-Wuninitialized] timing = >detailed_timings[i]; ^

Re: [PATCH] drm/amdgpu: stream's id should reduced after stream destruct

On 2021-02-20 1:30 a.m., ZhiJie.Zhang wrote: Signed-off-by: ZhiJie.Zhang --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c index

Re: [PATCH] drm/amdgpu: fix shutdown and poweroff process failed with s0ix

On Mon, Feb 22, 2021 at 3:25 AM Prike Liang wrote: > > In the shutdown and poweroff opt on the s0i3 system we still need > un-gate the gfx clock gating and power gating before destory amdgpu device. > > Bug: >

[PATCH] drm/radeon: A gray screen appears when going into hibernation(S4)

Radeon Card: Caicos[Radeon HD 6450/7450/8450 /R5 230 OEM] there is no gray screen when echo 4>/sys/module/drm/parameters/debug, so the WREG32 function after DRM_DEBUG_KMS may have wrong when going into hibernation.the delay of msleep(50) just can fix gray screen. Signed-off-by: wangjingyu

Re: [PATCH 08/13] drm/amd/display: Synchronize displays with different timings

[AMD Official Use Only - Internal Distribution Only] ​Hi Nils, We have incorporated the review comments and the updated patch would be applied with this promotion. @ Stempen, Vladimir, Thanks for your support. Regards, Bindu From: R, Bindu Sent:

[PATCH v2] drm/amdgpu/vcn3.0: add wptr/rptr reset/update for share memory

Because of dpg, the rptr/wptr need to be saved on fw shared memory, and restore them back in RBC_RB_RPTR/WPTR in kernel at power up. Signed-off-by: Sonny Jiang Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 13 +++-- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 24

RE: [PATCH 4/4] drm/amdgpu: Init the cp MQD if it's not be initialized before

[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Liu, Shaoyun Sent: Thursday, February 18, 2021 8:20 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: [PATCH 4/4] drm/amdgpu: Init the cp MQD if it's not be initialized before The MQD might

RE: [PATCH 3/4] drm/amdgpu: Add kfd init_complete flag to check from amdgpu side

[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Liu, Shaoyun Sent: Thursday, February 18, 2021 8:20 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: [PATCH 3/4] drm/amdgpu: Add kfd init_complete flag to check from amdgpu side amdgpu

RE: [PATCH 2/4] drm/amdgpu: get xgmi info at eary_init

[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Liu, Shaoyun Sent: Thursday, February 18, 2021 8:19 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: [PATCH 2/4] drm/amdgpu: get xgmi info at eary_init Driver need to get XGMI info function

RE: [PATCH 1/4] drm/amdgpu: Reset the devices in the XGMI hive duirng probe

[AMD Official Use Only - Internal Distribution Only] Ping. -Original Message- From: Liu, Shaoyun Sent: Thursday, February 18, 2021 8:19 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: [PATCH 1/4] drm/amdgpu: Reset the devices in the XGMI hive duirng probe In

Re: [PATCH] drm/amdgpu: fix wrong executable setting for dimgrey_cavefish_reg_init.c

[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: amd-gfx on behalf of Tao Zhou Sent: Monday, February 22, 2021 3:44 AM To: wangmin...@loongson.cn ; Zhang, Hawking ; Chen, Jiansong (Simon) ; amd-gfx@lists.freedesktop.org Cc:

Re: [PATCH 08/13] drm/amd/display: Synchronize displays with different timings

[AMD Official Use Only - Internal Distribution Only] Hi Nils,? ?Thanks for the inputs. @ Stempen, Vladimir, ? As the array 'prime_numbers' has constant values defined, we can mark this as static const. Would you like to change the count calculation -or-

Re: [PATCH v2] drm/scheduler: Fix hang when sched_entity released

Ping Andrey On 2021-02-20 7:12 a.m., Andrey Grodzovsky wrote: On 2/20/21 3:38 AM, Christian König wrote: Am 18.02.21 um 17:41 schrieb Andrey Grodzovsky: On 2/18/21 10:15 AM, Christian König wrote: Am 18.02.21 um 16:05 schrieb Andrey Grodzovsky: On 2/18/21 3:07 AM, Christian König

RE: [PATCH] drm/amdgpu: reserve backup pages for bad page retirment

[AMD Public Use] + if (!con->bad_page_cnt_threshold) { + max_eeprom_records_len = amdgpu_ras_eeprom_get_record_max_length(); + amdgpu_ras_validate_threshold(adev, max_eeprom_records_len); + + ret = amdgpu_vram_mgr_reserve_backup_pages( +

Re: [PATCH] drm/amdgpu: reserve backup pages for bad page retirment

Am 22.02.21 um 13:38 schrieb Dennis Li: it's not user friendly that users' visiable unused memories are decreased when bad pages are retired. Therefore reserve limit backup pages when init, and return ones when bad pages retired, to keep no change of unused memory size. NAK, it is even less

[PATCH] drm/amdgpu: reserve backup pages for bad page retirment

it's not user friendly that users' visiable unused memories are decreased when bad pages are retired. Therefore reserve limit backup pages when init, and return ones when bad pages retired, to keep no change of unused memory size. Signed-off-by: Dennis Li diff --git

Re: [PATCH v3 05/11] drm: Use the state pointer directly in planes atomic_check

Am 19.02.21 um 13:00 schrieb Maxime Ripard: Now that atomic_check takes the global atomic state as a parameter, we don't need to go through the pointer in the plane state. This was done using the following coccinelle script: @ plane_atomic_func @ identifier helpers; identifier func; @@

Re: [PATCH v3 02/11] drm: Rename plane atomic_check state names

Am 19.02.21 um 16:12 schrieb Maxime Ripard: Hi Thomas, Thanks for your review! On Fri, Feb 19, 2021 at 03:49:22PM +0100, Thomas Zimmermann wrote: diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 075508051b5f..1873a155bb26 100644 ---

Re: [PATCH v3 04/11] drm/atomic: Pass the full state to planes atomic_check

Am 19.02.21 um 13:00 schrieb Maxime Ripard: The current atomic helpers have either their object state being passed as an argument or the full atomic state. The former is the pattern that was done at first, before switching to the latter for new hooks or when it was needed. Let's convert all

[PATCH] drm/amdgpu: fix wrong executable setting for dimgrey_cavefish_reg_init.c

Remove executable configuration for the file. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/dimgrey_cavefish_reg_init.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/dimgrey_cavefish_reg_init.c diff --git

[PATCH] drm/amdgpu: fix shutdown and poweroff process failed with s0ix

In the shutdown and poweroff opt on the s0i3 system we still need un-gate the gfx clock gating and power gating before destory amdgpu device. Bug:

RE: [PATCH] drm/amd/pm: bump Navi1x driver if version and related data structures

[AMD Public Use] New changes were involved for the SmuMetrics strucutre. One spelling typo, s/strucutre /structure With this typo fixed, the patch is: Acked-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Evan Quan Sent: Monday, February 22, 2021 11:56

RE: [PATCH] drm/amd/pm: correct Arcturus mmTHM_BACO_CNTL register address

[AMD Public Use] Acked-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Evan Quan Sent: Monday, February 22, 2021 11:53 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH] drm/amd/pm: correct Arcturus mmTHM_BACO_CNTL