Re: linux-next: Tree for Feb 24 [drivers/gpu/drm/amd/amdgpu/amdgpu.ko]

2021-02-23 Thread Randy Dunlap
On 2/23/21 7:36 PM, Stephen Rothwell wrote: > Hi all, > > Please do not add any changes destined for v5.13 to your linux-next > included branches until after v5.12-rc1 has been released. > > Changes since 20210223: > on i386: ERROR: modpost: "__udivdi3" [drive

Re: [PATCH] drm/amdgpu: Enable SDMA MGCG for Vangogh

2021-02-23 Thread Huang Rui
On Wed, Feb 24, 2021 at 01:33:19PM +0800, Su, Jinzhou (Joe) wrote: > Add AMD_CG_SUPPORT_SDMA_MGCG for Vangogh > > Signed-off-by: Jinzhou Su Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/nv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c

Re: [PATCH] drm/amdgpu: Enable SDMA MGCG for Vangogh

2021-02-23 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: amd-gfx on behalf of Jinzhou Su Sent: Wednesday, February 24, 2021 12:33 AM To: amd-gfx@lists.freedesktop.org Cc: Su, Jinzhou (Joe) ; Huang, Ray Subject: [PATCH] drm/amdgpu: Ena

[PATCH] drm/amdgpu: Enable SDMA MGCG for Vangogh

2021-02-23 Thread Jinzhou Su
Add AMD_CG_SUPPORT_SDMA_MGCG for Vangogh Signed-off-by: Jinzhou Su --- drivers/gpu/drm/amd/amdgpu/nv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index 160fa5f59805..393a0d5905ab 100644 --- a/drivers/gpu/drm/amd/amdgpu/nv

RE: [PATCH] drm/ttm: Do not add non-system domain BO into swap list

2021-02-23 Thread Chen, Guchun
[AMD Public Use] Acked-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, February 24, 2021 11:35 AM To: Pan, Xinhui Cc: Deucher, Alexander ; Maling list - DRI developers ; Koenig, Christian ; amd-gfx list Subject: Re: [PATCH

RE: [PATCH 8/8] amdgpu/pm: Powerplay API for smu , updates to some pm functions

2021-02-23 Thread Quan, Evan
[AMD Public Use] Series is reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Darren Powell Sent: Tuesday, February 23, 2021 12:21 PM To: amd-gfx@lists.freedesktop.org Cc: Powell, Darren Subject: [PATCH 8/8] amdgpu/pm: Powerplay API for smu , updates to some pm funct

Re: [PATCH] drm/ttm: Do not add non-system domain BO into swap list

2021-02-23 Thread Alex Deucher
On Tue, Feb 23, 2021 at 10:28 PM xinhui pan wrote: > > BO would be added into swap list if it is validated into system domain. > If BO is validated again into non-system domain, say, VRAM domain. It > actually should not be in the swap list. > > Signed-off-by: xinhui pan Acked-by: Alex Deucher

[PATCH] drm/ttm: Do not add non-system domain BO into swap list

2021-02-23 Thread xinhui pan
BO would be added into swap list if it is validated into system domain. If BO is validated again into non-system domain, say, VRAM domain. It actually should not be in the swap list. Signed-off-by: xinhui pan --- drivers/gpu/drm/ttm/ttm_bo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

[PATCH 4/4] drm/amdgpu: Reset the devices in the XGMI hive duirng probe

2021-02-23 Thread shaoyunl
In passthrough configuration, hypervisior will trigger the SBR(Secondary bus reset) to the devices without sync to each other. This could cause device hang since for XGMI configuration, all the devices within the hive need to be reset at a limit time slot. This serial of patches try to solve thi

[PATCH 3/4] drm/amdgpu: Init the cp MQD if it's not be initialized before

2021-02-23 Thread shaoyunl
The MQD might not be initialized duirng first init period if the device need to be reset druing probe. Driver need to proper init them in gpu recovery period Signed-off-by: shaoyunl Acked-by: Alex Deucher Change-Id: Iad58a050939af2afa46d1c74a90866c47ba9efd2 --- drivers/gpu/drm/amd/amdgpu/gfx_v

[PATCH 2/4] drm/amdgpu: Add kfd init_complete flag to check from amdgpu side

2021-02-23 Thread shaoyunl
amdgpu driver may be in reset state during init which will not initialize the kfd, driver need to initialize the KFD after reset by check the flag Signed-off-by: shaoyunl Acked-by: Alex Deucher Change-Id: Ic1684b55b27e0afd42bee8b9b431c4fb0afcec15 --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c

[PATCH 1/4] drm/amdgpu: get xgmi info at eary_init

2021-02-23 Thread shaoyunl
Driver need to get XGMI info function earlier before ip_init since driver need to check the XGMI setting to determine how to perform reset during init Signed-off-by: shaoyunl Acked-by: Alex Deucher Change-Id: Ic37276bbb6640bb4e9360220fed99494cedd3ef5 --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c |

Re: [PATCH] drm/amdgpu: add ih call to process until checkpoint

2021-02-23 Thread Andrey Grodzovsky
On 2021-02-23 4:10 p.m., Jonathan Kim wrote: Add IH function to allow caller to process ring entries until the checkpoint write pointer. Suggested-by: Felix Kuehling Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 46 +- drivers/gpu/drm/amd

[PATCH] drm/amdgpu: add missing df counter disable write

2021-02-23 Thread Jonathan Kim
Request to stop DF performance counters is missing the actual write to the controller register. Reported-by: Chris Freehill Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c b/drivers/

[PATCH] drm/amdgpu: add ih call to process until checkpoint

2021-02-23 Thread Jonathan Kim
Add IH function to allow caller to process ring entries until the checkpoint write pointer. Suggested-by: Felix Kuehling Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 46 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 2 ++ 2 files changed, 47 in

Re: [PATCH 2/4] drm/amdgpu: get xgmi info at eary_init

2021-02-23 Thread Alex Deucher
On Tue, Feb 23, 2021 at 1:00 PM Liu, Shaoyun wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Thanks , Alex. > Whole four patches are needed for the XGMI reset to work normally . I try to > describe what these patches for in the first patch. But If you don't mind > this , I

RE: [PATCH 2/4] drm/amdgpu: get xgmi info at eary_init

2021-02-23 Thread Liu, Shaoyun
[AMD Official Use Only - Internal Distribution Only] Thanks , Alex. Whole four patches are needed for the XGMI reset to work normally . I try to describe what these patches for in the first patch. But If you don't mind this , I can adjust the order as suggested . Thanks Shaoyun.liu -

RE: [PATCH 1/4] drm/amdgpu: Reset the devices in the XGMI hive duirng probe

2021-02-23 Thread Liu, Shaoyun
[AMD Official Use Only - Internal Distribution Only] Comments inline , -Original Message- From: Alex Deucher Sent: Tuesday, February 23, 2021 11:47 AM To: Liu, Shaoyun Cc: amd-gfx list Subject: Re: [PATCH 1/4] drm/amdgpu: Reset the devices in the XGMI hive duirng probe On Thu, Feb

Re: [PATCH] drm/amdgpu: Remove unnecessary conversion to bool

2021-02-23 Thread Alex Deucher
On Mon, Feb 22, 2021 at 10:44 PM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:79:40-45: WARNING: conversion > to bool not needed here. > > ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:81:40-45: WARNING: conversion > to bool not needed h

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-23 Thread Alex Deucher
On Mon, Feb 22, 2021 at 3:13 PM Souptick Joarder wrote: > > >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9804:38: > >> warning: variable 'i' is uninitialized when used here > >> [-Wuninitialized] >timing = &edid->detailed_timings[i]; >

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-23 Thread Simon Ser
On Tuesday, February 23rd, 2021 at 6:42 PM, Alex Deucher wrote: > yeah, fdo ran out of disk space so I moved to gitlab: > > https://gitlab.freedesktop.org/agd5f/linux/-/commits/drm-next Ah, thanks for the info, my bad! ___ amd-gfx mailing list amd-gfx

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-23 Thread Alex Deucher
yeah, fdo ran out of disk space so I moved to gitlab: https://gitlab.freedesktop.org/agd5f/linux/-/commits/drm-next Alex On Mon, Feb 22, 2021 at 7:26 PM Bas Nieuwenhuizen wrote: > > I think Alex moved to gitlab for his branches > > On Tue, Feb 23, 2021, 12:50 AM Simon Ser wrote: >> >> On Tuesda

Re: [PATCH 0/3] drm/ttm: constify static vm_operations_structs

2021-02-23 Thread Alex Deucher
On Wed, Feb 10, 2021 at 8:14 AM Daniel Vetter wrote: > > On Wed, Feb 10, 2021 at 08:45:56AM +0100, Christian König wrote: > > Reviewed-by: Christian König for the series. > > Smash it into -misc? @Christian Koenig did these ever land? I don't see them in drm-misc. Alex > -Daniel > > > > > Am

Re: [PATCH 1/4] drm/amdgpu: Reset the devices in the XGMI hive duirng probe

2021-02-23 Thread Alex Deucher
On Thu, Feb 18, 2021 at 8:19 PM shaoyunl wrote: > > In passthrough configuration, hypervisior will trigger the SBR(Secondary bus > reset) to the devices > without sync to each other. This could cause device hang since for XGMI > configuration, all the devices > within the hive need to be reset a

Re: [PATCH 4/4] drm/amdgpu: Init the cp MQD if it's not be initialized before

2021-02-23 Thread Alex Deucher
On Thu, Feb 18, 2021 at 8:20 PM shaoyunl wrote: > > The MQD might not be initialized duirng first init period if the device need > to be reset > druing probe. Driver need to proper init them in gpu recovery period > > Signed-off-by: shaoyunl > Change-Id: Iad58a050939af2afa46d1c74a90866c47ba9efd2

Re: [PATCH 3/4] drm/amdgpu: Add kfd init_complete flag to check from amdgpu side

2021-02-23 Thread Alex Deucher
On Thu, Feb 18, 2021 at 8:19 PM shaoyunl wrote: > > amdgpu driver may in reset state duirng init which will not initialize the > kfd, grammer "may be in" typo duirng -> during > driver need to initialize the KFD after reset by check the flag > > Signed-off-by: shaoyunl > Change-Id: Ic1684b55b2

Re: [PATCH 2/4] drm/amdgpu: get xgmi info at eary_init

2021-02-23 Thread Alex Deucher
On Thu, Feb 18, 2021 at 8:19 PM shaoyunl wrote: > > Driver need to get XGMI info function earlier before ip_init since driver > need to check > the XGMI setting to determine how to perform reset during init > > Signed-off-by: shaoyunl > Change-Id: Ic37276bbb6640bb4e9360220fed99494cedd3ef5 I thi

Re: [PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-02-23 Thread Alex Deucher
This was already fixed by a patch from Yang Li . Alex On Tue, Feb 23, 2021 at 1:13 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8260:16-21: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot >

Re: [PATCH] drm/amd/display: Enable ASSR in Linux DM

2021-02-23 Thread Rodrigo Siqueira
Applied to amd-staging-drm-next. Thanks On 02/23, Rodrigo Siqueira wrote: > On 02/23, Stylon Wang wrote: > > ASSR implementation was already in DC and DM guarded by > > CONFIG_DRM_AMD_DC_HDCP. This patch enables ASSR if display > > declares such support in DPCD. > > > > Signed-off-by: Stylon Wan

Re: [PATCH] drm/amdgpu/display: fix compilation when CONFIG_DRM_AMD_DC_DCN is not set

2021-02-23 Thread Kazlauskas, Nicholas
On 2021-02-23 10:22 a.m., Alex Deucher wrote: Missing some CONFIG_DRM_AMD_DC_DCN ifdefs. Fixes: 9d99a805a9a0 ("drm/amd/display: Fix system hang after multiple hotplugs") Signed-off-by: Alex Deucher Cc: Stephen Rothwell Cc: Qingqing Zhuo Reviewed-by: Nicholas Kazlauskas Regards, Nicholas K

[PATCH] drm/amdgpu/display: fix compilation when CONFIG_DRM_AMD_DC_DCN is not set

2021-02-23 Thread Alex Deucher
Missing some CONFIG_DRM_AMD_DC_DCN ifdefs. Fixes: 9d99a805a9a0 ("drm/amd/display: Fix system hang after multiple hotplugs") Signed-off-by: Alex Deucher Cc: Stephen Rothwell Cc: Qingqing Zhuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ 1 file changed, 2 insertions(+) diff --g

[PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-02-23 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8260:16-21: WARNING: conversion to bool not needed here. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file changed, 1 insertion(+

[PATCH] drm/amdgpu: Remove unnecessary conversion to bool

2021-02-23 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:79:40-45: WARNING: conversion to bool not needed here. ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:81:40-45: WARNING: conversion to bool not needed here. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- dr

Re: [Intel-gfx] [PATCH 19/30] drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay()

2021-02-23 Thread Rodrigo Vivi
On Fri, Feb 19, 2021 at 04:53:15PM -0500, Lyude Paul wrote: > So that we can start using drm_dbg_*() in > drm_dp_link_train_clock_recovery_delay(). > > Signed-off-by: Lyude Paul I wonder if we could have a drm_dp so we encapsulate both aux and dpcd related information... But this one already so

Re: [PATCH] drm/amd/display: Enable ASSR in Linux DM

2021-02-23 Thread Rodrigo Siqueira
On 02/23, Stylon Wang wrote: > ASSR implementation was already in DC and DM guarded by > CONFIG_DRM_AMD_DC_HDCP. This patch enables ASSR if display > declares such support in DPCD. > > Signed-off-by: Stylon Wang > --- > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 16 > 1

Re: [PATCH 1/2] drm/amd/pm: correct gpu metrics related data structures

2021-02-23 Thread Tom St Denis
This is why I advocated for the sysfs output to be either standard packed or serialized. It was a hack as it is anyways. On Mon, Feb 22, 2021 at 4:46 PM Alex Deucher wrote: > On Sun, Feb 21, 2021 at 11:03 PM Evan Quan wrote: > > > > To make sure they are naturally aligned. > > > > Change-Id: I

[PATCH] drm/amd/display: Enable ASSR in Linux DM

2021-02-23 Thread Stylon Wang
ASSR implementation was already in DC and DM guarded by CONFIG_DRM_AMD_DC_HDCP. This patch enables ASSR if display declares such support in DPCD. Signed-off-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 16 1 file changed, 16 insertions(+) diff --git a/