RE: [PATCH] drm/amd/pm/swsmu: clean up user profile function

[AMD Public Use] -Original Message- From: Quan, Evan Sent: Tuesday, March 2, 2021 6:54 AM To: Paneer Selvam, Arunpravin ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar, Lijo ; Paneer Selvam, Arunpravin Subject: RE: [PATCH] drm/amd/pm/swsmu: clean up user profile func

Re: [PATCH] drm/ttm: ioremap buffer according to TTM mem caching setting

Hi Oak, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip linus/master v5.12-rc1 next-20210302] [cannot apply to tegra-drm/drm/tegra/for-next drm-exynos/exynos-drm-next drm/drm-next] [If your patch is

[PATCH 2/2] drm/amd/pm: update existing gpu_metrics interfaces V2

Update the gpu_metrics interface implementations to use the latest upgraded data structures. V2: fit the data type change of energy_accumulator Change-Id: Ibdbb1c3386de12c53bea3b8c68bbeebd14787287 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h| 8 ++-- .../gpu/drm/

[PATCH 1/2] drm/amd/pm: correct gpu metrics related data structures V3

To make sure they are naturally aligned. Also updating the data type for link_speed/width for future PCIE5 support. V2: define new structures with minor version bumped V3: update data type of energy_accumulator as 64bit and drop unnecessary padding members Change-Id: I0a139e1e1f09fe27deffdce1

Re: [PATCH] drm/ttm: ioremap buffer according to TTM mem caching setting

Hi Oak, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip linus/master v5.12-rc1 next-20210301] [cannot apply to tegra-drm/drm/tegra/for-next drm-exynos/exynos-drm-next drm/drm-next] [If your

RE: [PATCH 1/2] drm/amd/pm: correct gpu metrics related data structures V2

[AMD Public Use] Thanks! Will send out a new patch with these updated. Regards Evan -Original Message- From: Lazar, Lijo Sent: Monday, March 1, 2021 2:29 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: RE: [PATCH 1/2] drm/amd/pm: correct

RE: [PATCH] drm/amdgpu: enable BACO runpm by default on sienna ciclid and navy flounder

[AMD Public Use] Reviewed-by: Evan Quan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Monday, March 1, 2021 11:58 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: enable BACO runpm by default on sienna ciclid and navy flounder

RE: [PATCH] drm/amd/pm/swsmu: clean up user profile function

[AMD Official Use Only - Internal Distribution Only] -Original Message- From: amd-gfx On Behalf Of Arunpravin Sent: Tuesday, March 2, 2021 2:51 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar, Lijo ; Paneer Selvam, Arunpravin Subject: [PATCH] drm/amd/pm/swsmu: cle

[PATCH] drm/ttm: ioremap buffer according to TTM mem caching setting

If tbo.mem.bus.caching is cached, buffer is intended to be mapped as cached from CPU. Map it with ioremap_cache. This wasn't necessary before as device memory was never mapped as cached from CPU side. It becomes necessary for aldebaran as device memory is mapped cached from CPU. Signed-off-by: Oa

[PATCH] drm/amd/pm/swsmu: clean up user profile function

Remove unnecessary comments, enable restore mode using '|=' operator, fixes the alignment to improve the code readability. Signed-off-by: Arunpravin --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers/g

Re: [PATCH] drm/gem: add checks of drm_gem_object->funcs

+ Andrey On Mon, Mar 1, 2021 at 5:25 AM Christian König wrote: > > > > Am 01.03.21 um 11:04 schrieb Daniel Vetter: > > On Mon, Mar 1, 2021 at 10:56 AM Thomas Zimmermann > > wrote: > >> (cc'ing amd devs) > >> > >> Hi > >> > >> Am 28.02.21 um 17:10 schrieb Pavel Turinský: > >>> The checks were re

[PATCH] drm/amdgpu: Verify bo size can fit framebuffer size

When creating a new framebuffer, verify that the bo size associated with it can handle the fb size. drm_gem_fb_init_with_funcs implements this check by calculating the minimum expected size of each plane. amdgpu now uses this function to initialize its fb as it performs the required checks. The bu

Re: [PATCH 0/2] Fix for 64 bit divisions on 32-bit platform.

On Mon, Mar 1, 2021 at 12:06 PM Bindu Ramamurthy wrote: > > This patch set fixes 64 bit divisions for the display > synchronization code that caused a regression on 32-bit platform. > > Vladimir Stempen (2): > SWDEV-266369 - dc: Fix 64 bit divisions on 32 bit platforms by using > div64 API >

[PATCH 2/2] SWDEV-266369 - dc: Fix 64 bit modulus operation using div64 API

From: Vladimir Stempen [why] Synchronization displays with different timings feature uses reminder of 64 bit division (modulus operator) , which is not supported by 32 bit platforms [how] Use div64 API for 64 bit modulus Signed-off-by: Vladimir Stempen Tested-by: Bindu Ramamurthy --- .../drm/

[PATCH 1/2] SWDEV-266369 - dc: Fix 64 bit divisions on 32 bit platforms by using div64 API

From: Vladimir Stempen [why] Synchronization displays with different timings feature uses division operator for 64 bit division, which is not supported by 32 bit platforms [how] Use div64 API for 64 bit division Signed-off-by: Vladimir Stempen Tested-by: Bindu Ramamurthy --- drivers/gpu/drm/a

[PATCH 0/2] Fix for 64 bit divisions on 32-bit platform.

This patch set fixes 64 bit divisions for the display synchronization code that caused a regression on 32-bit platform. Vladimir Stempen (2): SWDEV-266369 - dc: Fix 64 bit divisions on 32 bit platforms by using div64 API SWDEV-266369 - dc: Fix 64 bit modulus operation using div64 API ...

Re: [PATCH] drm/amdgpu: enable BACO runpm by default on sienna ciclid and navy flounder

Reviewed-by: Rajneesh Bhardwaj > On 3/1/2021 10:57 AM, Alex Deucher wrote: [CAUTION: External Email] It works fine and was only disabled because primary GPUs don't enter runpm if there is a console bound to the fbdev due to the kmap. This will at least allow r

RE: [PATCH] drm/amdgpu: add missing df counter disable write

[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Harish Kasiviswanathan -Original Message- From: Alex Deucher Sent: Thursday, February 25, 2021 4:27 PM To: Kim, Jonathan Cc: amd-gfx list ; Kasiviswanathan, Harish Subject: Re: [PATCH] drm/amdgpu: add missing df counte

Re: [PATCH] drm/amdgpu: Only check for S0ix if AMD_PMC is configured

Reviewed-by: Rajneesh Bhardwaj On 2/26/2021 5:27 PM, Alex Deucher wrote: [CAUTION: External Email] The S0ix check only makes sense if the AMD PMC driver is present. We need to use the legacy S3 pathes when the PMC driver is not present. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/

2021 X.Org Board of Directions Nomination period ends next Sunday

Unfortunately my previous email seems to not have been received by many people. I will send this email separately to each mailing list to hopefully get better coverage. The nomination period is currently ongoing. So far we have received 3 nominations and will need at least 4 to fill the vacant

Re: [PATCH] drm/amdgpu: enable one vf mode on sienna cichlid vf

On Mon, Mar 1, 2021 at 6:37 AM Liu, Monk wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Pls change "if (smu->od_enabled) {" to " if > (amdgpu_sriov_vf() && smu->od_enabled) {" Won't that break bare metal? Alex > > With this addressed the patch is revi

[PATCH] drm/amdgpu: enable BACO runpm by default on sienna ciclid and navy flounder

It works fine and was only disabled because primary GPUs don't enter runpm if there is a console bound to the fbdev due to the kmap. This will at least allow runpm on secondary cards. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 -- 1 file changed, 2 deletions(-)

Re: [PATCH 1/1] drm/ttm: Ignore signaled move fences

Am 27.02.21 um 04:45 schrieb Felix Kuehling: Move fences that have already signaled should not prevent memory allocations with no_wait_gpu. Signed-off-by: Felix Kuehling Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: Build regressions/improvements in v5.12-rc1

On Mon, 1 Mar 2021, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v5.12-rc1[1] compared to v5.11[2]. Summarized: - build errors: +2/-0 [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8/ (all 1

Re: 6900XT HDMI 2.1 -> Missing 4K120Hz

On Sun, Feb 28, 2021 at 5:48 PM Adolfo Rodrigues wrote: > > Hi. > I cannot find a way to enable 4K @ 120Hz over hdmi 2.1. It seams limited to > HDMI 2.0b.. is it ? > > Under Windows 10 it works fine but not under linux. Why ? See this article for more background: https://www.phoronix.com/scan.ph

Re: [PATCH] drm/amdgpu: block hardware accessed by other threads when doing gpu recovery

Adding Andrey as well. Need to wrap my head around that problem once more. In general the in_irq/in_interrupt macros should not be used in driver code any more and I'm pretty sure we need to block the access at a higher level. Regards, Christian. Am 01.03.21 um 12:12 schrieb Dennis Li: When

RE: [PATCH] drm/amdgpu: block hardware accessed by other threads when doing gpu recovery

[AMD Official Use Only - Internal Distribution Only] For all the "locked = likely(!amdgpu_in_recovery_thread(adev)) & !in_irq();", logical operator "&&" should be used, Regards, Jiansong -Original Message- From: amd-gfx On Behalf Of Dennis Li Sent: Monday, March 1, 2021 7:12 PM To: amd

RE: [PATCH] drm/amdgpu: enable one vf mode on sienna cichlid vf

[AMD Official Use Only - Internal Distribution Only] Pls change "if (smu->od_enabled) {" to " if (amdgpu_sriov_vf() && smu->od_enabled) {" With this addressed the patch is reviewed by me Thanks -- Monk Liu | Cloud-GPU Core team --

[PATCH] drm/amdgpu: block hardware accessed by other threads when doing gpu recovery

When GPU recovery thread is doing GPU reset, it is unsafe that other threads access hardware concurrently, which could cause GPU reset randomly hang. Signed-off-by: Dennis Li diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index 1624c2bc8285..c71d3bba5f69

Re: [PATCH] drm/gem: add checks of drm_gem_object->funcs

Am 01.03.21 um 11:04 schrieb Daniel Vetter: On Mon, Mar 1, 2021 at 10:56 AM Thomas Zimmermann wrote: (cc'ing amd devs) Hi Am 28.02.21 um 17:10 schrieb Pavel Turinský: The checks were removed in commit d693def4fd1c ("drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver") and

[PATCH] drm/amdgpu: add pci BDF info in trace amdgpu_device_r[w]reg()

add pci BDF info in amdgpu_device_r[w]reg trace event to support muti-device in one host. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 53 +- 2 files changed, 33 insertions(+), 24 deletions(-)

Re: [PATCH] drm/gem: add checks of drm_gem_object->funcs

On Mon, Mar 1, 2021 at 10:56 AM Thomas Zimmermann wrote: > > (cc'ing amd devs) > > Hi > > Am 28.02.21 um 17:10 schrieb Pavel Turinský: > > The checks were removed in commit d693def4fd1c ("drm: Remove obsolete GEM > > and PRIME callbacks from struct drm_driver") and can lead to following > > kernel

Re: [PATCH 1/2] drm/amdgpu: refine PSP TA firmware info print in debugfs

[AMD Public Use] From: Zhang, Hawking Sent: Monday, March 1, 2021 5:31 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 1/2] drm/amdgpu: refine PSP TA firmware info print in debugfs [AMD Public Use] + for (i = TA_FW_TYPE_PS

Re: [PATCH] drm/gem: add checks of drm_gem_object->funcs

(cc'ing amd devs) Hi Am 28.02.21 um 17:10 schrieb Pavel Turinský: The checks were removed in commit d693def4fd1c ("drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver") and can lead to following kernel oops: Thanks for reporting. All drivers are supposed to set the funcs point

Re: [PATCH 17/35] drm/amdkfd: register HMM device private zone

On 3/1/21 9:58 AM, Daniel Vetter wrote: On Mon, Mar 01, 2021 at 09:46:44AM +0100, Thomas Hellström (Intel) wrote: On 3/1/21 9:32 AM, Daniel Vetter wrote: On Wed, Jan 06, 2021 at 10:01:09PM -0500, Felix Kuehling wrote: From: Philip Yang Register vram memory as MEMORY_DEVICE_PRIVATE type reso

RE: [PATCH 2/2] drm/amdgpu: add SECURE DISPLAY TA firmware info in debugfs

[AMD Public Use] With my concern on patch #1 addressed, the series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Wang, Kevin(Yang) Sent: Monday, March 1, 2021 17:10 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Wang, Kevin(Yang) Subject: [PATCH 2/2

RE: [PATCH 1/2] drm/amdgpu: refine PSP TA firmware info print in debugfs

[AMD Public Use] + for (i = TA_FW_TYPE_PSP_ASD; i < TA_FW_TYPE_PSP_COUNT; i++) { I think we still rely on AMDGPU_INFO_FW_ASD to query ASD firmware version. Therefore, we need to start from TA_FW_TYPE_PSP_XGMI. + TA_FW_TYPE_PSP_COUNT, + static const char *ta_fw_name[TA_FW_TYPE_

[PATCH 1/2] drm/amdgpu: refine PSP TA firmware info print in debugfs

refine PSP TA firmware info print in amdgpu_firmware_info(). Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 50 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 + 2 files changed, 21 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/am

[PATCH 2/2] drm/amdgpu: add SECURE DISPLAY TA firmware info in debugfs

add SECUREDISPLAY TA firmware info in amdgpu_fimrware_info() Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c index 1a27673271b0..ed51d

Re: [PATCH 17/35] drm/amdkfd: register HMM device private zone

On Mon, Mar 01, 2021 at 09:46:44AM +0100, Thomas Hellström (Intel) wrote: > On 3/1/21 9:32 AM, Daniel Vetter wrote: > > On Wed, Jan 06, 2021 at 10:01:09PM -0500, Felix Kuehling wrote: > > > From: Philip Yang > > > > > > Register vram memory as MEMORY_DEVICE_PRIVATE type resource, to > > > allocat

Re: [PATCH 17/35] drm/amdkfd: register HMM device private zone

On 3/1/21 9:32 AM, Daniel Vetter wrote: On Wed, Jan 06, 2021 at 10:01:09PM -0500, Felix Kuehling wrote: From: Philip Yang Register vram memory as MEMORY_DEVICE_PRIVATE type resource, to allocate vram backing pages for page migration. Signed-off-by: Philip Yang Signed-off-by: Felix Kuehling

Re: [PATCH 17/35] drm/amdkfd: register HMM device private zone

On Wed, Jan 06, 2021 at 10:01:09PM -0500, Felix Kuehling wrote: > From: Philip Yang > > Register vram memory as MEMORY_DEVICE_PRIVATE type resource, to > allocate vram backing pages for page migration. > > Signed-off-by: Philip Yang > Signed-off-by: Felix Kuehling So maybe I'm getting this all

[PATCH] drm/amd/display: Remove unnecessary conversion to bool

Fix the following coccicheck warnings: ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c:298:33-38: WARNING: conversion to bool not needed here. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c | 2 +- 1 file changed, 1 insertion

Re: [bug] tab crash on media playback

On 2/27/21 8:42 AM, Christian König wrote: This just means that the fault needs to be retried and isn't anything special. I have no idea why this should cause any problems. Regards, Christian. Thanks all.  I may try reporting this to the chrome folks to see if they have any ideas.  I am