Re: [RFC] CRIU support for ROCm

2021-06-18 Thread Felix Kuehling
Am 2021-05-01 um 1:03 p.m. schrieb Adrian Reber: > > It would also be good to have your patchset submitted as a PR on github > to have our normal CI test coverage of the changes. Hi Adrian, We moved our work to a new github repository that is a fork of checkpoint-restore/criu so that we could sen

Re: [PATCH v3] drm/amdkfd: Fix some double free when destroy queue fails

2021-06-18 Thread Felix Kuehling
Am 2021-06-18 um 2:02 a.m. schrieb xinhui pan: > Handle queue destroy failure while CP hang. > Once CP got hang, kfd trigger GPU reset and set related flags to stop > driver touching the queue. But all usermode queues have stopped, we > actually somehow succeed to remove queue from runlist. So lets

[PATCH 08/12] drm/amd/display: Fix edp_bootup_bl_level initialization issue

2021-06-18 Thread Bindu Ramamurthy
From: Logush Oliver [why] Updating the file to fix the missing line Signed-off-by: Logush Oliver Reviewed-by: Charlene Liu Acked-by: Bindu Ramamurthy --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd

RE: [PATCH 00/12] June, 21, 2021

2021-06-18 Thread Wheeler, Daniel
[Public] Hi all,   This week this patchset was tested on the following systems:   HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA)   AMD

[PATCH 09/12] drm/amd/display: Revert "Guard ASSR with internal display flag"

2021-06-18 Thread Bindu Ramamurthy
From: Stylon Wang [Why] 1. Previous patch regresses on some embedded panels. 2. Project coreboot doesn't support passing of internal display flag. [How] This reverts "Guard ASSR with internal display flag" commit. Signed-off-by: Stylon Wang Reviewed-by: Wesley Chalmers Acked-by: Bindu Ramamur

[PATCH 12/12] drm/amd/display: 3.2.141

2021-06-18 Thread Bindu Ramamurthy
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Bindu Ramamurthy --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 9d924e8496f9..76

[PATCH 11/12] drm/amd/display: [FW Promotion] Release 0.0.71

2021-06-18 Thread Bindu Ramamurthy
From: Anthony Koo - Introduce CMD for EDID CEA block parsing - Add SCR5 definition for reporting eDP power sequencer status Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Bindu Ramamurthy --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 90 ++- 1 file change

[PATCH 06/12] drm/amd/display: Delay PSR entry

2021-06-18 Thread Bindu Ramamurthy
From: Roman Li [Why] After panel power up, if PSR entry attempted too early, PSR state may get stuck in transition. This could happen if the panel is not ready to respond to the SDP PSR entry message. In this case dmub f/w is unable to abort PSR entry since abortion is not permitted after the SDP

[PATCH 00/12] June, 21, 2021

2021-06-18 Thread Bindu Ramamurthy
This DC patchset brings improvements in multiple areas. In summary, we highlight: * DC 3.2.141 * Firmware release 0.0.71 * Improvements across LTTPR, edp initialization, DML calculations, VBIOS for dcn302 and dcn303 etc. Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.71 Aric Cy

[PATCH 07/12] drm/amd/display: get refclk from MICROSECOND_TIME_BASE_DIV HW register

2021-06-18 Thread Bindu Ramamurthy
From: Charlene Liu [why] recent VBIOS dce_infotable reference clock change caused a I2c regression. instead of relying on vbios, let's get it from HW directly. Signed-off-by: Charlene Liu Reviewed-by: Chris Park Reviewed-by: Nicholas Kazlauskas Acked-by: Bindu Ramamurthy --- drivers/gpu/drm

[PATCH 03/12] drm/amd/display: Clear lane settings after LTTPRs have been trained

2021-06-18 Thread Bindu Ramamurthy
From: Martin Tsai [Why] The voltage swing has to start from the minimum level when transmit TPS1 over Main-Link in clock recovery sequence. The lane settings from current design will inherit the existing VS/PE values that could be adjusted by Repeater X, and to use the adjusted voltage swing lev

[PATCH 02/12] drm/amd/display: Clamp VStartup value at DML calculations time

2021-06-18 Thread Bindu Ramamurthy
From: Nikola Cornij [why] Some timings with a large VBlank cause the value to overflow the register related, while also producing other wrong values in DML output. [how] Clamp VStartup at the DCN3.1 maximum value Signed-off-by: Nikola Cornij Reviewed-by: Dmytro Laktyushkin Acked-by: Bindu Ram

[PATCH 01/12] drm/amd/display: Multiplane cursor position incorrect when plane rotated

2021-06-18 Thread Bindu Ramamurthy
From: Aric Cyr [Why] When video plane is rotate the cursor position is incorrect and not matching the desktop location. [How] When a plane is rotated 90 or 270 degrees, the src_rect.width and height should be swapped when determining the scaling factor compared to the dst_rect. Signed-off-by: A

[PATCH 05/12] drm/amd/display: get socBB from VBIOS for dcn302 and dcn303

2021-06-18 Thread Bindu Ramamurthy
From: Aurabindo Pillai [why] Some SOC BB paramters may vary per SKU, and it does not make sense for driver to hardcode these values. This change was added for dcn30 and dcn301, but not for dcn302 and dcn303 [how] Parse the values from VBIOS if available, and use them if valid Fixes: "drm/amd/dis

[PATCH 04/12] drm/amd/display: Fix incorrect variable name

2021-06-18 Thread Bindu Ramamurthy
From: Wesley Chalmers [WHY] extended_end_address can only be calculated from the extended_address and extended_size Signed-off-by: Wesley Chalmers Reviewed-by: Ashley Thomas Acked-by: Bindu Ramamurthy --- drivers/gpu/drm/amd/display/dc/core/dc_link_dpcd.c | 2 +- 1 file changed, 1 insertion(

Re: [PATCH] drm/amdgpu: fix amdgpu_preempt_mgr_new()

2021-06-18 Thread Alex Deucher
On Fri, Jun 18, 2021 at 11:40 AM Felix Kuehling wrote: > > Am 2021-06-18 um 4:39 a.m. schrieb Christian König: > > Am 18.06.21 um 10:37 schrieb Dan Carpenter: > >> There is a reversed if statement in amdgpu_preempt_mgr_new() so it > >> always returns -ENOMEM. > >> > >> Fixes: 09b020bb05a5 ("Merge

Re: [PATCH] drm/amdgpu: Call drm_framebuffer_init last for framebuffer init

2021-06-18 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 17, 2021 at 6:33 AM Michel Dänzer wrote: > > On 2021-06-16 12:46 p.m., Michel Dänzer wrote: > > From: Michel Dänzer > > > > Once drm_framebuffer_init has returned 0, the framebuffer is hooked up > > to the reference counting machinery and can no longer be dest

Re: [PATCH] drm/display: Fix duplicated argument

2021-06-18 Thread Alex Deucher
Applied. Thanks! On Fri, Jun 18, 2021 at 9:56 AM Harry Wentland wrote: > > On 2021-06-16 10:40 a.m., Wan Jiabing wrote: > > Fix coccicheck warning: > > > > ./drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c: > > 55:12-42: duplicated argument to && or || > > > > Signed-off-by: Wa

Re: [PATCH] drm/amd/display: Remove the repeated dpp1_full_bypass declaration

2021-06-18 Thread Alex Deucher
Applied. Thanks! On Fri, Jun 18, 2021 at 9:48 AM Harry Wentland wrote: > > > > On 2021-06-17 9:23 p.m., Shaokun Zhang wrote: > > Function 'dpp1_full_bypass' is declared twice, so remove the repeated > > declaration and unnessary blank line. > > > > Cc: Harry Wentland > > Cc: Leo Li > > Cc: Ale

Re: [PATCH][next] drm/amd/display: Fix fall-through warning for Clang

2021-06-18 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 17, 2021 at 3:20 PM Harry Wentland wrote: > > > > On 2021-06-16 4:52 p.m., Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix > > the following warning by replacing a /* fall through */ comment > > with the new pseudo-

Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'

2021-06-18 Thread Alex Deucher
Applied. Thanks! On Thu, Jun 17, 2021 at 3:04 PM Harry Wentland wrote: > > > > On 2021-06-16 9:16 p.m., Pu Lehui wrote: > > GCC reports the following warning with W=1: > > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13: > > warning: > > variable ‘dc’ set but not used

Re: [PATCH -next] drm/amd/display: Fix gcc unused variable warning

2021-06-18 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 17, 2021 at 2:43 PM Harry Wentland wrote: > > On 2021-06-16 10:31 p.m., Pu Lehui wrote: > > GCC reports the following warning with W=1: > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3635:17: > > warning: > > variable ‘status’ set but not u

Re: [PATCH] drm/amdgpu: fix amdgpu_preempt_mgr_new()

2021-06-18 Thread Felix Kuehling
Am 2021-06-18 um 4:39 a.m. schrieb Christian König: > Am 18.06.21 um 10:37 schrieb Dan Carpenter: >> There is a reversed if statement in amdgpu_preempt_mgr_new() so it >> always returns -ENOMEM. >> >> Fixes: 09b020bb05a5 ("Merge tag 'drm-misc-next-2021-06-09' of >> git://anongit.freedesktop.org/drm

[PATCH 10/12] drm/amd/display: do not compare integers of different widths

2021-06-18 Thread Bindu Ramamurthy
From: Josip Pavic [Why & How] Increase width of some variables to avoid comparing integers of different widths Signed-off-by: Josip Pavic Reviewed-by: Aric Cyr Acked-by: Bindu Ramamurthy --- drivers/gpu/drm/amd/display/dc/core/dc_link.c| 2 +- drivers/gpu/drm/amd/display/dc/core/dc_link_

Re: [PATCH] drm/amdgpu: Revert enlarging CP_MEC_DOORBELL_RANGE patches.

2021-06-18 Thread Alex Deucher
Probably better to revert each patch individually for upstream. With that changed, Acked-by: Alex Deucher Alex On Thu, Jun 17, 2021 at 10:23 PM Yifan Zhang wrote: > > Revert "drm/amdgpu/gfx9: fix the doorbell missing when in CGPG issue." > Revert "drm/amdgpu/gfx10: enlarge CP_MEC_DOORBELL_RANG

Re: [PATCH v1] drm/amdgpu: fix framebuffer memory use after free

2021-06-18 Thread Michel Dänzer
On 2021-06-18 10:46 a.m., Łukasz Bartosik wrote: > czw., 17 cze 2021 o 16:18 Michel Dänzer napisał(a): >> >> On 2021-06-17 10:18 a.m., Lukasz Bartosik wrote: >>> With option CONFIG_DEBUG_LIST enabled the kernel logs show list_add >>> corruption warning. The warning originates from drm_framebuffer_

Re: [PATCH] drm/amdgpu: Power down VCN and JPEG before disabling SMU features

2021-06-18 Thread Alex Deucher
Acked-by: Alex Deucher On Fri, Jun 18, 2021 at 5:17 AM Chengzhe Liu wrote: > > When unloading driver, if VCN is powered on, sending message > DisableAllSmuFeatures to SMU will cause SMU hang. We need to > power down VCN and JPEG before clean up SMU. > > Signed-off-by: Chengzhe Liu > --- > driv

Re: [PATCH] drm/display: Fix duplicated argument

2021-06-18 Thread Harry Wentland
On 2021-06-16 10:40 a.m., Wan Jiabing wrote: > Fix coccicheck warning: > > ./drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c: > 55:12-42: duplicated argument to && or || > > Signed-off-by: Wan Jiabing Reviewed-by: Harry Wentland Harry > --- > .../gpu/drm/amd/display/dc/dml

Re: [PATCH] drm/amd/display: Remove the repeated dpp1_full_bypass declaration

2021-06-18 Thread Harry Wentland
On 2021-06-17 9:23 p.m., Shaokun Zhang wrote: > Function 'dpp1_full_bypass' is declared twice, so remove the repeated > declaration and unnessary blank line. > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Signed-off-by: Shaokun Zhang Reviewed-by: Harry Wentland Harry > --- >

[PATCH] drm/amdgpu: Power down VCN and JPEG before disabling SMU features

2021-06-18 Thread Chengzhe Liu
When unloading driver, if VCN is powered on, sending message DisableAllSmuFeatures to SMU will cause SMU hang. We need to power down VCN and JPEG before clean up SMU. Signed-off-by: Chengzhe Liu --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deleti

Re: [PATCH] drm/amdgpu: fix amdgpu_preempt_mgr_new()

2021-06-18 Thread Christian König
Am 18.06.21 um 10:37 schrieb Dan Carpenter: There is a reversed if statement in amdgpu_preempt_mgr_new() so it always returns -ENOMEM. Fixes: 09b020bb05a5 ("Merge tag 'drm-misc-next-2021-06-09' of git://anongit.freedesktop.org/drm/drm-misc into drm-next") Signed-off-by: Dan Carpenter Most be

[PATCH] drm/amdgpu: fix amdgpu_preempt_mgr_new()

2021-06-18 Thread Dan Carpenter
There is a reversed if statement in amdgpu_preempt_mgr_new() so it always returns -ENOMEM. Fixes: 09b020bb05a5 ("Merge tag 'drm-misc-next-2021-06-09' of git://anongit.freedesktop.org/drm/drm-misc into drm-next") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c |

[PATCH v4 14/17] drm/i915/display: Add handling for new "preferred color format" property

2021-06-18 Thread Werner Sembach
This commit implements the "preferred color format" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 + drivers/gpu/drm/i915/display/intel_hdmi.c | 6 ++ 3 f

[PATCH v4 16/17] drm/i915/display: Use the general "Broadcast RGB" implementation

2021-06-18 Thread Werner Sembach
Change from the i915 specific "Broadcast RGB" drm property implementation to the general one. This commit delete all traces of the former "Broadcast RGB" implementation and add a new one using the new driver agnoistic functions an variables. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i91

[PATCH v4 15/17] drm/uAPI: Move "Broadcast RGB" property from driver specific to general context

2021-06-18 Thread Werner Sembach
Add "Broadcast RGB" to general drm context so that more drivers besides i915 and gma500 can implement it without duplicating code. Userspace can use this property to tell the graphic driver to use full or limited color range for a given connector, overwriting the default behaviour/automatic detect

[PATCH v4 17/17] drm/amd/display: Add handling for new "Broadcast RGB" property

2021-06-18 Thread Werner Sembach
This commit implements the "Broadcast RGB" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 22 ++- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 2 files changed, 21 insertions(+), 5 deletions(-) di

[PATCH v4 13/17] drm/amd/display: Add handling for new "preferred color format" property

2021-06-18 Thread Werner Sembach
This commit implements the "preferred color format" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 30 +++ .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 28 insertions(+), 6 deletion

[PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-18 Thread Werner Sembach
Add a new general drm property "preferred color format" which can be used by userspace to tell the graphic drivers to which color format to use. Possible options are: - auto (default/current behaviour) - rgb - ycbcr444 - ycbcr422 (not supported by both amdgpu and i915) - ycbcr4

[PATCH v4 11/17] drm/i915/display: Add handling for new "active color range" property

2021-06-18 Thread Werner Sembach
This commit implements the "active color range" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 6 ++ drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 + drivers/g

[PATCH v4 10/17] drm/amd/display: Add handling for new "active color range" property

2021-06-18 Thread Werner Sembach
This commit implements the "active color range" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 33 +++ .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 37 insertions(+) diff --git a/d

[PATCH v4 09/17] drm/uAPI: Add "active color range" drm property as feedback for userspace

2021-06-18 Thread Werner Sembach
Add a new general drm property "active color range" which can be used by graphic drivers to report the used color range back to userspace. There was no way to check which color range got actually used on a given monitor. To surely predict this, one must know the exact capabilities of the monitor a

[PATCH v4 07/17] drm/amd/display: Add handling for new "active color format" property

2021-06-18 Thread Werner Sembach
This commit implements the "active color format" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 +-- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +++ 2 files changed, 31 insertions(+), 2 deletions(-

[PATCH v4 08/17] drm/i915/display: Add handling for new "active color format" property

2021-06-18 Thread Werner Sembach
This commit implements the "active color format" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 22 +++- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ drivers/gpu/drm/i915/display/intel_dp_mst.c |

[PATCH v4 05/17] drm/i915/display: Add handling for new "active bpc" property

2021-06-18 Thread Werner Sembach
This commit implements the "active bpc" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_display.c | 17 + drivers/gpu/drm/i915/display/intel_dp.c | 7 +-- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 +

[PATCH v4 06/17] drm/uAPI: Add "active color format" drm property as feedback for userspace

2021-06-18 Thread Werner Sembach
Add a new general drm property "active color format" which can be used by graphic drivers to report the used color format back to userspace. There was no way to check which color format got actually used on a given monitor. To surely predict this, one must know the exact capabilities of the monito

[PATCH v4 02/17] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc

2021-06-18 Thread Werner Sembach
convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an integer had the casses for COLOR_DEPTH_999 and COLOR_DEPTH_11 missing. Signed-off-by: Werner Sembach --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 1 file changed, 4 insertions(+) diff --git a/dri

[PATCH v4 04/17] drm/amd/display: Add handling for new "active bpc" property

2021-06-18 Thread Werner Sembach
This commit implements the "active bpc" drm property for the AMD GPU driver. Signed-off-by: Werner Sembach --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 19 ++- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 2 files changed, 22 insertions(+), 1 deletion(-) diff -

[PATCH v4 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-18 Thread Werner Sembach
Add a new general drm property "active bpc" which can be used by graphic drivers to report the applied bit depth per pixel back to userspace. While "max bpc" can be used to change the color depth, there was no way to check which one actually got used. While in theory the driver chooses the best/hi

[PATCH v4 01/17] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check

2021-06-18 Thread Werner Sembach
Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check that was performed in the drm_mode_is_420_only() case, but not in the drm_mode_is_420_also() && force_yuv420_output case. Without further knowledge if YCbCr 4:2:0 is supported outside of HDMI, there is no reason to use RGB when the display reports d

[PATCH v4 00/17] New uAPI drm properties for color management

2021-06-18 Thread Werner Sembach
Implementation of https://lkml.org/lkml/2021/5/12/764 now feature complete albeit not fully tested. I have not yet corrected the DSC behavior and double checked the dithering behavior. I release the feature complete patch series now anyways so that work on the userspace implementation can start.