[pull] amdgpu, amdkfd, radeon drm-next-5.15

2021-08-06 Thread Alex Deucher
Hi Dave, Daniel, More updates for 5.15. The following changes since commit 04d505de7f82c8f2daa6139b460b05dc01e354e0: Merge tag 'amd-drm-next-5.15-2021-07-29' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2021-07-30 16:48:35 +1000) are available in the Git repository at:

Re: [PATCH] drm/amd/display: Remove redundant initialization of variable eng_id

2021-08-06 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Aug 6, 2021 at 7:16 AM Colin King wrote: > > From: Colin Ian King > > The variable eng_id is being initialized with a value that is never > read, it is being re-assigned on the next statment. The assignment > is redundant and can be removed. > >

Re: [PATCH] drm/amdgpu: check for allocation failure in amdgpu_vkms_sw_init()

2021-08-06 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Aug 6, 2021 at 11:09 AM Christian König wrote: > > Am 06.08.21 um 17:05 schrieb Dan Carpenter: > > Check whether the kcalloc() fails and return -ENOMEM if it does. > > > > Fixes: eeba0b9046fc ("drm/amdgpu: create amdgpu_vkms (v4)") > > Signed-off-by: Dan Carpenter

Re: [git pull] drm fixes for 5.14-rc4

2021-08-06 Thread Daniel Vetter
On Thu, Aug 5, 2021 at 8:14 PM Linus Torvalds wrote: > > This might possibly have been fixed already by the previous drm pull, > but I wanted to report it anyway, just in case. > > It happened after an uptime of over a week, so it might not be trivial > to reproduce. > > It's a NULL pointer

[PATCH 13/13] drm/amd/display: use GFP_ATOMIC in amdgpu_dm_irq_schedule_work

2021-08-06 Thread Anson Jacob
Replace GFP_KERNEL with GFP_ATOMIC as amdgpu_dm_irq_schedule_work can't sleep. BUG: sleeping function called from invalid context at include/linux/sched/mm.h:196 in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 253, name: kworker/6:1H CPU: 6 PID: 253 Comm: kworker/6:1H Tainted: GW

[PATCH 11/13] drm/amd/display: Clear GPINT after DMCUB has reset

2021-08-06 Thread Anson Jacob
From: Nicholas Kazlauskas [Why] Otherwise we can end up processing whatever was left in the register if the DMCUB was previously reset. If DMCUB gets force reset too early from another client then we might not have even acked the disable yet - causing DMCUB instantly shutdown if the command was

[PATCH 12/13] drm/amd/display: Increase timeout threshold for DMCUB reset

2021-08-06 Thread Anson Jacob
From: Nicholas Kazlauskas [Why] If we're backdoor loading the DMCUB performs more work than just the PHY reset so we can end up resetting before the cleanup has fully finished. [How] Increase timeout, add udelay between spins to guarantee a minimum. Acked-by: Anson Jacob Signed-off-by:

[PATCH 09/13] drm/amd/display: [FW Promotion] Release 0.0.78

2021-08-06 Thread Anson Jacob
From: Anthony Koo Acked-by: Anson Jacob Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 07/13] drm/amd/display: Add AUX I2C tracing.

2021-08-06 Thread Anson Jacob
From: Ashley Thomas [Why] Developers can find it useful if the driver can produce AUX traces without special equipment. [How] Add AUX tracing. Reviewed-by: Zhan Liu Acked-by: Anson Jacob Signed-off-by: Ashley Thomas --- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 192 ++-

[PATCH 04/13] drm/amd/display: refactor the cursor programing codes

2021-08-06 Thread Anson Jacob
From: Roy Chan Acked-by: Anson Jacob Signed-off-by: Roy Chan --- .../gpu/drm/amd/display/dc/core/dc_stream.c | 106 +++--- 1 file changed, 65 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c

[PATCH 10/13] drm/amd/display: 3.2.148

2021-08-06 Thread Anson Jacob
From: Anthony Koo This version brings along following fixes: - Fix memory allocation in dm IRQ context to use GFP_ATOMIC - Increase timeout threshold for DMCUB reset - Clear GPINT after DMCUB has reset - Add AUX I2C tracing - Fix code commenting style - Some refactoring - Remove invalid assert

[PATCH 02/13] drm/amd/display: fix missing writeback disablement if plane is removed

2021-08-06 Thread Anson Jacob
From: Roy Chan [Why] If the plane has been removed, the writeback disablement logic doesn't run [How] fix the logic order Acked-by: Anson Jacob Signed-off-by: Roy Chan --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 14 --

[PATCH 08/13] drm/amd/display: add authentication_complete in hdcp output

2021-08-06 Thread Anson Jacob
From: Wenjing Liu [why] DM needs to be notified when hdcp module has completed authentication attempt. Acked-by: Anson Jacob Signed-off-by: Wenjing Liu --- .../gpu/drm/amd/display/modules/hdcp/hdcp.c | 5 +- .../gpu/drm/amd/display/modules/hdcp/hdcp.h | 8 ++

[PATCH 03/13] drm/amd/display: refactor the codes to centralize the stream/pipe checking logic

2021-08-06 Thread Anson Jacob
From: Roy Chan Acked-by: Anson Jacob Signed-off-by: Roy Chan --- drivers/gpu/drm/amd/display/dc/core/dc.c | 62 1 file changed, 41 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index

[PATCH 05/13] drm/amd/display: fix incorrect CM/TF programming sequence in dwb

2021-08-06 Thread Anson Jacob
From: Roy Chan [How] the programming sequeune was for old asic. the correct programming sequeunce should be similar to the one used in mpc. the fix is copied from the mpc programming sequeunce. Acked-by: Anson Jacob Signed-off-by: Roy Chan --- .../drm/amd/display/dc/dcn30/dcn30_dwb_cm.c |

[PATCH 06/13] drm/amd/display: Correct comment style

2021-08-06 Thread Anson Jacob
From: Roy Chan Acked-by: Anson Jacob Signed-off-by: Roy Chan --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h index

[PATCH 01/13] drm/amd/display: Remove invalid assert for ODM + MPC case

2021-08-06 Thread Anson Jacob
From: Eric Bernstein Reviewed-by: Dmytro Laktyushkin Acked-by: Anson Jacob Signed-off-by: Eric Bernstein Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 00/13] DC Patches Aug 6, 2021

2021-08-06 Thread Anson Jacob
This DC patchset brings improvements in multiple areas. In summary, we highlight: - Fix memory allocation in dm IRQ context to use GFP_ATOMIC - Increase timeout threshold for DMCUB reset - Clear GPINT after DMCUB has reset - Add AUX I2C tracing - Fix code commenting style - Some refactoring -

Re: Power-saving/performance toggles for amdgpu

2021-08-06 Thread Bastien Nocera
On Fri, 2021-08-06 at 11:45 -0400, Alex Deucher wrote: > You could set one of the profiles which sets more or less aggressive > clocking, but you still get the advantages of the SMU being able to > dynamically adjust the clocks.  If you manually force the clock to low > or high, you end up forcing

Re: Power-saving/performance toggles for amdgpu

2021-08-06 Thread Alex Deucher
On Fri, Aug 6, 2021 at 12:20 PM Bastien Nocera wrote: > > On Fri, 2021-08-06 at 11:45 -0400, Alex Deucher wrote: > > You could set one of the profiles which sets more or less aggressive > > clocking, but you still get the advantages of the SMU being able to > > dynamically adjust the clocks. If

Re: Power-saving/performance toggles for amdgpu

2021-08-06 Thread Bastien Nocera
On Fri, 2021-08-06 at 11:08 -0400, Alex Deucher wrote: > On Fri, Aug 6, 2021 at 10:29 AM Bastien Nocera > wrote: > > > > Nearly a year later, hello again, :) > > > > On Mon, 2020-09-14 at 01:46 -0400, Alex Deucher wrote: > > > On older radeons (e.g., pre-GCN hardware), there were separate > > >

Re: Power-saving/performance toggles for amdgpu

2021-08-06 Thread Alex Deucher
On Fri, Aug 6, 2021 at 11:37 AM Bastien Nocera wrote: > > On Fri, 2021-08-06 at 11:08 -0400, Alex Deucher wrote: > > On Fri, Aug 6, 2021 at 10:29 AM Bastien Nocera > > wrote: > > > > > > Nearly a year later, hello again, :) > > > > > > On Mon, 2020-09-14 at 01:46 -0400, Alex Deucher wrote: > > >

Re: Power-saving/performance toggles for amdgpu

2021-08-06 Thread Bastien Nocera
Nearly a year later, hello again, :) On Mon, 2020-09-14 at 01:46 -0400, Alex Deucher wrote: > On older radeons (e.g., pre-GCN hardware), there were separate power > states for battery and AC, but these asics are supported by the radeon > kernel driver.  None of the hardware supported by amdgpu

Re: [PATCH] drm/amdgpu: check for allocation failure in amdgpu_vkms_sw_init()

2021-08-06 Thread Christian König
Am 06.08.21 um 17:05 schrieb Dan Carpenter: Check whether the kcalloc() fails and return -ENOMEM if it does. Fixes: eeba0b9046fc ("drm/amdgpu: create amdgpu_vkms (v4)") Signed-off-by: Dan Carpenter Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 2 ++ 1 file

Re: Power-saving/performance toggles for amdgpu

2021-08-06 Thread Alex Deucher
On Fri, Aug 6, 2021 at 10:29 AM Bastien Nocera wrote: > > Nearly a year later, hello again, :) > > On Mon, 2020-09-14 at 01:46 -0400, Alex Deucher wrote: > > On older radeons (e.g., pre-GCN hardware), there were separate power > > states for battery and AC, but these asics are supported by the

[PATCH] drm/amdgpu: check for allocation failure in amdgpu_vkms_sw_init()

2021-08-06 Thread Dan Carpenter
Check whether the kcalloc() fails and return -ENOMEM if it does. Fixes: eeba0b9046fc ("drm/amdgpu: create amdgpu_vkms (v4)") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c

[PATCH] drm/amd/display: Remove redundant initialization of variable eng_id

2021-08-06 Thread Colin King
From: Colin Ian King The variable eng_id is being initialized with a value that is never read, it is being re-assigned on the next statment. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-08-06 Thread Dmitry Baryshkov
On 29/06/2021 16:58, Thomas Zimmermann wrote: Print the name of the DRM driver when taking over fbdev devices. Makes the output to dmesg more consistent. Note that the driver name is only used for printing a string to the kernel log. No UAPI is affected by this change. Signed-off-by: Thomas

Re: [PATCHv2 1/2] drm/amd/amdgpu embed hw_fence into amdgpu_job

2021-08-06 Thread Jingwen Chen
On Thu Aug 05, 2021 at 05:13:22PM -0400, Andrey Grodzovsky wrote: > > On 2021-08-05 4:31 a.m., Jingwen Chen wrote: > > From: Jack Zhang > > > > Why: Previously hw fence is alloced separately with job. > > It caused historical lifetime issues and corner cases. > > The ideal situation is to take

Re: [PATCHv2 1/2] drm/amd/amdgpu embed hw_fence into amdgpu_job

2021-08-06 Thread Christian König
Am 06.08.21 um 07:52 schrieb Jingwen Chen: On Thu Aug 05, 2021 at 05:13:22PM -0400, Andrey Grodzovsky wrote: On 2021-08-05 4:31 a.m., Jingwen Chen wrote: From: Jack Zhang Why: Previously hw fence is alloced separately with job. It caused historical lifetime issues and corner cases. The

RE: [PATCH] drm/amd/amdgpu: skip locking delayed work if not initialized.

2021-08-06 Thread Wang, YuBiao
[AMD Official Use Only] Hi Christian, This part is added by a commit which stated that: When unloading driver after killing some applications, it will hit sdma flush tlb job timeout which is called by ttm_bo_delay_delete. So to avoid the job submit after fence driver fini, call