[resend PATCH] drm/ttm: Fix a deadlock if the target BO is not idle during swap

2021-09-06 Thread xinhui pan
The ret value might be -EBUSY, caller will think lru lock is still locked but actually NOT. So return -ENOSPC instead. Otherwise we hit list corruption. ttm_bo_cleanup_refs might fail too if BO is not idle. If we return 0, caller(ttm_tt_populate -> ttm_global_swapout ->ttm_device_swapout) will be

RE: [PATCH v2 1/2] drm/ttm: Fix a deadlock if the target BO is not idle during swap

2021-09-06 Thread Pan, Xinhui
[AMD Official Use Only] It is the internal staging drm-next. -Original Message- From: Koenig, Christian Sent: 2021年9月6日 19:26 To: Pan, Xinhui ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; che...@uniontech.com; dri-de...@lists.freedesktop.org Subject: Re: [PATCH v2 1/2]

RE: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-06 Thread Shankar, Uma
> -Original Message- > From: sebast...@sebastianwick.net > Sent: Monday, August 16, 2021 7:07 PM > To: Harry Wentland > Cc: Brian Starkey ; Sharma, Shashank > ; amd-gfx@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; ppaala...@gmail.com; mca...@google.com; >

Re: [Intel-gfx] [PATCH v7 5/8] drm_print: add choice to use dynamic debug in drm-debug

2021-09-06 Thread jim . cromie
> I'll try to extract the "executive summary" from this, you tell me if I > got it right. > > So using or not using dynamic debug for DRM debug ends up being about > shifting the cost between kernel binary size (data section grows by each > pr_debug call site) and runtime conditionals? Yes. >

Re: [Intel-gfx] [PATCH v7 3/8] i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create "gvt:core:" etc categories

2021-09-06 Thread jim . cromie
On Mon, Sep 6, 2021 at 6:26 AM Tvrtko Ursulin < tvrtko.ursu...@linux.intel.com> wrote: > > > On 03/09/2021 20:22, jim.cro...@gmail.com wrote: > > On Fri, Sep 3, 2021 at 5:07 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 31/08/2021 21:21, Jim Cromie wrote: > >>> The gvt component of this driver

Re: [PATCH 2/2] drm/amdgpu: cleanup debugfs for amdgpu rings

2021-09-06 Thread Sharma, Shashank
On 9/5/2021 5:01 PM, Das, Nirmoy wrote: On 9/5/2021 10:03 AM, Sharma, Shashank wrote: On 9/3/2021 9:44 PM, Das, Nirmoy wrote: Hi Shashank, On 9/3/2021 5:51 PM, Das, Nirmoy wrote: On 9/3/2021 5:26 PM, Sharma, Shashank wrote: On 9/3/2021 1:39 PM, Das, Nirmoy wrote: On 9/3/2021 8:36

Re: [diagnostic TDR mode patches] unify our solution opinions/suggestions in one thread

2021-09-06 Thread Jingwen Chen
Hi Christian/Andrey/Daniel, I read Boris's patch about ordered workqueue and I think maybe we can leverage this change. https://lore.kernel.org/dri-devel/20210625133327.2598825-2-boris.brezil...@collabora.com/ As the TDR race condition we are talking about is caused by a bailing job being

[PATCH] drm/amd/amdgpu: Enable some sysnodes for guest smi

2021-09-06 Thread Roy Sun
Enable sysnode vclk and dclk on Navi21 asic for guest smi Signed-off-by: Roy Sun --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c index

Re: [Intel-gfx] [PATCH v7 3/8] i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create "gvt:core:" etc categories

2021-09-06 Thread Tvrtko Ursulin
On 03/09/2021 20:22, jim.cro...@gmail.com wrote: On Fri, Sep 3, 2021 at 5:07 AM Tvrtko Ursulin wrote: On 31/08/2021 21:21, Jim Cromie wrote: The gvt component of this driver has ~120 pr_debugs, in 9 categories quite similar to those in DRM. Following the interface model of drm.debug, add

Re: [PATCH v2 1/2] drm/ttm: Fix a deadlock if the target BO is not idle during swap

2021-09-06 Thread Christian König
Which branch is this patch based on? Please rebase on top drm-misc-fixes and resend. Thanks, Christian. Am 06.09.21 um 03:12 schrieb xinhui pan: The ret value might be -EBUSY, caller will think lru lock is still locked but actually NOT. So return -ENOSPC instead. Otherwise we hit list

Re: [PATCH v2 0/2] Fix a hung during memory pressure test

2021-09-06 Thread Christian König
Am 06.09.21 um 12:16 schrieb Pan, Xinhui: 2021年9月6日 17:04,Christian König 写道: Am 06.09.21 um 03:12 schrieb xinhui pan: A long time ago, someone reports system got hung during memory test. In recent days, I am trying to look for or understand the potential deadlock in ttm/amdgpu code. This

Re: [Intel-gfx] [PATCH v7 5/8] drm_print: add choice to use dynamic debug in drm-debug

2021-09-06 Thread Tvrtko Ursulin
On 03/09/2021 22:57, jim.cro...@gmail.com wrote: On Fri, Sep 3, 2021 at 5:15 AM Tvrtko Ursulin wrote: On 31/08/2021 21:21, Jim Cromie wrote: drm's debug system writes 10 distinct categories of messages to syslog using a small API[1]: drm_dbg*(10 names), DRM_DEV_DEBUG*(3 names),

Re: [PATCH v2 0/2] Fix a hung during memory pressure test

2021-09-06 Thread Pan, Xinhui
> 2021年9月6日 17:04,Christian König 写道: > > > > Am 06.09.21 um 03:12 schrieb xinhui pan: >> A long time ago, someone reports system got hung during memory test. >> In recent days, I am trying to look for or understand the potential >> deadlock in ttm/amdgpu code. >> >> This patchset aims to

RE: [PATCH] drm/amdgpu: Create common PSP TA load function

2021-09-06 Thread Clements, John
[AMD Official Use Only] Reviewed-by: John Clements -Original Message- From: Li, Candice Sent: Monday, September 6, 2021 4:34 PM To: amd-gfx@lists.freedesktop.org Cc: Clements, John ; Li, Candice Subject: [PATCH] drm/amdgpu: Create common PSP TA load function Creat common PSP TA load

Re: [PATCH v2 0/2] Fix a hung during memory pressure test

2021-09-06 Thread Christian König
Am 06.09.21 um 03:12 schrieb xinhui pan: A long time ago, someone reports system got hung during memory test. In recent days, I am trying to look for or understand the potential deadlock in ttm/amdgpu code. This patchset aims to fix the deadlock during ttm populate. TTM has a parameter

Re: [PATCH v2 2/2] drm/amdpgu: Use VRAM domain in UVD IB test

2021-09-06 Thread Christian König
Am 06.09.21 um 03:12 schrieb xinhui pan: Like vce/vcn does, visible VRAM is OK for ib test. While commit a11d9ff3ebe0 ("drm/amdgpu: use GTT for uvd_get_create/destory_msg") says VRAM is not mapped correctly in his platform which is likely an arm64. So lets change back to use VRAM on x86_64

[PATCH] drm/amdgpu: Create common PSP TA load function

2021-09-06 Thread Candice Li
Creat common PSP TA load function and update PSP ta_mem_context with size information. Signed-off-by: Candice Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 280 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 17 +- 2 files changed, 93 insertions(+), 204 deletions(-)

[PATCH] drm/radeon: Prefer kcalloc over open coded arithmetic

2021-09-06 Thread Len Baker
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values

[QUESTION] [amd-gfx] iMac 5K resolution

2021-09-06 Thread Максим Мосейчук
Hello. I try to install Linux (Gentoo) on iMac 27'' with 5700 XT Pro. And I want to get 5k resolution. 5k uses 2 DP 1.2 links, but Linux detects only one connection. Max available resolution is 4k. kernel 5.6 and 5.14. Linux-firmware latest from git. Display sends EDID with max 4k resolution.

RE: [diagnostic TDR mode patches] unify our solution opinions/suggestions in one thread

2021-09-06 Thread Liu, Monk
[AMD Official Use Only] > I'm fearing that just repeating what Alex said, but to make it clear > once more: That is *not* necessary! > > The shared repository is owned by upstream maintainers and they are > usually free to do restructuring work without getting acknowledge from > every single