v2
add check for SMU_DEFAULT_PPT_LIMIT
v1
modify (pptable_funcs)->set_power_limit signature
modify smu11 set_power_limit signature (arcturus, navi10, sienna_cichlid)
modify smu13 set_power_limit signature (aldabaran)
modify vangogh_set_power_limit signature (vangogh)
=== Test ===
sudo
when smu->adev->pm.ac_power == 0, message parameter with bit 16 set is saved
to smu->current_power_limit.
Fixes: 0cb4c62125a9 ("drm/amd/pm: correct power limit setting for SMU V11)"
Signed-off-by: Darren Powell
---
drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 9 +
1 file
=== Description ===
Add limit_type to (pptable_funcs)->set_power_limit signature
plus small patch
Fix for incorrect power limit readback in smu11 if POWER_SOURCE_DC
v2
add check for SMU_DEFAULT_PPT_LIMIT
dropped patch: Explicit initialization of cached power limits in smu struct
=== Test
On 10/5/2021 10:15 PM, Christian König wrote:
Am 05.10.21 um 15:49 schrieb Das, Nirmoy:
On 10/5/2021 3:22 PM, Christian König wrote:
Am 05.10.21 um 15:11 schrieb Nirmoy Das:
Debugfs core APIs will throw -EPERM when user disables debugfs
using CONFIG_DEBUG_FS_ALLOW_NONE or with kernel
On Mon, Feb 15, 2021 at 04:21:35PM +0200, Andy Shevchenko wrote:
We have already few similar implementation and a lot of code that can benefit
of the yesno() helper. Consolidate yesno() helpers under string.h hood.
I was taking a look on i915_utils.h to reduce it and move some of it
elsewhere
On 2021-09-29 15:06, Simon Ser wrote:
> The current logic checks whether the cursor plane blending
> properties match the primary plane's. However that's wrong,
> because the cursor is painted on all planes underneath. If
> the cursor is over the primary plane and the cursor plane,
Do you mean
On 2021-09-29 15:06, Simon Ser wrote:
> Commit ddab8bd788f5 ("drm/amd/display: Fix two cursor duplication when
> using overlay") changed the atomic validation code to forbid the
> overlay plane from being used if it doesn't cover the whole CRTC. The
> motivation is that ChromeOS uses the atomic
On 2021-10-05 03:51, Wayne Lin wrote:
> USB4 runs over USB-C and can tunnels USB3, PCIe and DP protocols.
>
> A USB4 router is responsible for mapping Tunneled Protocol traffic
> to USB4 packets and routes packets through the USB4 Fabric.
> For this patchset, we have native DisplayPort able to be
On 2021-10-05 03:52, Wayne Lin wrote:
> From: Jimmy Kizito
>
> [Why & How]
> Additional debug flags that can be useful for testing USB4 DP
> link training.
>
> Add flags:
> - 0x2 : Forces USB4 DP link to non-LTTPR mode
> - 0x4 : Extends status read intervals to about 60s.
>
> Reviewed-by:
Am 05.10.21 um 15:49 schrieb Das, Nirmoy:
On 10/5/2021 3:22 PM, Christian König wrote:
Am 05.10.21 um 15:11 schrieb Nirmoy Das:
Debugfs core APIs will throw -EPERM when user disables debugfs
using CONFIG_DEBUG_FS_ALLOW_NONE or with kernel param. We shouldn't
see that as an error. Also
On 2021-10-05 03:51, Wayne Lin wrote:
> From: Jimmy Kizito
>
> [Why & How]
> Add codes for commit "822536713066 drm/amd/display: Add fallback
> and abort paths for DP link training" to support USB4 DP tunneling
> feature
>
Suggested title: "Train DPIA links with fallback"
Harry
>
On 2021-10-05 03:51, Wayne Lin wrote:
> From: Jimmy Kizito
>
> [why & how]
> Add codes for commit "ede4f6dac99e drm/amd/display: Update
> setting of DP training parameters." to support USB4 DP tunneling
> feature
>
Suggested title: Skip DPCD read for DPTX-to-DPIA hop
Suggested description:
On 2021-10-05 03:51, Wayne Lin wrote:
> From: Jimmy Kizito
>
> [why & how]
> Add codes for commit "99732e52e7f8 drm/amd/display: Update DPRX detection"
> to support USB4 DP tunneling feature
>
This patch does a few, seemingly unrelated, changes:
1. Add stub for getting tunneling device data
2.
On 2021-10-05 03:51, Wayne Lin wrote:
> From: Jimmy Kizito
>
> [why & how]
> Add codes for commit "79ed7354d70f drm/amd/display: Update
> display endpoint control path" to support USB4 DP tunneling
> feature.
>
Suggested Title: "Stub out DPIA link training call"
Suggested Description:
"Add
On 2021-10-05 03:51, Wayne Lin wrote:
> From: Jimmy Kizito
>
> [why & how]
> Add codes for commit "f42ef862fb1f drm/amd/display: Add dynamic
> link encoder selection" to support USB4 DP tunneling feature.
>
Title should be:
"Set DPIA link endpoint type"
Description:
"We will need a way to
On 2021-10-05 10:15, Harry Wentland wrote:
>
>
> On 2021-10-05 03:51, Wayne Lin wrote:
>> From: Jimmy Kizito
>>
>> [Why & How]
>> Add codes for commit "e1f4328f22c0 drm/amd/display: Update link
>> encoder object creation" to support USB4 DP tunneling feature
>>
>
> It looks like all of
On Tue, Oct 5, 2021 at 10:29 AM Paul Menzel wrote:
>
> Dear Tom, dear Linux folks,
>
>
> Selecting the symbol `AMD_MEM_ENCRYPT` – as done in Debian 5.13.9-1~exp1
> [1] – also selects `AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT`, as it defaults
> to yes, causing boot failures on AMD Raven systems. On the
On Tue, Oct 05, 2021 at 04:29:41PM +0200, Paul Menzel wrote:
> Selecting the symbol `AMD_MEM_ENCRYPT` – as
> done in Debian 5.13.9-1~exp1 [1] – also selects
> `AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT`, as it defaults to yes,
I'm assuming that "selecting" is done automatically: alldefconfig,
Dear Tom, dear Linux folks,
Selecting the symbol `AMD_MEM_ENCRYPT` – as done in Debian 5.13.9-1~exp1
[1] – also selects `AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT`, as it defaults
to yes, causing boot failures on AMD Raven systems. On the MSI B350M
MORTAR with AMD Ryzen 3 2200G, Linux logs and the
On 2021-10-05 03:51, Wayne Lin wrote:
> From: Jimmy Kizito
>
> [Why & How]
> Add codes for commit "e1f4328f22c0 drm/amd/display: Update link
> encoder object creation" to support USB4 DP tunneling feature
>
It looks like all of Jimmy's patches refer to porting code from some other
patches.
On 10/5/2021 7:19 PM, Das, Nirmoy wrote:
On 10/5/2021 3:22 PM, Christian König wrote:
Am 05.10.21 um 15:11 schrieb Nirmoy Das:
Debugfs core APIs will throw -EPERM when user disables debugfs
using CONFIG_DEBUG_FS_ALLOW_NONE or with kernel param. We shouldn't
see that as an error. Also
From: Leslie Shi
[ Upstream commit 66805763a97f8f7bdf742fc0851d85c02ed9411f ]
gmc_v{9,10}_0_gart_disable() isn't called matched with
correspoding gart_enbale function in SRIOV case. This will
lead to gart.bo pin_count leak on driver unload.
Cc: Hawking Zhang
Signed-off-by: Leslie Shi
On 10/5/2021 3:22 PM, Christian König wrote:
Am 05.10.21 um 15:11 schrieb Nirmoy Das:
Debugfs core APIs will throw -EPERM when user disables debugfs
using CONFIG_DEBUG_FS_ALLOW_NONE or with kernel param. We shouldn't
see that as an error. Also validate drm root dentry before creating
amdgpu
Am 05.10.21 um 15:11 schrieb Nirmoy Das:
Debugfs core APIs will throw -EPERM when user disables debugfs
using CONFIG_DEBUG_FS_ALLOW_NONE or with kernel param. We shouldn't
see that as an error. Also validate drm root dentry before creating
amdgpu debugfs files.
Signed-off-by: Nirmoy Das
---
Debugfs core APIs will throw -EPERM when user disables debugfs
using CONFIG_DEBUG_FS_ALLOW_NONE or with kernel param. We shouldn't
see that as an error. Also validate drm root dentry before creating
amdgpu debugfs files.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
On 10/5/2021 2:41 PM, Christian König wrote:
Am 05.10.21 um 14:20 schrieb Das, Nirmoy:
Hi Christian,
On 10/5/2021 2:01 PM, Christian König wrote:
Am 05.10.21 um 13:58 schrieb Nirmoy Das:
drm_dev_register() will try to init driver's debugfs using
drm_driver.debugfs_init call back
Am 05.10.21 um 14:20 schrieb Das, Nirmoy:
Hi Christian,
On 10/5/2021 2:01 PM, Christian König wrote:
Am 05.10.21 um 13:58 schrieb Nirmoy Das:
drm_dev_register() will try to init driver's debugfs using
drm_driver.debugfs_init call back function. Use that callback
also for amdgpu to
Hi Christian,
On 10/5/2021 2:01 PM, Christian König wrote:
Am 05.10.21 um 13:58 schrieb Nirmoy Das:
drm_dev_register() will try to init driver's debugfs using
drm_driver.debugfs_init call back function. Use that callback
also for amdgpu to intialize debugfs.
Mhm, why is that useful? We
On 10/5/2021 2:01 PM, Christian König wrote:
Am 05.10.21 um 13:58 schrieb Nirmoy Das:
drm_dev_register() will try to init driver's debugfs using
drm_driver.debugfs_init call back function. Use that callback
also for amdgpu to intialize debugfs.
Mhm, why is that useful? We rather wanted to
On 10/5/2021 1:58 PM, Nirmoy Das wrote:
drm_dev_register() will try to init driver's debugfs using
drm_driver.debugfs_init call back function. Use that callback
also for amdgpu to intialize debugfs.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 10 +-
Am 05.10.21 um 13:58 schrieb Nirmoy Das:
drm_dev_register() will try to init driver's debugfs using
drm_driver.debugfs_init call back function. Use that callback
also for amdgpu to intialize debugfs.
Mhm, why is that useful? We rather wanted to get rid of all this DRM
midlayering.
drm_dev_register() will try to init driver's debugfs using
drm_driver.debugfs_init call back function. Use that callback
also for amdgpu to intialize debugfs.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 10 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.h |
[Public]
Thanks Andrey, I will update the name to be " pci_channel_state " when
submitting.
Regards,
Guchun
-Original Message-
From: Grodzovsky, Andrey
Sent: Tuesday, October 5, 2021 12:04 AM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Koenig,
Christian ; Pan, Xinhui ;
From: Jude Shih
[Why]
YELLOW_CARP_B0 address was not correct
[How]
Set YELLOW_CARP_B0 to 0x1A.
Reviewed-by: Nicholas Kazlauskas
Acked-by: Wayne Lin
Signed-off-by: Jude Shih
---
drivers/gpu/drm/amd/display/include/dal_asic_id.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Jude Shih
[Why]
Condition variable sometimes terminated unexpectedly
[How]
Use wait_for_completion_timeout to avoid unexpected termination of CV
Reviewed-by: Nicholas Kazlauskas
Acked-by: Wayne Lin
Signed-off-by: Jude Shih
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
From: Jude Shih
[why]
1. HPD callback function has deadlock problem
2. HPD status is not assigned
3. There is crash due to null pointer
4. link_enc is NULL in DPIA case
[How]
1. Fix deadlock problem by moving it out of the
drm_modeset_lock
2. Assign HPD status from the notify of outbox
From: Meenakshikumar Somasundaram
[Why & How]
Add codes for commit "b693dfe24d61 drm/amd/display: Fix for null
pointer access for ddc pin and aux engine" to take USB4 feature
into account.
Reviewed-by: Jimmy Kizito
Acked-by: Wayne Lin
Acked-by: Nicholas Kazlauskas
Signed-off-by:
From: Jimmy Kizito
[Why & How]
Additional debug flags that can be useful for testing USB4 DP
link training.
Add flags:
- 0x2 : Forces USB4 DP link to non-LTTPR mode
- 0x4 : Extends status read intervals to about 60s.
Reviewed-by: Meenakshikumar Somasundaram
Reviewed-by: Jun Lei
Acked-by:
From: Jimmy Kizito
[Why]
DIB_BE_CNTL.DIG_HPD_SELECT selects the HPD block being used
by the display endpoint assigned to DIG. In the case of USB4
display endpoints, no physical HPD block is assigned.
[How]
Setting DIB_BE_CNTL.DIG_HPD_SELECT to 5 indicates that no HPD
is assigned to a display
From: Jude Shih
[Why]
To process SET_CONFIG transactions with DMUB using inbox1 and
outbox1 mail boxes.
[How]
1) DMUB posts SET_CONFIG reply as an Outbox1 message of type
DMUB_OUT_CMD__SET_CONFIG_REPLY.
2) The dmub async to sync mechanism for AUX is modified to accommodate
SET_CONFIG
From: Meenakshikumar Somasundaram
[Why & How]
To add support for dpia debug options.
Reviewed-by: Jimmy Kizito
Acked-by: Wayne Lin
Acked-by: Nicholas Kazlauskas
Signed-off-by: Meenakshikumar Somasundaram
---
drivers/gpu/drm/amd/display/dc/dc.h | 9 +
From: Jimmy Kizito
[Why]
We requires information from DPCD in order to identify USB4 DP
tunneling targets.
[How]
Add USB4 DP tunneling fields to DPCD struct and populate these fields
during sink detection.
Reviewed-by: Jun Lei
Acked-by: Wayne Lin
Acked-by: Nicholas Kazlauskas
Signed-off-by:
From: Meenakshikumar Somasundaram
[Why]
To process SET_CONFIG transactions with DMUB using inbox1 and
outbox1 mail boxes.
[How]
1) Added inbox1 DPIA command subtype DMUB_CMD__DPIA_SET_CONFIG_ACCESS to
issue SET_CONFIG command to DMUB in dc_process_dmub_set_config_async().
DMUB processes
From: Jimmy Kizito
[Why & How]
Clear training pattern sequence for hop in display path once clock
recovery and equalization phases of DP tunnel link training completed.
Reviewed-by: Jun Lei
Acked-by: Wayne Lin
Acked-by: Nicholas Kazlauskas
Signed-off-by: Jimmy Kizito
---
From: Jimmy Kizito
[Why]
Equalisation is the mandatory second phase of DisplayPort link training
over a USB4 DP tunnel.
[How]
Implement equalisation phase for DP tunneled over USB4 in DPIA
training module.
Reviewed-by: Jun Lei
Acked-by: Wayne Lin
Acked-by: Nicholas Kazlauskas
Signed-off-by:
From: Jimmy Kizito
[Why]
Clock recovery is the mandatory first phase of DP link training.
[How]
- Implement clock recovery phase in DPIA training module.
- Add helper functions for building SET_CONFIG messages.
Reviewed-by: Jun Lei
Acked-by: Wayne Lin
Acked-by: Nicholas Kazlauskas
From: Jimmy Kizito
[Why]
Training settings need to be applied to DPIA link at start of each
training loop. Note: FEC readiness should be configured before link
training while FEC enablement should be configured once training is
complete.
[How]
- Implement DPIA link configuration function.
-
From: Jimmy Kizito
[Why]
Training of DPIA link differs enough from that of conventional
DP link to warrant a separate implementation.
[How]
- Implement top-level of DPIA training loop.
- Make functions shared between DP and DPIA link training "public".
Reviewed-by: Jun Lei
Acked-by: Wayne Lin
From: Jimmy Kizito
[Why & How]
Add codes for commit "822536713066 drm/amd/display: Add fallback
and abort paths for DP link training" to support USB4 DP tunneling
feature
Reviewed-by: Jun Lei
Acked-by: Wayne Lin
Acked-by: Nicholas Kazlauskas
Signed-off-by: Jimmy Kizito
---
From: Jimmy Kizito
[why & how]
Add codes for commit "ede4f6dac99e drm/amd/display: Update
setting of DP training parameters." to support USB4 DP tunneling
feature
Reviewed-by: Jun Lei
Acked-by: Wayne Lin
Acked-by: Nicholas Kazlauskas
Signed-off-by: Jimmy Kizito
---
From: Jimmy Kizito
[why & how]
Add codes for commit "99732e52e7f8 drm/amd/display: Update DPRX detection"
to support USB4 DP tunneling feature
Reviewed-by: Jun Lei
Acked-by: Wayne Lin
Acked-by: Nicholas Kazlauskas
Signed-off-by: Jimmy Kizito
---
drivers/gpu/drm/amd/display/dc/Makefile
From: Jimmy Kizito
[why & how]
Add codes for commit "79ed7354d70f drm/amd/display: Update
display endpoint control path" to support USB4 DP tunneling
feature.
Reviewed-by: Jun Lei
Acked-by: Wayne Lin
Acked-by: Nicholas Kazlauskas
Signed-off-by: Jimmy Kizito
---
From: Jimmy Kizito
[why & how]
Add codes for commit "f42ef862fb1f drm/amd/display: Add dynamic
link encoder selection" to support USB4 DP tunneling feature.
Reviewed-by: Jun Lei
Acked-by: Wayne Lin
Acked-by: Nicholas Kazlauskas
Signed-off-by: Jimmy Kizito
---
From: Meenakshikumar Somasundaram
[WHY]
To add support for HPD & HPD RX interrupt handling for USB4 DPIA in
YELLOW_CARP_B0. USB4 DPIA HPD & HPD RX interrupts are issued from DMUB to
driver as a outbox1 message.
[HOW]
1) Created get_link_index_from_dpia_port_index() to retrieve link index
From: Meenakshikumar Somasundaram
[WHY]
To enable dc links for USB4 DPIA ports and AUX command tunneling
for YELLOW_CARP_B0.
[HOW]
1) Created dc links for all USB4 DPIA ports in create_links().
dc_link_construct() implementation is split for legacy DDC and DPIAs.
As usb4 has no ddc,
From: Jimmy Kizito
[Why & How]
Add codes for commit "e1f4328f22c0 drm/amd/display: Update link
encoder object creation" to support USB4 DP tunneling feature
Reviewed-by: Jun Lei
Acked-by: Wayne Lin
Acked-by: Nicholas Kazlauskas
Signed-off-by: Jimmy Kizito
---
USB4 runs over USB-C and can tunnels USB3, PCIe and DP protocols.
A USB4 router is responsible for mapping Tunneled Protocol traffic
to USB4 packets and routes packets through the USB4 Fabric.
For this patchset, we have native DisplayPort able to be tunneled
over USB4 Fabric.
E.g.
DP source ->
[Public]
> -Original Message-
> From: Wentland, Harry
> Sent: Monday, October 4, 2021 10:48 PM
> To: Lin, Wayne ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Kazlauskas, Nicholas
> ; Siqueira, Rodrigo
> ; Wang, Chao-kai (Stylon) ;
> Shih, Jude ; Kizito, Jimmy
> ;
58 matches
Mail list logo
