[PATCH] drm/amd/amdgpu: use advanced TDR mode by default

2021-11-26 Thread Bokun Zhang
From: Bokun Zhang In the patch about advanced TDR mode, we force to always set amdgpu_gpu_recovery=2 under SRIOV. This is not ideal, since we may want to revert back to use the legacy TDR routine. Therefore, we only set amdgpu_gpu_recovery=2 when it is configured as AUTO, which is the default va

[PATCH] drm/amdkfd: fix double free mem structure

2021-11-26 Thread Philip Yang
drm_gem_object_put calls release_notify callback to free the mem structure and unreserve_mem_limit, move it down after the last access of mem and make it conditional call. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 6 -- 1 file changed, 4 insertions(+),

Re: [PATCH] drm/amdkfd: set "r = 0" explicitly before goto

2021-11-26 Thread Felix Kuehling
[+Dan] On 2021-11-26 1:42 p.m., Philip Yang wrote: To silence the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:2615 svm_range_restore_pages() warn: missing error code here? 'get_task_mm()' failed. 'r' = '0' Signed-off-by: Philip Yang Pleas

[PATCH 11/16] drm/amd/display: Add vendor specific LTTPR workarounds for DCN31

2021-11-26 Thread Bhawanpreet Lakha
From: George Shen [Why] Certain LTTPR require special workarounds in order to comply with DP specifications. [How] Implement vendor specific sequences via DPCD writes to vendor-specific LTTPR registers. Reviewed-by: Jun Lei Reviewed-by: Wenjing Liu Acked-by: Bhawanpreet Lakha Signed-off-by:

[PATCH 04/16] drm/amd/display: Clear DPCD lane settings after repeater training

2021-11-26 Thread Bhawanpreet Lakha
From: "Shen, George" [Why] VS and PE requested by repeater should not persist for the sink. [How] Clear DPCD lane settings after repeater link training finishes. Reviewed-by: Wesley Chalmers Acked-by: Bhawanpreet Lakha Signed-off-by: George Shen --- drivers/gpu/drm/amd/display/dc/core/dc_li

[PATCH 16/16] drm/amd/display: 3.2.164

2021-11-26 Thread Bhawanpreet Lakha
From: Aric Cyr This version brings along the following: - FW promotion to 0.0.95 - DSC fixes for supported Docks - Fixes eDP display issue - Vendor LTTR workarounds - Fixes Tiled display audio issue Signed-off-by: Aric Cyr Acked-by: Bhawanpreet.Lakha --- drivers/gpu/drm/amd/display/dc/dc.h |

[PATCH 10/16] drm/amd/display: PSR panel capability debugfs

2021-11-26 Thread Bhawanpreet Lakha
From: Mikita Lipski [why] Adding a debugfs to show PSR capability of the panel and the driver. To use: cat /sys/kernel/debug/dri/0/eDP-X/psr_capability Expected output: Sink support: no/yes Driver support: no/yes [how] Adding psr_capability to eDP connectors. Reviewed-by: Nicholas Kazlauska

[PATCH 15/16] drm/amd/display: [FW Promotion] Release 0.0.95

2021-11-26 Thread Bhawanpreet Lakha
From: Anthony Koo Signed-off-by: Anthony Koo Acked-by: Bhawanpreet Lakha Reviewed-by: Aric Cyr --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/dis

[PATCH 14/16] drm/amd/display: Add 16ms AUX RD interval W/A for specific LTTPR

2021-11-26 Thread Bhawanpreet Lakha
From: George Shen [Why] Certain display configurations require an extra delay before reading lane status with certain LTTPR. [How] Add temporary workaround to force AUX RD interval to 16ms for CR and EQ. Needs to be refactored later. Reviewed-by: Jun Lei Acked-by: Bhawanpreet Lakha Signed-off

[PATCH 12/16] drm/amd/display: Skip vendor specific LTTPR w/a outside link training

2021-11-26 Thread Bhawanpreet Lakha
From: George Shen [Why] Vendor specific link rate toggle workaround should not be applied outside of link training scenario, such as when outputting PHY test pattern. [How] Add flag to indicate when link training is occuring. Make workaround a no-op when flag is not set. Reviewed-by: Jun Lei A

[PATCH 08/16] drm/amd/display: Add work around for tunneled MST.

2021-11-26 Thread Bhawanpreet Lakha
From: Jimmy Kizito [Why] Certain USB4 docks do not seem to be able to handle disabling DSC once it has been enabled on an MST stream. This can result in blank displays. [How] As a work around, always enable DSC on docks exhibiting this issue. The flag to indicate the use of DSC for MST streams o

[PATCH 13/16] drm/amd/display: Add force detile buffer size debug flag

2021-11-26 Thread Bhawanpreet Lakha
From: Michael Strauss [WHY] Allow changing DET size with debug flag for testing purposes Reviewed-by: Nicholas Kazlauskas Acked-by: Bhawanpreet Lakha Signed-off-by: Michael Strauss --- drivers/gpu/drm/amd/display/dc/dc.h | 12 .../gpu/drm/amd/display/dc/dcn31/dc

[PATCH 07/16] drm/amd/display: add function for eDP and backlight power on

2021-11-26 Thread Bhawanpreet Lakha
From: Evgenii Krasnikov [HOW&WHY] Add function to be used for early eDP power on Reviewed-by: Anthony Koo Acked-by: Bhawanpreet Lakha Signed-off-by: Evgenii Krasnikov --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 11 +++ drivers/gpu/drm/amd/display/dc/inc/dc_link_dp.h | 1

[PATCH 06/16] drm/amd/display: Fix for the no Audio bug with Tiled Displays

2021-11-26 Thread Bhawanpreet Lakha
From: Mustapha Ghaddar [WHY] It seems like after a series of plug/unplugs we end up in a situation where tiled display doesnt support Audio. [HOW] The issue seems to be related to when we check streams changed after an HPD, we should be checking the audio_struct as well to see if any of its valu

[PATCH 09/16] drm/amd/display: Fix dual eDP abnormal display issue

2021-11-26 Thread Bhawanpreet Lakha
From: Brandon Syu [WHY] Driver use primary eDP link stream as the condition to enable fastboot or not. In dual eDP case, set second screen only, this would cause slave eDP timing to be used on primary one. [HOW] Add a check for unmatched eDP link stream. Reviewed-by: Nicholas Kazlauskas Acked-

[PATCH 03/16] drm/amd/display: add hdmi disable debug check

2021-11-26 Thread Bhawanpreet Lakha
From: Dale Zhao [Why] Using the hdmi_disable option doesnt disable 6GB bandwidth [How] Add debug.hdmi20_disable flage when checking 6GB enable or not. Reviewed-by: Chris Park Reviewed-by: Aric Cyr Acked-by: Bhawanpreet Lakha Signed-off-by: Dale Zhao --- drivers/gpu/drm/amd/display/dc/dce/d

[PATCH 05/16] drm/amd/display: Fix for otg synchronization logic

2021-11-26 Thread Bhawanpreet Lakha
From: Meenakshikumar Somasundaram [Why] During otg sync trigger, plane states are used to decide whether the otg is already synchronized or not. There are scenarions when otgs are disabled without plane state getting disabled and in such case the otg is excluded from synchronization. [How] Intro

[PATCH 01/16] drm/amd/display: Enable P010 for DCN3x ASICs

2021-11-26 Thread Bhawanpreet Lakha
From: Stylon Wang [Why + How] Enable P010 for SDR video applications. Reviewed-by: Nicholas Kazlauskas Reviewed-by: Bhawanpreet Lakha Acked-by: Bhawanpreet Lakha Signed-off-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn

[PATCH 02/16] drm/amd/display: Allow DSC on supported MST branch devices

2021-11-26 Thread Bhawanpreet Lakha
From: Nicholas Kazlauskas [Why] When trying to lightup two 4k60 non-DSC displays behind a branch device that supports DSC we can't lightup both at once due to bandwidth limitations - each requires 48 VCPI slots but we only have 63. [How] The workaround already exists in the code but is guarded b

[PATCH 00/16] DC Patches Nov 26, 2021

2021-11-26 Thread Bhawanpreet Lakha
This DC patchset brings improvements in multiple areas. In summary, we have: - FW promotion to 0.0.95 - DSC fixes for supported Docks - Fixes eDP display issue - Vendor LTTR workarounds - Fixes Tiled display audio issue Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.95 Aric Cyr (

[PATCH] drm/amdkfd: set "r = 0" explicitly before goto

2021-11-26 Thread Philip Yang
To silence the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:2615 svm_range_restore_pages() warn: missing error code here? 'get_task_mm()' failed. 'r' = '0' Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 ++ 1 file chang

Re: [PATCH v2] drm/amd/display: Add DP-HDMI FRL PCON Support in DC

2021-11-26 Thread Kazlauskas, Nicholas
On 2021-11-26 9:32 a.m., Fangzhi Zuo wrote: Change since v1: add brief description 1. Add hdmi frl pcon support to existing asic family. 2. Determine pcon frl capability based on pcon dpcd. 3. pcon frl is taken into consideration into mode validation. Signed-off-by: Fangzhi Zuo Reviewed-by: N

Re: [PATCH 1/6] Documentation/gpu: Reorganize DC documentation

2021-11-26 Thread Daniel Vetter
On Thu, Nov 25, 2021 at 10:38:25AM -0500, Rodrigo Siqueira wrote: > Display core documentation is not well organized, and it is hard to find > information due to the lack of sections. This commit reorganizes the > documentation layout, and it is preparation work for future changes. > > Signed-off-

Re: [PATCH 1/6] Documentation/gpu: Reorganize DC documentation

2021-11-26 Thread Daniel Vetter
On Fri, Nov 26, 2021 at 11:35:03AM +0100, Christian König wrote: > Just a general comment. Could you name the new subdirectory "amdgpu" > instead? > > DC is just a component of the amdgpu driver and I think it would sooner or > later make sense to group together the amdgpu documentation in one fol

Re: [PATCH v2] drm/amd/display: Add DP-HDMI FRL PCON Support in DC

2021-11-26 Thread Harry Wentland
On 2021-11-26 09:32, Fangzhi Zuo wrote: > Change since v1: add brief description > 1. Add hdmi frl pcon support to existing asic family. > 2. Determine pcon frl capability based on pcon dpcd. > 3. pcon frl is taken into consideration into mode validation. > > Signed-off-by: Fangzhi Zuo Acked-by:

[PATCH v2] drm/amd/display: Add DP-HDMI FRL PCON Support in DC

2021-11-26 Thread Fangzhi Zuo
Change since v1: add brief description 1. Add hdmi frl pcon support to existing asic family. 2. Determine pcon frl capability based on pcon dpcd. 3. pcon frl is taken into consideration into mode validation. Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 15

Re: [PATCH v1] drm/amd/display: Add DP-HDMI PCON Support in DC

2021-11-26 Thread Harry Wentland
How does this differ or interact with the "Add DP-HDMI PCON SST Support" patch? A short description of what this patch does would be helpful. Harry On 2021-11-25 16:22, Fangzhi Zuo wrote: > Signed-off-by: Fangzhi Zuo > --- > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 15 > .../gpu/d

RE: [PATCH Review 1/1] drm/amdgpu: fix disable ras feature failed when unload drvier v2

2021-11-26 Thread Zhang, Hawking
[AMD Official Use Only] Thanks! Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Stanley.Yang Sent: Friday, November 26, 2021 21:26 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John ; Zhou1, Tao ; Li, Candice ; Chai, Thomas Cc: Yang, Stanley S

[PATCH Review 1/1] drm/amdgpu: fix disable ras feature failed when unload drvier v2

2021-11-26 Thread Stanley . Yang
v2: still need call ras_disable_all_featrures to handle ras initilization failure case. Function amdgpu_device_fini_hw is called before amdgpu_device_fini_sw, so ras ta will unload before send ras disable command, ras dsiable operation must before hw fini. Signed-off-by: Stanley.Yang ---

回复: [PATCH Review 1/1] drm/amdgpu: fix disable ras feature failed when unload drvier

2021-11-26 Thread Yang, Stanley
[AMD Official Use Only] Yeah, you are right, I ignored ras initialization failure case, will update soon, thanks. Regards, Stanley > -邮件原件- > 发件人: Zhang, Hawking > 发送时间: Friday, November 26, 2021 9:11 PM > 收件人: Yang, Stanley ; amd- > g...@lists.freedesktop.org; Clements, John ; > Zhou1,

RE: [PATCH Review 1/1] drm/amdgpu: fix disable ras feature failed when unload drvier

2021-11-26 Thread Zhang, Hawking
[AMD Official Use Only] I suspect it is still needed, especially when amdgpu_ras_fini is used to deal with ras initialization failure in psp_ras_initialize. Regards, Hawking -Original Message- From: Yang, Stanley Sent: Friday, November 26, 2021 21:08 To: Zhang, Hawking ; amd-gfx@lists

回复: [PATCH Review 1/1] drm/amdgpu: fix disable ras feature failed when unload drvier

2021-11-26 Thread Yang, Stanley
[AMD Official Use Only] It's not necessary, because before hw fini, all ras features have been disabled and con->features is set to zero. Regards, Stanley > -邮件原件- > 发件人: Zhang, Hawking > 发送时间: Friday, November 26, 2021 8:57 PM > 收件人: Yang, Stanley ; amd- > g...@lists.freedesktop.org; C

RE: [PATCH Review 1/1] drm/amdgpu: fix disable ras feature failed when unload drvier

2021-11-26 Thread Zhang, Hawking
[AMD Official Use Only] Good catch. We still need to release ras object in the end. Any reason the sequence was removed? @@ -2564,9 +2563,6 @@ int amdgpu_ras_fini(struct amdgpu_device *adev) WARN(con->features, "Feature mask is not cleared"); - if (con->features) -

Re: [PATCH v2 07/13] drm/msm: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-11-26 Thread Dmitry Baryshkov
On 16/10/2021 21:42, Claudio Suarez wrote: Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi Signed-off-by: Claudio Suarez

Re: [PATCH v10 08/10] dyndbg: add print-to-tracefs, selftest with it - RFC

2021-11-26 Thread Vincent Whitchurch
On Fri, Nov 19, 2021 at 11:46:31PM +0100, jim.cro...@gmail.com wrote: > Vincent's code has the macro magic to define that event, which IIUC > is what makes it controllable by ftrace, and therefore acceptable in > principle to Steve. > Would there be any reason to expand his set of 2 events into de

Failed to terminate hdcp ta during suspend on Xen

2021-11-26 Thread Josef Johansson
Hi, I'm trying to solve problems during Suspend/Resume on Qubes OS (which is running Xen). What happens is that the resume works, but the screen blanks out each time I type a letter on the keyboard and then returns again, then after a while the screen just goes black. If I boot the same kernel w

Re: kernel 5.15.x: AMD RX 6700 XT - Fails to resume after screen blank

2021-11-26 Thread Thorsten Leemhuis
Hi, this is your Linux kernel regression tracker speaking. On 24.11.21 20:14, Mark Boddington wrote: > Hi all, > > TL;DR - git bisection points to > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.4&id=61d861cf478576d85d6032f864360a34b26084b1 > as causing an issue

Re: [PATCH 1/6] Documentation/gpu: Reorganize DC documentation

2021-11-26 Thread Christian König
Just a general comment. Could you name the new subdirectory "amdgpu" instead? DC is just a component of the amdgpu driver and I think it would sooner or later make sense to group together the amdgpu documentation in one folder. Regards, Christian. Am 25.11.21 um 16:38 schrieb Rodrigo Siquei

[PATCH Review 1/1] drm/amdgpu: fix disable ras feature failed when unload drvier

2021-11-26 Thread Stanley . Yang
Function amdgpu_device_fini_hw is called before amdgpu_device_fini_sw, so ras ta will unload before send ras disable command, ras dsiable operation must before hw fini. Signed-off-by: Stanley.Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

[bug report] drm/amdkfd: process exit and retry fault race

2021-11-26 Thread Dan Carpenter
Hello Philip Yang, The patch a0c55ecee100: "drm/amdkfd: process exit and retry fault race" from Nov 16, 2021, leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:2615 svm_range_restore_pages() warn: missing error code here? 'get_ta