Re: [PATCH V4 02/17] drm/amd/pm: do not expose power implementation details to amdgpu_pm.c

2021-12-09 Thread Lazar, Lijo
On 12/3/2021 8:35 AM, Evan Quan wrote: amdgpu_pm.c holds all the user sysfs/hwmon interfaces. It's another client of our power APIs. It's not proper to spike into power implementation details there. Signed-off-by: Evan Quan Change-Id: I397853ddb13eacfce841366de2a623535422df9a -- v1->v2: -

Re: [PATCH V4 03/17] drm/amd/pm: do not expose power implementation details to display

2021-12-09 Thread Lazar, Lijo
On 12/3/2021 8:35 AM, Evan Quan wrote: Display is another client of our power APIs. It's not proper to spike into power implementation details there. Signed-off-by: Evan Quan Change-Id: Ic897131e16473ed29d3d7586d822a55c64e6574a --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +- .

[PATCH 1/2] drm/amdgpu: introduce a kind of halt state for amdgpu device

2021-12-09 Thread Lang Yu
It is useful to maintain error context when debugging SW/FW issues. We introduce amdgpu_device_halt() for this purpose. It will bring hardware to a kind of halt state, so that no one can touch it any more. Compare to a simple hang, the system will keep stable at least for SSH access. Then it shoul

Re: [PATCH v2] drm/amdgpu: fix incorrect VCN revision in SRIOV

2021-12-09 Thread Lazar, Lijo
On 12/9/2021 10:55 AM, Leslie Shi wrote: Guest OS will setup VCN instance 1 which is disabled as an enabled instance and execute initialization work on it, but this causes VCN ib ring test failure on the disabled VCN instance during modprobe: amdgpu :00:08.0: amdgpu: ring vcn_enc_1.0 uses

Re: [PATCH] drm/ttm: Don't inherit GEM object VMAs in child process

2021-12-09 Thread Christian König
Am 08.12.21 um 21:53 schrieb Rajneesh Bhardwaj: When an application having open file access to a node forks, its shared mappings also get reflected in the address space of child process even though it cannot access them with the object permissions applied. With the existing permission checks on t

[PATCH] drm/amdkfd: explicitly create/destroy queue attributes under /sys

2021-12-09 Thread Xiaogang . Chen
From: Xiaogang Chen When application is about finish it destroys queues it has created by an ioctl. Driver deletes queue entry(/sys/class/kfd/kfd/proc/pid/queues/queueid/) which is directory including this queue all attributes. Low level kernel code deletes all attributes under this directory. T

[pull] amdgpu drm-fixes-5.16

2021-12-09 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.16. The following changes since commit a687efed194bdc185fd7cb33920fe8b4e60ecb9e: Merge tag 'drm-intel-fixes-2021-12-02' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2021-12-03 05:59:31 +1000) are available in the Git repository at: https://g

Re: gpu block diagram

2021-12-09 Thread Alex Deucher
On Tue, Dec 7, 2021 at 5:07 PM Yann Dirson wrote: > > Thanks for the details Alex! > > Here is an attempt to formalize the decomposition of a > (mostly Renoir) APU, using plantuml. That's highly preliminary, > focusing on blocks/sub-blocks/firmware, based on my current > partial (and surely incor

RE: [PATCH 1/3] amdgpu/pm: Implement new API function "emit" that accepts buffer base and write offset

2021-12-09 Thread Quan, Evan
[AMD Official Use Only] > -Original Message- > From: amd-gfx On Behalf Of > Darren Powell > Sent: Wednesday, December 8, 2021 2:36 PM > To: amd-gfx@lists.freedesktop.org > Cc: Powell, Darren > Subject: [PATCH 1/3] amdgpu/pm: Implement new API function "emit" that > accepts buffer base

RE: [PATCH] drm/amdgpu: add modifiers in amdgpu_vkms_plane_init()

2021-12-09 Thread Chen, Guchun
[Public] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Leslie Shi Sent: Wednesday, December 8, 2021 4:46 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: add modifiers in amdgpu_vkms_plane_init() Fix following warning in SRIOV

[PATCH 1/2] drm/amdkfd: Use prange->list head for insert_list

2021-12-09 Thread Felix Kuehling
There are seven list_heads in struct svm_range: list, update_list, remove_list, insert_list, svm_bo_list, deferred_list, child_list. This patch and the next one remove two of them that are redundant. The insert_list head was only used for new ranges that are not on the svms->list yet. So we can us

Re: [PATCH] drm/amd/pm: skip gfx cgpg in the s0ix suspend-resume

2021-12-09 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: Liang, Prike Sent: Wednesday, December 8, 2021 8:51 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Limonciello, Mario ; Liang, Prike Subject: [PATCH] drm/amd/pm: skip gfx cgpg in the s0ix suspe

Re: [PATCH v2 03/11] mm/gup: migrate PIN_LONGTERM dev coherent pages to system

2021-12-09 Thread Alistair Popple
On Tuesday, 7 December 2021 5:52:43 AM AEDT Alex Sierra wrote: > Avoid long term pinning for Coherent device type pages. This could > interfere with their own device memory manager. > If caller tries to get user device coherent pages with PIN_LONGTERM flag > set, those pages will be migrated back t

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-09 Thread Alex Deucher
On Wed, Dec 8, 2021 at 5:50 PM Yann Dirson wrote: > > Hi Alex, > > > > > On Mon, Dec 6, 2021 at 4:36 PM Yann Dirson wrote: > > > > > > Hi Alex, > > > > > > > We have not validated virtualization of our integrated GPUs. I > > > > don't > > > > know that it will work at all. We had done a bit of

[PATCH v2] drm/amdgpu: fix incorrect VCN revision in SRIOV

2021-12-09 Thread Leslie Shi
Guest OS will setup VCN instance 1 which is disabled as an enabled instance and execute initialization work on it, but this causes VCN ib ring test failure on the disabled VCN instance during modprobe: amdgpu :00:08.0: amdgpu: ring vcn_enc_1.0 uses VM inv eng 5 on hub 1 amdgpu :00:08.0: [d

[PATCH 2/2] drm/amdkfd: Use prange->update_list head for remove_list

2021-12-09 Thread Felix Kuehling
The remove_list head was only used for keeping track of existing ranges that are to be removed from the svms->list. The update_list was used for new or existing ranges that need updated attributes. These two cases are mutually exclusive (i.e. the same range will never be on both lists). Therefore w

Re: [PATCH 1/3] amdgpu/pm: Implement new API function "emit" that accepts buffer base and write offset

2021-12-09 Thread Powell, Darren
[AMD Official Use Only] > The whole idea seems fine to me. However, we are trying to do some cleanups > to avoid spiking into power internals(as above via > adev->powerplay.pp_funcs->emit_clock_levels). > Check the patch series below: > https://lists.freedesktop.org/archives/amd-gfx/2021-Decembe

Re: [PATCH 1/2] drm/amdgpu: Detect if amdgpu in IOMMU isolation mode

2021-12-09 Thread philip yang
On 2021-12-07 5:16 p.m., Alex Deucher wrote: On Tue, Dec 7, 2021 at 4:59 PM Felix Kuehling wrote: On 2021-12-07 9:59 a.m., Philip Yang wrote: If host and amdgpu IOMMU is not enabled or IOMMU is pass through mode, dma_map_

[PATCH] drm/amd/pm: skip gfx cgpg in the s0ix suspend-resume

2021-12-09 Thread Prike Liang
In the s0ix entry need retain gfx in the gfxoff state,we don't disable gfx cgpg in the suspend so there is also needn't enable gfx cgpg in the s0ix resume. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2] drm/amdgpu: fix incorrect VCN revision in SRIOV

2021-12-09 Thread Leslie Shi
Guest OS will setup VCN instance 1 which is disabled as an enabled instance and execute initialization work on it, but this causes VCN ib ring test failure on the disabled VCN instance during modprobe: amdgpu :00:08.0: amdgpu: ring vcn_enc_1.0 uses VM inv eng 5 on hub 1 amdgpu :00:08.0: [d

Recall: [PATCH v2] drm/amdgpu: fix incorrect VCN revision in SRIOV

2021-12-09 Thread Shi, Leslie
Shi, Leslie would like to recall the message, "[PATCH v2] drm/amdgpu: fix incorrect VCN revision in SRIOV".

Re: [PATCH v2 03/11] mm/gup: migrate PIN_LONGTERM dev coherent pages to system

2021-12-09 Thread Jason Gunthorpe
On Wed, Dec 08, 2021 at 10:31:58PM +1100, Alistair Popple wrote: > On Tuesday, 7 December 2021 5:52:43 AM AEDT Alex Sierra wrote: > > Avoid long term pinning for Coherent device type pages. This could > > interfere with their own device memory manager. > > If caller tries to get user device coheren

<    1   2