[PATCH] drm/amdgpu: Fixed warning reported by kernel test robot

2022-02-21 Thread yipechai
Fixed warning reported by kernel test robot: 1.warning: no previous prototype for function 'amdgpu_ras_block_late_init_default'. 2.warning: variable 'ras_obj' is used uninitialized whenever '||' condition is true. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ++-- 1

[PATCH v2] drm/amd/display: add GTT domain support for dcn 3.1.5 and 3.1.6

2022-02-21 Thread Yifan Zhang
From: "Tianci.Yin" this patch adds GTT domain support for dcn 3.1.5 and 3.1.6 Signed-off-by: Tianci.Yin Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c

RE: [PATCH] drm/amd/display: add GTT domain support for dcn 3.1.5

2022-02-21 Thread Zhang, Yifan
[AMD Official Use Only] Hi Christian, We'd like to enable display S/G only for APUs which have smaller VRAM. If >= IP_VERSION(3, 1, 0) is used, new dGPUs will be included. That's not our intention. BRs, Yifan -Original Message- From: Christian König Sent: Tuesday, February 22, 2022

[PATCH v2] drm/amdgpu: check vm ready by amdgpu_vm->evicting flag

2022-02-21 Thread Qiang Yu
Workstation application ANSA/META v21.1.4 get this error dmesg when running CI test suite provided by ANSA/META: [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-16) This is caused by: 1. create a 256MB buffer in invisible VRAM 2. CPU map the buffer and access it causes vm_fault

RE: [PATCH] drm/amd/pm: new v3 SmuMetrics data structure for Sienna Cichlid

2022-02-21 Thread Quan, Evan
[AMD Official Use Only] Acked-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Danijel Slivka > Sent: Friday, February 18, 2022 8:36 PM > To: amd-gfx@lists.freedesktop.org > Cc: Slivka, Danijel > Subject: [PATCH] drm/amd/pm: new v3 SmuMetrics data structure for >

2022 X.Org Board of Directors Elections Nomination period is NOW

2022-02-21 Thread Lyude Paul
We are seeking nominations for candidates for election to the X.Org Foundation Board of Directors. All X.Org Foundation members are eligible for election to the board. Nominations for the 2022 election are now open and will remain open until 23:59 UTC on 06 March 2022. The Board consists of

[PATCH] drm/amdgpu: config HDP_MISC_CNTL.READ_BUFFER_WATERMARK to fix applications running across multiple GPU config hang.

2022-02-21 Thread Xiaogang . Chen
From: Xiaogang Chen Signed-off-by: Xiaogang Chen --- drivers/gpu/drm/amd/amdgpu/hdp_v4_0.c | 1 + drivers/gpu/drm/amd/include/asic_reg/hdp/hdp_4_0_sh_mask.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/hdp_v4_0.c

Re: [PATCH] drm/amdkfd: make CRAT table missing message informational only

2022-02-21 Thread Alex Deucher
On Fri, Feb 18, 2022 at 11:25 PM Paul Menzel wrote: > > Dear Alex, > > > Thank you for the patch. > > Am 18.02.22 um 21:42 schrieb Alex Deucher: > > The driver has a fallback, to make the message informational > > s/to/so/? fixed up locally. > > > rather than a warning. > > Maybe extend it a

Re: [PATCH] drm/amdgpu: Fix typo in *whether* in comment

2022-02-21 Thread Alex Deucher
Applied. Thanks! On Fri, Feb 18, 2022 at 11:56 PM Paul Menzel wrote: > > Signed-off-by: Paul Menzel > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c >

[PATCH 2/2] drm/amdgpu: use ktime rather than jiffies for benchmark results

2022-02-21 Thread Alex Deucher
To protect against wraparounds. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 31 ++- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c

[PATCH 1/2] drm/amdgpu: use kernel BO API for benchmark buffer management

2022-02-21 Thread Alex Deucher
Simplifies the code quite a bit. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 78 --- 1 file changed, 17 insertions(+), 61 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c

[PATCH] drm/amdgpu/test: convert amdgpu_test.c to use dev_info

2022-02-21 Thread Alex Deucher
Rather than the old DRM_INFO/ERROR macros. This makes it easier to differentiate the output when there are multiple GPUs in a system. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_test.c | 69 1 file changed, 35 insertions(+), 34 deletions(-) diff

Re: [PATCH] drm/amdgpu: fix printk format for size_t variable

2022-02-21 Thread Tom Rix
On 2/21/22 12:53 PM, Luben Tuikov wrote: On 2022-02-21 15:36, Tom Rix wrote: On 2/21/22 11:57 AM, Luben Tuikov wrote: Hi Tom, This was already fixed with this patch, and LKML was CC-ed. See the CC tags in the patch below, commit 4f7d7cda90cbd7 Author: Luben Tuikov Date: Wed Feb 16

Re: [PATCH] drm/amdgpu: fix printk format for size_t variable

2022-02-21 Thread Tom Rix
On 2/21/22 11:57 AM, Luben Tuikov wrote: Hi Tom, This was already fixed with this patch, and LKML was CC-ed. See the CC tags in the patch below, commit 4f7d7cda90cbd7 Author: Luben Tuikov Date: Wed Feb 16 16:47:32 2022 -0500 drm/amdgpu: Fix ARM compilation warning Fix

Re: [PATCH 7/7] drm/amdgpu: drop testing module parameter

2022-02-21 Thread Alex Deucher
On Mon, Feb 21, 2022 at 12:44 PM Michel Dänzer wrote: > > On 2022-02-18 23:26, Alex Deucher wrote: > > This was always duplicate functionality with the benchmark tests. > > Not really. The purpose of amdgpu_do_test_moves is testing that copies > between GTT & VRAM work across the whole GTT

Re: [PATCH] drm/amdgpu: fix printk format for size_t variable

2022-02-21 Thread Luben Tuikov
On 2022-02-21 15:36, Tom Rix wrote: > > On 2/21/22 11:57 AM, Luben Tuikov wrote: >> Hi Tom, >> >> This was already fixed with this patch, and LKML was CC-ed. See the CC tags >> in the patch below, >> >> commit 4f7d7cda90cbd7 >> Author: Luben Tuikov >> Date: Wed Feb 16 16:47:32 2022 -0500 >>

Re: [PATCH] drm/amdgpu: fix printk format for size_t variable

2022-02-21 Thread Luben Tuikov
Hi Tom, This was already fixed with this patch, and LKML was CC-ed. See the CC tags in the patch below, commit 4f7d7cda90cbd7 Author: Luben Tuikov Date: Wed Feb 16 16:47:32 2022 -0500 drm/amdgpu: Fix ARM compilation warning Fix this ARM warning:

[PATCH 1/2] drm/amdgpu/display: split dmcu and gpuvm handling logic

2022-02-21 Thread Alex Deucher
Separate the logic for each of these features to make the code easier to understand and update in the future. Signed-off-by: Alex Deucher --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 35 +++ 1 file changed, 20 insertions(+), 15 deletions(-) diff --git

[PATCH 2/2] drm/amdgpu: derive GTT display support from DM

2022-02-21 Thread Alex Deucher
Rather than duplicating the logic in two places, consolidate the logic in the display manager. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 30 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 +

Re: [PATCH v13 1/5] drm: improve drm_buddy_alloc function

2022-02-21 Thread Christian König
Going to let that sit on the mailing list till tomorrow, if I don't get any objections till then I will push it to drm-misc-next. Thanks, Christian. Am 21.02.22 um 17:45 schrieb Arunpravin: - Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands

Re: [PATCH] drm/amd/display: add GTT domain support for dcn 3.1.5

2022-02-21 Thread Christian König
Am 21.02.22 um 15:27 schrieb Alex Deucher: On Mon, Feb 21, 2022 at 5:15 AM Yifan Zhang wrote: From: "Tianci.Yin" this patch adds GTT domain support for dcn 3.1.5 Signed-off-by: Tianci.Yin Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 + 1 file

Re: [PATCH v12 1/5] drm: improve drm_buddy_alloc function

2022-02-21 Thread Arunpravin
On 16/02/22 1:37 pm, Arunpravin wrote: > > > On 14/02/22 2:42 pm, Christian König wrote: >> >> >> Am 14.02.22 um 09:36 schrieb Matthew Auld: >>> On Mon, 14 Feb 2022 at 06:32, Christian König >>> wrote: Am 13.02.22 um 09:52 schrieb Arunpravin: > - Make drm_buddy_alloc a single

[PATCH] drm/amdgpu: fix printk format for size_t variable

2022-02-21 Thread trix
From: Tom Rix On mips64 allyesconfig, there is this build break amdgpu_discovery.c:671:35: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t' {aka 'unsigned int'} DRM_DEBUG("match:%d @ ip_offset:%ld", ii, ip_offset); For size_t, use %zu. Fixes:

Re: [PATCH 7/7] drm/amdgpu: drop testing module parameter

2022-02-21 Thread Michel Dänzer
On 2022-02-18 23:26, Alex Deucher wrote: > This was always duplicate functionality with the benchmark tests. Not really. The purpose of amdgpu_do_test_moves is testing that copies between GTT & VRAM work across the whole GTT aperture (when I originally wrote radeon_do_test_moves, they didn't on

Re: [PATCH v9 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-21 Thread Somalapuram, Amaranath
[AMD Official Use Only] On 2/21/2022 7:58 PM, Christian König wrote: Am 21.02.22 um 15:19 schrieb Somalapuram, Amaranath: [AMD Official Use Only] On 2/21/2022 7:09 PM, Christian König wrote: Am 21.02.22 um 14:34 schrieb Somalapuram Amaranath: List of register populated for dump collection

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-21 Thread kernel test robot
to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jiawei-Gu/drm-sched-Add-device-pointer-to-drm_gpu_scheduler/20220221-175818 base: git

[PATCH v13 5/5] drm/amdgpu: add drm buddy support to amdgpu

2022-02-21 Thread Arunpravin
- Remove drm_mm references and replace with drm buddy functionalities - Add res cursor support for drm buddy v2(Matthew Auld): - replace spinlock with mutex as we call kmem_cache_zalloc (..., GFP_KERNEL) in drm_buddy_alloc() function - lock drm_buddy_block_trim() function as it calls

[PATCH v13 4/5] drm/amdgpu: move vram inline functions into a header

2022-02-21 Thread Arunpravin
Move shared vram inline functions and structs into a header file Signed-off-by: Arunpravin --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 51 1 file changed, 51 insertions(+) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h diff --git

[PATCH v13 2/5] drm: implement top-down allocation method

2022-02-21 Thread Arunpravin
Implemented a function which walk through the order list, compares the offset and returns the maximum offset block, this method is unpredictable in obtaining the high range address blocks which depends on allocation and deallocation. for instance, if driver requests address at a low specific

[PATCH v13 3/5] drm: implement a method to free unused pages

2022-02-21 Thread Arunpravin
On contiguous allocation, we round up the size to the *next* power of 2, implement a function to free the unused pages after the newly allocate block. v2(Matthew Auld): - replace function name 'drm_buddy_free_unused_pages' with drm_buddy_block_trim - replace input argument name

[PATCH v13 1/5] drm: improve drm_buddy_alloc function

2022-02-21 Thread Arunpravin
- Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which allocates the requested power-of-two block comply with range limitations - Moved order computation and memory alignment logic from i915

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-21 Thread kernel test robot
patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jiawei-Gu/drm-sched-Add-device-pointer-to-drm_gpu_scheduler/20220221

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-21 Thread kernel test robot
to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jiawei-Gu/drm-sched-Add-device-pointer-to-drm_gpu_scheduler/20220221-175818 base: git

Re: [PATCH] drm/radeon: fix variable type

2022-02-21 Thread Deucher, Alexander
[Public] Add: Bug: https://bugzilla.kernel.org/show_bug.cgi?id=215600 With that: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Monday, February 21, 2022 6:05 AM To: amd-gfx@lists.freedesktop.org Cc: Koenig, Christian Subject:

Re: Bug 215600 - Radeon - *ERROR* Failed waiting for UVD message

2022-02-21 Thread Alex Deucher
On Mon, Feb 21, 2022 at 3:30 AM Thorsten Leemhuis wrote: > > Hi, this is your Linux kernel regression tracker. > > I noticed a regression report in bugzilla.kernel.org that afaics nobody > acted upon since it was reported about a week ago, that's why I decided > to forward it to the lists and all

Re: [PATCH v9 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-21 Thread Christian König
Am 21.02.22 um 15:19 schrieb Somalapuram, Amaranath: [AMD Official Use Only] On 2/21/2022 7:09 PM, Christian König wrote: Am 21.02.22 um 14:34 schrieb Somalapuram Amaranath: List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath ---  

Re: [PATCH] drm/amd/display: add GTT domain support for dcn 3.1.5

2022-02-21 Thread Alex Deucher
On Mon, Feb 21, 2022 at 5:15 AM Yifan Zhang wrote: > > From: "Tianci.Yin" > > this patch adds GTT domain support for dcn 3.1.5 > > Signed-off-by: Tianci.Yin > Signed-off-by: Yifan Zhang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

RE: [PATCH] drm/amd/display: add GTT domain support for dcn 3.1.5

2022-02-21 Thread Chen, Guchun
Acked-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Yifan Zhang Sent: Monday, February 21, 2022 6:15 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo) ; Zhang, Yifan ; Yin, Tianci (Rico) ; Wentland, Harry Subject: [PATCH] drm/amd/display:

Re: [PATCH v9 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-21 Thread Somalapuram, Amaranath
[AMD Official Use Only] On 2/21/2022 7:09 PM, Christian König wrote: > > > Am 21.02.22 um 14:34 schrieb Somalapuram Amaranath: >> List of register populated for dump collection during the GPU reset. >> >> Signed-off-by: Somalapuram Amaranath >> --- >>   drivers/gpu/drm/amd/amdgpu/amdgpu.h   

Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-02-21 Thread Alex Deucher
On Mon, Feb 21, 2022 at 3:29 AM Eric Valette wrote: > > On 20/02/2022 16:48, Dominique Dumont wrote: > > On Monday, 14 February 2022 22:52:27 CET Alex Deucher wrote: > >> Does the system actually suspend? > > > > Not really. The screens looks like it's going to suspend, but it does come > > back

[PATCH v2 05/22] drm/amd/display: Fix color encoding mismatch

2022-02-21 Thread Maxime Ripard
The amdgpu KMS driver calls drm_plane_create_color_properties() with a default encoding set to BT709. However, the core will ignore it and the driver doesn't force it in its plane state reset hook, so the initial value will be 0, which represents BT601. Fix the mismatch by using an initial value

Re: [PATCH v9 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-21 Thread Christian König
Am 21.02.22 um 14:34 schrieb Somalapuram Amaranath: List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 96 + 2

[PATCH v9 2/2] drm/amdgpu: add reset register dump trace on GPU reset

2022-02-21 Thread Somalapuram Amaranath
Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 16 drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 2 files changed, 32 insertions(+) diff --git

[PATCH v9 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-21 Thread Somalapuram Amaranath
List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 96 + 2 files changed, 100 insertions(+) diff --git

[PATCH] drm/amd/display: move FPU-related code from dcn20 to dml folder

2022-02-21 Thread Melissa Wen
Move parts of dcn20 code that uses FPU to dml folder. It aims to isolate FPU operations as described by series: drm/amd/display: Introduce FPU directory inside DC https://patchwork.freedesktop.org/series/93042/ This patch moves the following functions from dcn20_resource to dml/dcn20_fpu and

[PATCH] drm/radeon: fix variable type

2022-02-21 Thread Christian König
When we switch to dma_resv_wait_timeout() the returned type changes as well. Signed-off-by: Christian König Fixes: 89aae41d740f ("drm/radeon: use dma_resv_wait_timeout() instead of manually waiting") --- drivers/gpu/drm/radeon/radeon_uvd.c | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH 1/1] drm/amdkfd: Use real device for messages

2022-02-21 Thread Christian König
Am 19.02.22 um 01:57 schrieb Felix Kuehling: kfd_chardev() doesn't provide much useful information in dev_... messages on multi-GPU systems because there is only one KFD device, which doesn't correspond to any particular GPU. Use the actual GPU device to indicate the GPU that caused a message.

Re: [PATCH 1/7] drm/amdgpu/benchmark: use dev_info rather than DRM macros for logging

2022-02-21 Thread Christian König
Am 18.02.22 um 23:25 schrieb Alex Deucher: So we can tell which output goes to which device when multiple GPUs are present. Also while we are here, convert DRM_ERROR to dev_info. The error cases are not critical. Signed-off-by: Alex Deucher Reviewed-by: Christian König for the entire

Re: [PATCH] drm/amdgpu: check vm ready by evicting

2022-02-21 Thread Paul Menzel
Dear Qiang Yu, Am 21.02.22 um 11:12 schrieb Qiang Yu: Thank you for your patch. Reading the commit message summary, I have no idea what “check vm ready by evicting” means. Can you please rephrase it? Workstation application ANSA/META get this error dmesg: What version, and how can this

Re: [PATCH] drm/amdgpu: check vm ready by evicting

2022-02-21 Thread Christian König
Am 21.02.22 um 11:12 schrieb Qiang Yu: Workstation application ANSA/META get this error dmesg: [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-16) This is caused by: 1. create a 256MB buffer in invisible VRAM 2. CPU map the buffer and access it causes vm_fault and try to

Re: [PATCH v8 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-21 Thread Christian König
Am 21.02.22 um 11:06 schrieb Somalapuram, Amaranath: [AMD Official Use Only] On 2/21/2022 2:45 PM, Christian König wrote: Am 21.02.22 um 08:15 schrieb Somalapuram Amaranath: List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath ---  

[PATCH 12/12] drm/amdgpu: Remove redundant .ras_fini initialization in some ras blocks

2022-02-21 Thread yipechai
1. Define amdgpu_ras_block_late_fini_default in amdgpu_ras.c as .ras_fini common function, which is called when .ras_fini of ras block isn't initialized. 2. Remove the code of using amdgpu_ras_block_late_fini to initialize .ras_fini in ras blocks. Signed-off-by: yipechai ---

[PATCH 09/12] drm/amdgpu: Remove redundant calls of amdgpu_ras_block_late_fini in hdp ras block

2022-02-21 Thread yipechai
Remove redundant calls of amdgpu_ras_block_late_fini in hdp ras block. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.c | 4 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.h | 1 - drivers/gpu/drm/amd/amdgpu/hdp_v4_0.c | 2 +- 3 files changed, 2 insertions(+), 5 deletions(-)

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-21 Thread Christian König
Am 21.02.22 um 10:57 schrieb Jiawei Gu: Add device pointer so scheduler's printing can use DRM_DEV_ERROR() instead, which makes life easier under multiple GPU scenario. v2: amend all calls of drm_sched_init() v3: fill dev pointer for all drm_sched_init() calls Signed-off-by: Jiawei Gu

[PATCH 11/12] drm/amdgpu: Remove redundant calls of amdgpu_ras_block_late_fini in mca ras block

2022-02-21 Thread yipechai
Remove redundant calls of amdgpu_ras_block_late_fini in mca ras block. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c | 6 -- drivers/gpu/drm/amd/amdgpu/amdgpu_mca.h | 3 --- drivers/gpu/drm/amd/amdgpu/mca_v3_0.c | 21 +++-- 3 files changed, 3

[PATCH 10/12] drm/amdgpu: Remove redundant calls of amdgpu_ras_block_late_fini in sdma ras block

2022-02-21 Thread yipechai
Remove redundant calls of amdgpu_ras_block_late_fini in sdma ras block. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 7 --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 1 - drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- 3 files changed, 1 insertion(+), 9

[PATCH 05/12] drm/amdgpu: Remove redundant calls of amdgpu_ras_block_late_fini in mmhub ras block

2022-02-21 Thread yipechai
Remove redundant calls of amdgpu_ras_block_late_fini in mmhub ras block. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.c | 4 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_mmhub.h | 1 - drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 3 files changed, 2 insertions(+), 5

[PATCH 08/12] drm/amdgpu: Remove redundant calls of amdgpu_ras_block_late_fini in xgmi ras block

2022-02-21 Thread yipechai
Remove redundant calls of amdgpu_ras_block_late_fini in xgmi ras block. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c

[PATCH 06/12] drm/amdgpu: Remove redundant calls of amdgpu_ras_block_late_fini in nbio ras block

2022-02-21 Thread yipechai
Remove redundant calls of amdgpu_ras_block_late_fini in nbio ras block. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.c | 7 --- drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h | 1 - drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 2 +- 3 files changed, 1 insertion(+), 9

[PATCH 07/12] drm/amdgpu: Remove redundant calls of amdgpu_ras_block_late_fini in umc ras block

2022-02-21 Thread yipechai
Remove redundant calls of amdgpu_ras_block_late_fini in umc ras block. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c | 7 --- drivers/gpu/drm/amd/amdgpu/amdgpu_umc.h | 1 - drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-

[PATCH 04/12] drm/amdgpu: Remove redundant calls of amdgpu_ras_block_late_fini in gfx ras block

2022-02-21 Thread yipechai
Remove redundant calls of amdgpu_ras_block_late_fini in gfx ras block. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 7 --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 1 - drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- 3 files changed, 1 insertion(+), 9 deletions(-)

[PATCH 03/12] drm/amdgpu: centrally calls the .ras_fini function of all ras blocks

2022-02-21 Thread yipechai
centrally calls the .ras_fini function of all ras blocks. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 10 -- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 22 -- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 3 ---

[PATCH 01/12] drm/amdgpu: Modify .ras_fini function pointer parameter

2022-02-21 Thread yipechai
Modify .ras_fini function pointer parameter so that it can remove redundant intermediate calls in some ras blocks. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 8

[PATCH 02/12] drm/amdgpu: Optimize xxx_ras_fini function of each ras block

2022-02-21 Thread yipechai
1. Move the variables of ras block instance members to the top of the call to xxx_ras_fini. 2. Function calls inside the modules only use parameters passed from xxx_ras_fini instead of ras block instance members. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4

[PATCH] drm/amd/display: add GTT domain support for dcn 3.1.5

2022-02-21 Thread Yifan Zhang
From: "Tianci.Yin" this patch adds GTT domain support for dcn 3.1.5 Signed-off-by: Tianci.Yin Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c

[PATCH] drm/amdgpu: check vm ready by evicting

2022-02-21 Thread Qiang Yu
Workstation application ANSA/META get this error dmesg: [drm:amdgpu_gem_va_ioctl [amdgpu]] *ERROR* Couldn't update BO_VA (-16) This is caused by: 1. create a 256MB buffer in invisible VRAM 2. CPU map the buffer and access it causes vm_fault and try to move it to visible VRAM 3. force visible

Re: [PATCH v8 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-21 Thread Somalapuram, Amaranath
[AMD Official Use Only] On 2/21/2022 2:45 PM, Christian König wrote: > > > Am 21.02.22 um 08:15 schrieb Somalapuram Amaranath: >> List of register populated for dump collection during the GPU reset. >> >> Signed-off-by: Somalapuram Amaranath >> --- >>   drivers/gpu/drm/amd/amdgpu/amdgpu.h   

[PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-21 Thread Jiawei Gu
Add device pointer so scheduler's printing can use DRM_DEV_ERROR() instead, which makes life easier under multiple GPU scenario. v2: amend all calls of drm_sched_init() v3: fill dev pointer for all drm_sched_init() calls Signed-off-by: Jiawei Gu --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c |

Re: [PATCH v8 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-21 Thread Christian König
Am 21.02.22 um 08:15 schrieb Somalapuram Amaranath: List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 114

Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-02-21 Thread Eric Valette
On 20/02/2022 16:48, Dominique Dumont wrote: On Monday, 14 February 2022 22:52:27 CET Alex Deucher wrote: Does the system actually suspend? Not really. The screens looks like it's going to suspend, but it does come back after 10s or so. The light mounted in the middle of the power button does

[PATCH v2 1/2] drm/edid: parse DRM VESA dsc bpp target

2022-02-21 Thread Yaroslav Bolyukin
As per DisplayID v2.0 Errata E9 spec "DSC pass-through timing support" VESA vendor-specific data block may contain target DSC bits per pixel fields Signed-off-by: Yaroslav Bolyukin --- drivers/gpu/drm/drm_edid.c | 33 ++--- include/drm/drm_connector.h | 6 ++

Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-02-21 Thread Dominique Dumont
On Monday, 14 February 2022 22:52:27 CET Alex Deucher wrote: > Does the system actually suspend? Not really. The screens looks like it's going to suspend, but it does come back after 10s or so. The light mounted in the middle of the power button does not switch off. > Is this system S0i3 or

Re: [PATCH 4/4] kunit: tool: Disable broken options for --alltests

2022-02-21 Thread Johannes Berg
On Sat, 2022-02-19 at 16:00 +0800, David Gow wrote: > On Fri, Feb 18, 2022 at 8:26 PM Johannes Berg > wrote: > > > > On Fri, 2022-02-18 at 15:57 +0800, David Gow wrote: > > > > > > Note that, while this does build again, it still segfaults on startup, > > > so more work remains to be done. > >

Bug 215600 - Radeon - *ERROR* Failed waiting for UVD message

2022-02-21 Thread Thorsten Leemhuis
Hi, this is your Linux kernel regression tracker. I noticed a regression report in bugzilla.kernel.org that afaics nobody acted upon since it was reported about a week ago, that's why I decided to forward it to the lists and all the relevant people. To quote

[PATCH v2 2/2] drm/amd: use fixed dsc bits-per-pixel from edid

2022-02-21 Thread Yaroslav Bolyukin
VESA vendor header from DisplayID spec may contain fixed bit per pixel rate, it should be respected by drm driver Signed-off-by: Yaroslav Bolyukin Reviewed-by: Wayne Lin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 ++ drivers/gpu/drm/amd/display/dc/core/dc_stream.c

Re: [PATCH] drm/amdgpu: check vm bo eviction valuable at last

2022-02-21 Thread Christian König
Am 21.02.22 um 04:28 schrieb Qiang Yu: On Fri, Feb 18, 2022 at 6:24 PM Christian König wrote: Am 18.02.22 um 11:16 schrieb Qiang Yu: [SNIP] If amdgpu_vm_ready() use evicting flag, it's still not equivalent to check vm idle: true -> vm idle, false -> vm may be idle or busy. Yeah, but why