[PATCH 1/3] drm/amdkfd: update parameter for event_interrupt_poison_consumption

2022-03-14 Thread Tao Zhou
Other parameters can be gotten from ih_ring_entry, so only inputting ih_ring_entry is enough. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v

[PATCH 3/3] drm/amdkfd: add RAS poison consumption support for utcl2

2022-03-14 Thread Tao Zhou
Do RAS page retirement and use gpu reset as fallback in utcl2 fault handler. Signed-off-by: Tao Zhou --- .../gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c b/drive

[PATCH 2/3] drm/amdgpu: add utcl2 RAS poison functions for Aldebaran

2022-03-14 Thread Tao Zhou
Add help functions to check and clear RAS utcl2 poison status. Signed-off-by: Tao Zhou --- .../drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c | 28 ++- .../gpu/drm/amd/include/kgd_kfd_interface.h | 3 ++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Re: [PATCH v3] drm/amdgpu: add workarounds for VCN TMZ issue on CHIP_RAVEN

2022-03-14 Thread Christian König
Am 14.03.22 um 03:45 schrieb Lang Yu: It is a hardware issue that VCN can't handle a GTT backing stored TMZ buffer on CHIP_RAVEN series ASIC. Move such a TMZ buffer to VRAM domain before command submission as a wrokaround. v2: - Use patch_cs_in_place callback. v3: - Bail out early if unsec

Re: [PATCH] drm/amdgpu: reject secure submission on rings which don't support it

2022-03-14 Thread Christian König
Am 14.03.22 um 03:46 schrieb Lang Yu: Only ring GFX, SDMA and VCN_DEC support secure submission at the moment. Signed-off-by: Lang Yu it would be nicer if we have that as flag in ring->funcs, but that way works for now as well. Reviewed-by: Christian König Thanks, Christian. --- driv

Re: [PATCH 2/3] drm/amdgpu: add utcl2 RAS poison functions for Aldebaran

2022-03-14 Thread Lazar, Lijo
On 3/14/2022 12:33 PM, Tao Zhou wrote: Add help functions to check and clear RAS utcl2 poison status. Signed-off-by: Tao Zhou --- .../drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c | 28 ++- .../gpu/drm/amd/include/kgd_kfd_interface.h | 3 ++ 2 files changed, 30 insertions(

Re: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for utcl2

2022-03-14 Thread Lazar, Lijo
On 3/14/2022 12:33 PM, Tao Zhou wrote: Do RAS page retirement and use gpu reset as fallback in utcl2 fault handler. Signed-off-by: Tao Zhou --- .../gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/gp

RE: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for utcl2

2022-03-14 Thread Zhang, Hawking
[AMD Official Use Only] Copy Felix @@ -119,10 +121,14 @@ static void event_interrupt_poison_consumption(struct kfd_dev *dev, break; case SOC15_INTSRC_SDMA_ECC: default: + if (client_id == SOC15_IH_CLIENTID_UTCL2) + ret = kfd_dqm

RE: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for utcl2

2022-03-14 Thread Zhang, Hawking
Never mind Tao. I guess you just want to leverage client_id to differentiate sdma int source from the default, right? Then might consider to explicitly call out the UTCL2_FAULT source. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Zhang, Hawking Sent: Monday, March 14

Re: [PATCH 1/5] dyndbg: fix static_branch manipulation

2022-03-14 Thread Jason Baron
On 3/10/22 23:47, Jim Cromie wrote: > In > https://urldefense.com/v3/__https://lore.kernel.org/lkml/20211209150910.ga23...@axis.com/__;!!GjvTz_vk!HGKKoni4RVdEBgv_V0zPSNSX428bpf02zkCy2WbeQkBdVtp1QJqGX-lJYlRDGg$ > > > Vincent's patch commented on, and worked around, a bug toggling > static_bra

[PATCH 29/30] drm/amdgpu: fix typos in comments

2022-03-14 Thread Julia Lawall
Various spelling mistakes in comments. Detected with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amd

[PATCH 00/30] fix typos in comments

2022-03-14 Thread Julia Lawall
Various spelling mistakes in comments. Detected with the help of Coccinelle. --- drivers/base/devres.c |4 ++-- drivers/clk/qcom/gcc-sm6125.c |2 +- drivers/clk/ti/clkctrl.c|2 +- drivers/gpu/drm/amd/amdg

Re: [PATCH 2/5] dyndbg: add class_id field and query support

2022-03-14 Thread Jason Baron
On 3/10/22 23:47, Jim Cromie wrote: > DRM defines/uses 10 enum drm_debug_category's to create exclusive > classes of debug messages. To support this directly in dynamic-debug, > add the following: > > - struct _ddebug.class_id:4 - 4 bits is enough > - define _DPRINTK_SITE_UNCLASSED 15 - see be

Re: [PATCH v1 1/3] mm: split vm_normal_pages for LRU and non-LRU handling

2022-03-14 Thread David Hildenbrand
On 10.03.22 18:26, Alex Sierra wrote: > DEVICE_COHERENT pages introduce a subtle distinction in the way > "normal" pages can be used by various callers throughout the kernel. > They behave like normal pages for purposes of mapping in CPU page > tables, and for COW. But they do not support LRU lists

Re: [PATCH v2] drm/amdgpu: Add support for drm_privacy_screen

2022-03-14 Thread Hans de Goede
Hi All, On 3/9/22 18:53, Rajat Jain wrote: > On Wed, Mar 9, 2022 at 7:06 AM Sean Paul wrote: >> >> From: Sean Paul >> >> This patch adds the necessary hooks to make amdgpu aware of privacy >> screens. On devices with privacy screen drivers (such as thinkpad-acpi), >> the amdgpu driver will defer

[PATCH 01/30] drm/amd/pm: fix typos in comments

2022-03-14 Thread Julia Lawall
Various spelling mistakes in comments. Detected with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/gpu/drm/amd/pm/amdgpu_pm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c index c

Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM

2022-03-14 Thread James Turner
Hi all, I've confirmed that changing the `amdgpu_atif_pci_probe_handle` function to do nothing does make the GPU work properly in the VM. I started with f9b7f3703ff9 ("drm/amdgpu/acpi: make ATPX/ATCS structures global (v2)") and changed the function implementation to: static bool amdgpu_atif_pci_

[PATCH 23/30] drm/amdgpu/dc: fix typos in comments

2022-03-14 Thread Julia Lawall
Various spelling mistakes in comments. Detected with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/gpu/drm/amd/display/dc/bios/command_table.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios/command_table.c b/dr

RE: [PATCH 00/12] DC Patches March 10, 2022

2022-03-14 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Leno

[PATCH] drm/amd/pm: fix indenting in __smu_cmn_reg_print_error()

2022-03-14 Thread Dan Carpenter
Smatch complains that the dev_err_ratelimited() is indented one tab more than the surrounding lines. drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:174 __smu_cmn_reg_print_error() warn: inconsistent indenting It looks like it's not a bug, just that the indenting needs to be clea

Re: [PATCH v2] drm/amdgpu: add workarounds for Raven VCN TMZ issue

2022-03-14 Thread Alex Deucher
On Thu, Mar 10, 2022 at 9:32 PM Lang Yu wrote: > > On 03/10/ , Christian König wrote: > > Ok, thanks. > > > > Lang is that case your patch should work fine. > > > > Just add another patch with a check for the encode case to reject any CS > > with TMZ buffers in it. > > Only VCN decode ring is care

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-14 Thread Alex Deucher
On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote: > > On Thu, 10 Mar 2022 11:56:41 -0800 > Rob Clark wrote: > > > For something like just notifying a compositor that a gpu crash > > happened, perhaps drm_event is more suitable. See > > virtio_gpu_fence_event_create() for an example of adding

[PATCH 1/1] drm/amdkfd: evict svm bo worker handle error

2022-03-14 Thread Philip Yang
Migrate vram to ram may fail to find the vma if process is exiting and vma is removed, evict svm bo worker sets prange->svm_bo to NULL and warn svm_bo ref count != 1 only if migrating vram to ram successfully. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 27 +

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-14 Thread Pekka Paalanen
On Mon, 14 Mar 2022 10:23:27 -0400 Alex Deucher wrote: > On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote: > > > > On Thu, 10 Mar 2022 11:56:41 -0800 > > Rob Clark wrote: > > > > > For something like just notifying a compositor that a gpu crash > > > happened, perhaps drm_event is more su

Re: [PATCH] drm/amd/pm: fix indenting in __smu_cmn_reg_print_error()

2022-03-14 Thread Luben Tuikov
Thanks! Reviewed-by: Luben Tuikov Regards, Luben On 2022-03-14 10:04, Dan Carpenter wrote: > Smatch complains that the dev_err_ratelimited() is indented one tab more > than the surrounding lines. > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:174 > __smu_cmn_reg_print_error()

Re: [PATCH 1/3] drm/amdkfd: update parameter for event_interrupt_poison_consumption

2022-03-14 Thread Felix Kuehling
Am 2022-03-14 um 03:03 schrieb Tao Zhou: Other parameters can be gotten from ih_ring_entry, so only inputting ih_ring_entry is enough. I'm not sure what's the reason for this change. You remove one parameter, but end up duplicating the SOC15_..._FROM_IH_RING_ENTRY translations. It doesn't loo

Re: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for utcl2

2022-03-14 Thread Felix Kuehling
I'm not sure I understand this change. It looks like you will check the RAS poison status on every UTCL2 VM fault? Is that because there is no dedicated interrupt source or client ID to distinguish UTCL2 poison consumption from VM faults? Why is kfd_signal_poison_consumed_event not done for UT

[PATCH 1/2] drm/amdgpu: Use fw vram offset when allocating stolen vga memory.

2022-03-14 Thread Yongqiang Sun
[Why] Memory access violation will happen in case of allocate stolen vga memory with size isn't 0. [How] when allocating stolen vga memory, use fw vram offset as the start point instead of hard code value 0. Signed-off-by: Yongqiang Sun Change-Id: I7c555a6c1fb4b3fa8685753b4bdcbe215f89ea1e --- d

[PATCH 2/2] drm/amdgpu: Add stolen reserved memory for MI25 SRIOV.

2022-03-14 Thread Yongqiang Sun
[Why] MI25 SRIOV guest driver loading failed due to allocate memory overlaps with private memory area. [How] 1. Allocate stolen reserved memory for MI25 SRIOV specifically to avoid the memory overlap. 2. Move allocate reserve allocation to vbios allocation since both the two functions are doing si

Re: [PATCH] drm: remove min_order BUG_ON check

2022-03-14 Thread Arunpravin
On 10/03/22 8:59 pm, Matthew Auld wrote: > On 10/03/2022 14:47, Arunpravin wrote: >> >> >> On 08/03/22 10:31 pm, Matthew Auld wrote: >>> On 08/03/2022 13:59, Arunpravin wrote: On 07/03/22 10:11 pm, Matthew Auld wrote: > On 07/03/2022 14:37, Arunpravin wrote: >> place BUG_O

[PATCH] drm/i915: round_up the size to the alignment value

2022-03-14 Thread Arunpravin
handle instances when size is not aligned with the min_page_size. Unigine Heaven has allocation requests for example required pages are 161 and alignment request is 128. To allocate the left over 33 pages, continues the iteration to find the order value which is 5 and 0 and when it compares with mi

Re: [PATCH 1/2] drm/amdgpu: Use fw vram offset when allocating stolen vga memory.

2022-03-14 Thread Christian König
Am 14.03.22 um 19:54 schrieb Yongqiang Sun: [Why] Memory access violation will happen in case of allocate stolen vga memory with size isn't 0. [How] when allocating stolen vga memory, use fw vram offset as the start point instead of hard code value 0. Please stop separating commit message into

[PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-14 Thread Arunpravin
handle a situation in the condition order-- == min_order, when order = 0, leading to order = -1, it now won't exit the loop. To avoid this problem, added a order check in the same condition, (i.e) when order is 0, we return -ENOSPC Signed-off-by: Arunpravin --- drivers/gpu/drm/drm_buddy.c | 2 +-

Re: [PATCH 2/2] drm/amdgpu: Add stolen reserved memory for MI25 SRIOV.

2022-03-14 Thread Christian König
Am 14.03.22 um 19:54 schrieb Yongqiang Sun: [Why] MI25 SRIOV guest driver loading failed due to allocate memory overlaps with private memory area. [How] 1. Allocate stolen reserved memory for MI25 SRIOV specifically to avoid the memory overlap. 2. Move allocate reserve allocation to vbios alloca

Re: [PATCH 1/1] drm/amdkfd: evict svm bo worker handle error

2022-03-14 Thread Felix Kuehling
Am 2022-03-14 um 10:50 schrieb Philip Yang: Migrate vram to ram may fail to find the vma if process is exiting and vma is removed, evict svm bo worker sets prange->svm_bo to NULL and warn svm_bo ref count != 1 only if migrating vram to ram successfully. Signed-off-by: Philip Yang --- drivers/

Re: [PATCH 1/1] drm/amdkfd: evict svm bo worker handle error

2022-03-14 Thread Felix Kuehling
Am 2022-03-14 um 10:50 schrieb Philip Yang: Migrate vram to ram may fail to find the vma if process is exiting and vma is removed, evict svm bo worker sets prange->svm_bo to NULL and warn svm_bo ref count != 1 only if migrating vram to ram successfully. Signed-off-by: Philip Yang --- drivers/

Re: [PATCH 00/30] fix typos in comments

2022-03-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski : On Mon, 14 Mar 2022 12:53:24 +0100 you wrote: > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > > --- > > drivers/base/devres.c |4 ++-- > drive

Re: [PATCH 2/2] drm/amdgpu: Add stolen reserved memory for MI25 SRIOV.

2022-03-14 Thread Alex Deucher
On Mon, Mar 14, 2022 at 3:41 PM Christian König wrote: > > Am 14.03.22 um 19:54 schrieb Yongqiang Sun: > > [Why] > > MI25 SRIOV guest driver loading failed due to allocate > > memory overlaps with private memory area. > > > > [How] > > 1. Allocate stolen reserved memory for MI25 SRIOV specifically

Re: [PATCH 1/2] drm/amdgpu: Use fw vram offset when allocating stolen vga memory.

2022-03-14 Thread Alex Deucher
On Mon, Mar 14, 2022 at 3:35 PM Christian König wrote: > > Am 14.03.22 um 19:54 schrieb Yongqiang Sun: > > [Why] > > Memory access violation will happen in case of allocate stolen vga > > memory with size isn't 0. > > > > [How] > > when allocating stolen vga memory, use fw vram offset as the start

[PATCH] drm/amdgpu: Add stolen reserved memory for MI25 SRIOV.

2022-03-14 Thread Yongqiang Sun
MI25 SRIOV guest driver loading failed due to allocate memory overlaps with private memory area. Add below change to fix the issue: 1. Allocate stolen reserved memory for MI25 SRIOV specifically to avoid the memory overlap. 2. Move allocate reserve allocation to vbios allocation since both the two

Re: [PATCH] drm/amdgpu: Add stolen reserved memory for MI25 SRIOV.

2022-03-14 Thread Alex Deucher
On Mon, Mar 14, 2022 at 5:10 PM Yongqiang Sun wrote: > > MI25 SRIOV guest driver loading failed due to allocate > memory overlaps with private memory area. maybe instead of "private memory area", say something like "firmware reserved area". > Add below change to fix the issue: > 1. Allocate stol

Re: [PATCH 2/5] dyndbg: add class_id field and query support

2022-03-14 Thread Jason Baron
On 3/11/22 20:06, jim.cro...@gmail.com wrote: > On Fri, Mar 11, 2022 at 12:06 PM Jason Baron wrote: >> >> >> >> On 3/10/22 23:47, Jim Cromie wrote: >>> DRM defines/uses 10 enum drm_debug_category's to create exclusive >>> classes of debug messages. To support this directly in dynamic-debug, >>

Re: [PATCH 00/22] drm: Review of mode copies

2022-03-14 Thread Ville Syrjälä
On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: > drm: Add drm_mode_init() > drm/bridge: Use drm_mode_copy() > drm/imx: Use drm_mode_duplicate() > drm/panel: Use drm_mode_duplicate() > drm/vc4: Use drm_mode_copy() These have been pushed to drm-misc-next. > drm/amdgpu: Re

[PATCH] drm/amdgpu/vcn: fix vcn ring test failure in igt reload test

2022-03-14 Thread Tianci Yin
From: "Tianci.Yin" [why] On Renoir, vcn ring test failed on the second time insmod in the reload test. After invetigation, it proves that vcn only can disable dpg under dpg unpause mode (dpg unpause mode is default for dec only, dpg pause mode is for dec/enc). [how] unpause dpg in dpg stopping p

[PATCH] drm/amdgpu: only allow secure submission on rings which support that

2022-03-14 Thread Lang Yu
Only GFX ring, SDMA ring and VCN decode ring support secure submission at the moment. Suggested-by: Christian König Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 + drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 + drive