Am 16.03.22 um 16:36 schrieb Rob Clark:
[SNIP]
just one point of clarification.. in the msm and i915 case it is
purely for debugging and telemetry (ie. sending crash logs back to
distro for analysis if user has crash reporting enabled).. it isn't
used for triggering any action like killing app or
Am 17.03.22 um 01:20 schrieb Felix Kuehling:
Let amdgpu_vm_handle_moved update all BO VA mappings of BOs reserved by
the caller. This will be useful for handling extra BO VA mappings in
KFD VMs that are managed through the render node API.
Yes, that change is on my TODO list for quite a while a
On 3/16/2022 10:50 PM, Rob Clark wrote:
On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma
wrote:
From: Shashank Sharma
This patch adds a new sysfs event, which will indicate
the userland about a GPU reset, and can also provide
some information like:
- process ID of the process involved with
On 17.03.22 03:54, Alistair Popple wrote:
> Felix Kuehling writes:
>
>> On 2022-03-11 04:16, David Hildenbrand wrote:
>>> On 10.03.22 18:26, Alex Sierra wrote:
DEVICE_COHERENT pages introduce a subtle distinction in the way
"normal" pages can be used by various callers throughout the ke
Hi Peter,
Am 17.03.22 um 01:14 schrieb Peter Geis:
Good Evening,
I apologize for raising this email chain from the dead, but there have
been some developments that have introduced even more questions.
I've looped the Rockchip mailing list into this too, as this affects
rk356x, and likely the up
Am 17.03.22 um 09:42 schrieb Sharma, Shashank:
On 3/16/2022 10:50 PM, Rob Clark wrote:
On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma
wrote:
From: Shashank Sharma
This patch adds a new sysfs event, which will indicate
the userland about a GPU reset, and can also provide
some information li
On Mon, Mar 14, 2022 at 10:23:27AM -0400, Alex Deucher wrote:
> On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote:
> >
> > On Thu, 10 Mar 2022 11:56:41 -0800
> > Rob Clark wrote:
> >
> > > For something like just notifying a compositor that a gpu crash
> > > happened, perhaps drm_event is more
On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
> Am 16.03.22 um 16:36 schrieb Rob Clark:
> > [SNIP]
> > just one point of clarification.. in the msm and i915 case it is
> > purely for debugging and telemetry (ie. sending crash logs back to
> > distro for analysis if user has crash
Am 17.03.22 um 10:29 schrieb Daniel Vetter:
On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
Am 16.03.22 um 16:36 schrieb Rob Clark:
[SNIP]
just one point of clarification.. in the msm and i915 case it is
purely for debugging and telemetry (ie. sending crash logs back to
distro
Hi,
On Thu, 17 Mar 2022 at 09:21, Christian König wrote:
> Am 17.03.22 um 09:42 schrieb Sharma, Shashank:
> >> AFAIU you probably want to be passing around a `struct pid *`, and
> >> then somehow use pid_vnr() in the context of the process reading the
> >> event to get the numeric pid. Otherwise
To pair with amdgpu_gmc_pdb0_alloc as a more generic handling
in amdgpu_gmc.c, no functional change.
Signed-off-by: Guchun Chen
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 6 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 1 +
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
3 files changed,
On 3/15/2022 7:38 PM, Elena Sakhnovitch wrote:
On Sienna Cichild, not all platforms use PMFW based fan control. On such
ASICs fan control by PMFW will be disabled in PPTable. Disable hwmon
knobs for fan control also as it is not possible to report or control
fan speed on such platforms through
Am 17.03.22 um 12:21 schrieb Guchun Chen:
To pair with amdgpu_gmc_pdb0_alloc as a more generic handling
in amdgpu_gmc.c, no functional change.
Signed-off-by: Guchun Chen
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 6 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 1 +
drivers/gpu/drm/am
Hi Christian,
My intention is to use a paired generic gmc alloc/free function to proceed PDB
bo. Current code is gmc v9 code calls amdgpu_gmc_pdb0_alloc to allocate PDB bo
buffer, and release the bo directly in gmc_v9_0_sw_fini. I guess PDB bo is not
a gmc v9 specific buffer, so it's better to
Am 17.03.22 um 13:26 schrieb Peter Geis:
On Thu, Mar 17, 2022 at 6:37 AM Robin Murphy wrote:
On 2022-03-17 00:14, Peter Geis wrote:
Good Evening,
I apologize for raising this email chain from the dead, but there have
been some developments that have introduced even more questions.
I've looped
Mhm, actually that is indeed purely gmc 9 specific.
This is a workaround for a very specific hardware bug issue which will
hopefully never happen again :)
We just implemented it in the common handler to be able to test it with
gmc 8 before gmc 9 came out of production.
Do we have a generic
On Thu, Mar 17, 2022 at 5:15 AM Christian König
wrote:
>
> Hi Peter,
>
> Am 17.03.22 um 01:14 schrieb Peter Geis:
> > Good Evening,
> >
> > I apologize for raising this email chain from the dead, but there have
> > been some developments that have introduced even more questions.
> > I've looped th
On 13.03.22 19:33, James Turner wrote:
>
>> My understanding at this point is that the root problem is probably
>> not in the Linux kernel but rather something else (e.g. the machine
>> firmware or AMD Windows driver) and that the change in f9b7f3703ff9
>> ("drm/amdgpu/acpi: make ATPX/ATCS structur
On Wed, Mar 16, 2022 at 11:08 PM Kever Yang wrote:
>
> Hi Peter,
>
> On 2022/3/17 08:14, Peter Geis wrote:
> > Good Evening,
> >
> > I apologize for raising this email chain from the dead, but there have
> > been some developments that have introduced even more questions.
> > I've looped the Rockc
On 2022-03-17 00:14, Peter Geis wrote:
Good Evening,
I apologize for raising this email chain from the dead, but there have
been some developments that have introduced even more questions.
I've looped the Rockchip mailing list into this too, as this affects
rk356x, and likely the upcoming rk3588
On Thu, Mar 17, 2022 at 6:37 AM Robin Murphy wrote:
>
> On 2022-03-17 00:14, Peter Geis wrote:
> > Good Evening,
> >
> > I apologize for raising this email chain from the dead, but there have
> > been some developments that have introduced even more questions.
> > I've looped the Rockchip mailing
Presently the Client can be freed whilst still in use.
Use the already provided lock to prevent this.
Cc: Felix Kuehling
Cc: Alex Deucher
Cc: "Christian König"
Cc: "Pan, Xinhui"
Cc: David Airlie
Cc: Daniel Vetter
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org
Signed-o
On 2022-03-17 12:26, Peter Geis wrote:
On Thu, Mar 17, 2022 at 6:37 AM Robin Murphy wrote:
On 2022-03-17 00:14, Peter Geis wrote:
Good Evening,
I apologize for raising this email chain from the dead, but there have
been some developments that have introduced even more questions.
I've looped
Thanks for the info, Christian, and I will abandon this patch. We don’t have a
generic amdgpu_gmc_sw_fini.
Regards,
Guchun
-Original Message-
From: Koenig, Christian
Sent: Thursday, March 17, 2022 8:55 PM
To: Chen, Guchun ; Christian König
; amd-gfx@lists.freedesktop.org; Zhang,
Hawk
On Thu, Mar 17, 2022 at 09:13:50AM +0100, David Hildenbrand wrote:
> On 17.03.22 03:54, Alistair Popple wrote:
> > Felix Kuehling writes:
> >
> >> On 2022-03-11 04:16, David Hildenbrand wrote:
> >>> On 10.03.22 18:26, Alex Sierra wrote:
> DEVICE_COHERENT pages introduce a subtle distinction
Move the page tables to the idle list after updating the PDEs.
We have gone back and forth with that a couple of times because of problems
with the inter PD dependencies, but it should work now that we have the
state handling cleanly separated.
Signed-off-by: Christian König
---
drivers/gpu/drm
Separate the VM page table backend operations from the state machine since
the amdgpu_vm.c file is becoming to complex.
The allocating, freeing and updating page tables and page directories can
easily be moved into a separate file.
While at it cleanup everything checkpatch.pl reported and rename
Store the 64bit sequence directly. Makes it simpler to use and saves a bit
of fence reference counting overhead.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 40 +++-
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.h | 2 +-
drivers/gpu/drm/amd/amdgpu
Instead of tracking the VM updates through the dependencies just use a
sequence counter for page table updates which indicates the need to
flush the TLB.
This reduces the need to flush the TLB drastically.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 8 ++--
dr
Instead of trying to figure out if a TLB flush is necessary or not use
the information provided by the VM subsystem now.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 1 +
drivers/gpu/drm/amd/amdkfd/kfd_process.c | 7 +++
2 files changed, 8 insertions(+)
diff
Instead of hand rolling the table_freed parameter.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 5 ++---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 18 --
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 19 ---
drivers/g
Better to leave the decision when to flush the VM changes in the TLB to
the VM code.
Signed-off-by: Christian König
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 6 +++---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +-
drivers
Am 2022-03-16 um 21:01 schrieb Chen, Guchun:
Shall we sort it? Anyway, the patch is: Reviewed-by: Guchun Chen
Sure, I'll sort the switch cases before I submit.
Thanks,
Felix
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Felix
Kuehling
Sent: Thursday, March 17
On Thu, Mar 17, 2022 at 9:17 AM Robin Murphy wrote:
>
> On 2022-03-17 12:26, Peter Geis wrote:
> > On Thu, Mar 17, 2022 at 6:37 AM Robin Murphy wrote:
> >>
> >> On 2022-03-17 00:14, Peter Geis wrote:
> >>> Good Evening,
I've added the Designware driver maintainers, since the Rockchip host
driver
On Thu, 17 Mar 2022, Lee Jones wrote:
> Presently the Client can be freed whilst still in use.
>
> Use the already provided lock to prevent this.
>
> Cc: Felix Kuehling
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: "Pan, Xinhui"
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: amd-gfx@lists
Am 2022-03-17 um 09:16 schrieb Lee Jones:
Presently the Client can be freed whilst still in use.
Use the already provided lock to prevent this.
Cc: Felix Kuehling
Cc: Alex Deucher
Cc: "Christian König"
Cc: "Pan, Xinhui"
Cc: David Airlie
Cc: Daniel Vetter
Cc: amd-gfx@lists.freedesktop.org
Am 2022-03-16 um 21:57 schrieb Yat Sin, David:
Use proper amdgpu_gem_prime_import function to handle all kinds of
imports. Remember the dmabuf reference to enable proper multi-GPU
attachment to multiple VMs without erroneously re-exporting the underlying
BO multiple times.
Signed-off-by: Felix K
Am 2022-03-17 um 11:00 schrieb Lee Jones:
Good afternoon Felix,
Thanks for your review.
Am 2022-03-17 um 09:16 schrieb Lee Jones:
Presently the Client can be freed whilst still in use.
Use the already provided lock to prevent this.
Cc: Felix Kuehling
Cc: Alex Deucher
Cc: "Christian Köni
Good afternoon Felix,
Thanks for your review.
> Am 2022-03-17 um 09:16 schrieb Lee Jones:
> > Presently the Client can be freed whilst still in use.
> >
> > Use the already provided lock to prevent this.
> >
> > Cc: Felix Kuehling
> > Cc: Alex Deucher
> > Cc: "Christian König"
> > Cc: "Pan,
On Thu, 17 Mar 2022, Felix Kuehling wrote:
>
> Am 2022-03-17 um 11:00 schrieb Lee Jones:
> > Good afternoon Felix,
> >
> > Thanks for your review.
> >
> > > Am 2022-03-17 um 09:16 schrieb Lee Jones:
> > > > Presently the Client can be freed whilst still in use.
> > > >
> > > > Use the already
On Sienna Cichild, not all platforms use PMFW based fan control. On such
ASICs fan control by PMFW will be disabled in PPTable. Disable hwmon
knobs for fan control also as it is not possible to report or control
fan speed on such platforms through driver.
v2: FEATURE_FAN_CONTROL_MASK is replaced wi
On Sienna Cichild, not all platforms use PMFW based fan control. On such
ASICs fan control by PMFW will be disabled in PPTable. Disable hwmon
knobs for fan control also as it is not possible to report or control
fan speed on such platforms through driver.
v2: FEATURE_FAN_CONTROL_MASK is replaced wi
On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote:
>
> On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
> > Am 16.03.22 um 16:36 schrieb Rob Clark:
> > > [SNIP]
> > > just one point of clarification.. in the msm and i915 case it is
> > > purely for debugging and telemetry (ie. se
On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote:
>
> On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
> > Am 16.03.22 um 16:36 schrieb Rob Clark:
> > > [SNIP]
> > > just one point of clarification.. in the msm and i915 case it is
> > > purely for debugging and telemetry (ie. se
On 2022-03-17 11:13 a.m., Lee Jones
wrote:
On Thu, 17 Mar 2022, Felix Kuehling wrote:
Am 2022-03-17 um 11:00 schrieb Lee Jones:
Good afternoon Felix,
Thanks for your review.
Am 2022-03-17 um 09:1
On Thu, 17 Mar 2022, philip yang wrote:
>On 2022-03-17 11:13 a.m., Lee Jones wrote:
>
> On Thu, 17 Mar 2022, Felix Kuehling wrote:
>
>
> Am 2022-03-17 um 11:00 schrieb Lee Jones:
>
> Good afternoon Felix,
>
> Thanks for your review.
>
>
> Am 2022-03-17 um 09:16 schrieb Lee Jones:
>
> P
On Sienna Cichild, not all platforms use PMFW based fan control. On such
ASICs fan control by PMFW will be disabled in PPTable. Disable hwmon
knobs for fan control also as it is not possible to report or control
fan speed on such platforms through driver.
v2: FEATURE_FAN_CONTROL_MASK is replaced wi
On Thu, Mar 17, 2022 at 08:34:21AM -0700, Rob Clark wrote:
> On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote:
> >
> > On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
> > > Am 16.03.22 um 16:36 schrieb Rob Clark:
> > > > [SNIP]
> > > > just one point of clarification.. in the m
On Thu, Mar 17, 2022 at 08:40:51AM -0700, Rob Clark wrote:
> On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote:
> >
> > On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
> > > Am 16.03.22 um 16:36 schrieb Rob Clark:
> > > > [SNIP]
> > > > just one point of clarification.. in the m
On Thu, Mar 17, 2022 at 10:27 AM Daniel Vetter wrote:
>
> On Thu, Mar 17, 2022 at 08:40:51AM -0700, Rob Clark wrote:
> > On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote:
> > >
> > > On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
> > > > Am 16.03.22 um 16:36 schrieb Rob Clark
[AMD Official Use Only]
Few comments inline.
-Original Message-
From: amd-gfx On Behalf Of Elena
Sakhnovitch
Sent: Thursday, March 17, 2022 12:45 PM
To: amd-gfx@lists.freedesktop.org
Cc: Sakhnovitch, Elena (Elen)
Subject: [PATCH v2] drm/amd/pm: Disable fan control if not supported
On
Am 2022-03-17 um 09:50 schrieb Christian König:
Instead of hand rolling the table_freed parameter.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 5 ++---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 18 --
drivers/gpu/drm/amd/amdkfd
Am 2022-03-17 um 04:21 schrieb Christian König:
Am 17.03.22 um 01:20 schrieb Felix Kuehling:
Let amdgpu_vm_handle_moved update all BO VA mappings of BOs reserved by
the caller. This will be useful for handling extra BO VA mappings in
KFD VMs that are managed through the render node API.
Yes,
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 21 -
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 4c20c23d6ba0..bda1b5132
Am 2022-03-17 um 15:37 schrieb Tushar Patel:
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 21 -
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index 39073f72fe5f..f95904d38d24 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
+++ b/d
On Thu, Mar 17, 2022 at 5:15 AM Christian König
wrote:
>
> Hi Peter,
>
> Am 17.03.22 um 01:14 schrieb Peter Geis:
> > Good Evening,
> >
> > I apologize for raising this email chain from the dead, but there have
> > been some developments that have introduced even more questions.
> > I've looped th
Please squash this with your other patch. One more comment inline
Am 2022-03-17 um 16:24 schrieb Tushar Patel:
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
b/drivers/gpu/drm/
Applied. Thanks!
Alex
On Tue, Mar 15, 2022 at 4:20 PM Colin Ian King wrote:
>
> There is a spelling mistake in a dev_error error message. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
Applied. Thanks!
Alex
On Wed, Mar 16, 2022 at 4:42 AM Dan Carpenter wrote:
>
> This post-op should be a pre-op so that we do not pass -1 as the bit
> number to test_bit(). The current code will loop downwards from 63 to
> -1. After changing to a pre-op, it loops from 63 to 0.
>
> Fixes: 71c37
Removed dev_error message for incorrect VMIDs
Fix Incorrect VMIDs passed to HWS
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 12 +++-
2 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
Am 2022-03-17 um 16:57 schrieb Tushar Patel:
Removed dev_error message for incorrect VMIDs
Fix Incorrect VMIDs passed to HWS
This could use more of an explanation. The problem here was, that the
previous default was based on an outdated number of VMIDs. On Arcturus
and Aldebaran we reserve m
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 11 +++
2 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 4c20c23d6ba0..bda1b5132ee8 100644
-
The code looks good. But please add a patch description.
Regards,
Felix
Am 2022-03-17 um 17:40 schrieb Tushar Patel:
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 11 +++
2 files changed, 4 insertions(+), 9 deletions(-)
diff --git
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 97add482e9033a9386baa8824fbea34d0cbfe663 Add linux-next specific
files for 20220317
Error/Warning reports:
https://lore.kernel.org/linux-doc/202202240704.pqd40a9l-...@intel.com
https
Dear Thorsten, dear James,
Am 17.03.22 um 13:54 schrieb Thorsten Leemhuis:
On 13.03.22 19:33, James Turner wrote:
My understanding at this point is that the root problem is probably
not in the Linux kernel but rather something else (e.g. the machine
firmware or AMD Windows driver) and that t
Dear Aashish,
Am 17.03.22 um 15:01 schrieb Aashish Sharma:
Thank you for your patch. If you are going to send a v2, please use
imperative mood. Maybe:
drm/amd/display: Fix unused-but-set-variable warning
Fixed this kernel test robot warning:
Maybe:
Fix the kernel test robot warning bel
67 matches
Mail list logo
