Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-22 Thread Paul Menzel
Dear Arunprivin, Thank you for your patch. Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam: - Remove drm_mm references and replace with drm buddy functionalities The commit message summary to me suggested, you can somehow use both allocators now. Two suggestions below: 1. Switch to

Re: [PATCH] drm/amdkfd:Check use_xgmi_p2p before reporting hive_id

2022-03-22 Thread Paul Menzel
Dear Divya, Thank you for your patch. Am 22.03.22 um 20:23 schrieb Divya Shikre: Please add a space after the colon in the commit message summary. XGMI iolinks will not be created in KFD topology when use_xgmi_p2p module parameter is disabled in a dGPU. 1. Is “will not be” the current pr

[PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-22 Thread Arunpravin Paneer Selvam
- Remove drm_mm references and replace with drm buddy functionalities - Add res cursor support for drm buddy v2(Matthew Auld): - replace spinlock with mutex as we call kmem_cache_zalloc (..., GFP_KERNEL) in drm_buddy_alloc() function - lock drm_buddy_block_trim() function as it calls

Re: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init

2022-03-22 Thread Paul Menzel
Dear Jun, Thank you for your patch. Am 23.03.22 um 04:02 schrieb Ma, Jun: On 3/22/2022 9:33 PM, Christian König wrote: Am 22.03.22 um 13:53 schrieb Ma Jun: Correct the parameter name of amdgpu_ring_init() in header file. Maybe write "Sync up header and implementation to use the same param

Re: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init

2022-03-22 Thread Ma, Jun
On 3/22/2022 9:33 PM, Christian König wrote: > Am 22.03.22 um 13:53 schrieb Ma Jun: >> Correct the parameter name of amdgpu_ring_init() in header file. > > Maybe write "Sync up header and implementation to use the same parameter > names", otherwise somebody could think that this is a real func

[PATCH] drm/amdkfd:Check use_xgmi_p2p before reporting hive_id

2022-03-22 Thread Divya Shikre
XGMI iolinks will not be created in KFD topology when use_xgmi_p2p module parameter is disabled in a dGPU. In this case PCIe p2p links will be used instead. Signed-off-by: Divya Shikre --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

RE: [RFC] Add KFD available memory ioctl thunk support

2022-03-22 Thread Yat Sin, David
> -Original Message- > From: amd-gfx On Behalf Of Daniel > Phillips > Sent: Tuesday, March 22, 2022 1:29 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix > Subject: [RFC] Add KFD available memory ioctl thunk support > > Hi all, > > This patch adds thunk support for the new

[RFC] Add KFD available memory ioctl thunk test

2022-03-22 Thread Daniel Phillips
Hi all, This patch adds at unit test to thunk for the new KFD memory availability ioctl. KFDMemoryTest.cpp | 25 + 1 file changed, 25 insertions(+) Regards, Daniel diff --git a/tests/kfdtest/src/KFDMemoryTest.cpp b/tests/kfdtest/src/KFDMemoryTest.cpp index f7ac73f..b

[RFC] Add KFD available memory ioctl thunk support

2022-03-22 Thread Daniel Phillips
Hi all, This patch adds thunk support for the new KFD memory availability ioctl. I am posting this patch inline with Thunderbird just for now, to establish the principle that I can post patches/code old school style without mangling whitespace. Please bear with me while I get that sorted out. I w

Re: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v2)

2022-03-22 Thread Felix Kuehling
Am 2022-03-21 um 23:17 schrieb Zhou1, Tao: [AMD Official Use Only] -Original Message- From: Lazar, Lijo Sent: Monday, March 21, 2022 7:21 PM To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Kuehling, Felix ; Yang, Stanley ; Chai, Thomas Subject: Re: [PATCH] drm/amd

Re: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init

2022-03-22 Thread Christian König
Am 22.03.22 um 13:53 schrieb Ma Jun: Correct the parameter name of amdgpu_ring_init() in header file. Maybe write "Sync up header and implementation to use the same parameter names", otherwise somebody could think that this is a real functional bug fix and backport it. Signed-off-by: Ma J

RE: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init

2022-03-22 Thread Chen, Guchun
Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Ma Jun Sent: Tuesday, March 22, 2022 8:53 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Zhang, Hawking Subject: [PATCH] drm/amdgpu: Correct the parameter name of

[PATCH] drm/amd/display: use NULL instead of using plain integer as pointer

2022-03-22 Thread Haowen Bai
This fixes the following sparse warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dsc/rc_calc_fpu.c:71:40: warning: Using plain integer as NULL pointer Signed-off-by: Haowen Bai --- drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] drm/amd/display: use NULL instead of using plain integer as pointer

2022-03-22 Thread Haowen Bai
This fixes the following sparse warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:865:16: warning: Using plain integer as NULL pointer Signed-off-by: Haowen Bai --- drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[PATCH] drm/amd/display: use NULL instead of using plain integer as pointer

2022-03-22 Thread Haowen Bai
This fixes the following sparse warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1910:16: warning: Using plain integer as NULL pointer Signed-off-by: Haowen Bai --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init

2022-03-22 Thread Ma Jun
Correct the parameter name of amdgpu_ring_init() in header file. Signed-off-by: Ma Jun Change-Id: I202d76ba04b137926b456b1c8a4c05a5b1a01bff --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.