Re: [PATCH V2] drm/amdgpu/vcn3: send smu interface type

2022-03-24 Thread Paul Menzel
Dear Boyuan, Thank for the improved patch. Am 24.03.22 um 18:25 schrieb Zhang, Boyuan: [AMD Official Use Only] No idea if this would confuse `git am`. From: Boyuan Zhang mailto:boyuan.zh...@amd.com>> Your mailer(?) mangled the patch. Did you edit it in your MUA’s compose window?

Re: [PATCH] UPSTREAM: drm/amdgpu: Disable ABM when AC mode

2022-03-24 Thread Bas Nieuwenhuizen
Please drop the UPSTREAM prefix. Might be needed in the ChromeOS patch, but not for upstream. On Fri, Mar 25, 2022, 2:29 AM Ryan Lin wrote: > Disable ABM feature when the system is running on AC mode to get > the more perfect contrast of the display. > > Signed-off-by: Ryan Lin > > --- >

RE: [PATCH v1 0/2] amdgpu/pm: Implement parallel sysfs_emit solution for vega10

2022-03-24 Thread Quan, Evan
[AMD Official Use Only] Seems fine to me. Series is reviewed-by: Evan Quan Thanks, Evan From: Powell, Darren Sent: Friday, March 25, 2022 4:24 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: Re: [PATCH v1 0/2] amdgpu/pm: Implement parallel sysfs_emit solution for vega10 [AMD

[PATCH] UPSTREAM: drm/amdgpu: Disable ABM when AC mode

2022-03-24 Thread Ryan Lin
Disable ABM feature when the system is running on AC mode to get the more perfect contrast of the display. Signed-off-by: Ryan Lin --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 1 + drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 58

[PATCH] drm/amd: Re-classify some log messages in commit path

2022-03-24 Thread Sean Paul
From: Sean Paul ATOMIC and DRIVER log categories do not typically contain per-frame log messages. This patch re-classifies some messages in amd to chattier categories to keep ATOMIC/DRIVER quiet. Signed-off-by: Sean Paul --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 5 +++--

Re: [PATCH] drm/amdkfd: fix comparison warning with min() macro

2022-03-24 Thread Felix Kuehling
Am 2022-03-24 um 17:31 schrieb Alex Deucher: Properly case to u32 to fix the warning. Fixes: 83f1287c57228f ("drm/amdkfd: Fix Incorrect VMIDs passed to HWS") Signed-off-by: Alex Deucher Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +- 1 file changed, 1

[PATCH] drm/amdkfd: fix comparison warning with min() macro

2022-03-24 Thread Alex Deucher
Properly case to u32 to fix the warning. Fixes: 83f1287c57228f ("drm/amdkfd: Fix Incorrect VMIDs passed to HWS") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c

Re: [PATCH v1 0/2] amdgpu/pm: Implement parallel sysfs_emit solution for vega10

2022-03-24 Thread Powell, Darren
[AMD Official Use Only] PING? ** https://lore.kernel.org/amd-gfx/20220313052839.5777-1-darren.pow...@amd.com/T/#u [PATCH v1 0/2] amdgpu/pm: Implement parallel sysfs_emit solution for vega10 2022-03-13 5:28 UTC (3+ messages) ` [PATCH 1/2] amdgpu/pm: Add new hwmgr API function

Re: [PATCH v1] drm/amdkfd: Check for potential null return of kmalloc_array()

2022-03-24 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Mar 24, 2022 at 9:46 AM QintaoShen wrote: > > As the kmalloc_array() may return null, the 'event_waiters[i].wait' would > lead to null-pointer dereference. > Therefore, it is better to check the return value of kmalloc_array() to avoid > this confusion. > >

Re: ATI Radeon Mobility 3470 fails with Kernel 5.0

2022-03-24 Thread Alex Deucher
On Thu, Mar 24, 2022 at 2:07 AM Paul Menzel wrote: > > Dear Craig, > > > Am 24.03.22 um 02:09 schrieb Craig M: > > I should add some further information: > > > > I have tried using Manjaro KDE, Kubuntu 20 and Kubuntu 18.03 live > > disks and all exhibit this 'tearing' issue. > > > > The problem

RE: [PATCH] drm/amdgpu/vcn3: send smu interface type

2022-03-24 Thread Zhang, Boyuan
[AMD Official Use Only] Hi Paul, This change is to differentiate device (IP_VERSION(3, 1, 2)) and device (IP_VERSION(3, 1, 1)), since they are using different mailbox registers for VCN DPM. There is no other impact for VCN. And thank for pointing out the format issue. I just sent out V2.

[PATCH V2] drm/amdgpu/vcn3: send smu interface type

2022-03-24 Thread Zhang, Boyuan
[AMD Official Use Only] From: Boyuan Zhang mailto:boyuan.zh...@amd.com>> For VCN FW to detect ASIC type, in order to use different mailbox registers. V2: simplify codes and fix format issue. Signed-off-by: Boyuan Zhang mailto:boyuan.zh...@amd.com>> Acked-by Huang Rui ---

Re: [PATCH] drm/amdgpu: add missing NULL check in amdgpu_vm_update_mapping

2022-03-24 Thread philip yang
Reviewed-By: Philip Yang On 2022-03-24 4:13 a.m., Christian König wrote: The fence parameter is only optional. Signed-off-by: Christian König Fixes: 86fd5edfbdae ("drm/amdgpu: rework TLB flushing") --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 --- 1

Re: [PATCH v2] drm/amdkfd: Check use_xgmi_p2p before reporting hive_id

2022-03-24 Thread Paul Menzel
Dear Divya, Am 23.03.22 um 15:20 schrieb Divya Shikre: Recently introduced commit "845ebd6b7c32 drm/amdgpu: Add use_xgmi_p2p module parameter" did not update XGMI iolinks when use_xgmi_p2p is disabled. Add fix to not create XGMI iolinks in KFD topology when this parameter is disabled. Thank

[PATCH] drm/amd/display: Fix pointer dereferenced before checking

2022-03-24 Thread Haowen Bai
The value actual_pix_clk_100Hz is dereferencing pointer pix_clk_params before pix_clk_params is being null checked. Fix this by assigning pix_clk_params->requested_pix_clk_100hz to actual_pix_clk_100Hz only if pix_clk_params is not NULL, otherwise just NULL. Signed-off-by: Haowen Bai ---

[PATCH] drm/amd/display: Fix pointer dereferenced before checking

2022-03-24 Thread Haowen Bai
The pointer edid_buf is dereferencing pointer edid before edid is being null checked. Fix this by assigning edid->raw_edid to edid_buf only if edid is not NULL, otherwise just NULL. Signed-off-by: Haowen Bai --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +- 1 file changed,

[PATCH v1] drm/amdkfd: Check for potential null return of kmalloc_array()

2022-03-24 Thread QintaoShen
As the kmalloc_array() may return null, the 'event_waiters[i].wait' would lead to null-pointer dereference. Therefore, it is better to check the return value of kmalloc_array() to avoid this confusion. Signed-off-by: QintaoShen --- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 2 ++ 1 file

Re: [PATCH] drm/amdgpu/gfx10: enable gfx1037 clock counter retrieval function

2022-03-24 Thread Alex Deucher
Reviewed-by: Alex Deucher On Thu, Mar 24, 2022 at 6:16 AM Prike Liang wrote: > > Enable gfx1037 clock counter retrieval function for > KFDPerfCountersTest.ClockCountersBasicTest. > > Signed-off-by: Prike Liang > --- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 + > 1 file changed, 1

RE: [PATCH] drm/amd/display: Program color range and encoding correctly for DCN2+

2022-03-24 Thread Wu, Hersen
Reviewed-by: Hersen Wu -Original Message- From: Chauhan, Ikshwaku Sent: Thursday, March 24, 2022 3:12 AM To: Wentland, Harry ; amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; sta...@vger.kernel.org; Wu, Hersen ; Kazlauskas, Nicholas ; VURDIGERENATARAJ, CHANDAN Subject: RE:

Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-24 Thread Daniel Vetter
On Wed, 23 Mar 2022 at 16:32, Christian König wrote: > > Am 23.03.22 um 16:24 schrieb Daniel Stone: > > On Wed, 23 Mar 2022 at 15:14, Alex Deucher wrote: > >> On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: > >>> That's not what anyone's saying here ... > >>> > >>> No-one's demanding AMD

[PATCH] drm/amdgpu/gfx10: enable gfx1037 clock counter retrieval function

2022-03-24 Thread Prike Liang
Enable gfx1037 clock counter retrieval function for KFDPerfCountersTest.ClockCountersBasicTest. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c

[PATCH] drm/amdgpu: add missing NULL check in amdgpu_vm_update_mapping

2022-03-24 Thread Christian König
The fence parameter is only optional. Signed-off-by: Christian König Fixes: 86fd5edfbdae ("drm/amdgpu: rework TLB flushing") --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

RE: [PATCH] drm/amd/display: Program color range and encoding correctly for DCN2+

2022-03-24 Thread Chauhan, Ikshwaku
[AMD Official Use Only] Tested-by: ikshwaku.chau...@amd.com Thanks, Ikshwaku Chauhan -Original Message- From: Harry Wentland Sent: Thursday, March 24, 2022 2:39 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; sta...@vger.kernel.org; Wu, Hersen ; Chauhan, Ikshwaku ;

Re: ATI Radeon Mobility 3470 fails with Kernel 5.0

2022-03-24 Thread Paul Menzel
Dear Craig, Am 24.03.22 um 02:09 schrieb Craig M: I should add some further information: I have tried using Manjaro KDE, Kubuntu 20 and Kubuntu 18.03 live disks and all exhibit this 'tearing' issue. The problem begins rather early on in the boot sequence while the TUI is logging the startup