RE: [PATCH] drm/amdgpu: fix incorrect GCR_GENERAL_CNTL address

2022-03-28 Thread Liang, Prike
[Public] Thanks for the correcting fix and I confirm on the gfx1037 exactly need update the mmGCR_GENERAL_CNTL offset to 0x1580. Meanwhile, please confirm whether this change also apply in the gfx1036, anyway this patch is Acked-by: Prike Liang > -Original Message- > From: Ji,

Re: [PATCH] amd/display: set backlight only if required

2022-03-28 Thread Paul Menzel
Dear Shirish, Thank you for the patch. Am 11.03.22 um 16:33 schrieb Shirish S: [Why] comparing pwm bl values (coverted) with user brightness(converted) 1. co*n*verted 2. Please add a space before the (. levels in commit_tail leads to continuous setting of backlight via dmub as they

Re: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Lazar, Lijo
On 3/28/2022 10:37 PM, Kent Russell wrote: This is being added to SMU Metrics, so add the required tie-ins in the kernel. Also create the corresponding unique_id sysfs file. v2: Add FW version check, remove SMU mutex v3: Fix style warning v4: Add MP1 IP_VERSION check to FW version check

[PATCH v3 1/1] drm/amdkfd: Use atomic64_t type for pdd->tlb_seq

2022-03-28 Thread Philip Yang
To support multi-thread update page table. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 2 +- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h

Re: [PATCH] amd/display: set backlight only if required

2022-03-28 Thread Harry Wentland
On 2022-03-20 23:47, S, Shirish wrote: > [AMD Official Use Only] > > Ping! > After internal discussions it turns out that the readback is indeed not expected to match the value being set if ABM is enabled. The suggested way to deal with this is to track the previous value in SW, i.e. exactly

2022 X.org Foundation Election Candidates

2022-03-28 Thread Lyude Paul
To all X.Org Foundation Members: The election for the X.Org Foundation Board of Directors will begin on 04 April 2022. We have 6 candidates who are running for 4 seats. They are: Emma Anholt Shashank Sharma Ricardo Garcia Mark Filion Lucas Stach Alyssa Rosenzweig To be

Re: BUG: Bad page state in process systemd-udevd (was: [PATCH v9 bpf-next 1/9] x86/Kconfig: select HAVE_ARCH_HUGE_VMALLOC with HAVE_ARCH_HUGE_VMAP)

2022-03-28 Thread Paul Menzel
Dear Song, Am 28.03.22 um 21:24 schrieb Song Liu: On Mar 27, 2022, at 11:51 PM, Paul Menzel wrote: Am 28.03.22 um 08:37 schrieb Song Liu: […] On Mar 27, 2022, at 3:36 AM, Paul Menzel wrote: Am 26.03.22 um 19:46 schrieb Paul Menzel: #regzbot introduced:

Re: [PATCH 2/5] dyndbg: add class_id field and query support

2022-03-28 Thread jim . cromie
On Mon, Mar 14, 2022 at 3:30 PM Jason Baron wrote: > > > > On 3/11/22 20:06, jim.cro...@gmail.com wrote: > > On Fri, Mar 11, 2022 at 12:06 PM Jason Baron wrote: > >> > >> > >> > >> On 3/10/22 23:47, Jim Cromie wrote: > >>> > >>> With the patch, one can enable current/unclassed callsites by: >

Re: [RFC PATCH] drm/amd/display: dont ignore alpha property

2022-03-28 Thread Harry Wentland
On 2022-03-28 12:54, Melissa Wen wrote: > On 03/28, Simon Ser wrote: >> Thanks a lot for you patch! I've noticed as well that amdgpu ignores >> the plane alpha property [1]. I'll try to find time to test it. > Hi Simon, > > So you've faced this kind of issue many times :/ > Let me know the

Re: [PATCH 1/2] drm/amd/display: detach fpu operations from dcn10_validate_bandwidth in calcs

2022-03-28 Thread Christian König
Am 28.03.22 um 19:17 schrieb Melissa Wen: On 03/28, Christian König wrote: Am 26.03.22 um 21:24 schrieb Melissa Wen: dcn10_validate_bandwidth is only used on dcn10 files, but is declared in dcn_calcs files. Rename dcn10_* to dcn_* in calcs, remove DC_FP_* wrapper inside DML folder and create

Re: [PATCH 1/2] drm/amd/display: detach fpu operations from dcn10_validate_bandwidth in calcs

2022-03-28 Thread Melissa Wen
On 03/28, Christian König wrote: > Am 26.03.22 um 21:24 schrieb Melissa Wen: > > dcn10_validate_bandwidth is only used on dcn10 files, but is declared in > > dcn_calcs files. Rename dcn10_* to dcn_* in calcs, remove DC_FP_* wrapper > > inside DML folder and create an specific

Re: [PATCH 5/5] umr: Completion: update new format options

2022-03-28 Thread StDenis, Tom
[AMD Official Use Only] Thanks Luben, I've committed and pushed out these patches. Cheers, Tom From: Tuikov, Luben Sent: Sunday, March 27, 2022 06:42 To: amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben; StDenis, Tom; Su, Jinzhou (Joe) Subject: [PATCH

[PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Kent Russell
This is being added to SMU Metrics, so add the required tie-ins in the kernel. Also create the corresponding unique_id sysfs file. v2: Add FW version check, remove SMU mutex v3: Fix style warning v4: Add MP1 IP_VERSION check to FW version check Signed-off-by: Kent Russell Reviewed-by: Alex

[PATCH 1/2] drm/amdgpu: Use switch case for unique_id

2022-03-28 Thread Kent Russell
To ease readability, use switch to set unique_id as supported for the supported IP_VERSIONs, and set it to unsupported by default for all other ASICs. This makes it easier to add IP_VERSIONs later on, and makes it obvious that it is not supported by default, instead of the current logic that

RE: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Alex Deucher > Sent: Monday, March 28, 2022 1:02 PM > To: Russell, Kent > Cc: amd-gfx list ; Deucher, Alexander > > Subject: Re: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid > > On Mon, Mar 28, 2022 at 12:53 PM

Re: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Alex Deucher
On Mon, Mar 28, 2022 at 12:53 PM Kent Russell wrote: > > This is being added to SMU Metrics, so add the required tie-ins in the > kernel. Also create the corresponding unique_id sysfs file. > > v2: Add FW version check, remove SMU mutex > v3: Fix style warning > v4: Add IP_VERSION check to FW

Re: [RFC PATCH] drm/amd/display: dont ignore alpha property

2022-03-28 Thread Melissa Wen
On 03/28, Simon Ser wrote: > Thanks a lot for you patch! I've noticed as well that amdgpu ignores > the plane alpha property [1]. I'll try to find time to test it. Hi Simon, So you've faced this kind of issue many times :/ Let me know the results from your side, so we can use it to find the

[PATCH 1/2] drm/amdgpu: Use switch case for unique_id

2022-03-28 Thread Kent Russell
To ease readability, use switch to set unique_id as supported for the supported IP_VERSIONs, and set it to unsupported by default for all other ASICs. This makes it easier to add IP_VERSIONs later on, and makes it obvious that it is not supported by default, instead of the current logic that

[PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Kent Russell
This is being added to SMU Metrics, so add the required tie-ins in the kernel. Also create the corresponding unique_id sysfs file. v2: Add FW version check, remove SMU mutex v3: Fix style warning v4: Add IP_VERSION check to FW version check Signed-off-by: Kent Russell Reviewed-by: Alex Deucher

Re: [RFC PATCH] drm/amd/display: dont ignore alpha property

2022-03-28 Thread Melissa Wen
On 03/28, Kazlauskas, Nicholas wrote: > [AMD Official Use Only] > > > -Original Message- > > From: Melissa Wen > > Sent: Friday, March 25, 2022 4:45 PM > > To: amd-gfx@lists.freedesktop.org; Wentland, Harry > > ; Deucher, Alexander > > ; Siqueira, Rodrigo > > ; Kazlauskas, Nicholas > > ;

RE: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Russell, Kent
[AMD Official Use Only] Thanks Lijo, I'll do another revision to drop the PMFW ticket (I saw it higher up and thought it was standard practice). Once the PMFW gets officially released I'll test it out and make sure that it doesn't get corrupted. I would assume that it would continue to work,

Re: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Lazar, Lijo
[AMD Official Use Only] Yes, that check looks good. A couple of other things - PMFW ticket as a comment is not needed. I remember Satish updating the same struct for smartshift related data. Some additional fields added towards the end. Not sure if Sienna struct also carries those fields.

RE: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Monday, March 28, 2022 11:48 AM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid > > > > On 3/28/2022 9:12

Re: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Lazar, Lijo
On 3/28/2022 9:12 PM, Russell, Kent wrote: [AMD Official Use Only] Responses inline -Original Message- From: Lazar, Lijo Sent: Monday, March 28, 2022 11:18 AM To: Russell, Kent ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH 2/2] drm/amdgpu: Add

RE: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Russell, Kent
[AMD Official Use Only] Responses inline > -Original Message- > From: Lazar, Lijo > Sent: Monday, March 28, 2022 11:18 AM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid > > > >

Re: [RFC PATCH] drm/amd/display: dont ignore alpha property

2022-03-28 Thread Simon Ser
Thanks a lot for you patch! I've noticed as well that amdgpu ignores the plane alpha property [1]. I'll try to find time to test it. [1]: https://gitlab.freedesktop.org/drm/amd/-/issues/1734

Re: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Lazar, Lijo
On 3/28/2022 8:05 PM, Kent Russell wrote: This is being added to SMU Metrics, so add the required tie-ins in the kernel. Also create the corresponding unique_id sysfs file. v2: Add FW version check, remove SMU mutex v3: Fix style warning Signed-off-by: Kent Russell Reviewed-by: Alex

Re: [PATCH] drm/amd/display: DCN3.1: don't mark as kernel-doc

2022-03-28 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Mar 26, 2022 at 7:37 PM Randy Dunlap wrote: > > There is no need for this one static function to be marked as > kernel-doc notation. > > Avoid this doc build warning: > > warning: This comment starts with '/**', but isn't a kernel-doc comment. > Refer

Re: [PATCH 1/2] drm/amdgpu: Use switch case for unique_id

2022-03-28 Thread Wang, Yang(Kevin)
[AMD Official Use Only] Series is Reviewed-by: kevinyang.w...@amd.com Best Regards, Kevin

[PATCH] amdgpu/pm: Enable sysfs nodes for pp_dpm_vclk and dclk

2022-03-28 Thread Marko Zekovic
SMI clock measure API is failing on NAVI12, because sysfs node for pp_dpm_vclk is not existing. Enable sysfs node for pp_dpm_vclk. v2: Also enable sysfs node for pp_dpm_dclk. Signed-off-by: Marko Zekovic Change-Id: I240fa055600bfc0d46dfec374339ba61764f9ab2 ---

[PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Kent Russell
This is being added to SMU Metrics, so add the required tie-ins in the kernel. Also create the corresponding unique_id sysfs file. v2: Add FW version check, remove SMU mutex v3: Fix style warning Signed-off-by: Kent Russell Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/pm/amdgpu_pm.c

[PATCH 1/2] drm/amdgpu: Use switch case for unique_id

2022-03-28 Thread Kent Russell
To ease readability, use switch to set unique_id as supported for the supported IP_VERSIONs, and set it to unsupported by default for all other ASICs. This makes it easier to add IP_VERSIONs later on, and makes it obvious that it is not supported by default, instead of the current logic that

RE: [PATCH 1/2] drm/amdgpu: Change unique_id to use IP_VERSION

2022-03-28 Thread Russell, Kent
[Public] Thanks Alex. Sending out a 3rd version shortly with a couple style fixes due to rebasing onto Lijo's work. Kent From: Deucher, Alexander Sent: Monday, March 28, 2022 9:45 AM To: Russell, Kent ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amdgpu: Change unique_id to use

RE: [RFC PATCH] drm/amd/display: dont ignore alpha property

2022-03-28 Thread Kazlauskas, Nicholas
[AMD Official Use Only] > -Original Message- > From: Melissa Wen > Sent: Friday, March 25, 2022 4:45 PM > To: amd-gfx@lists.freedesktop.org; Wentland, Harry > ; Deucher, Alexander > ; Siqueira, Rodrigo > ; Kazlauskas, Nicholas > ; Gutierrez, Agustin > ; Liu, Zhan > Cc:

Re: [PATCH] drm/amdgpu: fix incorrect size printing in error msg

2022-03-28 Thread Alex Deucher
On Mon, Mar 28, 2022 at 10:12 AM Christian König wrote: > > That are bytes not pages. > > Signed-off-by: Christian König Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH] drm/amdgpu: fix incorrect size printing in error msg

2022-03-28 Thread Christian König
That are bytes not pages. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index ea0cde4904f0..f4a148917520

Re: [PATCH v2 1/3] drm/amdgpu: Correct unlocked update fence handling

2022-03-28 Thread Christian König
Am 28.03.22 um 15:06 schrieb Philip Yang: To fix two issues with unlocked update fence: 1. vm->last_unlocked store the latest fence without taking refcount. 2. amdgpu_vm_bo_update_mapping returns old fence, not the latest fence. Signed-off-by: Philip Yang Now I see what you mean. Patch is

Re: [PATCH 1/2] drm/amdgpu: Change unique_id to use IP_VERSION

2022-03-28 Thread Deucher, Alexander
[Public] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kent Russell Sent: Monday, March 28, 2022 9:06 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH 1/2] drm/amdgpu: Change unique_id to use IP_VERSION This is

Re: [PATCH v2 1/3] drm/amdgpu: Correct unlocked update fence handling

2022-03-28 Thread Christian König
Am 28.03.22 um 15:35 schrieb philip yang: On 2022-03-28 9:14 a.m., Christian König wrote: Am 28.03.22 um 15:06 schrieb Philip Yang: To fix two issues with unlocked update fence: 1. vm->last_unlocked store the latest fence without taking refcount. 2. amdgpu_vm_bo_update_mapping returns old

Re: [PATCH v2 1/3] drm/amdgpu: Correct unlocked update fence handling

2022-03-28 Thread philip yang
On 2022-03-28 9:14 a.m., Christian König wrote: Am 28.03.22 um 15:06 schrieb Philip Yang: To fix two issues with unlocked update fence: 1. vm->last_unlocked store the latest fence without taking refcount.

Re: [PATCH v2 3/3] drm/amdkfd: Use atomic64_t type for pdd->tlb_seq

2022-03-28 Thread Christian König
Am 28.03.22 um 15:07 schrieb Philip Yang: To support multi-thread update page table. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 2 +- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v2 2/3] drm/amdgpu: Add tlb_cb for unlocked update

2022-03-28 Thread Christian König
Am 28.03.22 um 15:06 schrieb Philip Yang: Flush TLB needs wait for GPU update fence done. MMU notify callback to unmap range from GPUs uses unlocked GPU page table update, so add tlb_cb to unlocked update fence to increase vm->tlb_seq. Signed-off-by: Philip Yang Reviewed-by: Christian König

Re: [PATCH v2 1/3] drm/amdgpu: Correct unlocked update fence handling

2022-03-28 Thread Christian König
Am 28.03.22 um 15:06 schrieb Philip Yang: To fix two issues with unlocked update fence: 1. vm->last_unlocked store the latest fence without taking refcount. 2. amdgpu_vm_bo_update_mapping returns old fence, not the latest fence. NAK, that code here is perfectly correct. vm->last_unlocked

[PATCH v2 3/3] drm/amdkfd: Use atomic64_t type for pdd->tlb_seq

2022-03-28 Thread Philip Yang
To support multi-thread update page table. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 2 +- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h

[PATCH v2 2/3] drm/amdgpu: Add tlb_cb for unlocked update

2022-03-28 Thread Philip Yang
Flush TLB needs wait for GPU update fence done. MMU notify callback to unmap range from GPUs uses unlocked GPU page table update, so add tlb_cb to unlocked update fence to increase vm->tlb_seq. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1

[PATCH v2 1/3] drm/amdgpu: Correct unlocked update fence handling

2022-03-28 Thread Philip Yang
To fix two issues with unlocked update fence: 1. vm->last_unlocked store the latest fence without taking refcount. 2. amdgpu_vm_bo_update_mapping returns old fence, not the latest fence. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 2 +- 1 file changed, 1

[PATCH 1/2] drm/amdgpu: Change unique_id to use IP_VERSION

2022-03-28 Thread Kent Russell
This is transitioning throughout amdgpu, so we may as well get it started now. This also cleans up the logic on what IP_VERSIONs do or don't support unique_id. Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)

[PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Kent Russell
This is being added to SMU Metrics, so add the required tie-ins in the kernel. Also create the corresponding unique_id sysfs file. v2: Add FW version check, remove SMU mutex Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/pm/amdgpu_pm.c| 1 +

Re: [PATCH 2/2] drm/amdgpu: Use last_unlocked fence for unlocked update

2022-03-28 Thread philip yang
On 2022-03-28 5:21 a.m., Christian König wrote: Am 26.03.22 um 01:56 schrieb Philip Yang: MMU callback update page table set unlocked flag, add callback tlb_cb to vm->last_unlocked fence, and pass it back to upper layer

Re: [PATCH] amdgpu/pm: Enable sysfs node for pp_dpm_vclk for NAVI12

2022-03-28 Thread Lazar, Lijo
On 3/28/2022 4:21 PM, Marko Zekovic wrote: SMI clock measure API is failing on NAVI12, because sysfs node for pp_dpm_vclk is not existing Signed-off-by: Marko Zekovic Change-Id: I240fa055600bfc0d46dfec374339ba61764f9ab2 --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 3 ++- 1 file changed, 2

Radeon Pro W5500 in passthrough with vfio generates spurious NMI reason 25

2022-03-28 Thread Ruben De Smet
Dear AMD, I recently posted a bug report on Launchpad (https://bugs.launchpad.net/ubuntu/+source/linux-signed-hwe-5.13/+bug/1963893). I hoped it would reach you via that channel, but I don't really see anything moving. We have three of your W5500 cards in three identical EPYC 7302P HP

Re: [PATCH v2 03/11] drm/edid: slightly restructure timing and non-timing descriptor structs

2022-03-28 Thread Jani Nikula
On Mon, 28 Mar 2022, Jani Nikula wrote: > The pixel clock is conceptually part of the detailed timings, while it's > just zero padding for display descriptors. Modify the structures to > reflect this. Rename struct detailed_non_pixel to > edid_display_descriptor to better reflect spec while at

[PATCH] amdgpu/pm: Enable sysfs node for pp_dpm_vclk for NAVI12

2022-03-28 Thread Marko Zekovic
SMI clock measure API is failing on NAVI12, because sysfs node for pp_dpm_vclk is not existing Signed-off-by: Marko Zekovic Change-Id: I240fa055600bfc0d46dfec374339ba61764f9ab2 --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Lazar, Lijo
On 3/28/2022 3:25 PM, Paul Menzel wrote: Dear Mohammad, Am 28.03.22 um 11:49 schrieb Ziya, Mohammad zafar: -Original Message- From: Paul Menzel Sent: Monday, March 28, 2022 3:08 PM Am 28.03.22 um 10:47 schrieb Ziya, Mohammad zafar: […] -Original Message- From: Paul

Re: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Paul Menzel
Dear Mohammad, Am 28.03.22 um 11:49 schrieb Ziya, Mohammad zafar: -Original Message- From: Paul Menzel Sent: Monday, March 28, 2022 3:08 PM Am 28.03.22 um 10:47 schrieb Ziya, Mohammad zafar: […] -Original Message- From: Paul Menzel Sent: Monday, March 28, 2022 1:39 PM

RE: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Ziya, Mohammad zafar
[AMD Official Use Only] Dear Paul, Comment inline. Regards, Zafar >-Original Message- >From: Paul Menzel >Sent: Monday, March 28, 2022 3:08 PM >To: Ziya, Mohammad zafar ; Zhou1, Tao > >Cc: Lazar, Lijo ; amd-gfx@lists.freedesktop.org; Zhang, >Hawking >Subject: Re: [PATCH v4 5/6]

Re: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Paul Menzel
Dear Mohammad, Am 28.03.22 um 10:47 schrieb Ziya, Mohammad zafar: […] -Original Message- From: Paul Menzel Sent: Monday, March 28, 2022 1:39 PM Am 28.03.22 um 10:00 schrieb Ziya, Mohammad zafar: […] From: Paul Menzel Sent: Monday, March 28, 2022 1:22 PM Am 28.03.22 um

Re: [PATCH 2/2] drm/amdgpu: Use last_unlocked fence for unlocked update

2022-03-28 Thread Christian König
Am 26.03.22 um 01:56 schrieb Philip Yang: MMU callback update page table set unlocked flag, add callback tlb_cb to vm->last_unlocked fence, and pass it back to upper layer to wait for page table update done. Signed-off-by: Philip Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 - 1

Re: [PATCH] drm/amdgpu: Reorder ttm_resource_manager_evict_all() before disabling ttm resource manager

2022-03-28 Thread Christian König
Am 28.03.22 um 10:47 schrieb Leslie Shi: ttm_resource_manager_evict_all() evicts objects out of resource manager until lru is empty. ttm_resource_manager_set_used() WARN_ON non-empty lru. This patch exchanges these two function calls to avoid following call trace during amdgpu driver unload:

[PATCH] drm/amdgpu: Reorder ttm_resource_manager_evict_all() before disabling ttm resource manager

2022-03-28 Thread Leslie Shi
ttm_resource_manager_evict_all() evicts objects out of resource manager until lru is empty. ttm_resource_manager_set_used() WARN_ON non-empty lru. This patch exchanges these two function calls to avoid following call trace during amdgpu driver unload: WARNING: CPU: 6 PID: 22873 at

RE: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Ziya, Mohammad zafar
[AMD Official Use Only] Dear Paul, Thank you for review. Comment added inline. Regards, Zafar >-Original Message- >From: Paul Menzel >Sent: Monday, March 28, 2022 1:39 PM >To: Ziya, Mohammad zafar ; Zhou1, Tao > >Cc: Lazar, Lijo ; amd-gfx@lists.freedesktop.org; Zhang, >Hawking

Re: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Paul Menzel
Dear Mohammad, Am 28.03.22 um 10:00 schrieb Ziya, Mohammad zafar: […] From: Paul Menzel Sent: Monday, March 28, 2022 1:22 PM […] Tao, it’s hard to find your reply in the quote, as the message is not quoted correctly (> prepended). Is it possible to use a different email client? Am

RE: [PATCH v4 0/6] VCN and JPEG RAS poison detection

2022-03-28 Thread Zhou1, Tao
[AMD Official Use Only] With Paul's comment fixed, the series is: Reviewed-by: Tao Zhou -Original Message- From: Ziya, Mohammad zafar Sent: Monday, March 28, 2022 2:58 PM To: Paul Menzel Cc: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Lazar, Lijo ; Zhang, Hawking Subject: RE:

RE: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Ziya, Mohammad zafar
[AMD Official Use Only] Dear Paul and Tao, Comments are added inline. Regards, Zafar >-Original Message- >From: Paul Menzel >Sent: Monday, March 28, 2022 1:22 PM >To: Zhou1, Tao ; Ziya, Mohammad zafar > >Cc: amd-gfx@lists.freedesktop.org; Lazar, Lijo ; Zhang, >Hawking >Subject: Re:

Re: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Paul Menzel
Dear Mohammad, dear Tao, Tao, it’s hard to find your reply in the quote, as the message is not quoted correctly (> prepended). Is it possible to use a different email client? Am 28.03.22 um 09:43 schrieb Zhou1, Tao: -Original Message- From: Ziya, Mohammad zafar Sent: Monday,

RE: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Zhou1, Tao
[AMD Official Use Only] -Original Message- From: Ziya, Mohammad zafar Sent: Monday, March 28, 2022 2:25 PM To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Zhou1, Tao ; Zhang, Hawking ; Ziya, Mohammad zafar Subject: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support RAS

Re: [PATCH] drm/amdgpu: resolve s3 hang for r7340

2022-03-28 Thread Paul Menzel
[Cc: -Jack Zhang (invalid address) Am 28.03.22 um 09:36 schrieb Paul Menzel: Dear Zhenneng, Thank you for your patch. Am 28.03.22 um 06:05 schrieb Zhenneng Li: This is a workaround for s3 hang for r7340(amdgpu). Is it hanging when resuming from S3? Maybe also use the line below for the

Re: [PATCH] drm/amdgpu: resolve s3 hang for r7340

2022-03-28 Thread Paul Menzel
Dear Zhenneng, Thank you for your patch. Am 28.03.22 um 06:05 schrieb Zhenneng Li: This is a workaround for s3 hang for r7340(amdgpu). Is it hanging when resuming from S3? Maybe also use the line below for the commit message summary: drm/amdgpu: Add 1 ms delay to init handler to fix s3

[PATCH] drm/amdgpu: resolve s3 hang for r7340

2022-03-28 Thread Zhenneng Li
This is a workaround for s3 hang for r7340(amdgpu). When we test s3 with r7340 on arm64 platform, graphics card will hang up, the error message are as follows: Mar 4 01:14:11 greatwall-GW-XX-XXX kernel: [1.599374][ 7] [ T291] amdgpu :02:00.0: fb0: amdgpudrmfb frame buffer device Mar

[PATCH] drm/amd/display: DCN3.1: don't mark as kernel-doc

2022-03-28 Thread Randy Dunlap
There is no need for this one static function to be marked as kernel-doc notation. Avoid this doc build warning: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Enable CRTC Fixes: 110d3968fe95 ("drm/amd/display: Add

Re: Waiting for fences timed out on MacBook Pro 2019

2022-03-28 Thread Tomasz Moń
On 2/6/22 09:17, Tomasz Moń wrote: On Mon, Jul 12, 2021 at 11:56 AM Tomasz Moń wrote: I am having trouble getting Linux to run on MacBook Pro 2019 with Radeon Pro Vega 20 4 GB. Basically as soon as graphical user interface starts, the whole system freezes. This happens with every Linux kernel

RE: [PATCH v4 0/6] VCN and JPEG RAS poison detection

2022-03-28 Thread Ziya, Mohammad zafar
[AMD Official Use Only] Dear Paul, Thank for review. Added comment inline. Regards, Mohammad >-Original Message- >From: Paul Menzel >Sent: Monday, March 28, 2022 12:09 PM >To: Ziya, Mohammad zafar >Cc: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; >Lazar, Lijo ; Zhang, Hawking >

Re: [PATCH 1/2] drm/amd/display: detach fpu operations from dcn10_validate_bandwidth in calcs

2022-03-28 Thread Christian König
Am 26.03.22 um 21:24 schrieb Melissa Wen: dcn10_validate_bandwidth is only used on dcn10 files, but is declared in dcn_calcs files. Rename dcn10_* to dcn_* in calcs, remove DC_FP_* wrapper inside DML folder and create an specific dcn10_validate_bandwidth in dcn10_resources that calls

Re: [PATCH v4 2/6] drm/amdgpu/vcn: Add vcn ras support

2022-03-28 Thread Paul Menzel
Dear Mohammad, Thank you for your patch. Am 28.03.22 um 08:24 schrieb Mohammad Zafar Ziya: VCN block ras feature support addition V2: default ras callback removed Signed-off-by: Mohammad Zafar Ziya Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 10 ++

Re: [PATCH v4 0/6] VCN and JPEG RAS poison detection

2022-03-28 Thread Paul Menzel
Dear Mahommad, Am 28.03.22 um 08:24 schrieb Mohammad Zafar Ziya: VCN and JPEG RAS poison detection It’d be great if you extended this a little bit. Especially, how it can be tested. Mohammad Zafar Ziya (6): drm/amdgpu: Add vcn and jpeg ras support flag drm/amdgpu/vcn: Add vcn ras

[PATCH v4 6/6] drm/amdgpu/jpeg: jpeg ras error query support

2022-03-28 Thread Mohammad Zafar Ziya
RAS error query support addition for JPEG 2.6 V2: removed unused options and corrected comment format. Moved register definition to header file. V3: poison query status check added. Removed the error query support V4: Return statement refactored. Signed-off-by: Mohammad Zafar Ziya

[PATCH v4 4/6] drm/amdgpu/vcn: vcn and jpeg ver 2.6 ras register definition

2022-03-28 Thread Mohammad Zafar Ziya
Adding vcn and jpeg ver 2.6 ras register definition Signed-off-by: Mohammad Zafar Ziya Reviewed-by: Hawking Zhang --- .../amd/include/asic_reg/vcn/vcn_2_5_offset.h | 13 ++ .../include/asic_reg/vcn/vcn_2_5_sh_mask.h| 24 +++ 2 files changed, 37 insertions(+) diff

[PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Mohammad Zafar Ziya
RAS error query support addition for VCN 2.6 V2: removed unused option and corrected comment format Moved the register definition under header file V3: poison query status check added. Removed error query interface V4: MMSCH poison check option removed, return true/false refactored.

[PATCH v4 3/6] drm/amdgpu/jpeg: Add jpeg block ras support

2022-03-28 Thread Mohammad Zafar Ziya
Ras support addition for JPEG block V2: removed default callback Signed-off-by: Mohammad Zafar Ziya Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h

[PATCH v4 2/6] drm/amdgpu/vcn: Add vcn ras support

2022-03-28 Thread Mohammad Zafar Ziya
VCN block ras feature support addition V2: default ras callback removed Signed-off-by: Mohammad Zafar Ziya Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h

[PATCH v4 1/6] drm/amdgpu: Add vcn and jpeg ras support flag

2022-03-28 Thread Mohammad Zafar Ziya
Add vcn and jpeg ras support options V2: vcn and jpeg ras flag enabled for aldebaran asic only V3: vcn and jpeg ras flag disabled for error counter query Generic poison query interface added VCN and JPEG ras enabled based on IP version check V4: vcn and jpeg ras flag moved under ecc flag for

[PATCH v4 0/6] VCN and JPEG RAS poison detection

2022-03-28 Thread Mohammad Zafar Ziya
VCN and JPEG RAS poison detection Mohammad Zafar Ziya (6): drm/amdgpu: Add vcn and jpeg ras support flag drm/amdgpu/vcn: Add vcn ras support drm/amdgpu/jpeg: Add jpeg block ras support drm/amdgpu/vcn: vcn and jpeg ver 2.6 ras register definition drm/amdgpu/vcn: VCN ras error query